Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- (12:14:00 PM) Tomasz Bąk: hi
- (12:14:06 PM) ts@skalar.no/Home777B9D97: hey :)
- (12:14:36 PM) ts@skalar.no/Home777B9D97: im not sure if you are up to date with what has been done
- (12:14:41 PM) ts@skalar.no/Home777B9D97: but tgn is working on bundling the css/javascript
- (12:14:51 PM) ts@skalar.no/Home777B9D97: hopefully without the sideeffects we had the last time we tried (a long time ago)
- (12:16:34 PM) ts@skalar.no/Home777B9D97: i noticed each driving distance query took ~300ms
- (12:16:38 PM) ts@skalar.no/Home777B9D97: because of LIKE usage
- (12:16:50 PM) ts@skalar.no/Home777B9D97: because the floats stored in db was very precise, but the query floats where rounded
- (12:16:53 PM) ts@skalar.no/Home777B9D97: changed it to use range
- (12:16:57 PM) ts@skalar.no/Home777B9D97: so it should be < 10ms per request
- (12:19:08 PM) ts@skalar.no/Home777B9D97: if you have 20 x 300ms = 6 secs.. so it should be significant
- (12:19:56 PM) ts@skalar.no/Home777B9D97: i have added some missing indices
- (12:20:09 PM) ts@skalar.no/Home777B9D97: there are probably more, but I took the ones which were frequently appearing in mysqls slow log
- (12:23:38 PM) ts@skalar.no/Home777B9D97: The thing its hard for me to work on are optimizations/refactorings of methods
- (12:23:53 PM) ts@skalar.no/Home777B9D97: for prioritizing the slow methods
- (12:24:15 PM) ts@skalar.no/Home777B9D97: the two major criterias are cumulative request time (consumes resources, contributes to global slow down)
- (12:24:26 PM) ts@skalar.no/Home777B9D97: and average request times for often used functions
- (12:24:41 PM) ts@skalar.no/Home777B9D97: and also of course how much effort is required to improve something
- (12:24:47 PM) ts@skalar.no/Home777B9D97: less cost and more benefit first
- (12:25:05 PM) ts@skalar.no/Home777B9D97: the last one you will have to judge
- (12:25:11 PM) ts@skalar.no/Home777B9D97: but I have some suspicions
- (12:25:12 PM) ts@skalar.no/Home777B9D97: like with
- (12:25:16 PM) ts@skalar.no/Home777B9D97: Assignment::PhotoAssignmentsController#handle_to_as_edited.html [POST]
- (12:25:20 PM) ts@skalar.no/Home777B9D97: average time of 22 seconds
- (12:25:28 PM) ts@skalar.no/Home777B9D97: i cant think of anything that method should do that takes > 1 second
Add Comment
Please, Sign In to add comment