First pass qa testing the enhancement module for BFA AMR
-all comments come from the following gear profile (but several reports were run to checkall talents switched around to test things): https://beta.askmrrobot.com/wow/simulator/report/98700c655e69456c8937dbc8ef7c6706

-stormstrike isn't adding the "2nd cast" (goes on full CD immediately instead of 1 free then 1 full cost
-strength of earth not affected by spec passive (azerite trait effect is it, dmg should be a lot lower)
-maelstrom cap is still 150 instead of 100. the maelstrom cap is on our spec passive (effect#6, base is 100, effect is now +0 instead of +50 in legion)
-doomhammer artifact import from armory is real wonky (imported a ~390 ilvl mainhand and a ~160 offhand when weapon was ~258) (probably not a big deal with legion stuff going away)
-feral spirits with elemental spirits is being cast every 120s instead of 90s.
-lava lash not affected by molten weapon flat fire buff from molten weapon (fire dog with elemental spirits). fire buff should also be multiplicative, but the dot damage should be additive (70% dot with 2 stacks)
-crackling surge not affecting wind strike (don't see it in the buff definition for crackling surge). While ele spirits and ascendance are on the same talent tier (barring legion gloves), the spell data for crackling surge affects both - if some ascendance proc like the gloves comes back this may come back to bite you.
-crackling surge seems to be applying 2 seperate buffs instead of stacking to 2 like icy edge and molten weapon are. They all apply seperate buffs in game, but its more intuitive if its just a stacking thing in the report - this is just a weird reporting gripe <https://i.imgur.com/qq6LyOT.png>. Also seeing the stack counts seperately (% of time at 1 and 2 stacks) would be nice instead of just overall uptime of any stacks.
-earthen spike debuff not increasing the damage of sundering (flamestrike damage still counts as physical for the dmg taken mod).
-I see in your elemental spirits ability definition comment you have "TODO: Only auto attacks are proc'ing Icy Edge Right now. Bug?", icy edge does only proc off white attacks - the original implementation made it so your wolves proc'd the icy edge attack when you auto attacked, they simplified the ability to just be the player procs the attack on white attacks instead, its far more likely that the tooltip is just very misleading and very wrong.
-Spellpower not listed in the stats panel (nor the composite attack power, but to be fair simc hasn't overhauled the stats table either to show composite attack power). Spellpower on the stats is relevant because at the moment blizzard bumped our ap->sp conversion from 100% to 101% (god only knows why) but its hard to confirm the correct stats if we can't see the spellpower. Relevant for Overcharge.
-Gale-force striking appears to be stacking its intensity and doing odd things with its buff apply / refresh logic, none of the new weapon enchants stack in-game <https://i.imgur.com/iGhKTKG.png> ~1.3 swing speed is way too fast (2.6 / 1.1 / 1.35 / 1.35 = ~1.3) - <https://i.imgur.com/2Y53602.png>
-Vile Bile (weapon proc from Bil-Stained Crawg Tusks) is not refreshing its duration back to 9s on buff stacking - <https://i.imgur.com/16vbZgY.png>
-obvious rotation improvements, i imagine optimization is last after bug fixing for you guys.
-Some Enhance specific Azerite traits appear unimplemented (Primal Primer, Roiling Storm, Lightning Conduit). Striker's Grace, Storm's Eye and Electropotence have yet to be found ingame so personally I wouldn't bother with those.
-The Stormstrike that triggers the 20th (and 21st) stacks of Lightning Shield should apply 1 Lightning Shield damage event, current AMR is applying zero. Basically the main hand SS hit brings you to 20 stacks, you gain the overcharge buff, then the off hand lands with the buff up and applies one damage event. With a defensive proc bringing you to 18 stacks, if you SS and go to 20 there should be zero damage events (as the overcharge hit is evaluated before the LS buff gains a stack).