RajB47

evaluate turn skill

Oct 1st, 2026 (edited)
124
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
Bash 2.38 KB | Source Code | 0 0
  1. ---
  2. name: evaluate-turn
  3. description: "Review diffs from the previous turn(s) that implemented a feature and report defects. Use when asked to evaluate a turn, audit a feature diff, or find what is wrong in recent changes. Not for implementing the feature or linting the whole repo."
  4. ---
  5.  
  6. # evaluate-turn
  7.  
  8. Review the diff. Do not grade the chat or the agent's summary.
  9.  
  10. ## Inputs
  11.  
  12. 1. Claim: one sentence on what the feature must do, and what must not change. Take it from the user request, not the implementer's recap. If inferred, label it inferred.
  13. 2. Boundary: working tree vs HEAD, or a named base ref. Do not review the whole tree.
  14.  
  15. Collect the diff with `git diff HEAD` or `git diff <base>...HEAD`. Read the stat first. Open a hunk only if it is on the claim path or needed as proof. For every changed production file, read the unchanged callers the new code plugs into.
  16.  
  17. ## Hunt in this order
  18.  
  19. 1. Claim gap. Required behavior is missing, stubbed, or never called.
  20. 2. Behavior change outside the claim. Signatures, persisted data, error codes, defaults, side effects.
  21. 3. Wrong logic. Bad branch, off-by-one, empty or error path, race, leak.
  22. 4. Contract lies. Types, comments, docs, or tests that assert behavior the code does not implement. Imports or APIs that do not exist in this repo.
  23. 5. Tests that cannot fail. Mocking the unit under test, `toBeDefined`, `not.toThrow`, skipped tests presented as coverage.
  24. 6. Security and data. Auth bypass, injection, committed secrets, dropped fields.
  25. 7. Slop that hides a defect. Dead code, narrating comments, swallowed errors, one-caller abstractions, `any` added to silence the compiler. Cap at five. Skip "could be more generic."
  26.  
  27. ## Evidence
  28.  
  29. Every finding needs `path:line`, the wrong behavior, and why the claim or a caller makes it wrong. No line, no finding. Do not report pre-existing issues the diff does not make reachable, or style the untouched code already violates.
  30.  
  31. ## Report
  32.  
  33. Verdict: merge | fix-then-merge | reject
  34. Claim: <sentence>
  35. Boundary: <ref>; <N files>, +<add>/-<del>
  36.  
  37. Blockers
  38. - [class] path:line — what is wrong. Fix: <one line>.
  39.  
  40. Defects
  41. - [class] path:line — same shape.
  42.  
  43. Slop
  44. - [class] path:line — what to delete. Omit if empty.
  45.  
  46. Checked
  47. - <paths opened, tests run or not run>
  48.  
  49. `reject` if any blocker remains. `merge` only if the claim path was opened and nothing was found. Do not rewrite the feature.
Tags: blog prompts
Advertisement
Add Comment
Please, Sign In to add comment