Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- ---
- name: evaluate-turn
- description: "Review diffs from the previous turn(s) that implemented a feature and report defects. Use when asked to evaluate a turn, audit a feature diff, or find what is wrong in recent changes. Not for implementing the feature or linting the whole repo."
- ---
- # evaluate-turn
- Review the diff. Do not grade the chat or the agent's summary.
- ## Inputs
- 1. Claim: one sentence on what the feature must do, and what must not change. Take it from the user request, not the implementer's recap. If inferred, label it inferred.
- 2. Boundary: working tree vs HEAD, or a named base ref. Do not review the whole tree.
- Collect the diff with `git diff HEAD` or `git diff <base>...HEAD`. Read the stat first. Open a hunk only if it is on the claim path or needed as proof. For every changed production file, read the unchanged callers the new code plugs into.
- ## Hunt in this order
- 1. Claim gap. Required behavior is missing, stubbed, or never called.
- 2. Behavior change outside the claim. Signatures, persisted data, error codes, defaults, side effects.
- 3. Wrong logic. Bad branch, off-by-one, empty or error path, race, leak.
- 4. Contract lies. Types, comments, docs, or tests that assert behavior the code does not implement. Imports or APIs that do not exist in this repo.
- 5. Tests that cannot fail. Mocking the unit under test, `toBeDefined`, `not.toThrow`, skipped tests presented as coverage.
- 6. Security and data. Auth bypass, injection, committed secrets, dropped fields.
- 7. Slop that hides a defect. Dead code, narrating comments, swallowed errors, one-caller abstractions, `any` added to silence the compiler. Cap at five. Skip "could be more generic."
- ## Evidence
- Every finding needs `path:line`, the wrong behavior, and why the claim or a caller makes it wrong. No line, no finding. Do not report pre-existing issues the diff does not make reachable, or style the untouched code already violates.
- ## Report
- Verdict: merge | fix-then-merge | reject
- Claim: <sentence>
- Boundary: <ref>; <N files>, +<add>/-<del>
- Blockers
- - [class] path:line — what is wrong. Fix: <one line>.
- Defects
- - [class] path:line — same shape.
- Slop
- - [class] path:line — what to delete. Omit if empty.
- Checked
- - <paths opened, tests run or not run>
- `reject` if any blocker remains. `merge` only if the claim path was opened and nothing was found. Do not rewrite the feature.
Advertisement
Add Comment
Please, Sign In to add comment