Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- Collator* Collator::makeInstance(....)
- {
- ....
- RuleBasedCollator* collation =
- new RuleBasedCollator(desiredLocale, status);
- /* test for NULL */
- if (collation == 0) {
- status = U_MEMORY_ALLOCATION_ERROR;
- return 0;
- }
- ....
- }
- #info P.S. /* test for NULL */ - A not so super comment. :)
- This suspicious code was found in icu project by PVS-Studio static code analyzer.
- Warning message is:
- V668 There is no sense in testing the 'collation' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. coll.cpp 365
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment