PVS-StudioWarnings

PVS-Studio warning V629 for Clang

Nov 12th, 2014
157
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.61 KB | None | 0 0
  1. void EmitVBR64(uint64_t Val, unsigned NumBits) {
  2.   if ((uint32_t)Val == Val)
  3.     return EmitVBR((uint32_t)Val, NumBits);
  4.  
  5.   uint64_t Threshold = 1U << (NumBits-1);
  6.   ...
  7. }
  8.  
  9. This suspicious code was found in Clang project by PVS-Studio static code analyzer.
  10. Warning message is:
  11. V629 Consider inspecting the '1U << (NumBits - 1)' expression. Bit shifting of the 32-bit value with a subsequent expansion to the 64-bit type. bitstreamwriter.h 173
  12.  
  13. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment