PVS-StudioWarnings

PVS-Studio warning V517 for Skia

Nov 20th, 2014
158
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.78 KB | None | 0 0
  1. SkString*
  2. SkObjectParser::SaveFlagsToString(SkCanvas::SaveFlags flags)
  3. {
  4.   SkString* mFlags = new SkString("SkCanvas::SaveFlags: ");
  5.  
  6.   if(flags == SkCanvas::kMatrixClip_SaveFlag) {
  7.     mFlags->append("kMatrixClip_SaveFlag");
  8.   ....
  9.   } else if (flags == SkCanvas::kMatrixClip_SaveFlag) {
  10.     mFlags->append("kMatrixClip_SaveFlag");
  11.   ....
  12. }
  13.  
  14. This suspicious code was found in Skia project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 301, 311. skobjectparser.cpp 301
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment