Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- /*
- * MD5 password encryption.
- */
- char* php_md5_crypt_r(const char *pw,const char *salt, char *out)
- {
- static char passwd[MD5_HASH_MAX_LEN], *p;
- unsigned char final[16];
- ....
- /* Don't leave anything around in vm they could use. */
- memset(final, 0, sizeof(final)); //<==
- return (passwd);
- }
- This suspicious code was found in PHP project by PVS-Studio static code analyzer.
- Warning message is:
- V597 The compiler could delete the 'memset' function call, which is used to flush 'final' buffer. The RtlSecureZeroMemory() function should be used to erase the private data. php_crypt_r.c 421
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment