From 47afb50ea3128f7dabb4622cc8251c1348f829f6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lubo=C5=A1=20Lu=C5=88=C3=A1k?= <l.lunak@collabora.com>
Date: Tue, 14 Jan 2020 12:26:52 +0100
Subject: [PATCH] do not ignore return value of a (confusing) function
 (tdf#126248)

The two ScCellFormat::GetString() overloads are lame API, one returns
the value normally and the other one returns void and uses a reference
parameter. I got confused by this in 6f810e3d7dafcd7d0101173a501
and didn't use the return value in one case.

Change-Id: I0b6c839f9d0299e14ea022813481802275df5ea6
---
 sc/source/core/data/documen6.cxx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sc/source/core/data/documen6.cxx b/sc/source/core/data/documen6.cxx
index 789f26c2c009..e6d7a315f7bf 100644
--- a/sc/source/core/data/documen6.cxx
+++ b/sc/source/core/data/documen6.cxx
@@ -120,7 +120,7 @@ SvtScriptType ScDocument::GetCellScriptType( const ScAddress& rPos, sal_uInt32 n
     if( pCell )
         ScCellFormat::GetString(*pCell, nNumberFormat, aStr, &pColor, *mxPoolHelper->GetFormTable(), this);
     else
-        ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, *mxPoolHelper->GetFormTable());
+        aStr = ScCellFormat::GetString(*this, rPos, nNumberFormat, &pColor, *mxPoolHelper->GetFormTable());

     SvtScriptType nRet = GetStringScriptType( aStr );

--
2.16.4