Advertisement
Guest User

EmuDeck shellcheck

a guest
Sep 1st, 2022
731
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 67.99 KB | None | 0 0
  1. In ./execFnList.sh line 2:
  2. source "$HOME/emudeck/backend/functions/all.sh"
  3. ^-- SC1091 (info): Not following: ./emudeck/backend/functions/all.sh was not specified as input (see shellcheck -x).
  4.  
  5.  
  6. In ./installCLI.sh line 16:
  7. if [ $? -eq 0 ]; then
  8. ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  9.  
  10.  
  11. In ./installCLI.sh line 22:
  12. if [ $? -ne 0 ]; then
  13. ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  14.  
  15.  
  16. In ./installCLI.sh line 29:
  17. if [ $? -ne 0 ]; then
  18. ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  19.  
  20.  
  21. In ./installCLI.sh line 120:
  22. if [[ ! $noPull == true ]]; then
  23. ^-----^ SC2154 (warning): noPull is referenced but not assigned.
  24.  
  25.  
  26. In ./installCLI.sh line 249:
  27. pause
  28. ^---^ SC2119 (info): Use pause "$@" if function's $1 should mean script's $1.
  29.  
  30.  
  31. In ./installCLI.sh line 709:
  32. if [ "$zenity" == true ]; then
  33. ^-----^ SC2154 (warning): zenity is referenced but not assigned.
  34.  
  35.  
  36. In ./installCLI.sh line 1043:
  37. text="$(printf "<b>Yuzu is not configured</b>\nYou need to copy your Keys and firmware to: \n${biosPath}yuzu/keys\n${biosPath}yuzu/firmware\n\nMake sure to copy your files inside the folders. <b>Do not overwrite them</b>")"
  38. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  39.  
  40.  
  41. In ./installCLI.sh line 1086:
  42. text="$(printf "<b>Done!</b>\n\nRemember to add your games here:\n<b>${romsPath}</b>\nAnd your Bios (PS1, PS2, Yuzu) here:\n<b>${biosPath}</b>\n\nOpen Steam Rom Manager on your Desktop to add your games to your SteamUI Interface.\n\nThere is a bug in RetroArch that if you are using Bezels you can not set save configuration files unless you close your current game. Use overrides for your custom configurations or use expert mode to disabled them\n\nIf you encounter any problem please visit our Discord:\n<b>https://discord.gg/b9F7GpXtFP</b>\n\nTo Update EmuDeck in the future, just run this App again.\n\nEnjoy!")"
  43. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  44.  
  45.  
  46. In ./functions/installEmuAI.sh line 11:
  47. echo $name
  48. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
  49.  
  50. Did you mean:
  51. echo "$name"
  52.  
  53.  
  54. In ./functions/installEmuAI.sh line 12:
  55. echo $url
  56. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  57.  
  58. Did you mean:
  59. echo "$url"
  60.  
  61.  
  62. In ./functions/installEmuAI.sh line 13:
  63. echo $altName
  64. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  65.  
  66. Did you mean:
  67. echo "$altName"
  68.  
  69.  
  70. In ./functions/installEmuAI.sh line 22:
  71. find "${toolsPath}/launchers/" -type f -iname "$shName.sh" -o -type f -iname "$shName-emu.sh" | \
  72. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  73.  
  74.  
  75. In ./functions/dialogBox.sh line 31:
  76. if [ -z $2 ] ; then
  77. ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
  78.  
  79. Did you mean:
  80. if [ -z "$2" ] ; then
  81.  
  82.  
  83. In ./functions/dialogBox.sh line 32:
  84. dir_list=$(ls -lhp | awk -F ' ' ' { print $9 " " $5 } ')
  85. ^-----^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
  86.  
  87.  
  88. In ./functions/dialogBox.sh line 34:
  89. cd "$2"
  90. ^-----^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  91.  
  92. Did you mean:
  93. cd "$2" || exit
  94.  
  95.  
  96. In ./functions/dialogBox.sh line 35:
  97. dir_list=$(ls -lhp | awk -F ' ' ' { print $9 " " $5 } ')
  98. ^-----^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
  99.  
  100.  
  101. In ./functions/dialogBox.sh line 43:
  102. --ok-button Select $dir_list 3>&1 1>&2 2>&3)
  103. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  104.  
  105. Did you mean:
  106. --ok-button Select "$dir_list" 3>&1 1>&2 2>&3)
  107.  
  108.  
  109. In ./functions/dialogBox.sh line 48:
  110. --ok-button Select ../ BACK $dir_list 3>&1 1>&2 2>&3)
  111. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  112.  
  113. Did you mean:
  114. --ok-button Select ../ BACK "$dir_list" 3>&1 1>&2 2>&3)
  115.  
  116.  
  117. In ./functions/dialogBox.sh line 58:
  118. if [[ $selection == *$filext ]]; then # Check if selected File has .jpg extension
  119. ^-----^ SC2154 (warning): filext is referenced but not assigned.
  120.  
  121.  
  122. In ./functions/dialogBox.sh line 62:
  123. filename="$selection"
  124. ^------^ SC2034 (warning): filename appears unused. Verify use (or export if used externally).
  125.  
  126.  
  127. In ./functions/dialogBox.sh line 63:
  128. filepath="$curdir" # Return full filepath and filename as selection variables
  129. ^------^ SC2034 (warning): filepath appears unused. Verify use (or export if used externally).
  130.  
  131.  
  132. In ./functions/installEmuBI.sh line 12:
  133. echo $name
  134. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
  135.  
  136. Did you mean:
  137. echo "$name"
  138.  
  139.  
  140. In ./functions/installEmuBI.sh line 13:
  141. echo $url
  142. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  143.  
  144. Did you mean:
  145. echo "$url"
  146.  
  147.  
  148. In ./functions/installEmuBI.sh line 14:
  149. echo $altName
  150. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  151.  
  152. Did you mean:
  153. echo "$altName"
  154.  
  155.  
  156. In ./functions/installEmuBI.sh line 23:
  157. find "${toolsPath}/launchers/" -type f -iname "$shName.sh" -o -type f -iname "$shName-emu.sh" | \
  158. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  159.  
  160.  
  161. In ./functions/RunFunc.sh line 2:
  162. source all.sh && "@a"
  163. ^----^ SC1091 (info): Not following: all.sh was not specified as input (see shellcheck -x).
  164.  
  165.  
  166. In ./functions/helperFunctions.sh line 50:
  167. local OLD=$(escapeSedKeyword "$KEYWORD")
  168. ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  169.  
  170.  
  171. In ./functions/helperFunctions.sh line 51:
  172. local NEW=$(escapeSedValue "$REPLACE")
  173. ^-^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  174.  
  175.  
  176. In ./functions/helperFunctions.sh line 54:
  177. echo "Old: "$(cat "$FILE" | grep "^$OLD")
  178. ^---------------------------^ SC2046 (warning): Quote this to prevent word splitting.
  179. ^-----^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
  180.  
  181.  
  182. In ./functions/helperFunctions.sh line 56:
  183. echo "New: "$(cat "$FILE" | grep "^$OLD")
  184. ^---------------------------^ SC2046 (warning): Quote this to prevent word splitting.
  185. ^-----^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
  186.  
  187.  
  188. In ./functions/helperFunctions.sh line 112:
  189. find "$HOME/emudeck/backend/configs/org.libretro.RetroArch/config/retroarch/config" -type f -iname "*.cfg" | while read file
  190. ^--^ SC2162 (info): read without -r will mangle backslashes.
  191.  
  192.  
  193. In ./functions/helperFunctions.sh line 120:
  194. for line in $(cat "$file")
  195. ^------------^ SC2013 (info): To read lines rather than words, pipe/redirect to a 'while read' loop.
  196.  
  197.  
  198. In ./functions/helperFunctions.sh line 122:
  199. local option=$(echo "$line" | awk '{print $1}')
  200. ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  201.  
  202.  
  203. In ./functions/helperFunctions.sh line 123:
  204. local value=$(echo "$line" | awk '{print $3}')
  205. ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  206.  
  207.  
  208. In ./functions/helperFunctions.sh line 132:
  209. find "$HOME/emudeck/backend/configs/org.libretro.RetroArch/config/retroarch/config" -type f -iname "*.opt" -o -type f -iname "*.cfg"| while read file
  210. ^--^ SC2162 (info): read without -r will mangle backslashes.
  211.  
  212.  
  213. In ./functions/helperFunctions.sh line 161:
  214. sed -i -e '$a\'"$var=$new_val" "$emuDecksettingsFile"
  215. ^-- SC1003 (info): Want to escape a single quote? echo 'This is how it'\''s done'.
  216.  
  217.  
  218. In ./functions/helperFunctions.sh line 193:
  219. local fullPath=$(dirname "$configFile")
  220. ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  221.  
  222.  
  223. In ./functions/helperFunctions.sh line 197:
  224. local optionFound=$(grep -rnw "$configFile" -e "$option")
  225. ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  226.  
  227.  
  228. In ./functions/helperFunctions.sh line 207:
  229. local sdpath=$(getSDPath)
  230. ^----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  231.  
  232.  
  233. In ./functions/helperFunctions.sh line 208:
  234. local sdValid=$(testLocationValid "sd" "$sdpath")
  235. ^-----^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  236.  
  237.  
  238. In ./functions/helperFunctions.sh line 214:
  239. local uname=$(uname -a)
  240. ^---^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  241.  
  242.  
  243. In ./functions/helperFunctions.sh line 215:
  244. local productName=$(getProductName)
  245. ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  246.  
  247.  
  248. In ./functions/helperFunctions.sh line 216:
  249. local aspectRatio=$(getScreenAR)
  250. ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  251.  
  252.  
  253. In ./functions/helperFunctions.sh line 309:
  254. cat "$emuDecksettingsFile" | awk '!unique[$0]++' > "$tmp" && mv "$tmp" "$emuDecksettingsFile"
  255. ^--------------------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
  256.  
  257.  
  258. In ./functions/helperFunctions.sh line 312:
  259. local settingName=$(cut -d "=" -f1 <<< "$setting")
  260. ^---------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  261.  
  262.  
  263. In ./functions/helperFunctions.sh line 313:
  264. local settingVal=$(cut -d "=" -f2 <<< "$setting")
  265. ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  266.  
  267.  
  268. In ./functions/helperFunctions.sh line 354:
  269. url="$(curl -sL $url | jq -r ".assets[].browser_download_url" | grep -ve 'i386' | grep .${fileType}\$)"
  270. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  271. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  272.  
  273. Did you mean:
  274. url="$(curl -sL "$url" | jq -r ".assets[].browser_download_url" | grep -ve 'i386' | grep ."${fileType}"\$)"
  275.  
  276.  
  277. In ./functions/helperFunctions.sh line 378:
  278. mkdir -p $savesPath/$emu
  279. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  280.  
  281. Did you mean:
  282. mkdir -p $savesPath/"$emu"
  283.  
  284.  
  285. In ./functions/helperFunctions.sh line 380:
  286. mkdir -p $path
  287. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
  288.  
  289. Did you mean:
  290. mkdir -p "$path"
  291.  
  292.  
  293. In ./functions/helperFunctions.sh line 381:
  294. ln -sn $path $savesPath/$emu/$folderName
  295. ^---^ SC2086 (info): Double quote to prevent globbing and word splitting.
  296. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  297. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  298.  
  299. Did you mean:
  300. ln -sn "$path" $savesPath/"$emu"/"$folderName"
  301.  
  302.  
  303. In ./functions/helperFunctions.sh line 391:
  304. local linkedTarget=$(readlink -f "$savesPath/$emu/$folderName")
  305. ^----------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  306.  
  307.  
  308. In ./functions/migrateAndLinkConfig.sh line 48:
  309. text="`printf "Data was found for both the appimage and flatpak for ${emu}.\nWe will be using the AppImage from now on.\nPlease choose which data to keep.\nThe AppImage version should perform better than the one you already have\nDo not forget to run Steam Rom Manager to update your games for ${emu}"`"
  310. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
  311. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  312.  
  313. Did you mean:
  314. text="$(printf "Data was found for both the appimage and flatpak for ${emu}.\nWe will be using the AppImage from now on.\nPlease choose which data to keep.\nThe AppImage version should perform better than the one you already have\nDo not forget to run Steam Rom Manager to update your games for ${emu}")"
  315.  
  316.  
  317. In ./functions/migrateAndLinkConfig.sh line 49:
  318. ans=$(zenity --info --title "Migrate "${emu}" Data?" \
  319. ^----^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
  320. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  321.  
  322. Did you mean:
  323. ans=$(zenity --info --title "Migrate ""${emu}"" Data?" \
  324.  
  325.  
  326. In ./functions/migrateAndLinkConfig.sh line 55:
  327. rc=$?
  328. ^-- SC2034 (warning): rc appears unused. Verify use (or export if used externally).
  329.  
  330.  
  331. In ./functions/migrateAndLinkConfig.sh line 66:
  332. unlink ${toDir}
  333. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  334.  
  335. Did you mean:
  336. unlink "${toDir}"
  337.  
  338.  
  339. In ./functions/migrateAndLinkConfig.sh line 67:
  340. echo ${toDir}" is a symlink. Unlinked."
  341. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  342.  
  343. Did you mean:
  344. echo "${toDir}"" is a symlink. Unlinked."
  345.  
  346.  
  347. In ./functions/migrateAndLinkConfig.sh line 71:
  348. echo ${toDir}" is a directory. Backed up."
  349. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  350.  
  351. Did you mean:
  352. echo "${toDir}"" is a directory. Backed up."
  353.  
  354.  
  355. In ./functions/migrateAndLinkConfig.sh line 73:
  356. mkdir -p $toDir && rsync -av "${fromDir}/" "${toDir}"
  357. ^----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  358.  
  359. Did you mean:
  360. mkdir -p "$toDir" && rsync -av "${fromDir}/" "${toDir}"
  361.  
  362.  
  363. In ./functions/migrateAndLinkConfig.sh line 74:
  364. cd ${fromDir}
  365. ^-----------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  366. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  367.  
  368. Did you mean:
  369. cd "${fromDir}" || exit
  370.  
  371.  
  372. In ./functions/migrateAndLinkConfig.sh line 75:
  373. cd ..
  374. ^---^ SC2103 (info): Use a ( subshell ) to avoid having to cd back.
  375.  
  376.  
  377. In ./functions/migrateAndLinkConfig.sh line 80:
  378. ln -sfn ${toDir} .
  379. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  380.  
  381. Did you mean:
  382. ln -sfn "${toDir}" .
  383.  
  384.  
  385. In ./functions/migrateAndLinkConfig.sh line 85:
  386. cd ${toDir}
  387. ^---------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  388. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  389.  
  390. Did you mean:
  391. cd "${toDir}" || exit
  392.  
  393.  
  394. In ./functions/migrateAndLinkConfig.sh line 86:
  395. cd ..
  396. ^---^ SC2103 (info): Use a ( subshell ) to avoid having to cd back.
  397.  
  398.  
  399. In ./functions/migrateAndLinkConfig.sh line 112:
  400. cd ${fromDir}/..
  401. ^--------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  402. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  403.  
  404. Did you mean:
  405. cd "${fromDir}"/.. || exit
  406.  
  407.  
  408. In ./functions/migrateAndLinkConfig.sh line 114:
  409. mkdir -p ${toDir} && rmdir ${toDir} #make the path for todir, but remove the end folder
  410. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  411. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  412.  
  413. Did you mean:
  414. mkdir -p "${toDir}" && rmdir "${toDir}" #make the path for todir, but remove the end folder
  415.  
  416.  
  417. In ./functions/migrateAndLinkConfig.sh line 117:
  418. ln -sfn ${toDir} .
  419. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  420.  
  421. Did you mean:
  422. ln -sfn "${toDir}" .
  423.  
  424.  
  425. In ./functions/migrateAndLinkConfig.sh line 123:
  426. touch $migrationFlag
  427. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  428.  
  429. Did you mean:
  430. touch "$migrationFlag"
  431.  
  432.  
  433. In ./functions/migrateAndLinkConfig.sh line 124:
  434. elif [ $doMigrate == "Leave ${emu} alone forever" ]; then
  435. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  436.  
  437. Did you mean:
  438. elif [ "$doMigrate" == "Leave ${emu} alone forever" ]; then
  439.  
  440.  
  441. In ./functions/migrateAndLinkConfig.sh line 125:
  442. touch $migrationFlag
  443. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  444.  
  445. Did you mean:
  446. touch "$migrationFlag"
  447.  
  448.  
  449. In ./functions/updateEmuFP.sh line 9:
  450. flatpak update $ID -y --system
  451. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  452.  
  453. Did you mean:
  454. flatpak update "$ID" -y --system
  455.  
  456.  
  457. In ./functions/updateEmuFP.sh line 10:
  458. flatpak override $ID --filesystem=host --user
  459. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  460.  
  461. Did you mean:
  462. flatpak override "$ID" --filesystem=host --user
  463.  
  464.  
  465. In ./functions/updateEmuFP.sh line 11:
  466. flatpak override $ID --share=network --user
  467. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  468.  
  469. Did you mean:
  470. flatpak override "$ID" --share=network --user
  471.  
  472.  
  473. In ./functions/updateEmuFP.sh line 15:
  474. find "${toolsPath}"launchers/ -type f -iname $shName.sh | while read f; do echo "deleting $f"; rm -f "$f"; done;
  475. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  476. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  477. ^--^ SC2162 (info): read without -r will mangle backslashes.
  478.  
  479. Did you mean:
  480. find "${toolsPath}"launchers/ -type f -iname "$shName".sh | while read f; do echo "deleting $f"; rm -f "$f"; done;
  481.  
  482.  
  483. In ./functions/emuDeckPrereqs.sh line 11:
  484. wheel=$(awk '/'${USER}'/ {if ($1 ~ /wheel/) print}' /etc/group)
  485. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  486.  
  487. Did you mean:
  488. wheel=$(awk '/'"${USER}"'/ {if ($1 ~ /wheel/) print}' /etc/group)
  489.  
  490.  
  491. In ./functions/emuDeckPrereqs.sh line 18:
  492. sudo usermod -a -G wheel ${USER}
  493. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  494.  
  495. Did you mean:
  496. sudo usermod -a -G wheel "${USER}"
  497.  
  498.  
  499. In ./functions/emuDeckPrereqs.sh line 23:
  500. if [[ "$(stat -c %U ${HOME}/Desktop)" =~ root ]]; then
  501. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  502.  
  503. Did you mean:
  504. if [[ "$(stat -c %U "${HOME}"/Desktop)" =~ root ]]; then
  505.  
  506.  
  507. In ./functions/emuDeckPrereqs.sh line 24:
  508. sudo chown -R ${USER}:${USER} ~/Desktop
  509. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  510. ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
  511.  
  512. Did you mean:
  513. sudo chown -R "${USER}":"${USER}" ~/Desktop
  514.  
  515.  
  516. In ./functions/checkPSBIOS.sh line 6:
  517. for entry in $biosPath/*
  518. ^-------^ SC2154 (warning): biosPath is referenced but not assigned.
  519. ^-------^ SC2231 (info): Quote expansions in this for loop glob to prevent wordsplitting, e.g. "$dir"/*.txt .
  520.  
  521.  
  522. In ./functions/checkPSBIOS.sh line 9:
  523. md5=($(md5sum "$entry"))
  524. ^----------------^ SC2207 (warning): Prefer mapfile or read -a to split command output (or quote to avoid splitting).
  525.  
  526.  
  527. In ./functions/checkPSBIOS.sh line 14:
  528. if [[ "$md5" == *"${i}"* ]]; then
  529. ^--^ SC2128 (warning): Expanding an array without an index only gives the first element.
  530.  
  531.  
  532. In ./functions/checkPSBIOS.sh line 27:
  533. if [[ "$md5" == *"${i}"* ]]; then
  534. ^--^ SC2128 (warning): Expanding an array without an index only gives the first element.
  535.  
  536.  
  537. In ./functions/checkPSBIOS.sh line 41:
  538. text="`printf "<b>PS1 bios not detected</b>\nYou need to copy your BIOS to: \n${biosPath}\n\n<b>Make sure they are not in a subdirectory</b>"`"
  539. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
  540. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  541.  
  542. Did you mean:
  543. text="$(printf "<b>PS1 bios not detected</b>\nYou need to copy your BIOS to: \n${biosPath}\n\n<b>Make sure they are not in a subdirectory</b>")"
  544.  
  545.  
  546. In ./functions/checkPSBIOS.sh line 50:
  547. text="`printf "<b>PS2 bios not detected</b>\nYou need to copy your BIOS to: \n${biosPath}\n\n<b>Make sure they are not in a subdirectory</b>"`"
  548. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
  549. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  550.  
  551. Did you mean:
  552. text="$(printf "<b>PS2 bios not detected</b>\nYou need to copy your BIOS to: \n${biosPath}\n\n<b>Make sure they are not in a subdirectory</b>")"
  553.  
  554.  
  555. In ./functions/ToolScripts/emuDeckESDE.sh line 4:
  556. ESDE_toolType="AppImage"
  557. ^-----------^ SC2034 (warning): ESDE_toolType appears unused. Verify use (or export if used externally).
  558.  
  559.  
  560. In ./functions/ToolScripts/emuDeckESDE.sh line 5:
  561. ESDE_toolPath="${toolsPath}/EmulationStation-DE-x64_SteamDeck.AppImage"
  562. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  563.  
  564.  
  565. In ./functions/ToolScripts/emuDeckESDE.sh line 42:
  566. ESDE_applyTheme "$esdeTheme"
  567. ^--------^ SC2154 (warning): esdeTheme is referenced but not assigned.
  568.  
  569.  
  570. In ./functions/ToolScripts/emuDeckESDE.sh line 74:
  571. --var newSystem '$prev' \
  572. ^-----^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  573.  
  574.  
  575. In ./functions/ToolScripts/emuDeckESDE.sh line 75:
  576. --subnode '$newSystem' --type elem --name 'name' -v 'wiiu' \
  577. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  578.  
  579.  
  580. In ./functions/ToolScripts/emuDeckESDE.sh line 76:
  581. --subnode '$newSystem' --type elem --name 'fullname' -v 'Nintendo Wii U' \
  582. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  583.  
  584.  
  585. In ./functions/ToolScripts/emuDeckESDE.sh line 77:
  586. --subnode '$newSystem' --type elem --name 'path' -v '%ROMPATH%/wiiu/roms' \
  587. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  588.  
  589.  
  590. In ./functions/ToolScripts/emuDeckESDE.sh line 78:
  591. --subnode '$newSystem' --type elem --name 'extension' -v '.rpx .RPX .wud .WUD .wux .WUX .elf .ELF .iso .ISO .wad .WAD .wua .WUA' \
  592. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  593.  
  594.  
  595. In ./functions/ToolScripts/emuDeckESDE.sh line 79:
  596. --subnode '$newSystem' --type elem --name 'command' -v "/usr/bin/bash ${toolsPath}/launchers/cemu.sh -f -g z:%ROM%" \
  597. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  598.  
  599.  
  600. In ./functions/ToolScripts/emuDeckESDE.sh line 80:
  601. --insert '$newSystem/command' --type attr --name 'label' --value "Cemu (Proton)" \
  602. ^------------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  603.  
  604.  
  605. In ./functions/ToolScripts/emuDeckESDE.sh line 81:
  606. --subnode '$newSystem' --type elem --name 'platform' -v 'wiiu' \
  607. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  608.  
  609.  
  610. In ./functions/ToolScripts/emuDeckESDE.sh line 82:
  611. --subnode '$newSystem' --type elem --name 'theme' -v 'wiiu' \
  612. ^----------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  613.  
  614.  
  615. In ./functions/ToolScripts/emuDeckESDE.sh line 128:
  616. esDE_romDir="<string name=\"ROMDirectory\" value=\""${romsPath}"\" />" #roms
  617. ^---------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
  618. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  619.  
  620.  
  621. In ./functions/ToolScripts/emuDeckESDE.sh line 134:
  622. esDE_MediaDir="<string name=\"MediaDirectory\" value=\""${ESDEscrapData}"\" />"
  623. ^--------------^ SC2027 (warning): The surrounding quotes actually unquote this. Remove or escape them.
  624. ^--------------^ SC2154 (warning): ESDEscrapData is referenced but not assigned.
  625.  
  626.  
  627. In ./functions/ToolScripts/emuDeckESDE.sh line 183:
  628. cd $(echo $romsPath | tr -d '\r')
  629. ^-- SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  630. ^----------------------------^ SC2046 (warning): Quote this to prevent word splitting.
  631. ^-------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  632.  
  633. Did you mean:
  634. cd $(echo "$romsPath" | tr -d '\r') || exit
  635.  
  636.  
  637. In ./functions/ToolScripts/emuDeckESDE.sh line 200:
  638. gamelistFound=$(grep -rnw $gamelistFile -e 'gameList')
  639. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  640.  
  641. Did you mean:
  642. gamelistFound=$(grep -rnw "$gamelistFile" -e 'gameList')
  643.  
  644.  
  645. In ./functions/ToolScripts/emuDeckESDE.sh line 202:
  646. sed -i -e '$a\<gameList />' $gamelistFile
  647. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  648.  
  649. Did you mean:
  650. sed -i -e '$a\<gameList />' "$gamelistFile"
  651.  
  652.  
  653. In ./functions/ToolScripts/emuDeckESDE.sh line 204:
  654. alternativeEmu=$(grep -rnw $gamelistFile -e 'alternativeEmulator')
  655. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  656.  
  657. Did you mean:
  658. alternativeEmu=$(grep -rnw "$gamelistFile" -e 'alternativeEmulator')
  659.  
  660.  
  661. In ./functions/ToolScripts/emuDeckESDE.sh line 206:
  662. echo "<alternativeEmulator><label>$emu</label></alternativeEmulator>" >> $gamelistFile
  663. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  664.  
  665. Did you mean:
  666. echo "<alternativeEmulator><label>$emu</label></alternativeEmulator>" >> "$gamelistFile"
  667.  
  668.  
  669. In ./functions/ToolScripts/emuDeckESDE.sh line 208:
  670. sed -i "s|<?xml version=\"1.0\">|<?xml version=\"1.0\"?>|g" $gamelistFile
  671. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  672.  
  673. Did you mean:
  674. sed -i "s|<?xml version=\"1.0\">|<?xml version=\"1.0\"?>|g" "$gamelistFile"
  675.  
  676.  
  677. In ./functions/ToolScripts/emuDeckBINUP.sh line 4:
  678. BINUP_toolType="script"
  679. ^------------^ SC2034 (warning): BINUP_toolType appears unused. Verify use (or export if used externally).
  680.  
  681.  
  682. In ./functions/ToolScripts/emuDeckBINUP.sh line 5:
  683. BINUP_toolPath="${toolsPath}/binupdate/binupdate.sh"
  684. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  685.  
  686.  
  687. In ./functions/ToolScripts/emuDeckBINUP.sh line 16:
  688. sed -i "s|/run/media/mmcblk0p1/Emulation/roms|${romsPath}|g" "$BINUP_toolPath"
  689. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  690.  
  691.  
  692. In ./functions/ToolScripts/emuDeckSRM.sh line 3:
  693. SRM_toolName="Steam Rom Manager"
  694. ^----------^ SC2034 (warning): SRM_toolName appears unused. Verify use (or export if used externally).
  695.  
  696.  
  697. In ./functions/ToolScripts/emuDeckSRM.sh line 4:
  698. SRM_toolType="AppImage"
  699. ^----------^ SC2034 (warning): SRM_toolType appears unused. Verify use (or export if used externally).
  700.  
  701.  
  702. In ./functions/ToolScripts/emuDeckSRM.sh line 5:
  703. SRM_toolPath="${toolsPath}/srm/Steam-ROM-Manager.AppImage"
  704. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  705.  
  706.  
  707. In ./functions/ToolScripts/emuDeckSRM.sh line 56:
  708. jq -r --arg ROMSDIR "$romsPath" '.environmentVariables.romsDirectory = "\($ROMSDIR)"' \
  709. ^-------^ SC2154 (warning): romsPath is referenced but not assigned.
  710.  
  711.  
  712. In ./functions/ToolScripts/emuDeckSRM.sh line 62:
  713. sed -i "s|/run/media/mmcblk0p1/Emulation/storage|${storagePath}|g" "$HOME/.config/steam-rom-manager/userData/userConfigurations.json"
  714. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  715.  
  716.  
  717. In ./functions/ToolScripts/emuDeckCHD.sh line 4:
  718. CHD_toolType="script"
  719. ^----------^ SC2034 (warning): CHD_toolType appears unused. Verify use (or export if used externally).
  720.  
  721.  
  722. In ./functions/ToolScripts/emuDeckCHD.sh line 5:
  723. CHD_toolPath="${toolsPath}/chdconv/chddeck.sh"
  724. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  725.  
  726.  
  727. In ./functions/ToolScripts/emuDeckCHD.sh line 16:
  728. sed -i "s|/run/media/mmcblk0p1/Emulation/roms|${romsPath}|g" "$CHD_toolPath"
  729. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  730.  
  731.  
  732. In ./functions/ToolScripts/emuDeckSaveSync.sh line 3:
  733. SAVESYNC_toolName="EmuDeck SaveSync"
  734. ^---------------^ SC2034 (warning): SAVESYNC_toolName appears unused. Verify use (or export if used externally).
  735.  
  736.  
  737. In ./functions/ToolScripts/emuDeckSaveSync.sh line 4:
  738. SAVESYNC_toolType="AppImage"
  739. ^---------------^ SC2034 (warning): SAVESYNC_toolType appears unused. Verify use (or export if used externally).
  740.  
  741.  
  742. In ./functions/ToolScripts/emuDeckSaveSync.sh line 28:
  743. mv "${toolsPath}/savesync/config.yml" "${toolsPath}/savesync/config.yml.bak"
  744. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  745.  
  746.  
  747. In ./functions/ToolScripts/emuDeckSaveSync.sh line 31:
  748. "$SAVESYNC_toolPath" "$emulationPath" --setup "$cloudProvider"
  749. ^------------^ SC2154 (warning): emulationPath is referenced but not assigned.
  750.  
  751.  
  752. In ./functions/configEmuAI.sh line 18:
  753. rsync -avhp --mkpath $gitLocation/ $folderPath $overwrite
  754. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  755. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  756.  
  757. Did you mean:
  758. rsync -avhp --mkpath "$gitLocation"/ "$folderPath" $overwrite
  759.  
  760.  
  761. In ./functions/installEmuFP.sh line 9:
  762. flatpak install flathub $ID -y --system
  763. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  764.  
  765. Did you mean:
  766. flatpak install flathub "$ID" -y --system
  767.  
  768.  
  769. In ./functions/installEmuFP.sh line 10:
  770. flatpak override $ID --filesystem=host --user
  771. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  772.  
  773. Did you mean:
  774. flatpak override "$ID" --filesystem=host --user
  775.  
  776.  
  777. In ./functions/installEmuFP.sh line 11:
  778. flatpak override $ID --share=network --user
  779. ^-^ SC2086 (info): Double quote to prevent globbing and word splitting.
  780.  
  781. Did you mean:
  782. flatpak override "$ID" --share=network --user
  783.  
  784.  
  785. In ./functions/installEmuFP.sh line 15:
  786. find "${toolsPath}/launchers/" -type f -iname "$shName.sh" -o -type f -iname "$shName-emu.sh" | while read -r f; do echo "deleting $f"; rm -f "$f"; done;
  787. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  788.  
  789.  
  790. In ./functions/EmuScripts/emuDeckXemu.sh line 4:
  791. Xemu_emuType="FlatPak"
  792. ^----------^ SC2034 (warning): Xemu_emuType appears unused. Verify use (or export if used externally).
  793.  
  794.  
  795. In ./functions/EmuScripts/emuDeckXemu.sh line 43:
  796. bootrrom_pathSetting="${bootrrom_path}""'${biosPath}/mcpx_1.0.bin'"
  797. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  798.  
  799.  
  800. In ./functions/EmuScripts/emuDeckXemu.sh line 45:
  801. eeprom_pathSetting="${eeprom_path}""'${storagePath}/xemu/eeprom.bin'"
  802. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  803.  
  804.  
  805. In ./functions/EmuScripts/emuDeckXemu.sh line 66:
  806. cd "${storagePath}/xemu"
  807. ^----------------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  808.  
  809. Did you mean:
  810. cd "${storagePath}/xemu" || exit
  811.  
  812.  
  813. In ./functions/EmuScripts/emuDeckXemu.sh line 98:
  814. if [ -f "${savesPath}/xemu/xbox_hdd.qcow2" ]; then
  815. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  816.  
  817.  
  818. In ./functions/EmuScripts/emuDeckXemu.sh line 99:
  819. mv -fv ${savesPath}/xemu/* ${storagePath}/xemu/ && rm -rf ${savesPath}/xemu/
  820. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  821. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  822. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  823.  
  824. Did you mean:
  825. mv -fv "${savesPath}"/xemu/* "${storagePath}"/xemu/ && rm -rf "${savesPath}"/xemu/
  826.  
  827.  
  828. In ./functions/EmuScripts/emuDeckXemu.sh line 102:
  829. mv "$HOME/.var/app/app.xemu.xemu/data/xemu/xemu/xbox_hdd.qcow2" $storagePath/xemu/
  830. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  831.  
  832. Did you mean:
  833. mv "$HOME/.var/app/app.xemu.xemu/data/xemu/xemu/xbox_hdd.qcow2" "$storagePath"/xemu/
  834.  
  835.  
  836. In ./functions/EmuScripts/emuDeckXemu.sh line 103:
  837. mv "$HOME/.var/app/app.xemu.xemu/data/xemu/xemu/eeprom.bin" $storagePath/xemu/
  838. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  839.  
  840. Did you mean:
  841. mv "$HOME/.var/app/app.xemu.xemu/data/xemu/xemu/eeprom.bin" "$storagePath"/xemu/
  842.  
  843.  
  844. In ./functions/EmuScripts/emuDeckCemu.sh line 4:
  845. Cemu_emuType="windows"
  846. ^----------^ SC2034 (warning): Cemu_emuType appears unused. Verify use (or export if used externally).
  847.  
  848.  
  849. In ./functions/EmuScripts/emuDeckCemu.sh line 5:
  850. Cemu_emuPath="${romsPath}/wiiu/cemu.exe"
  851. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  852.  
  853.  
  854. In ./functions/EmuScripts/emuDeckCemu.sh line 26:
  855. if [ -e "${toolsPath}/launchers/cemu.sh" ]; then #retain launch settings
  856. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  857.  
  858.  
  859. In ./functions/EmuScripts/emuDeckCemu.sh line 27:
  860. local launchLine=$( tail -n 1 "${toolsPath}/launchers/cemu.sh" )
  861. ^--------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
  862.  
  863.  
  864. In ./functions/EmuScripts/emuDeckCemu.sh line 37:
  865. changeLine '"${PROTONLAUNCH}"' "$launchLine" "${toolsPath}/launchers/cemu.sh"
  866. ^-----------------^ SC2016 (info): Expressions don't expand in single quotes, use double quotes for that.
  867.  
  868.  
  869. In ./functions/EmuScripts/emuDeckCemu.sh line 85:
  870. unlink "${savesPath}/Cemu/saves" # Fix for previous bad symlink
  871. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  872.  
  873.  
  874. In ./functions/EmuScripts/emuDeckRetroArch.sh line 4:
  875. RetroArch_emuType="FlatPak"
  876. ^---------------^ SC2034 (warning): RetroArch_emuType appears unused. Verify use (or export if used externally).
  877.  
  878.  
  879. In ./functions/EmuScripts/emuDeckRetroArch.sh line 6:
  880. RetroArch_releaseURL=""
  881. ^------------------^ SC2034 (warning): RetroArch_releaseURL appears unused. Verify use (or export if used externally).
  882.  
  883.  
  884. In ./functions/EmuScripts/emuDeckRetroArch.sh line 59:
  885. system_directorySetting="${system_directory}""\"${biosPath}\""
  886. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  887.  
  888.  
  889. In ./functions/EmuScripts/emuDeckRetroArch.sh line 1456:
  890. curl $raUrl$i.zip --output ~/.var/app/org.libretro.RetroArch/config/retroarch/cores/${i}.zip
  891. ^-- SC2086 (info): Double quote to prevent globbing and word splitting.
  892. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  893.  
  894. Did you mean:
  895. curl $raUrl"$i".zip --output ~/.var/app/org.libretro.RetroArch/config/retroarch/cores/"${i}".zip
  896.  
  897.  
  898. In ./functions/EmuScripts/emuDeckRetroArch.sh line 1493:
  899. find "$RetroArch_coreConfigFolders" -type f -iname "*.cfg" -o -type f -iname "*.opt"| while read file
  900. ^--^ SC2162 (info): read without -r will mangle backslashes.
  901.  
  902.  
  903. In ./functions/EmuScripts/emuDeckRetroArch.sh line 1559:
  904. if [ "$RABezels" == true ]; then
  905. ^-------^ SC2154 (warning): RABezels is referenced but not assigned.
  906.  
  907.  
  908. In ./functions/EmuScripts/emuDeckRetroArch.sh line 1566:
  909. if [ "$RAHandClassic2D" == true ]; then
  910. ^--------------^ SC2154 (warning): RAHandClassic2D is referenced but not assigned.
  911.  
  912.  
  913. In ./functions/EmuScripts/emuDeckRetroArch.sh line 1573:
  914. if [ "$RAHandHeldShader" == true ]; then
  915. ^---------------^ SC2154 (warning): RAHandHeldShader is referenced but not assigned.
  916.  
  917.  
  918. In ./functions/EmuScripts/emuDeckYuzu.sh line 4:
  919. Yuzu_emuName="Yuzu"
  920. ^----------^ SC2034 (warning): Yuzu_emuName appears unused. Verify use (or export if used externally).
  921.  
  922.  
  923. In ./functions/EmuScripts/emuDeckYuzu.sh line 5:
  924. Yuzu_emuType="AppImage"
  925. ^----------^ SC2034 (warning): Yuzu_emuType appears unused. Verify use (or export if used externally).
  926.  
  927.  
  928. In ./functions/EmuScripts/emuDeckYuzu.sh line 68:
  929. newScreenshotDirOpt='Screenshots\\screenshot_path='"${storagePath}/yuzu/screenshots"
  930. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  931.  
  932.  
  933. In ./functions/EmuScripts/emuDeckYuzu.sh line 69:
  934. newGameDirOpt='Paths\\gamedirs\\4\\path='"${romsPath}/switch"
  935. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  936.  
  937.  
  938. In ./functions/EmuScripts/emuDeckYuzu.sh line 86:
  939. unlink "${biosPath}/yuzu/keys" 2>/dev/null
  940. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  941.  
  942.  
  943. In ./functions/EmuScripts/emuDeckYuzu.sh line 102:
  944. unlink "${savesPath}/yuzu/saves" 2>/dev/null # Fix for previous bad symlink2>/dev/null
  945. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  946.  
  947.  
  948. In ./functions/EmuScripts/emuDeckYuzu.sh line 147:
  949. migrateAndLinkConfig "$emu" "$migrationTable"
  950. ^-------------^ SC2128 (warning): Expanding an array without an index only gives the first element.
  951.  
  952.  
  953. In ./functions/EmuScripts/emuDeckCitra.sh line 4:
  954. Citra_emuType="FlatPak"
  955. ^-----------^ SC2034 (warning): Citra_emuType appears unused. Verify use (or export if used externally).
  956.  
  957.  
  958. In ./functions/EmuScripts/emuDeckCitra.sh line 6:
  959. Citra_releaseURL=""
  960. ^--------------^ SC2034 (warning): Citra_releaseURL appears unused. Verify use (or export if used externally).
  961.  
  962.  
  963. In ./functions/EmuScripts/emuDeckCitra.sh line 45:
  964. newGameDirOpt='Paths\\gamedirs\\3\\path='"${romsPath}/3ds"
  965. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  966.  
  967.  
  968. In ./functions/EmuScripts/emuDeckRyujinx.sh line 4:
  969. Ryujinx_emuName="Ryujinx"
  970. ^-------------^ SC2034 (warning): Ryujinx_emuName appears unused. Verify use (or export if used externally).
  971.  
  972.  
  973. In ./functions/EmuScripts/emuDeckRyujinx.sh line 5:
  974. Ryujinx_emuType="Binary"
  975. ^-------------^ SC2034 (warning): Ryujinx_emuType appears unused. Verify use (or export if used externally).
  976.  
  977.  
  978. In ./functions/EmuScripts/emuDeckRyujinx.sh line 78:
  979. unlink "${biosPath}/ryujinx/keys"
  980. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  981.  
  982.  
  983. In ./functions/EmuScripts/emuDeckRyujinx.sh line 84:
  984. sed -i "s|/run/media/mmcblk0p1/Emulation/roms|${romsPath}|g" "$HOME/.config/Ryujinx/Config.json"
  985. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  986.  
  987.  
  988. In ./functions/EmuScripts/emuDeckRyujinx.sh line 102:
  989. mkdir -p "${storagePath}/ryujinx/"
  990. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  991.  
  992.  
  993. In ./functions/EmuScripts/emuDeckRyujinx.sh line 125:
  994. emu="Ryujinx"
  995. ^-^ SC2034 (warning): emu appears unused. Verify use (or export if used externally).
  996.  
  997.  
  998. In ./functions/EmuScripts/emuDeckDolphin.sh line 4:
  999. Dolphin_emuType="FlatPak"
  1000. ^-------------^ SC2034 (warning): Dolphin_emuType appears unused. Verify use (or export if used externally).
  1001.  
  1002.  
  1003. In ./functions/EmuScripts/emuDeckDolphin.sh line 6:
  1004. Dolphin_releaseURL=""
  1005. ^----------------^ SC2034 (warning): Dolphin_releaseURL appears unused. Verify use (or export if used externally).
  1006.  
  1007.  
  1008. In ./functions/EmuScripts/emuDeckDolphin.sh line 47:
  1009. gameDirOpt1Setting='ISOPath0 = '"${romsPath}/gc"
  1010. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1011.  
  1012.  
  1013. In ./functions/EmuScripts/emuDeckPPSSPP.sh line 4:
  1014. PPSSPP_emuType="FlatPak"
  1015. ^------------^ SC2034 (warning): PPSSPP_emuType appears unused. Verify use (or export if used externally).
  1016.  
  1017.  
  1018. In ./functions/EmuScripts/emuDeckPPSSPP.sh line 6:
  1019. PPSSPP_releaseURL=""
  1020. ^---------------^ SC2034 (warning): PPSSPP_releaseURL appears unused. Verify use (or export if used externally).
  1021.  
  1022.  
  1023. In ./functions/EmuScripts/emuDeckPPSSPP.sh line 40:
  1024. newGameDirOpt='CurrentDirectory = '"${romsPath}/psp"
  1025. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1026.  
  1027.  
  1028. In ./functions/EmuScripts/emuDeckDuckStation.sh line 5:
  1029. DuckStation_emuType="FlatPak"
  1030. ^-----------------^ SC2034 (warning): DuckStation_emuType appears unused. Verify use (or export if used externally).
  1031.  
  1032.  
  1033. In ./functions/EmuScripts/emuDeckDuckStation.sh line 47:
  1034. newGameDirOpt="${gameDirOpt}""${romsPath}/psx"
  1035. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1036.  
  1037.  
  1038. In ./functions/EmuScripts/emuDeckDuckStation.sh line 49:
  1039. biosDirSetting="${biosDir}""${biosPath}"
  1040. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  1041.  
  1042.  
  1043. In ./functions/EmuScripts/emuDeckDuckStation.sh line 54:
  1044. statesDirSetting="${statesDir}""${savesPath}/duckstation/states"
  1045. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  1046.  
  1047.  
  1048. In ./functions/EmuScripts/emuDeckRPCS3.sh line 4:
  1049. RPCS3_emuType="FlatPak"
  1050. ^-----------^ SC2034 (warning): RPCS3_emuType appears unused. Verify use (or export if used externally).
  1051.  
  1052.  
  1053. In ./functions/EmuScripts/emuDeckRPCS3.sh line 6:
  1054. RPCS3_releaseURL=""
  1055. ^--------------^ SC2034 (warning): RPCS3_releaseURL appears unused. Verify use (or export if used externally).
  1056.  
  1057.  
  1058. In ./functions/EmuScripts/emuDeckRPCS3.sh line 42:
  1059. linkToSaveFolder rpcs3 saves "${storagePath}/rpcs3/dev_hdd0/home/00000001/savedata"
  1060. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  1061.  
  1062.  
  1063. In ./functions/EmuScripts/emuDeckRPCS3.sh line 50:
  1064. sed -i "/dev_hdd0/c\\${rpcs3DevHDD0Line}" $rpcs3VFSConf
  1065. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1066.  
  1067. Did you mean:
  1068. sed -i "/dev_hdd0/c\\${rpcs3DevHDD0Line}" "$rpcs3VFSConf"
  1069.  
  1070.  
  1071. In ./functions/EmuScripts/emuDeckRPCS3.sh line 52:
  1072. mkdir -p $storagePath/rpcs3/
  1073. ^----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1074.  
  1075. Did you mean:
  1076. mkdir -p "$storagePath"/rpcs3/
  1077.  
  1078.  
  1079. In ./functions/EmuScripts/emuDeckRPCS3.sh line 63:
  1080. if [ -d "$savesPath/rpcs3/dev_hdd0" ]; then
  1081. ^--------^ SC2154 (warning): savesPath is referenced but not assigned.
  1082.  
  1083.  
  1084. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 4:
  1085. PCSX2QT_emuType="AppImage"
  1086. ^-------------^ SC2034 (warning): PCSX2QT_emuType appears unused. Verify use (or export if used externally).
  1087.  
  1088.  
  1089. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 5:
  1090. PCSX2QT_emuPath="$HOME/Applications/pcsx2-Qt.AppImage"
  1091. ^-------------^ SC2034 (warning): PCSX2QT_emuPath appears unused. Verify use (or export if used externally).
  1092.  
  1093.  
  1094. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 52:
  1095. newBiosDirOpt='Bios = '"${biosPath}"
  1096. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  1097.  
  1098.  
  1099. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 53:
  1100. newsnapShotsDirOpt='Snapshots = '"${storagePath}/pcsx2/snaps"
  1101. ^------------^ SC2154 (warning): storagePath is referenced but not assigned.
  1102.  
  1103.  
  1104. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 54:
  1105. newsaveStatesDirOpt='SaveStates = '"${savesPath}/pcsx2/states"
  1106. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  1107.  
  1108.  
  1109. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 59:
  1110. newrecursivePathsDirOpt='RecursivePaths = '"${romsPath}/ps2"
  1111. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1112.  
  1113.  
  1114. In ./functions/EmuScripts/emuDeckPCSX2QT.sh line 103:
  1115. rm -rf "$emuPath"
  1116. ^------^ SC2154 (warning): emuPath is referenced but not assigned.
  1117.  
  1118.  
  1119. In ./functions/EmuScripts/emuDeckPrimehack.sh line 5:
  1120. Primehack_emuType="FlatPak"
  1121. ^---------------^ SC2034 (warning): Primehack_emuType appears unused. Verify use (or export if used externally).
  1122.  
  1123.  
  1124. In ./functions/EmuScripts/emuDeckPrimehack.sh line 7:
  1125. releaseURL=""
  1126. ^--------^ SC2034 (warning): releaseURL appears unused. Verify use (or export if used externally).
  1127.  
  1128.  
  1129. In ./functions/EmuScripts/emuDeckPrimehack.sh line 40:
  1130. newGameDirOpt='ISOPath0 = '"${romsPath}/primehacks"
  1131. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1132.  
  1133.  
  1134. In ./functions/EmuScripts/emuDeckXenia.sh line 3:
  1135. Xenia_emuName="Xenia"
  1136. ^-----------^ SC2034 (warning): Xenia_emuName appears unused. Verify use (or export if used externally).
  1137.  
  1138.  
  1139. In ./functions/EmuScripts/emuDeckXenia.sh line 4:
  1140. Xenia_emuType="windows"
  1141. ^-----------^ SC2034 (warning): Xenia_emuType appears unused. Verify use (or export if used externally).
  1142.  
  1143.  
  1144. In ./functions/EmuScripts/emuDeckXenia.sh line 5:
  1145. Xenia_emuPath="${romsPath}/xbox360/Xenia.exe"
  1146. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1147.  
  1148.  
  1149. In ./functions/EmuScripts/emuDeckXenia.sh line 7:
  1150. Xenia_XeniaSettings="${romsPath}/xbox360/settings.xml"
  1151. ^-----------------^ SC2034 (warning): Xenia_XeniaSettings appears unused. Verify use (or export if used externally).
  1152.  
  1153.  
  1154. In ./functions/EmuScripts/emuDeckXenia.sh line 29:
  1155. rsync -avhp $EMUDECKGIT/configs/xenia/ "$romsPath"/xbox360
  1156. ^---------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1157.  
  1158. Did you mean:
  1159. rsync -avhp "$EMUDECKGIT"/configs/xenia/ "$romsPath"/xbox360
  1160.  
  1161.  
  1162. In ./functions/EmuScripts/emuDeckMAME.sh line 4:
  1163. MAME_emuType="FlatPak"
  1164. ^----------^ SC2034 (warning): MAME_emuType appears unused. Verify use (or export if used externally).
  1165.  
  1166.  
  1167. In ./functions/EmuScripts/emuDeckMAME.sh line 6:
  1168. MAME_releaseURL=""
  1169. ^-------------^ SC2034 (warning): MAME_releaseURL appears unused. Verify use (or export if used externally).
  1170.  
  1171.  
  1172. In ./functions/EmuScripts/emuDeckMAME.sh line 41:
  1173. newGameDirOpt="$gameDirOpt""${romsPath}/arcade;${biosPath};${biosPath}/mame"
  1174. ^---------^ SC2154 (warning): romsPath is referenced but not assigned.
  1175. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  1176.  
  1177.  
  1178. In ./functions/EmuScripts/emuDeckPCSX2.sh line 4:
  1179. PCSX2_emuType="FlatPak"
  1180. ^-----------^ SC2034 (warning): PCSX2_emuType appears unused. Verify use (or export if used externally).
  1181.  
  1182.  
  1183. In ./functions/EmuScripts/emuDeckPCSX2.sh line 46:
  1184. newBiosDirOpt='Bios='"${biosPath}"
  1185. ^---------^ SC2154 (warning): biosPath is referenced but not assigned.
  1186.  
  1187.  
  1188. In ./functions/EmuScripts/emuDeckPCSX2.sh line 47:
  1189. newsaveStatesDirOpt='Savestates='"${savesPath}/pcsx2/states"
  1190. ^----------^ SC2154 (warning): savesPath is referenced but not assigned.
  1191.  
  1192.  
  1193. In ./functions/nonDeck.sh line 22:
  1194. find "$RetroArch_coreConfigFolders" -type f -name "nes.cfg"| while read -r configFile
  1195. ^--------------------------^ SC2154 (warning): RetroArch_coreConfigFolders is referenced but not assigned.
  1196.  
  1197.  
  1198. In ./uninstall.sh line 2:
  1199. NONE='\033[00m'
  1200. ^--^ SC2034 (warning): NONE appears unused. Verify use (or export if used externally).
  1201.  
  1202.  
  1203. In ./uninstall.sh line 3:
  1204. RED='\033[01;31m'
  1205. ^-^ SC2034 (warning): RED appears unused. Verify use (or export if used externally).
  1206.  
  1207.  
  1208. In ./uninstall.sh line 4:
  1209. GREEN='\033[01;32m'
  1210. ^---^ SC2034 (warning): GREEN appears unused. Verify use (or export if used externally).
  1211.  
  1212.  
  1213. In ./uninstall.sh line 5:
  1214. YELLOW='\033[01;33m'
  1215. ^----^ SC2034 (warning): YELLOW appears unused. Verify use (or export if used externally).
  1216.  
  1217.  
  1218. In ./uninstall.sh line 6:
  1219. PURPLE='\033[01;35m'
  1220. ^----^ SC2034 (warning): PURPLE appears unused. Verify use (or export if used externally).
  1221.  
  1222.  
  1223. In ./uninstall.sh line 7:
  1224. CYAN='\033[01;36m'
  1225. ^--^ SC2034 (warning): CYAN appears unused. Verify use (or export if used externally).
  1226.  
  1227.  
  1228. In ./uninstall.sh line 8:
  1229. WHITE='\033[01;37m'
  1230. ^---^ SC2034 (warning): WHITE appears unused. Verify use (or export if used externally).
  1231.  
  1232.  
  1233. In ./uninstall.sh line 9:
  1234. BOLD='\033[1m'
  1235. ^--^ SC2034 (warning): BOLD appears unused. Verify use (or export if used externally).
  1236.  
  1237.  
  1238. In ./uninstall.sh line 10:
  1239. UNDERLINE='\033[4m'
  1240. ^-------^ SC2034 (warning): UNDERLINE appears unused. Verify use (or export if used externally).
  1241.  
  1242.  
  1243. In ./uninstall.sh line 11:
  1244. BLINK='\x1b[5m'
  1245. ^---^ SC2034 (warning): BLINK appears unused. Verify use (or export if used externally).
  1246.  
  1247.  
  1248. In ./uninstall.sh line 24:
  1249. doUninstallXenua=false
  1250. ^--------------^ SC2034 (warning): doUninstallXenua appears unused. Verify use (or export if used externally).
  1251.  
  1252.  
  1253. In ./uninstall.sh line 32:
  1254. text="`printf "<b>Hi!</b>\nDo you really want to uninstall Emudek?\n\nIf you are having issues please go to our Discord, Reddit so we can help you. You can see the links here: https://www.emudeck.com/#download"`"
  1255. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
  1256.  
  1257. Did you mean:
  1258. text="$(printf "<b>Hi!</b>\nDo you really want to uninstall Emudek?\n\nIf you are having issues please go to our Discord, Reddit so we can help you. You can see the links here: https://www.emudeck.com/#download")"
  1259.  
  1260.  
  1261. In ./uninstall.sh line 50:
  1262. text="`printf " <b>This will delete Emudeck , the emulators and all of its configuration files and saved games</b>\n\n You can keep the Emulators installed, tell me which ones you want to keep.\n\nIf you select none of them, everything will be deleted<b>We won't delete your roms, if you wanna keep your saved games go to the Emulation/saves folder and make a backup of its contents</b>"`"
  1263. ^-- SC2006 (style): Use $(...) notation instead of legacy backticks `...`.
  1264.  
  1265. Did you mean:
  1266. text="$(printf " <b>This will delete Emudeck , the emulators and all of its configuration files and saved games</b>\n\n You can keep the Emulators installed, tell me which ones you want to keep.\n\nIf you select none of them, everything will be deleted<b>We won't delete your roms, if you wanna keep your saved games go to the Emulation/saves folder and make a backup of its contents</b>")"
  1267.  
  1268.  
  1269. In ./uninstall.sh line 195:
  1270. rm -rf ~/emudeck &>> /dev/null
  1271. ^----------------------------^ SC2129 (style): Consider using { cmd1; cmd2; } >> file instead of individual redirects.
  1272.  
  1273.  
  1274. In ./uninstall.sh line 210:
  1275. --text="${text}" &>> /dev/null
  1276. ^--------------^ SC2215 (warning): This flag is used as a command name. Bad line break or missing [ .. ]?
  1277.  
  1278.  
  1279. In ./install.sh line 16:
  1280. if [ $? -eq 0 ]; then
  1281. ^-- SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1282.  
  1283.  
  1284. In ./install.sh line 22:
  1285. if [ $? -ne 0 ]; then
  1286. ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  1287.  
  1288.  
  1289. In ./install.sh line 29:
  1290. if [ $? -ne 0 ]; then
  1291. ^-- SC2181 (style): Check exit code directly with e.g. 'if ! mycmd;', not indirectly with $?.
  1292.  
  1293.  
  1294. In ./install.sh line 159:
  1295. if [[ ! $noPull == true ]]; then
  1296. ^-----^ SC2154 (warning): noPull is referenced but not assigned.
  1297.  
  1298.  
  1299. In ./install.sh line 160:
  1300. cd "$EMUDECKGIT"
  1301. ^--------------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  1302.  
  1303. Did you mean:
  1304. cd "$EMUDECKGIT" || exit
  1305.  
  1306.  
  1307. In ./install.sh line 226:
  1308. text="$(printf "<b>Hi, this is the changelog of the new features added in this version</b>\n\n${latest}")"
  1309. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  1310.  
  1311.  
  1312. In ./install.sh line 372:
  1313. expertModeFeatureList=$(zenity --list --checklist --width=1000 --height="${height}" \
  1314. ^-------^ SC2128 (warning): Expanding an array without an index only gives the first element.
  1315.  
  1316.  
  1317. In ./install.sh line 510:
  1318. setSetting esdeTheme $esdeTheme
  1319. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1320.  
  1321. Did you mean:
  1322. setSetting esdeTheme "$esdeTheme"
  1323.  
  1324.  
  1325. In ./install.sh line 1078:
  1326. if [ "$doSetupMAME" == "true" ]; then
  1327. ^----------^ SC2154 (warning): doSetupMAME is referenced but not assigned (did you mean 'doSetupMame'?).
  1328.  
  1329.  
  1330. In ./install.sh line 1137:
  1331. if [ "$PCSX2QTWide" == true ]; then
  1332. ^----------^ SC2154 (warning): PCSX2QTWide is referenced but not assigned (did you mean 'pcsx2QTWide'?).
  1333.  
  1334.  
  1335. In ./install.sh line 1359:
  1336. text="$(printf "<b>Yuzu is not configured</b>\nYou need to copy your Keys and firmware to: \n${biosPath}/yuzu/keys\n${biosPath}\yuzu/firmware\n\nMake sure to copy your files inside the folders. <b>Do not overwrite them</b>")"
  1337. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  1338.  
  1339.  
  1340. In ./install.sh line 1396:
  1341. text="$(printf "<b>Done!</b>\n\nRemember to add your games here:\n<b>${romsPath}</b>\nAnd your Bios (PS1, PS2, Yuzu, Ryujinx) here:\n<b>${biosPath}</b>\n\nOpen Steam Rom Manager on your Desktop to add your games to your SteamUI Interface.\n\nThere is a bug in RetroArch that if you are using Bezels you can not set save configuration files unless you close your current game. Use overrides for your custom configurations or use expert mode to disabled them\n\nIf you encounter any problem please visit our Discord:\n<b>https://discord.gg/b9F7GpXtFP</b>\n\nTo Update EmuDeck in the future, just run this App again.\n\nEnjoy!")"
  1342. ^-- SC2059 (info): Don't use variables in the printf format string. Use printf '..%s..' "$foo".
  1343.  
  1344.  
  1345. In ./tools/binupdate/binupdate.sh line 4:
  1346. source "$HOME/emudeck/backend/functions/all.sh"
  1347. ^-- SC1091 (info): Not following: ./emudeck/backend/functions/all.sh was not specified as input (see shellcheck -x).
  1348.  
  1349.  
  1350. In ./tools/binupdate/binupdate.sh line 47:
  1351. curl "$releaseChoice" --output "$romsPath/wiiu/cemu.zip"
  1352. ^-------^ SC2154 (warning): romsPath is referenced but not assigned.
  1353.  
  1354.  
  1355. In ./tools/binupdate/binupdate.sh line 62:
  1356. scriptPath="${toolsPath}/binupdate"
  1357. ^----------^ SC2154 (warning): toolsPath is referenced but not assigned.
  1358.  
  1359.  
  1360. In ./tools/binupdate/binupdate.sh line 99:
  1361. if [ "$?" == "0" ]; then
  1362. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1363.  
  1364.  
  1365. In ./tools/binupdate/binupdate.sh line 107:
  1366. if [ "$?" == "0" ]; then
  1367. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1368.  
  1369.  
  1370. In ./tools/binupdate/binupdate.sh line 115:
  1371. if [ "$?" == "0" ]; then
  1372. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1373.  
  1374.  
  1375. In ./tools/binupdate/binupdate.sh line 123:
  1376. if [ "$?" == "0" ]; then
  1377. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1378.  
  1379.  
  1380. In ./tools/binupdate/binupdate.sh line 131:
  1381. if [ "$?" == "0" ]; then
  1382. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1383.  
  1384.  
  1385. In ./tools/binupdate/binupdate.sh line 139:
  1386. if [ "$?" == "0" ]; then
  1387. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1388.  
  1389.  
  1390. In ./tools/binupdate/binupdate.sh line 147:
  1391. if [ "$?" == "0" ]; then
  1392. ^--^ SC2181 (style): Check exit code directly with e.g. 'if mycmd;', not indirectly with $?.
  1393.  
  1394.  
  1395. In ./tools/flatpakupdate/flatpakupdate.sh line 2:
  1396. source "$HOME/emudeck/backend/functions/all.sh"
  1397. ^-- SC1091 (info): Not following: ./emudeck/backend/functions/all.sh was not specified as input (see shellcheck -x).
  1398.  
  1399.  
  1400. In ./tools/launchers/yuzu.sh line 6:
  1401. exe=$(find $emufolder -iname "${emuName}*.AppImage" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1402. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1403.  
  1404. Did you mean:
  1405. exe=$(find "$emufolder" -iname "${emuName}*.AppImage" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1406.  
  1407.  
  1408. In ./tools/launchers/yuzu.sh line 9:
  1409. if [[ $exe == '' ]]; then
  1410. ^--------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
  1411.  
  1412.  
  1413. In ./tools/launchers/yuzu.sh line 15:
  1414. chmod +x $exe
  1415. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1416.  
  1417. Did you mean:
  1418. chmod +x "$exe"
  1419.  
  1420.  
  1421. In ./tools/launchers/yuzu.sh line 19:
  1422. param="${@}"
  1423. ^----^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
  1424.  
  1425.  
  1426. In ./tools/launchers/yuzu.sh line 21:
  1427. param=${param/\'/"$substituteWith"}
  1428. ^---------------------------^ SC3060 (warning): In POSIX sh, string replacement is undefined.
  1429.  
  1430.  
  1431. In ./tools/launchers/xenia.sh line 19:
  1432. export STEAM_COMPAT_DATA_PATH="${PFX}"/${SteamAppId:-${APPID}}
  1433. ^---------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1434.  
  1435. Did you mean:
  1436. export STEAM_COMPAT_DATA_PATH="${PFX}"/"${SteamAppId:-${APPID}}"
  1437.  
  1438.  
  1439. In ./tools/launchers/xenia.sh line 20:
  1440. elif ! [ ${SteamGameId} -ge 0 ] 2>/dev/null && ! [ ${SteamAppId} -ge 0 ] 2>/dev/null && ! [ $(basename ${STEAM_COMPAT_DATA_PATH}) -ge 0 ] 2>/dev/null; then
  1441. ^------------^ SC2154 (warning): SteamGameId is referenced but not assigned.
  1442. ^------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1443. ^-----------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1444. ^-- SC2046 (warning): Quote this to prevent word splitting.
  1445. ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1446.  
  1447. Did you mean:
  1448. elif ! [ "${SteamGameId}" -ge 0 ] 2>/dev/null && ! [ "${SteamAppId}" -ge 0 ] 2>/dev/null && ! [ $(basename "${STEAM_COMPAT_DATA_PATH}") -ge 0 ] 2>/dev/null; then
  1449.  
  1450.  
  1451. In ./tools/launchers/xenia.sh line 28:
  1452. if ! [ -d ${STEAM_COMPAT_DATA_PATH} ]; then
  1453. ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1454.  
  1455. Did you mean:
  1456. if ! [ -d "${STEAM_COMPAT_DATA_PATH}" ]; then
  1457.  
  1458.  
  1459. In ./tools/launchers/xenia.sh line 29:
  1460. install -d ${STEAM_COMPAT_DATA_PATH} || exit 1
  1461. ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1462.  
  1463. Did you mean:
  1464. install -d "${STEAM_COMPAT_DATA_PATH}" || exit 1
  1465.  
  1466.  
  1467. In ./tools/launchers/xenia.sh line 32:
  1468. cd $apppath
  1469. ^---------^ SC2164 (warning): Use 'cd ... || exit' or 'cd ... || return' in case cd fails.
  1470. ^------^ SC2154 (warning): apppath is referenced but not assigned (did you mean 'APPPATH'?).
  1471. ^------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1472.  
  1473. Did you mean:
  1474. cd "$apppath" || exit
  1475.  
  1476.  
  1477. In ./tools/launchers/pcsx2-qt.sh line 6:
  1478. exe=$(find $emufolder -iname "${emuName}*.AppImage" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1479. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1480.  
  1481. Did you mean:
  1482. exe=$(find "$emufolder" -iname "${emuName}*.AppImage" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1483.  
  1484.  
  1485. In ./tools/launchers/pcsx2-qt.sh line 9:
  1486. if [[ $exe == '' ]]; then
  1487. ^--------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
  1488.  
  1489.  
  1490. In ./tools/launchers/pcsx2-qt.sh line 15:
  1491. chmod +x $exe
  1492. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1493.  
  1494. Did you mean:
  1495. chmod +x "$exe"
  1496.  
  1497.  
  1498. In ./tools/launchers/pcsx2-qt.sh line 19:
  1499. param="${@}"
  1500. ^----^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
  1501.  
  1502.  
  1503. In ./tools/launchers/pcsx2-qt.sh line 21:
  1504. param=${param/\'/"$substituteWith"}
  1505. ^---------------------------^ SC3060 (warning): In POSIX sh, string replacement is undefined.
  1506.  
  1507.  
  1508. In ./tools/launchers/ryujinx.sh line 6:
  1509. exe=$(find $emufolder -iname "${emuName}" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1510. ^--------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1511.  
  1512. Did you mean:
  1513. exe=$(find "$emufolder" -iname "${emuName}" | sort -n | cut -d' ' -f 2- | tail -n 1 2>/dev/null)
  1514.  
  1515.  
  1516. In ./tools/launchers/ryujinx.sh line 9:
  1517. if [[ $exe == '' ]]; then
  1518. ^--------------^ SC3010 (warning): In POSIX sh, [[ ]] is undefined.
  1519.  
  1520.  
  1521. In ./tools/launchers/ryujinx.sh line 15:
  1522. chmod +x $exe
  1523. ^--^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1524.  
  1525. Did you mean:
  1526. chmod +x "$exe"
  1527.  
  1528.  
  1529. In ./tools/launchers/ryujinx.sh line 19:
  1530. param="${@}"
  1531. ^----^ SC2124 (warning): Assigning an array to a string! Assign as array, or use * instead of @ to concatenate.
  1532.  
  1533.  
  1534. In ./tools/launchers/ryujinx.sh line 21:
  1535. param=${param/\'/"$substituteWith"}
  1536. ^---------------------------^ SC3060 (warning): In POSIX sh, string replacement is undefined.
  1537.  
  1538.  
  1539. In ./tools/proton-launch.sh line 25:
  1540. if [ -z ${STEAM_COMPAT_DATA_PATH+x} ] && ! [ -z ${PFX+x} ]; then
  1541. ^-- SC2237 (style): Use [ -n .. ] instead of ! [ -z .. ].
  1542.  
  1543.  
  1544. In ./tools/proton-launch.sh line 32:
  1545. if [ -z ${SteamAppId+x} ] && ! [ -z ${APPID+x} ]; then
  1546. ^-- SC2237 (style): Use [ -n .. ] instead of ! [ -z .. ].
  1547.  
  1548.  
  1549. In ./tools/proton-launch.sh line 43:
  1550. if ! [ -d ${STEAM_COMPAT_DATA_PATH} ]; then
  1551. ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1552.  
  1553. Did you mean:
  1554. if ! [ -d "${STEAM_COMPAT_DATA_PATH}" ]; then
  1555.  
  1556.  
  1557. In ./tools/proton-launch.sh line 44:
  1558. install -d ${STEAM_COMPAT_DATA_PATH} || exit 1
  1559. ^-----------------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1560.  
  1561. Did you mean:
  1562. install -d "${STEAM_COMPAT_DATA_PATH}" || exit 1
  1563.  
  1564.  
  1565. In ./tools/proton-launch.sh line 135:
  1566. elif [ -z ${PROTON+x} ] && [ ! -z ${ALTSTEAM+x} ] && [ -f "${ALTSTEAM}/common/Proton 7.0/proton" ]; then
  1567. ^-- SC2236 (style): Use -n instead of ! -z.
  1568.  
  1569.  
  1570. In ./tools/proton-launch.sh line 149:
  1571. if [ -z ${PFX+x} ] && ! [ -z ${COMPATDATA+x} ]; then
  1572. ^-- SC2237 (style): Use [ -n .. ] instead of ! [ -z .. ].
  1573.  
  1574.  
  1575. In ./tools/chdconv/chddeck.sh line 77:
  1576. --height="$height" \
  1577. ^-----^ SC2128 (warning): Expanding an array without an index only gives the first element.
  1578.  
  1579.  
  1580. In ./tools/chdconv/chddeck.sh line 84:
  1581. --column=${selectColumnStr}) #goddamnit shellcheck broke this. array! do not quote.
  1582. ^----------------^ SC2086 (info): Double quote to prevent globbing and word splitting.
  1583.  
  1584. Did you mean:
  1585. --column="${selectColumnStr}") #goddamnit shellcheck broke this. array! do not quote.
  1586.  
  1587.  
  1588. In ./tools/chdconv/chddeck.sh line 103:
  1589. if [[ " ${chdfolderWhiteList[*]} " =~ " ${romfolder} " ]]; then
  1590. ^--------------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.
  1591.  
  1592.  
  1593. In ./tools/chdconv/chddeck.sh line 156:
  1594. if [[ " ${rvzfolderWhiteList[*]} " =~ " ${romfolder} " ]]; then
  1595. ^--------------^ SC2076 (warning): Remove quotes from right-hand side of =~ to match as a regex rather than literally.
  1596.  
  1597.  
  1598. In ./execFn.sh line 2:
  1599. source "$HOME/emudeck/backend/functions/all.sh"
  1600. ^-- SC1091 (info): Not following: ./emudeck/backend/functions/all.sh was not specified as input (see shellcheck -x).
  1601.  
  1602. For more information:
  1603. https://www.shellcheck.net/wiki/SC2027 -- The surrounding quotes actually u...
  1604. https://www.shellcheck.net/wiki/SC2034 -- BINUP_toolType appears unused. Ve...
  1605. https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...
  1606.  
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement