Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- Our man page changes for this quarter are at:
- https://gist.github.com/alanc/cfbaa19eb1ee04afe996da97f121fe7e
- My big man page project for the quarter was a cleanup pass across the
- section 4M man pages. Changes from those included:
- - Formatting, spelling, grammar, wording, and typo fixes across many pages
- - Add History sections to many pages
- - Add Attributes tables in a few pages
- - Standardize on <> being included in the bold text for header references
- - Standardize markup for I_PUSH ioctl lines in Synopsis sections
- - Remove "PCI-based systems" from Architecture tables, since that is all
- we support in Solaris 11.4 (as opposed to Sbus-based systems supported
- before the sun4u EOF).
- - Add missing x86 modules to the Files section where needed
- Fixes I see that apply to your pages as well include:
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/kbd.1#L59
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/kbd.1#L129
- - Even on the illumos distros that support SPARC, I don't think you support
- any hardware old enough to have a keyboard with a key labeled "L1" instead
- of "Stop"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/loadkeys.1#L26
- - "," is not part of the filename, should be after \fR, not before it
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/loadkeys.1#L27
- - "dd" refers to the replaceable value here, not the command, so should be
- italic, not bold
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/loadkeys.1#L30-L32
- - DIP switches to set layouts are only on Type 5 & older Sun keyboards
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man1/loadkeys.1#L42
- - missing the type_tt directory from the path that was shown above
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man2/mount.2
- - when mounting ZFS filesystems, the spec argument points to a dataset name,
- not a device file. (Other values may be used for pseudo-filesystems that
- aren't stored on disk, like procfs, ctfs, etc.)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/qsort.3c#L129
- - the (void *) cast on the first argument is unnecessary
- kb(4M)
- - where you seem to have removed this in the SPARC EOL, I moved it to kbio(4I)
- and dropped a bunch of obsolete bits that only applied to old SPARC keyboards
- and started delivering it on x86 as well
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/bufmod.4m#L23
- - "-based" should not be bold
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/bufmod.4m#L23
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/bufmod.4m#L191
- - "uint_t" should be a type (bold) not a parameter name (italic)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/bufmod.4m#L203
- - "description of effect" seems like it should have a "the" before "effect"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/bufmod.4m#L287-L291
- - the SBIOCSFLAGS ioctl was added in Solaris 2.1, so the "older versions"
- mentioned here were Solaris 2.0 and earlier, not something you really need
- to consider when writing code in the 21st century
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ldterm.4m#L32-L33
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ldterm.4m#L39
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ldterm.4m#L174
- - "The" and "module" should not be bold
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ldterm.4m#L72
- - ")," should not be bold
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pfmod.4m
- - doesn't document Pf_ext_packetfilt added in PSARC/1998/429 as part of the
- IPv6 support projects
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pfmod.4m#L17
- - "IPUSH" should be "I_PUSH"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pfmod.4m#L100
- - "ushort_t" should be bold, the following "s" should not
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pfmod.4m#L103-L125
- - the "_" should be replaced by italics to mark as replaceable text
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pfmod.4m#L250-L255
- - See Also is missing streamio(4I)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/pipemod.4m#L26
- - "all message" should be "all messages"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/timod.4m#L13
- - missing <sys/timod.h>
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/timod.4m#L50-L53
- - "strioctl" should be "my_strioctl" when referring to the variable name
- instead of the type name
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/timod.4m#L52
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/timod.4m#L60-L61
- - "size" should be italic (parameter name) instead of bold (command name)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/timod.4m#L171
- - errno values are listed in Intro(2), not Intro(3)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/tirdwr.4m#L18
- - there is no Section 3N - you have 3NSL, we merged into 3C
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/tirdwr.4m#L21-L22
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/tirdwr.4m#L65
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/tirdwr.4m#L94
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/tirdwr.4m#L118-L119
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L26-L27
- - missing "()" after system call names (getmsg, putmsg, read, write, ioctl)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L26-L27
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L73
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L143
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L305-L306
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L451
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L461
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L570-L571
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L658
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/ttcompat.4m#L672
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L48
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L133-L136
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L160-L167
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L187
- - symbols/macros should be bold (TIOCGETP, TIOCSETP, VERASE, VKILL, INPCK, etc.)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usb_ah.4m#L14
- - "button" should be "buttons"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usb_ah.4m#L46
- - missing space between "x86" and "64-bit"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbkbm.4m#L37
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbkbm.4m#L100
- - defining with references to kb(4M) doesn't help if kb(4M) isn't delivered
- (see above note about kb(4M))
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbkbm.4m#L90
- - missing "." at end of sentences
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbkbm.4m#L141-L145
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L259-L263
- - this should be 64-bit now, with "/amd64" in the path
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L76
- - "too" should be "to"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/usbms.4m#L187
- - "'VUIDGWHEEL INFO'" should be "VUIDGWHEELINFO"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/vuidmice.4m#L28-L48
- - the third argument in each call should be a quoted string
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/vuidmice.4m#L81
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/vuidmice.4m#L84
- - if statements should not have ";" after ")"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4m/vuidmice.4m#L263
- - "/" should be after space, not before (i.e. "/dev/msm")
Advertisement
Add Comment
Please, Sign In to add comment