API tools faq
paste
Advertisement
Guest User

Untitled

a guest
Mar 18th, 2024
19
0
Never
Add comment
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 393.66 KB | None | 0 0
raw download clone embed print report
  1. cppcheck: unusedFunction check can't be used with '-j' option. Disabling unusedFunction check.
  2. src/addon/downloader.hpp:107:8: style: Unused private function: 'TransferStatusList::on_transfer_complete' [unusedPrivateFunction]
  3. void on_transfer_complete(TransferStatusPtr this_status, bool successful);
  4. ^
  5. src/addon/downloader.hpp:86:3: style: Class 'TransferStatusList' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6. TransferStatusList(const std::vector<TransferStatusPtr>& list);
  7. ^
  8. src/addon/md5.hpp:54:3: style: Class 'MD5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  9. MD5(uint8_t* string); /**< digest string, finalize */
  10. ^
  11. src/addon/md5.hpp:55:3: style: Class 'MD5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  12. MD5(std::istream& stream); /**< digest stream, finalize */
  13. ^
  14. src/addon/md5.hpp:56:3: style: Class 'MD5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  15. MD5(FILE *file); /**< digest file, close, finalize */
  16. ^
  17. src/addon/md5.hpp:57:3: style: Class 'MD5' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  18. MD5(std::ifstream& stream); /**< digest stream, close, finalize */
  19. ^
  20. src/addon/md5.cpp:333:46: style: Parameter 'input' can be declared as pointer to const [constParameterPointer]
  21. void MD5::encode (uint8_t* output, uint32_t* input, uint32_t len) {
  22. ^
  23. src/addon/md5.cpp:353:45: style: Parameter 'input' can be declared as pointer to const [constParameterPointer]
  24. void MD5::memcpy (uint8_t* output, uint8_t* input, uint32_t len) {
  25. ^
  26. src/audio/openal_sound_source.hpp:43:16: style: Virtual function 'set_reference_distance' is called from constructor 'OpenALSoundSource()' at line 33. Dynamic binding is not used. [virtualCallInConstructor]
  27. virtual void set_reference_distance(float distance) override;
  28. ^
  29. src/audio/openal_sound_source.cpp:33:3: note: Calling set_reference_distance
  30. set_reference_distance(128);
  31. ^
  32. src/audio/openal_sound_source.hpp:43:16: note: set_reference_distance is a virtual function
  33. virtual void set_reference_distance(float distance) override;
  34. ^
  35. src/audio/sound_error.hpp:26:3: style: Class 'SoundError' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  36. SoundError(const std::string& message) throw();
  37. ^
  38. src/audio/openal_sound_source.hpp:33:16: style: Virtual function 'stop' is called from destructor '~OpenALSoundSource()' at line 38. Dynamic binding is not used. [virtualCallInConstructor]
  39. virtual void stop(bool unload_buffer = true) override;
  40. ^
  41. src/audio/openal_sound_source.cpp:38:3: note: Calling stop
  42. stop();
  43. ^
  44. src/audio/openal_sound_source.hpp:33:16: note: stop is a virtual function
  45. virtual void stop(bool unload_buffer = true) override;
  46. ^
  47. src/audio/wav_sound_file.hpp:27:3: style: Class 'WavSoundFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  48. WavSoundFile(PHYSFS_file* file);
  49. ^
  50. src/audio/sound_manager.cpp:235:53: style: Parameter 'sss' can be declared as pointer to const [constParameterPointer]
  51. SoundManager::remove_from_update(StreamSoundSource* sss)
  52. ^
  53. src/sdk/integration.hpp:20:0: information: Include file: "config.h" not found. [missingInclude]
  54. #include "config.h"
  55. ^
  56. src/math/rect.hpp:72:3: style: Class 'Rect' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  57. Rect(const SDL_Rect& rect) :
  58. ^
  59. src/math/sizef.hpp:47:3: style: Class 'Sizef' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  60. Sizef(const Size& rhs);
  61. ^
  62. src/math/rectf.hpp:71:3: style: Class 'Rectf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  63. Rectf(const SDL_FRect& rect) :
  64. ^
  65. src/math/rectf.hpp:76:3: style: Class 'Rectf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  66. Rectf(const Rect& rect);
  67. ^
  68. src/video/color.hpp:98:3: style: Class 'Color' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  69. Color(const std::vector<float>& vals);
  70. ^
  71. src/video/drawing_transform.hpp:33:3: style: Class 'DrawingTransform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  72. DrawingTransform(const Viewport& viewport_) :
  73. ^
  74. src/gui/dialog.hpp:52:3: style: Class 'Dialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  75. Dialog(bool passive = false, bool auto_clear_dialogs = true);
  76. ^
  77. src/supertux/menu/addon_menu.hpp:42:3: style: Class 'AddonMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  78. AddonMenu(bool language_packs_only = false);
  79. ^
  80. src/addon/addon_manager.cpp:881:12: style: The scope of the variable 'm_addons' can be reduced. [variableScope]
  81. AddonMap m_addons;
  82. ^
  83. src/addon/addon_manager.cpp:167:14: style: Variable 'addon' can be declared as reference to const [constVariableReference]
  84. for (auto& addon : m_addon_config)
  85. ^
  86. src/addon/addon_manager.cpp:320:9: style: Variable 'addon' can be declared as reference to const [constVariableReference]
  87. auto& addon = get_repository_addon(addon_id);
  88. ^
  89. src/addon/addon_manager.cpp:335:16: style: Variable 'repository_addon' can be declared as reference to const [constVariableReference]
  90. Addon& repository_addon = get_repository_addon(addon_id);
  91. ^
  92. src/addon/addon_manager.cpp:423:9: style: Variable 'repository_addon' can be declared as reference to const [constVariableReference]
  93. auto& repository_addon = get_repository_addon(addon_id);
  94. ^
  95. src/addon/addon_manager.cpp:473:9: style: Variable 'addon' can be declared as reference to const [constVariableReference]
  96. auto& addon = get_installed_addon(addon_id);
  97. ^
  98. src/addon/addon_manager.cpp:946:14: style: Variable 'langpack' can be declared as reference to const [constVariableReference]
  99. Addon& langpack = get_repository_addon(addon_id);
  100. ^
  101. src/addon/addon_manager.cpp:950:15: style: Variable 'installed_langpack' can be declared as reference to const [constVariableReference]
  102. auto& installed_langpack = get_installed_addon(addon_id);
  103. ^
  104. src/object/moving_sprite.hpp:51:22: warning: The class 'MovingSprite' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  105. static std::string class_name() { return "moving-sprite"; }
  106. ^
  107. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  108. static std::string class_name() { return "moving-object"; }
  109. ^
  110. src/object/moving_sprite.hpp:51:22: note: Derived function 'MovingSprite::class_name'
  111. static std::string class_name() { return "moving-sprite"; }
  112. ^
  113. src/badguy/badguy.hpp:59:22: warning: The class 'BadGuy' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  114. static std::string class_name() { return "badguy"; }
  115. ^
  116. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  117. static std::string class_name() { return "moving-sprite"; }
  118. ^
  119. src/badguy/badguy.hpp:59:22: note: Derived function 'BadGuy::class_name'
  120. static std::string class_name() { return "badguy"; }
  121. ^
  122. src/badguy/badguy.hpp:59:22: warning: The class 'BadGuy' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  123. static std::string class_name() { return "badguy"; }
  124. ^
  125. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  126. static std::string class_name() { return "moving-object"; }
  127. ^
  128. src/badguy/badguy.hpp:59:22: note: Derived function 'BadGuy::class_name'
  129. static std::string class_name() { return "badguy"; }
  130. ^
  131. src/badguy/angrystone.hpp:37:22: warning: The class 'AngryStone' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  132. static std::string class_name() { return "angrystone"; }
  133. ^
  134. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  135. static std::string class_name() { return "badguy"; }
  136. ^
  137. src/badguy/angrystone.hpp:37:22: note: Derived function 'AngryStone::class_name'
  138. static std::string class_name() { return "angrystone"; }
  139. ^
  140. src/badguy/angrystone.hpp:39:22: warning: The class 'AngryStone' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  141. static std::string display_name() { return _("Angry Stone"); }
  142. ^
  143. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  144. static std::string display_name() { return _("Badguy"); }
  145. ^
  146. src/badguy/angrystone.hpp:39:22: note: Derived function 'AngryStone::display_name'
  147. static std::string display_name() { return _("Angry Stone"); }
  148. ^
  149. src/badguy/angrystone.hpp:37:22: warning: The class 'AngryStone' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  150. static std::string class_name() { return "angrystone"; }
  151. ^
  152. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  153. static std::string class_name() { return "moving-sprite"; }
  154. ^
  155. src/badguy/angrystone.hpp:37:22: note: Derived function 'AngryStone::class_name'
  156. static std::string class_name() { return "angrystone"; }
  157. ^
  158. src/badguy/angrystone.hpp:37:22: warning: The class 'AngryStone' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  159. static std::string class_name() { return "angrystone"; }
  160. ^
  161. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  162. static std::string class_name() { return "moving-object"; }
  163. ^
  164. src/badguy/angrystone.hpp:37:22: note: Derived function 'AngryStone::class_name'
  165. static std::string class_name() { return "angrystone"; }
  166. ^
  167. src/object/path.hpp:81:3: style: Class 'Path' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  168. Path(PathGameObject& parent);
  169. ^
  170. src/object/path.hpp:67:5: style: Class 'Node' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  171. Node(Path* parent_) :
  172. ^
  173. src/object/path_walker.hpp:47:3: style: Class 'PathWalker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  174. PathWalker(UID path_uid, bool running = true);
  175. ^
  176. src/sprite/sprite_data.hpp:37:3: style: Class 'SpriteData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  177. SpriteData(const ReaderMapping& mapping);
  178. ^
  179. src/sprite/sprite_data.hpp:39:3: style: Class 'SpriteData' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  180. SpriteData(const std::string& image);
  181. ^
  182. src/sprite/sprite.hpp:34:3: style: Class 'Sprite' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  183. Sprite(SpriteData& data);
  184. ^
  185. src/editor/object_settings.hpp:41:3: style: Class 'ObjectSettings' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  186. ObjectSettings(const std::string& name);
  187. ^
  188. src/object/moving_sprite.hpp:45:3: style: Class 'MovingSprite' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  189. MovingSprite(const ReaderMapping& reader,
  190. ^
  191. src/supertux/game_object_iterator.hpp:113:3: style: Class 'GameObjectRange' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  192. GameObjectRange(const GameObjectManager& manager) :
  193. ^
  194. src/scripting/badguy.hpp:42:3: style: Class 'BadGuy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  195. BadGuy(const ::GameObject& object) :
  196. ^
  197. src/squirrel/squirrel_virtual_machine.hpp:33:3: style: Class 'SquirrelVirtualMachine' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  198. SquirrelVirtualMachine(bool enable_debugger);
  199. ^
  200. src/badguy/angrystone.hpp:25:3: style: Class 'AngryStone' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  201. AngryStone(const ReaderMapping& reader);
  202. ^
  203. src/supertux/player_status.hpp:42:3: style: Class 'PlayerStatus' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  204. PlayerStatus(int num_players);
  205. ^
  206. src/object/player.hpp:52:5: style: Class 'GrabListener' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  207. GrabListener(Player& player) : m_player(player)
  208. ^
  209. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < BadGuy , scripting :: BadGuy >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  210. ExposedObject(S* parent) :
  211. ^
  212. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Player , scripting :: Player >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  213. ExposedObject(S* parent) :
  214. ^
  215. src/badguy/angrystone.cpp:92:12: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  216. auto player = get_nearest_player();
  217. ^
  218. src/badguy/angrystone.cpp:95:14: style: Variable 'badguy' can be declared as pointer to const [constVariablePointer]
  219. auto badguy = this;
  220. ^
  221. src/object/explosion.hpp:33:22: warning: The class 'Explosion' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  222. static std::string class_name() { return "explosion"; }
  223. ^
  224. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  225. static std::string class_name() { return "moving-sprite"; }
  226. ^
  227. src/object/explosion.hpp:33:22: note: Derived function 'Explosion::class_name'
  228. static std::string class_name() { return "explosion"; }
  229. ^
  230. src/object/explosion.hpp:33:22: warning: The class 'Explosion' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  231. static std::string class_name() { return "explosion"; }
  232. ^
  233. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  234. static std::string class_name() { return "moving-object"; }
  235. ^
  236. src/object/explosion.hpp:33:22: note: Derived function 'Explosion::class_name'
  237. static std::string class_name() { return "explosion"; }
  238. ^
  239. src/object/explosion.hpp:31:3: style: Class 'Explosion' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  240. Explosion(const ReaderMapping& reader);
  241. ^
  242. src/collision/collision_system.hpp:47:3: style: Class 'CollisionSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  243. CollisionSystem(Sector& sector);
  244. ^
  245. src/supertux/sector.hpp:68:3: style: Class 'Sector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  246. Sector(Level& parent);
  247. ^
  248. src/badguy/dispenser.hpp:49:22: warning: The class 'Dispenser' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  249. static std::string class_name() { return "dispenser"; }
  250. ^
  251. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  252. static std::string class_name() { return "badguy"; }
  253. ^
  254. src/badguy/dispenser.hpp:49:22: note: Derived function 'Dispenser::class_name'
  255. static std::string class_name() { return "dispenser"; }
  256. ^
  257. src/badguy/dispenser.hpp:51:22: warning: The class 'Dispenser' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  258. static std::string display_name() { return _("Dispenser"); }
  259. ^
  260. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  261. static std::string display_name() { return _("Badguy"); }
  262. ^
  263. src/badguy/dispenser.hpp:51:22: note: Derived function 'Dispenser::display_name'
  264. static std::string display_name() { return _("Dispenser"); }
  265. ^
  266. src/badguy/dispenser.hpp:49:22: warning: The class 'Dispenser' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  267. static std::string class_name() { return "dispenser"; }
  268. ^
  269. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  270. static std::string class_name() { return "moving-sprite"; }
  271. ^
  272. src/badguy/dispenser.hpp:49:22: note: Derived function 'Dispenser::class_name'
  273. static std::string class_name() { return "dispenser"; }
  274. ^
  275. src/badguy/dispenser.hpp:49:22: warning: The class 'Dispenser' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  276. static std::string class_name() { return "dispenser"; }
  277. ^
  278. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  279. static std::string class_name() { return "moving-object"; }
  280. ^
  281. src/badguy/dispenser.hpp:49:22: note: Derived function 'Dispenser::class_name'
  282. static std::string class_name() { return "dispenser"; }
  283. ^
  284. src/object/bullet.hpp:48:13: warning: The class 'Bullet' defines member function with name 'get_type' also defined in its parent class 'GameObject'. [duplInheritedMember]
  285. BonusType get_type() const { return type; }
  286. ^
  287. src/supertux/game_object.hpp:123:7: note: Parent function 'GameObject::get_type'
  288. int get_type() const { return m_type; }
  289. ^
  290. src/object/bullet.hpp:48:13: note: Derived function 'Bullet::get_type'
  291. BonusType get_type() const { return type; }
  292. ^
  293. src/util/typed_uid.hpp:62:20: warning: The class 'TypedUID < MovingObject >' defines member function with name 'operator=' also defined in its parent class 'UID'. [duplInheritedMember]
  294. inline TypedUID& operator=(const UID& other)
  295. ^
  296. src/util/uid.hpp:56:8: note: Parent function 'UID::operator='
  297. UID& operator=(const UID& other) = default;
  298. ^
  299. src/util/typed_uid.hpp:62:20: note: Derived function 'TypedUID < MovingObject >::operator='
  300. inline TypedUID& operator=(const UID& other)
  301. ^
  302. src/util/typed_uid.hpp:92:10: warning: The class 'TypedUID < MovingObject >' defines member function with name 'operatorbool' also defined in its parent class 'UID'. [duplInheritedMember]
  303. inline operator bool() const {
  304. ^
  305. src/util/uid.hpp:58:10: note: Parent function 'UID::operatorbool'
  306. inline operator bool() const {
  307. ^
  308. src/util/typed_uid.hpp:92:10: note: Derived function 'TypedUID < MovingObject >::operatorbool'
  309. inline operator bool() const {
  310. ^
  311. src/util/typed_uid.hpp:62:20: warning: The class 'TypedUID < GameObject >' defines member function with name 'operator=' also defined in its parent class 'UID'. [duplInheritedMember]
  312. inline TypedUID& operator=(const UID& other)
  313. ^
  314. src/util/uid.hpp:56:8: note: Parent function 'UID::operator='
  315. UID& operator=(const UID& other) = default;
  316. ^
  317. src/util/typed_uid.hpp:62:20: note: Derived function 'TypedUID < GameObject >::operator='
  318. inline TypedUID& operator=(const UID& other)
  319. ^
  320. src/util/typed_uid.hpp:92:10: warning: The class 'TypedUID < GameObject >' defines member function with name 'operatorbool' also defined in its parent class 'UID'. [duplInheritedMember]
  321. inline operator bool() const {
  322. ^
  323. src/util/uid.hpp:58:10: note: Parent function 'UID::operatorbool'
  324. inline operator bool() const {
  325. ^
  326. src/util/typed_uid.hpp:92:10: note: Derived function 'TypedUID < GameObject >::operatorbool'
  327. inline operator bool() const {
  328. ^
  329. src/util/typed_uid.hpp:62:20: warning: The class 'TypedUID < PathGameObject >' defines member function with name 'operator=' also defined in its parent class 'UID'. [duplInheritedMember]
  330. inline TypedUID& operator=(const UID& other)
  331. ^
  332. src/util/uid.hpp:56:8: note: Parent function 'UID::operator='
  333. UID& operator=(const UID& other) = default;
  334. ^
  335. src/util/typed_uid.hpp:62:20: note: Derived function 'TypedUID < PathGameObject >::operator='
  336. inline TypedUID& operator=(const UID& other)
  337. ^
  338. src/util/typed_uid.hpp:92:10: warning: The class 'TypedUID < PathGameObject >' defines member function with name 'operatorbool' also defined in its parent class 'UID'. [duplInheritedMember]
  339. inline operator bool() const {
  340. ^
  341. src/util/uid.hpp:58:10: note: Parent function 'UID::operatorbool'
  342. inline operator bool() const {
  343. ^
  344. src/util/typed_uid.hpp:92:10: note: Derived function 'TypedUID < PathGameObject >::operatorbool'
  345. inline operator bool() const {
  346. ^
  347. src/util/typed_uid.hpp:62:20: warning: The class 'TypedUID < NodeMarker >' defines member function with name 'operator=' also defined in its parent class 'UID'. [duplInheritedMember]
  348. inline TypedUID& operator=(const UID& other)
  349. ^
  350. src/util/uid.hpp:56:8: note: Parent function 'UID::operator='
  351. UID& operator=(const UID& other) = default;
  352. ^
  353. src/util/typed_uid.hpp:62:20: note: Derived function 'TypedUID < NodeMarker >::operator='
  354. inline TypedUID& operator=(const UID& other)
  355. ^
  356. src/util/typed_uid.hpp:92:10: warning: The class 'TypedUID < NodeMarker >' defines member function with name 'operatorbool' also defined in its parent class 'UID'. [duplInheritedMember]
  357. inline operator bool() const {
  358. ^
  359. src/util/uid.hpp:58:10: note: Parent function 'UID::operatorbool'
  360. inline operator bool() const {
  361. ^
  362. src/util/typed_uid.hpp:92:10: note: Derived function 'TypedUID < NodeMarker >::operatorbool'
  363. inline operator bool() const {
  364. ^
  365. src/scripting/dispenser.hpp:41:3: style: Class 'Dispenser' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  366. Dispenser(const ::GameObject& object) :
  367. ^
  368. src/badguy/dispenser.hpp:35:3: style: Class 'Dispenser' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  369. Dispenser(const ReaderMapping& reader);
  370. ^
  371. src/object/path_gameobject.hpp:36:3: style: Class 'PathGameObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  372. PathGameObject(const Vector& pos);
  373. ^
  374. src/object/path_gameobject.hpp:37:3: style: Class 'PathGameObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  375. PathGameObject(const ReaderMapping& mapping, bool backward_compatibility_hack=false);
  376. ^
  377. src/object/tilemap.hpp:49:3: style: Class 'TileMap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  378. TileMap(const TileSet *tileset);
  379. ^
  380. src/editor/overlay_widget.hpp:53:3: style: Class 'EditorOverlayWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  381. EditorOverlayWidget(Editor& editor);
  382. ^
  383. src/editor/toolbox_widget.hpp:56:3: style: Class 'EditorToolboxWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  384. EditorToolboxWidget(Editor& editor);
  385. ^
  386. src/editor/layers_widget.hpp:47:3: style: Class 'EditorLayersWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  387. EditorLayersWidget(Editor& editor);
  388. ^
  389. src/editor/scroller_widget.hpp:35:3: style: Class 'EditorScrollerWidget' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  390. EditorScrollerWidget(Editor& editor);
  391. ^
  392. src/object/camera.hpp:47:3: style: Class 'Camera' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  393. Camera(const std::string& name);
  394. ^
  395. src/object/camera.hpp:48:3: style: Class 'Camera' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  396. Camera(const ReaderMapping& reader);
  397. ^
  398. src/util/writer.hpp:30:3: style: Class 'Writer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  399. Writer(const std::string& filename);
  400. ^
  401. src/util/writer.hpp:31:3: style: Class 'Writer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  402. Writer(std::ostream& out);
  403. ^
  404. src/util/typed_uid.hpp:34:3: style: Class 'TypedUID < MovingObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  405. TypedUID(const T* object) : UID() { if (object) *this = object->get_uid(); }
  406. ^
  407. src/util/typed_uid.hpp:34:3: style: Class 'TypedUID < GameObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  408. TypedUID(const T* object) : UID() { if (object) *this = object->get_uid(); }
  409. ^
  410. src/util/typed_uid.hpp:34:3: style: Class 'TypedUID < PathGameObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  411. TypedUID(const T* object) : UID() { if (object) *this = object->get_uid(); }
  412. ^
  413. src/util/typed_uid.hpp:34:3: style: Class 'TypedUID < NodeMarker >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  414. TypedUID(const T* object) : UID() { if (object) *this = object->get_uid(); }
  415. ^
  416. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Dispenser , scripting :: Dispenser >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  417. ExposedObject(S* parent) :
  418. ^
  419. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < TileMap , scripting :: TileMap >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  420. ExposedObject(S* parent) :
  421. ^
  422. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Camera , scripting :: Camera >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  423. ExposedObject(S* parent) :
  424. ^
  425. src/badguy/badguy.cpp:711:11: style: Variable 'cam' can be declared as reference to const [constVariableReference]
  426. Camera& cam = Sector::get().get_camera();
  427. ^
  428. src/badguy/badguy.cpp:190:10: style: Variable 'this_portable' can be declared as pointer to const [constVariablePointer]
  429. auto this_portable = dynamic_cast<Portable*> (this);
  430. ^
  431. src/badguy/badguy.cpp:718:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  432. auto player = get_nearest_player();
  433. ^
  434. src/badguy/badguy.cpp:737:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  435. auto player = get_nearest_player();
  436. ^
  437. src/badguy/badguy.cpp:746:14: style: Variable 'player_' can be declared as pointer to const [constVariablePointer]
  438. auto player_ = get_nearest_player();
  439. ^
  440. src/badguy/bouncing_snowball.hpp:36:22: warning: The class 'BouncingSnowball' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  441. static std::string class_name() { return "bouncingsnowball"; }
  442. ^
  443. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  444. static std::string class_name() { return "badguy"; }
  445. ^
  446. src/badguy/bouncing_snowball.hpp:36:22: note: Derived function 'BouncingSnowball::class_name'
  447. static std::string class_name() { return "bouncingsnowball"; }
  448. ^
  449. src/badguy/bouncing_snowball.hpp:38:22: warning: The class 'BouncingSnowball' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  450. static std::string display_name() { return _("Bouncing Snowball"); }
  451. ^
  452. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  453. static std::string display_name() { return _("Badguy"); }
  454. ^
  455. src/badguy/bouncing_snowball.hpp:38:22: note: Derived function 'BouncingSnowball::display_name'
  456. static std::string display_name() { return _("Bouncing Snowball"); }
  457. ^
  458. src/badguy/bouncing_snowball.hpp:36:22: warning: The class 'BouncingSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  459. static std::string class_name() { return "bouncingsnowball"; }
  460. ^
  461. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  462. static std::string class_name() { return "moving-sprite"; }
  463. ^
  464. src/badguy/bouncing_snowball.hpp:36:22: note: Derived function 'BouncingSnowball::class_name'
  465. static std::string class_name() { return "bouncingsnowball"; }
  466. ^
  467. src/badguy/bouncing_snowball.hpp:36:22: warning: The class 'BouncingSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  468. static std::string class_name() { return "bouncingsnowball"; }
  469. ^
  470. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  471. static std::string class_name() { return "moving-object"; }
  472. ^
  473. src/badguy/bouncing_snowball.hpp:36:22: note: Derived function 'BouncingSnowball::class_name'
  474. static std::string class_name() { return "bouncingsnowball"; }
  475. ^
  476. src/badguy/bouncing_snowball.hpp:25:3: style: Class 'BouncingSnowball' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  477. BouncingSnowball(const ReaderMapping& reader);
  478. ^
  479. src/badguy/walking_badguy.hpp:76:8: warning: The class 'WalkingBadguy' defines member function with name 'is_active' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  480. bool is_active() const { return BadGuy::is_active(); }
  481. ^
  482. src/badguy/badguy.hpp:231:8: note: Parent function 'BadGuy::is_active'
  483. bool is_active() const;
  484. ^
  485. src/badguy/walking_badguy.hpp:76:8: note: Derived function 'WalkingBadguy::is_active'
  486. bool is_active() const { return BadGuy::is_active(); }
  487. ^
  488. src/badguy/captainsnowball.hpp:30:22: warning: The class 'CaptainSnowball' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  489. static std::string class_name() { return "captainsnowball"; }
  490. ^
  491. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  492. static std::string class_name() { return "badguy"; }
  493. ^
  494. src/badguy/captainsnowball.hpp:30:22: note: Derived function 'CaptainSnowball::class_name'
  495. static std::string class_name() { return "captainsnowball"; }
  496. ^
  497. src/badguy/captainsnowball.hpp:32:22: warning: The class 'CaptainSnowball' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  498. static std::string display_name() { return _("Captain Snowball"); }
  499. ^
  500. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  501. static std::string display_name() { return _("Badguy"); }
  502. ^
  503. src/badguy/captainsnowball.hpp:32:22: note: Derived function 'CaptainSnowball::display_name'
  504. static std::string display_name() { return _("Captain Snowball"); }
  505. ^
  506. src/badguy/captainsnowball.hpp:30:22: warning: The class 'CaptainSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  507. static std::string class_name() { return "captainsnowball"; }
  508. ^
  509. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  510. static std::string class_name() { return "moving-sprite"; }
  511. ^
  512. src/badguy/captainsnowball.hpp:30:22: note: Derived function 'CaptainSnowball::class_name'
  513. static std::string class_name() { return "captainsnowball"; }
  514. ^
  515. src/badguy/captainsnowball.hpp:30:22: warning: The class 'CaptainSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  516. static std::string class_name() { return "captainsnowball"; }
  517. ^
  518. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  519. static std::string class_name() { return "moving-object"; }
  520. ^
  521. src/badguy/captainsnowball.hpp:30:22: note: Derived function 'CaptainSnowball::class_name'
  522. static std::string class_name() { return "captainsnowball"; }
  523. ^
  524. src/badguy/captainsnowball.hpp:25:3: style: Class 'CaptainSnowball' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  525. CaptainSnowball(const ReaderMapping& reader);
  526. ^
  527. src/badguy/corrupted_granito.hpp:42:22: warning: The class 'CorruptedGranito' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  528. static std::string class_name() { return "corrupted_granito"; }
  529. ^
  530. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  531. static std::string class_name() { return "badguy"; }
  532. ^
  533. src/badguy/corrupted_granito.hpp:42:22: note: Derived function 'CorruptedGranito::class_name'
  534. static std::string class_name() { return "corrupted_granito"; }
  535. ^
  536. src/badguy/corrupted_granito.hpp:44:22: warning: The class 'CorruptedGranito' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  537. static std::string display_name() { return _("Corrupted Granito"); }
  538. ^
  539. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  540. static std::string display_name() { return _("Badguy"); }
  541. ^
  542. src/badguy/corrupted_granito.hpp:44:22: note: Derived function 'CorruptedGranito::display_name'
  543. static std::string display_name() { return _("Corrupted Granito"); }
  544. ^
  545. src/badguy/corrupted_granito.hpp:42:22: warning: The class 'CorruptedGranito' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  546. static std::string class_name() { return "corrupted_granito"; }
  547. ^
  548. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  549. static std::string class_name() { return "moving-sprite"; }
  550. ^
  551. src/badguy/corrupted_granito.hpp:42:22: note: Derived function 'CorruptedGranito::class_name'
  552. static std::string class_name() { return "corrupted_granito"; }
  553. ^
  554. src/badguy/corrupted_granito.hpp:42:22: warning: The class 'CorruptedGranito' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  555. static std::string class_name() { return "corrupted_granito"; }
  556. ^
  557. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  558. static std::string class_name() { return "moving-object"; }
  559. ^
  560. src/badguy/corrupted_granito.hpp:42:22: note: Derived function 'CorruptedGranito::class_name'
  561. static std::string class_name() { return "corrupted_granito"; }
  562. ^
  563. src/badguy/corrupted_granito.hpp:31:3: style: Class 'CorruptedGranito' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  564. CorruptedGranito(const ReaderMapping& reader);
  565. ^
  566. src/badguy/corrupted_granito_big.hpp:33:22: warning: The class 'CorruptedGranitoBig' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  567. static std::string class_name() { return "corrupted_granito_big"; }
  568. ^
  569. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  570. static std::string class_name() { return "badguy"; }
  571. ^
  572. src/badguy/corrupted_granito_big.hpp:33:22: note: Derived function 'CorruptedGranitoBig::class_name'
  573. static std::string class_name() { return "corrupted_granito_big"; }
  574. ^
  575. src/badguy/corrupted_granito_big.hpp:35:22: warning: The class 'CorruptedGranitoBig' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  576. static std::string display_name() { return _("Corrupted Big Granito"); }
  577. ^
  578. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  579. static std::string display_name() { return _("Badguy"); }
  580. ^
  581. src/badguy/corrupted_granito_big.hpp:35:22: note: Derived function 'CorruptedGranitoBig::display_name'
  582. static std::string display_name() { return _("Corrupted Big Granito"); }
  583. ^
  584. src/badguy/corrupted_granito_big.hpp:33:22: warning: The class 'CorruptedGranitoBig' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  585. static std::string class_name() { return "corrupted_granito_big"; }
  586. ^
  587. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  588. static std::string class_name() { return "moving-sprite"; }
  589. ^
  590. src/badguy/corrupted_granito_big.hpp:33:22: note: Derived function 'CorruptedGranitoBig::class_name'
  591. static std::string class_name() { return "corrupted_granito_big"; }
  592. ^
  593. src/badguy/corrupted_granito_big.hpp:33:22: warning: The class 'CorruptedGranitoBig' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  594. static std::string class_name() { return "corrupted_granito_big"; }
  595. ^
  596. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  597. static std::string class_name() { return "moving-object"; }
  598. ^
  599. src/badguy/corrupted_granito_big.hpp:33:22: note: Derived function 'CorruptedGranitoBig::class_name'
  600. static std::string class_name() { return "corrupted_granito_big"; }
  601. ^
  602. src/object/shard.hpp:33:22: warning: The class 'Shard' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  603. static std::string class_name() { return "shard"; }
  604. ^
  605. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  606. static std::string class_name() { return "moving-sprite"; }
  607. ^
  608. src/object/shard.hpp:33:22: note: Derived function 'Shard::class_name'
  609. static std::string class_name() { return "shard"; }
  610. ^
  611. src/object/shard.hpp:33:22: warning: The class 'Shard' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  612. static std::string class_name() { return "shard"; }
  613. ^
  614. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  615. static std::string class_name() { return "moving-object"; }
  616. ^
  617. src/object/shard.hpp:33:22: note: Derived function 'Shard::class_name'
  618. static std::string class_name() { return "shard"; }
  619. ^
  620. src/object/shard.hpp:27:3: style: Class 'Shard' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  621. Shard(const ReaderMapping& reader);
  622. ^
  623. src/badguy/corrupted_granito_big.cpp:65:14: style: Local variable 'crack' shadows outer function [shadowFunction]
  624. const bool crack = try_cracking();
  625. ^
  626. src/badguy/corrupted_granito_big.hpp:44:8: note: Shadowed declaration
  627. void crack();
  628. ^
  629. src/badguy/corrupted_granito_big.cpp:65:14: note: Shadow variable
  630. const bool crack = try_cracking();
  631. ^
  632. src/badguy/crystallo.hpp:31:22: warning: The class 'Crystallo' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  633. static std::string class_name() { return "crystallo"; }
  634. ^
  635. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  636. static std::string class_name() { return "badguy"; }
  637. ^
  638. src/badguy/crystallo.hpp:31:22: note: Derived function 'Crystallo::class_name'
  639. static std::string class_name() { return "crystallo"; }
  640. ^
  641. src/badguy/crystallo.hpp:33:22: warning: The class 'Crystallo' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  642. static std::string display_name() { return _("Crystallo"); }
  643. ^
  644. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  645. static std::string display_name() { return _("Badguy"); }
  646. ^
  647. src/badguy/crystallo.hpp:33:22: note: Derived function 'Crystallo::display_name'
  648. static std::string display_name() { return _("Crystallo"); }
  649. ^
  650. src/badguy/crystallo.hpp:31:22: warning: The class 'Crystallo' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  651. static std::string class_name() { return "crystallo"; }
  652. ^
  653. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  654. static std::string class_name() { return "moving-sprite"; }
  655. ^
  656. src/badguy/crystallo.hpp:31:22: note: Derived function 'Crystallo::class_name'
  657. static std::string class_name() { return "crystallo"; }
  658. ^
  659. src/badguy/crystallo.hpp:31:22: warning: The class 'Crystallo' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  660. static std::string class_name() { return "crystallo"; }
  661. ^
  662. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  663. static std::string class_name() { return "moving-object"; }
  664. ^
  665. src/badguy/crystallo.hpp:31:22: note: Derived function 'Crystallo::class_name'
  666. static std::string class_name() { return "crystallo"; }
  667. ^
  668. src/badguy/rcrystallo.hpp:31:22: warning: The class 'RCrystallo' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  669. static std::string class_name() { return "rcrystallo"; }
  670. ^
  671. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  672. static std::string class_name() { return "badguy"; }
  673. ^
  674. src/badguy/rcrystallo.hpp:31:22: note: Derived function 'RCrystallo::class_name'
  675. static std::string class_name() { return "rcrystallo"; }
  676. ^
  677. src/badguy/rcrystallo.hpp:33:22: warning: The class 'RCrystallo' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  678. static std::string display_name() { return _("Roof Crystallo"); }
  679. ^
  680. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  681. static std::string display_name() { return _("Badguy"); }
  682. ^
  683. src/badguy/rcrystallo.hpp:33:22: note: Derived function 'RCrystallo::display_name'
  684. static std::string display_name() { return _("Roof Crystallo"); }
  685. ^
  686. src/badguy/rcrystallo.hpp:31:22: warning: The class 'RCrystallo' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  687. static std::string class_name() { return "rcrystallo"; }
  688. ^
  689. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  690. static std::string class_name() { return "moving-sprite"; }
  691. ^
  692. src/badguy/rcrystallo.hpp:31:22: note: Derived function 'RCrystallo::class_name'
  693. static std::string class_name() { return "rcrystallo"; }
  694. ^
  695. src/badguy/rcrystallo.hpp:31:22: warning: The class 'RCrystallo' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  696. static std::string class_name() { return "rcrystallo"; }
  697. ^
  698. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  699. static std::string class_name() { return "moving-object"; }
  700. ^
  701. src/badguy/rcrystallo.hpp:31:22: note: Derived function 'RCrystallo::class_name'
  702. static std::string class_name() { return "rcrystallo"; }
  703. ^
  704. src/badguy/crystallo.hpp:26:3: style: Class 'Crystallo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  705. Crystallo(const ReaderMapping& reader);
  706. ^
  707. src/badguy/rcrystallo.hpp:25:3: style: Class 'RCrystallo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  708. RCrystallo(const ReaderMapping& reader);
  709. ^
  710. src/badguy/crusher.hpp:69:22: warning: The class 'Crusher' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  711. static std::string class_name() { return "crusher"; }
  712. ^
  713. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  714. static std::string class_name() { return "moving-sprite"; }
  715. ^
  716. src/badguy/crusher.hpp:69:22: note: Derived function 'Crusher::class_name'
  717. static std::string class_name() { return "crusher"; }
  718. ^
  719. src/badguy/crusher.hpp:69:22: warning: The class 'Crusher' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  720. static std::string class_name() { return "crusher"; }
  721. ^
  722. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  723. static std::string class_name() { return "moving-object"; }
  724. ^
  725. src/badguy/crusher.hpp:69:22: note: Derived function 'Crusher::class_name'
  726. static std::string class_name() { return "crusher"; }
  727. ^
  728. src/object/brick.hpp:32:22: warning: The class 'Brick' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  729. static std::string class_name() { return "brick"; }
  730. ^
  731. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  732. static std::string class_name() { return "moving-sprite"; }
  733. ^
  734. src/object/brick.hpp:32:22: note: Derived function 'Brick::class_name'
  735. static std::string class_name() { return "brick"; }
  736. ^
  737. src/object/brick.hpp:32:22: warning: The class 'Brick' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  738. static std::string class_name() { return "brick"; }
  739. ^
  740. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  741. static std::string class_name() { return "moving-object"; }
  742. ^
  743. src/object/brick.hpp:32:22: note: Derived function 'Brick::class_name'
  744. static std::string class_name() { return "brick"; }
  745. ^
  746. src/object/brick.hpp:68:22: warning: The class 'HeavyBrick' defines member function with name 'class_name' also defined in its parent class 'Brick'. [duplInheritedMember]
  747. static std::string class_name() { return "heavy-brick"; }
  748. ^
  749. src/object/brick.hpp:32:22: note: Parent function 'Brick::class_name'
  750. static std::string class_name() { return "brick"; }
  751. ^
  752. src/object/brick.hpp:68:22: note: Derived function 'HeavyBrick::class_name'
  753. static std::string class_name() { return "heavy-brick"; }
  754. ^
  755. src/object/brick.hpp:70:22: warning: The class 'HeavyBrick' defines member function with name 'display_name' also defined in its parent class 'Brick'. [duplInheritedMember]
  756. static std::string display_name() { return _("Heavy Brick"); }
  757. ^
  758. src/object/brick.hpp:34:22: note: Parent function 'Brick::display_name'
  759. static std::string display_name() { return _("Brick"); }
  760. ^
  761. src/object/brick.hpp:70:22: note: Derived function 'HeavyBrick::display_name'
  762. static std::string display_name() { return _("Heavy Brick"); }
  763. ^
  764. src/object/brick.hpp:68:22: warning: The class 'HeavyBrick' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  765. static std::string class_name() { return "heavy-brick"; }
  766. ^
  767. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  768. static std::string class_name() { return "moving-sprite"; }
  769. ^
  770. src/object/brick.hpp:68:22: note: Derived function 'HeavyBrick::class_name'
  771. static std::string class_name() { return "heavy-brick"; }
  772. ^
  773. src/object/brick.hpp:68:22: warning: The class 'HeavyBrick' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  774. static std::string class_name() { return "heavy-brick"; }
  775. ^
  776. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  777. static std::string class_name() { return "moving-object"; }
  778. ^
  779. src/object/brick.hpp:68:22: note: Derived function 'HeavyBrick::class_name'
  780. static std::string class_name() { return "heavy-brick"; }
  781. ^
  782. src/object/coin.hpp:42:22: warning: The class 'Coin' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  783. static std::string class_name() { return "coin"; }
  784. ^
  785. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  786. static std::string class_name() { return "moving-sprite"; }
  787. ^
  788. src/object/coin.hpp:42:22: note: Derived function 'Coin::class_name'
  789. static std::string class_name() { return "coin"; }
  790. ^
  791. src/object/coin.hpp:42:22: warning: The class 'Coin' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  792. static std::string class_name() { return "coin"; }
  793. ^
  794. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  795. static std::string class_name() { return "moving-object"; }
  796. ^
  797. src/object/coin.hpp:42:22: note: Derived function 'Coin::class_name'
  798. static std::string class_name() { return "coin"; }
  799. ^
  800. src/object/coin.hpp:95:22: warning: The class 'HeavyCoin' defines member function with name 'class_name' also defined in its parent class 'Coin'. [duplInheritedMember]
  801. static std::string class_name() { return "heavycoin"; }
  802. ^
  803. src/object/coin.hpp:42:22: note: Parent function 'Coin::class_name'
  804. static std::string class_name() { return "coin"; }
  805. ^
  806. src/object/coin.hpp:95:22: note: Derived function 'HeavyCoin::class_name'
  807. static std::string class_name() { return "heavycoin"; }
  808. ^
  809. src/object/coin.hpp:97:22: warning: The class 'HeavyCoin' defines member function with name 'display_name' also defined in its parent class 'Coin'. [duplInheritedMember]
  810. static std::string display_name() { return _("Heavy Coin"); }
  811. ^
  812. src/object/coin.hpp:44:22: note: Parent function 'Coin::display_name'
  813. static std::string display_name() { return _("Coin"); }
  814. ^
  815. src/object/coin.hpp:97:22: note: Derived function 'HeavyCoin::display_name'
  816. static std::string display_name() { return _("Heavy Coin"); }
  817. ^
  818. src/object/coin.hpp:95:22: warning: The class 'HeavyCoin' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  819. static std::string class_name() { return "heavycoin"; }
  820. ^
  821. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  822. static std::string class_name() { return "moving-sprite"; }
  823. ^
  824. src/object/coin.hpp:95:22: note: Derived function 'HeavyCoin::class_name'
  825. static std::string class_name() { return "heavycoin"; }
  826. ^
  827. src/object/coin.hpp:95:22: warning: The class 'HeavyCoin' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  828. static std::string class_name() { return "heavycoin"; }
  829. ^
  830. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  831. static std::string class_name() { return "moving-object"; }
  832. ^
  833. src/object/coin.hpp:95:22: note: Derived function 'HeavyCoin::class_name'
  834. static std::string class_name() { return "heavycoin"; }
  835. ^
  836. src/badguy/crusher.hpp:59:3: style: Class 'Crusher' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  837. Crusher(const ReaderMapping& reader);
  838. ^
  839. src/object/brick.hpp:28:3: style: Class 'Brick' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  840. Brick(const ReaderMapping& mapping, const std::string& sprite_name = "images/objects/bonus_block/brick.sprite");
  841. ^
  842. src/object/brick.hpp:65:3: style: Class 'HeavyBrick' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  843. HeavyBrick(const ReaderMapping& mapping);
  844. ^
  845. src/object/coin.hpp:34:3: style: Class 'Coin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  846. Coin(const Vector& pos, bool count_stats = true,
  847. ^
  848. src/object/coin.hpp:36:3: style: Class 'Coin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  849. Coin(const ReaderMapping& reader, bool count_stats = true);
  850. ^
  851. src/object/coin.hpp:90:3: style: Class 'HeavyCoin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  852. HeavyCoin(const ReaderMapping& reader, bool count_stats = true);
  853. ^
  854. src/badguy/crusher.cpp:277:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  855. if (auto* player = Sector::get().get_nearest_player(m_col.m_bbox))
  856. ^
  857. src/badguy/crusher.cpp:484:14: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  858. for (auto* player : Sector::get().get_players())
  859. ^
  860. src/badguy/crusher.cpp:590:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  861. if (auto* player = Sector::get().get_nearest_player(m_col.m_bbox))
  862. ^
  863. src/badguy/dart.hpp:42:22: warning: The class 'Dart' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  864. static std::string class_name() { return "dart"; }
  865. ^
  866. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  867. static std::string class_name() { return "badguy"; }
  868. ^
  869. src/badguy/dart.hpp:42:22: note: Derived function 'Dart::class_name'
  870. static std::string class_name() { return "dart"; }
  871. ^
  872. src/badguy/dart.hpp:44:22: warning: The class 'Dart' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  873. static std::string display_name() { return _("Dart"); }
  874. ^
  875. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  876. static std::string display_name() { return _("Badguy"); }
  877. ^
  878. src/badguy/dart.hpp:44:22: note: Derived function 'Dart::display_name'
  879. static std::string display_name() { return _("Dart"); }
  880. ^
  881. src/badguy/dart.hpp:42:22: warning: The class 'Dart' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  882. static std::string class_name() { return "dart"; }
  883. ^
  884. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  885. static std::string class_name() { return "moving-sprite"; }
  886. ^
  887. src/badguy/dart.hpp:42:22: note: Derived function 'Dart::class_name'
  888. static std::string class_name() { return "dart"; }
  889. ^
  890. src/badguy/dart.hpp:42:22: warning: The class 'Dart' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  891. static std::string class_name() { return "dart"; }
  892. ^
  893. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  894. static std::string class_name() { return "moving-object"; }
  895. ^
  896. src/badguy/dart.hpp:42:22: note: Derived function 'Dart::class_name'
  897. static std::string class_name() { return "dart"; }
  898. ^
  899. src/badguy/dart.hpp:28:3: style: Class 'Dart' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  900. Dart(const ReaderMapping& reader);
  901. ^
  902. src/badguy/darttrap.hpp:33:22: warning: The class 'DartTrap' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  903. static std::string class_name() { return "darttrap"; }
  904. ^
  905. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  906. static std::string class_name() { return "badguy"; }
  907. ^
  908. src/badguy/darttrap.hpp:33:22: note: Derived function 'DartTrap::class_name'
  909. static std::string class_name() { return "darttrap"; }
  910. ^
  911. src/badguy/darttrap.hpp:35:22: warning: The class 'DartTrap' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  912. static std::string display_name() { return _("Dart Trap"); }
  913. ^
  914. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  915. static std::string display_name() { return _("Badguy"); }
  916. ^
  917. src/badguy/darttrap.hpp:35:22: note: Derived function 'DartTrap::display_name'
  918. static std::string display_name() { return _("Dart Trap"); }
  919. ^
  920. src/badguy/darttrap.hpp:33:22: warning: The class 'DartTrap' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  921. static std::string class_name() { return "darttrap"; }
  922. ^
  923. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  924. static std::string class_name() { return "moving-sprite"; }
  925. ^
  926. src/badguy/darttrap.hpp:33:22: note: Derived function 'DartTrap::class_name'
  927. static std::string class_name() { return "darttrap"; }
  928. ^
  929. src/badguy/darttrap.hpp:33:22: warning: The class 'DartTrap' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  930. static std::string class_name() { return "darttrap"; }
  931. ^
  932. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  933. static std::string class_name() { return "moving-object"; }
  934. ^
  935. src/badguy/darttrap.hpp:33:22: note: Derived function 'DartTrap::class_name'
  936. static std::string class_name() { return "darttrap"; }
  937. ^
  938. src/badguy/darttrap.hpp:26:3: style: Class 'DartTrap' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  939. DartTrap(const ReaderMapping& reader);
  940. ^
  941. src/badguy/dispenser.cpp:56:16: style: Variable 'badguy' can be declared as reference to const [constVariableReference]
  942. for (auto& badguy : badguys)
  943. ^
  944. src/badguy/dispenser.cpp:142:10: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  945. auto player = get_nearest_player();
  946. ^
  947. src/badguy/dispenser.cpp:178:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  948. Player* player = get_nearest_player();
  949. ^
  950. src/badguy/dispenser.cpp:199:10: style: Variable 'obj_badguy' can be declared as pointer to const [constVariablePointer]
  951. auto obj_badguy = dynamic_cast<BadGuy*>(object);
  952. ^
  953. src/badguy/dive_mine.hpp:48:22: warning: The class 'DiveMine' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  954. static std::string class_name() { return "dive-mine"; }
  955. ^
  956. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  957. static std::string class_name() { return "badguy"; }
  958. ^
  959. src/badguy/dive_mine.hpp:48:22: note: Derived function 'DiveMine::class_name'
  960. static std::string class_name() { return "dive-mine"; }
  961. ^
  962. src/badguy/dive_mine.hpp:50:22: warning: The class 'DiveMine' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  963. static std::string display_name() { return _("Dive Mine"); }
  964. ^
  965. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  966. static std::string display_name() { return _("Badguy"); }
  967. ^
  968. src/badguy/dive_mine.hpp:50:22: note: Derived function 'DiveMine::display_name'
  969. static std::string display_name() { return _("Dive Mine"); }
  970. ^
  971. src/badguy/dive_mine.hpp:48:22: warning: The class 'DiveMine' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  972. static std::string class_name() { return "dive-mine"; }
  973. ^
  974. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  975. static std::string class_name() { return "moving-sprite"; }
  976. ^
  977. src/badguy/dive_mine.hpp:48:22: note: Derived function 'DiveMine::class_name'
  978. static std::string class_name() { return "dive-mine"; }
  979. ^
  980. src/badguy/dive_mine.hpp:48:22: warning: The class 'DiveMine' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  981. static std::string class_name() { return "dive-mine"; }
  982. ^
  983. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  984. static std::string class_name() { return "moving-object"; }
  985. ^
  986. src/badguy/dive_mine.hpp:48:22: note: Derived function 'DiveMine::class_name'
  987. static std::string class_name() { return "dive-mine"; }
  988. ^
  989. src/badguy/dive_mine.hpp:32:3: style: Class 'DiveMine' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  990. DiveMine(const ReaderMapping& reader);
  991. ^
  992. src/badguy/dive_mine.cpp:146:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  993. auto player = get_nearest_player();
  994. ^
  995. src/badguy/fish_swimming.hpp:38:22: warning: The class 'FishSwimming' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  996. static std::string class_name() { return "fish-swimming"; }
  997. ^
  998. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  999. static std::string class_name() { return "badguy"; }
  1000. ^
  1001. src/badguy/fish_swimming.hpp:38:22: note: Derived function 'FishSwimming::class_name'
  1002. static std::string class_name() { return "fish-swimming"; }
  1003. ^
  1004. src/badguy/fish_swimming.hpp:40:22: warning: The class 'FishSwimming' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1005. static std::string display_name() { return _("Swimming Fish"); }
  1006. ^
  1007. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1008. static std::string display_name() { return _("Badguy"); }
  1009. ^
  1010. src/badguy/fish_swimming.hpp:40:22: note: Derived function 'FishSwimming::display_name'
  1011. static std::string display_name() { return _("Swimming Fish"); }
  1012. ^
  1013. src/badguy/fish_swimming.hpp:38:22: warning: The class 'FishSwimming' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1014. static std::string class_name() { return "fish-swimming"; }
  1015. ^
  1016. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1017. static std::string class_name() { return "moving-sprite"; }
  1018. ^
  1019. src/badguy/fish_swimming.hpp:38:22: note: Derived function 'FishSwimming::class_name'
  1020. static std::string class_name() { return "fish-swimming"; }
  1021. ^
  1022. src/badguy/fish_swimming.hpp:38:22: warning: The class 'FishSwimming' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1023. static std::string class_name() { return "fish-swimming"; }
  1024. ^
  1025. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1026. static std::string class_name() { return "moving-object"; }
  1027. ^
  1028. src/badguy/fish_swimming.hpp:38:22: note: Derived function 'FishSwimming::class_name'
  1029. static std::string class_name() { return "fish-swimming"; }
  1030. ^
  1031. src/badguy/fish_chasing.hpp:31:22: warning: The class 'FishChasing' defines member function with name 'class_name' also defined in its parent class 'FishSwimming'. [duplInheritedMember]
  1032. static std::string class_name() { return "fish-chasing"; }
  1033. ^
  1034. src/badguy/fish_swimming.hpp:38:22: note: Parent function 'FishSwimming::class_name'
  1035. static std::string class_name() { return "fish-swimming"; }
  1036. ^
  1037. src/badguy/fish_chasing.hpp:31:22: note: Derived function 'FishChasing::class_name'
  1038. static std::string class_name() { return "fish-chasing"; }
  1039. ^
  1040. src/badguy/fish_chasing.hpp:33:22: warning: The class 'FishChasing' defines member function with name 'display_name' also defined in its parent class 'FishSwimming'. [duplInheritedMember]
  1041. static std::string display_name() { return _("Chasing Fish"); }
  1042. ^
  1043. src/badguy/fish_swimming.hpp:40:22: note: Parent function 'FishSwimming::display_name'
  1044. static std::string display_name() { return _("Swimming Fish"); }
  1045. ^
  1046. src/badguy/fish_chasing.hpp:33:22: note: Derived function 'FishChasing::display_name'
  1047. static std::string display_name() { return _("Chasing Fish"); }
  1048. ^
  1049. src/badguy/fish_chasing.hpp:31:22: warning: The class 'FishChasing' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1050. static std::string class_name() { return "fish-chasing"; }
  1051. ^
  1052. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1053. static std::string class_name() { return "badguy"; }
  1054. ^
  1055. src/badguy/fish_chasing.hpp:31:22: note: Derived function 'FishChasing::class_name'
  1056. static std::string class_name() { return "fish-chasing"; }
  1057. ^
  1058. src/badguy/fish_chasing.hpp:33:22: warning: The class 'FishChasing' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1059. static std::string display_name() { return _("Chasing Fish"); }
  1060. ^
  1061. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1062. static std::string display_name() { return _("Badguy"); }
  1063. ^
  1064. src/badguy/fish_chasing.hpp:33:22: note: Derived function 'FishChasing::display_name'
  1065. static std::string display_name() { return _("Chasing Fish"); }
  1066. ^
  1067. src/badguy/fish_chasing.hpp:31:22: warning: The class 'FishChasing' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1068. static std::string class_name() { return "fish-chasing"; }
  1069. ^
  1070. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1071. static std::string class_name() { return "moving-sprite"; }
  1072. ^
  1073. src/badguy/fish_chasing.hpp:31:22: note: Derived function 'FishChasing::class_name'
  1074. static std::string class_name() { return "fish-chasing"; }
  1075. ^
  1076. src/badguy/fish_chasing.hpp:31:22: warning: The class 'FishChasing' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1077. static std::string class_name() { return "fish-chasing"; }
  1078. ^
  1079. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1080. static std::string class_name() { return "moving-object"; }
  1081. ^
  1082. src/badguy/fish_chasing.hpp:31:22: note: Derived function 'FishChasing::class_name'
  1083. static std::string class_name() { return "fish-chasing"; }
  1084. ^
  1085. src/badguy/fish_swimming.hpp:26:3: style: Class 'FishSwimming' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1086. FishSwimming(const ReaderMapping& reader);
  1087. ^
  1088. src/badguy/fish_chasing.hpp:25:3: style: Class 'FishChasing' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1089. FishChasing(const ReaderMapping& reader);
  1090. ^
  1091. src/badguy/fish_chasing.cpp:84:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1092. auto player = get_nearest_player();
  1093. ^
  1094. src/badguy/fish_harmless.hpp:28:22: warning: The class 'FishHarmless' defines member function with name 'class_name' also defined in its parent class 'FishSwimming'. [duplInheritedMember]
  1095. static std::string class_name() { return "fish-harmless"; }
  1096. ^
  1097. src/badguy/fish_swimming.hpp:38:22: note: Parent function 'FishSwimming::class_name'
  1098. static std::string class_name() { return "fish-swimming"; }
  1099. ^
  1100. src/badguy/fish_harmless.hpp:28:22: note: Derived function 'FishHarmless::class_name'
  1101. static std::string class_name() { return "fish-harmless"; }
  1102. ^
  1103. src/badguy/fish_harmless.hpp:30:22: warning: The class 'FishHarmless' defines member function with name 'display_name' also defined in its parent class 'FishSwimming'. [duplInheritedMember]
  1104. static std::string display_name() { return _("Harmless Fish"); }
  1105. ^
  1106. src/badguy/fish_swimming.hpp:40:22: note: Parent function 'FishSwimming::display_name'
  1107. static std::string display_name() { return _("Swimming Fish"); }
  1108. ^
  1109. src/badguy/fish_harmless.hpp:30:22: note: Derived function 'FishHarmless::display_name'
  1110. static std::string display_name() { return _("Harmless Fish"); }
  1111. ^
  1112. src/badguy/fish_harmless.hpp:28:22: warning: The class 'FishHarmless' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1113. static std::string class_name() { return "fish-harmless"; }
  1114. ^
  1115. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1116. static std::string class_name() { return "badguy"; }
  1117. ^
  1118. src/badguy/fish_harmless.hpp:28:22: note: Derived function 'FishHarmless::class_name'
  1119. static std::string class_name() { return "fish-harmless"; }
  1120. ^
  1121. src/badguy/fish_harmless.hpp:30:22: warning: The class 'FishHarmless' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1122. static std::string display_name() { return _("Harmless Fish"); }
  1123. ^
  1124. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1125. static std::string display_name() { return _("Badguy"); }
  1126. ^
  1127. src/badguy/fish_harmless.hpp:30:22: note: Derived function 'FishHarmless::display_name'
  1128. static std::string display_name() { return _("Harmless Fish"); }
  1129. ^
  1130. src/badguy/fish_harmless.hpp:28:22: warning: The class 'FishHarmless' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1131. static std::string class_name() { return "fish-harmless"; }
  1132. ^
  1133. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1134. static std::string class_name() { return "moving-sprite"; }
  1135. ^
  1136. src/badguy/fish_harmless.hpp:28:22: note: Derived function 'FishHarmless::class_name'
  1137. static std::string class_name() { return "fish-harmless"; }
  1138. ^
  1139. src/badguy/fish_harmless.hpp:28:22: warning: The class 'FishHarmless' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1140. static std::string class_name() { return "fish-harmless"; }
  1141. ^
  1142. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1143. static std::string class_name() { return "moving-object"; }
  1144. ^
  1145. src/badguy/fish_harmless.hpp:28:22: note: Derived function 'FishHarmless::class_name'
  1146. static std::string class_name() { return "fish-harmless"; }
  1147. ^
  1148. src/badguy/fish_harmless.hpp:26:3: style: Class 'FishHarmless' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1149. FishHarmless(const ReaderMapping& reader);
  1150. ^
  1151. src/badguy/fish_jumping.hpp:39:22: warning: The class 'FishJumping' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1152. static std::string class_name() { return "fish-jumping"; }
  1153. ^
  1154. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1155. static std::string class_name() { return "badguy"; }
  1156. ^
  1157. src/badguy/fish_jumping.hpp:39:22: note: Derived function 'FishJumping::class_name'
  1158. static std::string class_name() { return "fish-jumping"; }
  1159. ^
  1160. src/badguy/fish_jumping.hpp:41:22: warning: The class 'FishJumping' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1161. static std::string display_name() { return _("Jumping Fish"); }
  1162. ^
  1163. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1164. static std::string display_name() { return _("Badguy"); }
  1165. ^
  1166. src/badguy/fish_jumping.hpp:41:22: note: Derived function 'FishJumping::display_name'
  1167. static std::string display_name() { return _("Jumping Fish"); }
  1168. ^
  1169. src/badguy/fish_jumping.hpp:39:22: warning: The class 'FishJumping' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1170. static std::string class_name() { return "fish-jumping"; }
  1171. ^
  1172. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1173. static std::string class_name() { return "moving-sprite"; }
  1174. ^
  1175. src/badguy/fish_jumping.hpp:39:22: note: Derived function 'FishJumping::class_name'
  1176. static std::string class_name() { return "fish-jumping"; }
  1177. ^
  1178. src/badguy/fish_jumping.hpp:39:22: warning: The class 'FishJumping' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1179. static std::string class_name() { return "fish-jumping"; }
  1180. ^
  1181. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1182. static std::string class_name() { return "moving-object"; }
  1183. ^
  1184. src/badguy/fish_jumping.hpp:39:22: note: Derived function 'FishJumping::class_name'
  1185. static std::string class_name() { return "fish-jumping"; }
  1186. ^
  1187. src/badguy/fish_jumping.hpp:25:3: style: Class 'FishJumping' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1188. FishJumping(const ReaderMapping& );
  1189. ^
  1190. src/badguy/fish_swimming.cpp:106:25: style: Condition '!m_frozen' is always true [knownConditionTrueFalse]
  1191. if (hit.bottom && !m_frozen)
  1192. ^
  1193. src/badguy/fish_swimming.cpp:94:7: note: Assuming that condition 'm_frozen' is not redundant
  1194. if (m_frozen) {
  1195. ^
  1196. src/badguy/fish_swimming.cpp:106:25: note: Condition '!m_frozen' is always true
  1197. if (hit.bottom && !m_frozen)
  1198. ^
  1199. src/badguy/flame.hpp:45:22: warning: The class 'Flame' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1200. static std::string class_name() { return "flame"; }
  1201. ^
  1202. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1203. static std::string class_name() { return "badguy"; }
  1204. ^
  1205. src/badguy/flame.hpp:45:22: note: Derived function 'Flame::class_name'
  1206. static std::string class_name() { return "flame"; }
  1207. ^
  1208. src/badguy/flame.hpp:47:22: warning: The class 'Flame' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1209. static std::string display_name() { return _("Flame"); }
  1210. ^
  1211. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1212. static std::string display_name() { return _("Badguy"); }
  1213. ^
  1214. src/badguy/flame.hpp:47:22: note: Derived function 'Flame::display_name'
  1215. static std::string display_name() { return _("Flame"); }
  1216. ^
  1217. src/badguy/flame.hpp:45:22: warning: The class 'Flame' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1218. static std::string class_name() { return "flame"; }
  1219. ^
  1220. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1221. static std::string class_name() { return "moving-sprite"; }
  1222. ^
  1223. src/badguy/flame.hpp:45:22: note: Derived function 'Flame::class_name'
  1224. static std::string class_name() { return "flame"; }
  1225. ^
  1226. src/badguy/flame.hpp:45:22: warning: The class 'Flame' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1227. static std::string class_name() { return "flame"; }
  1228. ^
  1229. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1230. static std::string class_name() { return "moving-object"; }
  1231. ^
  1232. src/badguy/flame.hpp:45:22: note: Derived function 'Flame::class_name'
  1233. static std::string class_name() { return "flame"; }
  1234. ^
  1235. src/badguy/flame.hpp:27:3: style: Class 'Flame' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1236. Flame(const ReaderMapping& reader, int type = -1);
  1237. ^
  1238. src/badguy/flyingsnowball.hpp:31:22: warning: The class 'FlyingSnowBall' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1239. static std::string class_name() { return "flyingsnowball"; }
  1240. ^
  1241. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1242. static std::string class_name() { return "badguy"; }
  1243. ^
  1244. src/badguy/flyingsnowball.hpp:31:22: note: Derived function 'FlyingSnowBall::class_name'
  1245. static std::string class_name() { return "flyingsnowball"; }
  1246. ^
  1247. src/badguy/flyingsnowball.hpp:33:22: warning: The class 'FlyingSnowBall' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1248. static std::string display_name() { return _("Flying Snowball"); }
  1249. ^
  1250. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1251. static std::string display_name() { return _("Badguy"); }
  1252. ^
  1253. src/badguy/flyingsnowball.hpp:33:22: note: Derived function 'FlyingSnowBall::display_name'
  1254. static std::string display_name() { return _("Flying Snowball"); }
  1255. ^
  1256. src/badguy/flyingsnowball.hpp:31:22: warning: The class 'FlyingSnowBall' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1257. static std::string class_name() { return "flyingsnowball"; }
  1258. ^
  1259. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1260. static std::string class_name() { return "moving-sprite"; }
  1261. ^
  1262. src/badguy/flyingsnowball.hpp:31:22: note: Derived function 'FlyingSnowBall::class_name'
  1263. static std::string class_name() { return "flyingsnowball"; }
  1264. ^
  1265. src/badguy/flyingsnowball.hpp:31:22: warning: The class 'FlyingSnowBall' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1266. static std::string class_name() { return "flyingsnowball"; }
  1267. ^
  1268. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1269. static std::string class_name() { return "moving-object"; }
  1270. ^
  1271. src/badguy/flyingsnowball.hpp:31:22: note: Derived function 'FlyingSnowBall::class_name'
  1272. static std::string class_name() { return "flyingsnowball"; }
  1273. ^
  1274. src/badguy/flyingsnowball.hpp:25:3: style: Class 'FlyingSnowBall' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1275. FlyingSnowBall(const ReaderMapping& reader);
  1276. ^
  1277. src/badguy/flyingsnowball.cpp:89:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1278. auto player = get_nearest_player();
  1279. ^
  1280. src/object/lantern.hpp:36:22: warning: The class 'Lantern' defines member function with name 'class_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  1281. static std::string class_name() { return "lantern"; }
  1282. ^
  1283. src/object/rock.hpp:41:22: note: Parent function 'Rock::class_name'
  1284. static std::string class_name() { return "rock"; }
  1285. ^
  1286. src/object/lantern.hpp:36:22: note: Derived function 'Lantern::class_name'
  1287. static std::string class_name() { return "lantern"; }
  1288. ^
  1289. src/object/lantern.hpp:38:22: warning: The class 'Lantern' defines member function with name 'display_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  1290. static std::string display_name() { return _("Lantern"); }
  1291. ^
  1292. src/object/rock.hpp:43:22: note: Parent function 'Rock::display_name'
  1293. static std::string display_name() { return _("Rock"); }
  1294. ^
  1295. src/object/lantern.hpp:38:22: note: Derived function 'Lantern::display_name'
  1296. static std::string display_name() { return _("Lantern"); }
  1297. ^
  1298. src/object/lantern.hpp:36:22: warning: The class 'Lantern' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1299. static std::string class_name() { return "lantern"; }
  1300. ^
  1301. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1302. static std::string class_name() { return "moving-sprite"; }
  1303. ^
  1304. src/object/lantern.hpp:36:22: note: Derived function 'Lantern::class_name'
  1305. static std::string class_name() { return "lantern"; }
  1306. ^
  1307. src/object/lantern.hpp:36:22: warning: The class 'Lantern' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1308. static std::string class_name() { return "lantern"; }
  1309. ^
  1310. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1311. static std::string class_name() { return "moving-object"; }
  1312. ^
  1313. src/object/lantern.hpp:36:22: note: Derived function 'Lantern::class_name'
  1314. static std::string class_name() { return "lantern"; }
  1315. ^
  1316. src/badguy/ghosttree.hpp:41:22: warning: The class 'GhostTree' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1317. static std::string class_name() { return "ghosttree"; }
  1318. ^
  1319. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1320. static std::string class_name() { return "badguy"; }
  1321. ^
  1322. src/badguy/ghosttree.hpp:41:22: note: Derived function 'GhostTree::class_name'
  1323. static std::string class_name() { return "ghosttree"; }
  1324. ^
  1325. src/badguy/ghosttree.hpp:43:22: warning: The class 'GhostTree' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1326. static std::string display_name() { return _("Ghost Tree"); }
  1327. ^
  1328. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1329. static std::string display_name() { return _("Badguy"); }
  1330. ^
  1331. src/badguy/ghosttree.hpp:43:22: note: Derived function 'GhostTree::display_name'
  1332. static std::string display_name() { return _("Ghost Tree"); }
  1333. ^
  1334. src/badguy/ghosttree.hpp:41:22: warning: The class 'GhostTree' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1335. static std::string class_name() { return "ghosttree"; }
  1336. ^
  1337. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1338. static std::string class_name() { return "moving-sprite"; }
  1339. ^
  1340. src/badguy/ghosttree.hpp:41:22: note: Derived function 'GhostTree::class_name'
  1341. static std::string class_name() { return "ghosttree"; }
  1342. ^
  1343. src/badguy/ghosttree.hpp:41:22: warning: The class 'GhostTree' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1344. static std::string class_name() { return "ghosttree"; }
  1345. ^
  1346. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1347. static std::string class_name() { return "moving-object"; }
  1348. ^
  1349. src/badguy/ghosttree.hpp:41:22: note: Derived function 'GhostTree::class_name'
  1350. static std::string class_name() { return "ghosttree"; }
  1351. ^
  1352. src/object/rock.hpp:41:22: warning: The class 'Rock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1353. static std::string class_name() { return "rock"; }
  1354. ^
  1355. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1356. static std::string class_name() { return "moving-sprite"; }
  1357. ^
  1358. src/object/rock.hpp:41:22: note: Derived function 'Rock::class_name'
  1359. static std::string class_name() { return "rock"; }
  1360. ^
  1361. src/object/rock.hpp:41:22: warning: The class 'Rock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1362. static std::string class_name() { return "rock"; }
  1363. ^
  1364. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1365. static std::string class_name() { return "moving-object"; }
  1366. ^
  1367. src/object/rock.hpp:41:22: note: Derived function 'Rock::class_name'
  1368. static std::string class_name() { return "rock"; }
  1369. ^
  1370. src/badguy/ghosttree.hpp:28:3: style: Class 'GhostTree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1371. GhostTree(const ReaderMapping& mapping);
  1372. ^
  1373. src/object/rock.hpp:31:3: style: Class 'Rock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1374. Rock(const ReaderMapping& reader, const std::string& spritename = "images/objects/rock/rock.sprite");
  1375. ^
  1376. src/object/rock.hpp:32:3: style: Class 'Rock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1377. Rock(const Vector& pos, const std::string& spritename = "images/objects/rock/rock.sprite");
  1378. ^
  1379. src/object/lantern.hpp:26:3: style: Class 'Lantern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1380. Lantern(const Vector& pos);
  1381. ^
  1382. src/object/lantern.hpp:27:3: style: Class 'Lantern' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1383. Lantern(const ReaderMapping& reader);
  1384. ^
  1385. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Rock , scripting :: Rock >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1386. ExposedObject(S* parent) :
  1387. ^
  1388. src/badguy/ghoul.hpp:29:22: warning: The class 'Ghoul' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1389. static std::string class_name() { return "ghoul"; }
  1390. ^
  1391. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1392. static std::string class_name() { return "badguy"; }
  1393. ^
  1394. src/badguy/ghoul.hpp:29:22: note: Derived function 'Ghoul::class_name'
  1395. static std::string class_name() { return "ghoul"; }
  1396. ^
  1397. src/badguy/ghoul.hpp:30:22: warning: The class 'Ghoul' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1398. static std::string display_name() { return _("Ghoul"); }
  1399. ^
  1400. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1401. static std::string display_name() { return _("Badguy"); }
  1402. ^
  1403. src/badguy/ghoul.hpp:30:22: note: Derived function 'Ghoul::display_name'
  1404. static std::string display_name() { return _("Ghoul"); }
  1405. ^
  1406. src/badguy/ghoul.hpp:29:22: warning: The class 'Ghoul' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1407. static std::string class_name() { return "ghoul"; }
  1408. ^
  1409. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1410. static std::string class_name() { return "moving-sprite"; }
  1411. ^
  1412. src/badguy/ghoul.hpp:29:22: note: Derived function 'Ghoul::class_name'
  1413. static std::string class_name() { return "ghoul"; }
  1414. ^
  1415. src/badguy/ghoul.hpp:29:22: warning: The class 'Ghoul' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1416. static std::string class_name() { return "ghoul"; }
  1417. ^
  1418. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1419. static std::string class_name() { return "moving-object"; }
  1420. ^
  1421. src/badguy/ghoul.hpp:29:22: note: Derived function 'Ghoul::class_name'
  1422. static std::string class_name() { return "ghoul"; }
  1423. ^
  1424. src/badguy/ghoul.hpp:28:3: style: Class 'Ghoul' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1425. Ghoul(const ReaderMapping& reader);
  1426. ^
  1427. src/squirrel/squirrel_scheduler.hpp:31:3: style: Class 'SquirrelScheduler' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1428. SquirrelScheduler(SquirrelVM& vm);
  1429. ^
  1430. src/badguy/ghoul.cpp:106:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1431. auto player = get_nearest_player();
  1432. ^
  1433. src/badguy/goldbomb.hpp:48:22: warning: The class 'GoldBomb' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1434. static std::string class_name() { return "goldbomb"; }
  1435. ^
  1436. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1437. static std::string class_name() { return "badguy"; }
  1438. ^
  1439. src/badguy/goldbomb.hpp:48:22: note: Derived function 'GoldBomb::class_name'
  1440. static std::string class_name() { return "goldbomb"; }
  1441. ^
  1442. src/badguy/goldbomb.hpp:50:22: warning: The class 'GoldBomb' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1443. static std::string display_name() { return _("Gold Bomb"); }
  1444. ^
  1445. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1446. static std::string display_name() { return _("Badguy"); }
  1447. ^
  1448. src/badguy/goldbomb.hpp:50:22: note: Derived function 'GoldBomb::display_name'
  1449. static std::string display_name() { return _("Gold Bomb"); }
  1450. ^
  1451. src/badguy/goldbomb.hpp:48:22: warning: The class 'GoldBomb' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1452. static std::string class_name() { return "goldbomb"; }
  1453. ^
  1454. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1455. static std::string class_name() { return "moving-sprite"; }
  1456. ^
  1457. src/badguy/goldbomb.hpp:48:22: note: Derived function 'GoldBomb::class_name'
  1458. static std::string class_name() { return "goldbomb"; }
  1459. ^
  1460. src/badguy/goldbomb.hpp:48:22: warning: The class 'GoldBomb' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1461. static std::string class_name() { return "goldbomb"; }
  1462. ^
  1463. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1464. static std::string class_name() { return "moving-object"; }
  1465. ^
  1466. src/badguy/goldbomb.hpp:48:22: note: Derived function 'GoldBomb::class_name'
  1467. static std::string class_name() { return "goldbomb"; }
  1468. ^
  1469. src/badguy/haywire.hpp:44:22: warning: The class 'Haywire' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1470. static std::string class_name() { return "haywire"; }
  1471. ^
  1472. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1473. static std::string class_name() { return "badguy"; }
  1474. ^
  1475. src/badguy/haywire.hpp:44:22: note: Derived function 'Haywire::class_name'
  1476. static std::string class_name() { return "haywire"; }
  1477. ^
  1478. src/badguy/haywire.hpp:46:22: warning: The class 'Haywire' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1479. static std::string display_name() { return _("Haywire"); }
  1480. ^
  1481. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1482. static std::string display_name() { return _("Badguy"); }
  1483. ^
  1484. src/badguy/haywire.hpp:46:22: note: Derived function 'Haywire::display_name'
  1485. static std::string display_name() { return _("Haywire"); }
  1486. ^
  1487. src/badguy/haywire.hpp:44:22: warning: The class 'Haywire' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1488. static std::string class_name() { return "haywire"; }
  1489. ^
  1490. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1491. static std::string class_name() { return "moving-sprite"; }
  1492. ^
  1493. src/badguy/haywire.hpp:44:22: note: Derived function 'Haywire::class_name'
  1494. static std::string class_name() { return "haywire"; }
  1495. ^
  1496. src/badguy/haywire.hpp:44:22: warning: The class 'Haywire' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1497. static std::string class_name() { return "haywire"; }
  1498. ^
  1499. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1500. static std::string class_name() { return "moving-object"; }
  1501. ^
  1502. src/badguy/haywire.hpp:44:22: note: Derived function 'Haywire::class_name'
  1503. static std::string class_name() { return "haywire"; }
  1504. ^
  1505. src/badguy/owl.hpp:43:22: warning: The class 'Owl' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1506. static std::string class_name() { return "owl"; }
  1507. ^
  1508. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1509. static std::string class_name() { return "badguy"; }
  1510. ^
  1511. src/badguy/owl.hpp:43:22: note: Derived function 'Owl::class_name'
  1512. static std::string class_name() { return "owl"; }
  1513. ^
  1514. src/badguy/owl.hpp:45:22: warning: The class 'Owl' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1515. static std::string display_name() { return _("Owl"); }
  1516. ^
  1517. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1518. static std::string display_name() { return _("Badguy"); }
  1519. ^
  1520. src/badguy/owl.hpp:45:22: note: Derived function 'Owl::display_name'
  1521. static std::string display_name() { return _("Owl"); }
  1522. ^
  1523. src/badguy/owl.hpp:43:22: warning: The class 'Owl' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1524. static std::string class_name() { return "owl"; }
  1525. ^
  1526. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1527. static std::string class_name() { return "moving-sprite"; }
  1528. ^
  1529. src/badguy/owl.hpp:43:22: note: Derived function 'Owl::class_name'
  1530. static std::string class_name() { return "owl"; }
  1531. ^
  1532. src/badguy/owl.hpp:43:22: warning: The class 'Owl' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1533. static std::string class_name() { return "owl"; }
  1534. ^
  1535. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1536. static std::string class_name() { return "moving-object"; }
  1537. ^
  1538. src/badguy/owl.hpp:43:22: note: Derived function 'Owl::class_name'
  1539. static std::string class_name() { return "owl"; }
  1540. ^
  1541. src/badguy/goldbomb.hpp:29:3: style: Class 'GoldBomb' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1542. GoldBomb(const ReaderMapping& reader);
  1543. ^
  1544. src/badguy/haywire.hpp:28:3: style: Class 'Haywire' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1545. Haywire(const ReaderMapping& reader);
  1546. ^
  1547. src/badguy/owl.hpp:31:3: style: Class 'Owl' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1548. Owl(const ReaderMapping& reader);
  1549. ^
  1550. src/object/coin_explode.hpp:26:3: style: Class 'CoinExplode' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1551. CoinExplode(const Vector& pos, bool count_stats = true,
  1552. ^
  1553. src/badguy/goldbomb.cpp:190:10: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1554. auto player = dynamic_cast<Player*>(obj);
  1555. ^
  1556. src/badguy/goldbomb.cpp:193:10: style: Variable 'haywire' can be declared as pointer to const [constVariablePointer]
  1557. auto haywire = dynamic_cast<Haywire*>(obj);
  1558. ^
  1559. src/badguy/goldbomb.cpp:196:10: style: Variable 'bomb' can be declared as pointer to const [constVariablePointer]
  1560. auto bomb = dynamic_cast<Bomb*>(obj);
  1561. ^
  1562. src/badguy/goldbomb.cpp:199:10: style: Variable 'goldbomb' can be declared as pointer to const [constVariablePointer]
  1563. auto goldbomb = dynamic_cast<GoldBomb*>(obj);
  1564. ^
  1565. src/badguy/granito_big.hpp:31:22: warning: The class 'GranitoBig' defines member function with name 'class_name' also defined in its parent class 'Granito'. [duplInheritedMember]
  1566. static std::string class_name() { return "granito_big"; }
  1567. ^
  1568. src/badguy/granito.hpp:37:22: note: Parent function 'Granito::class_name'
  1569. static std::string class_name() { return "granito"; }
  1570. ^
  1571. src/badguy/granito_big.hpp:31:22: note: Derived function 'GranitoBig::class_name'
  1572. static std::string class_name() { return "granito_big"; }
  1573. ^
  1574. src/badguy/granito_big.hpp:33:22: warning: The class 'GranitoBig' defines member function with name 'display_name' also defined in its parent class 'Granito'. [duplInheritedMember]
  1575. static std::string display_name() { return _("Big Granito"); }
  1576. ^
  1577. src/badguy/granito.hpp:39:22: note: Parent function 'Granito::display_name'
  1578. static std::string display_name() { return _("Granito"); }
  1579. ^
  1580. src/badguy/granito_big.hpp:33:22: note: Derived function 'GranitoBig::display_name'
  1581. static std::string display_name() { return _("Big Granito"); }
  1582. ^
  1583. src/badguy/granito_big.hpp:31:22: warning: The class 'GranitoBig' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1584. static std::string class_name() { return "granito_big"; }
  1585. ^
  1586. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1587. static std::string class_name() { return "badguy"; }
  1588. ^
  1589. src/badguy/granito_big.hpp:31:22: note: Derived function 'GranitoBig::class_name'
  1590. static std::string class_name() { return "granito_big"; }
  1591. ^
  1592. src/badguy/granito_big.hpp:33:22: warning: The class 'GranitoBig' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1593. static std::string display_name() { return _("Big Granito"); }
  1594. ^
  1595. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1596. static std::string display_name() { return _("Badguy"); }
  1597. ^
  1598. src/badguy/granito_big.hpp:33:22: note: Derived function 'GranitoBig::display_name'
  1599. static std::string display_name() { return _("Big Granito"); }
  1600. ^
  1601. src/badguy/granito_big.hpp:31:22: warning: The class 'GranitoBig' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1602. static std::string class_name() { return "granito_big"; }
  1603. ^
  1604. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1605. static std::string class_name() { return "moving-sprite"; }
  1606. ^
  1607. src/badguy/granito_big.hpp:31:22: note: Derived function 'GranitoBig::class_name'
  1608. static std::string class_name() { return "granito_big"; }
  1609. ^
  1610. src/badguy/granito_big.hpp:31:22: warning: The class 'GranitoBig' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1611. static std::string class_name() { return "granito_big"; }
  1612. ^
  1613. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1614. static std::string class_name() { return "moving-object"; }
  1615. ^
  1616. src/badguy/granito_big.hpp:31:22: note: Derived function 'GranitoBig::class_name'
  1617. static std::string class_name() { return "granito_big"; }
  1618. ^
  1619. src/badguy/granito.hpp:37:22: warning: The class 'Granito' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1620. static std::string class_name() { return "granito"; }
  1621. ^
  1622. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1623. static std::string class_name() { return "badguy"; }
  1624. ^
  1625. src/badguy/granito.hpp:37:22: note: Derived function 'Granito::class_name'
  1626. static std::string class_name() { return "granito"; }
  1627. ^
  1628. src/badguy/granito.hpp:39:22: warning: The class 'Granito' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1629. static std::string display_name() { return _("Granito"); }
  1630. ^
  1631. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1632. static std::string display_name() { return _("Badguy"); }
  1633. ^
  1634. src/badguy/granito.hpp:39:22: note: Derived function 'Granito::display_name'
  1635. static std::string display_name() { return _("Granito"); }
  1636. ^
  1637. src/badguy/granito.hpp:37:22: warning: The class 'Granito' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1638. static std::string class_name() { return "granito"; }
  1639. ^
  1640. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1641. static std::string class_name() { return "moving-sprite"; }
  1642. ^
  1643. src/badguy/granito.hpp:37:22: note: Derived function 'Granito::class_name'
  1644. static std::string class_name() { return "granito"; }
  1645. ^
  1646. src/badguy/granito.hpp:37:22: warning: The class 'Granito' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1647. static std::string class_name() { return "granito"; }
  1648. ^
  1649. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1650. static std::string class_name() { return "moving-object"; }
  1651. ^
  1652. src/badguy/granito.hpp:37:22: note: Derived function 'Granito::class_name'
  1653. static std::string class_name() { return "granito"; }
  1654. ^
  1655. src/badguy/granito.hpp:28:3: style: Class 'Granito' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1656. Granito(const ReaderMapping& reader,
  1657. ^
  1658. src/badguy/granito_big.hpp:25:3: style: Class 'GranitoBig' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1659. GranitoBig(const ReaderMapping& reader);
  1660. ^
  1661. src/badguy/granito_giant.hpp:30:22: warning: The class 'GranitoGiant' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1662. static std::string class_name() { return "granito_giant"; }
  1663. ^
  1664. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1665. static std::string class_name() { return "badguy"; }
  1666. ^
  1667. src/badguy/granito_giant.hpp:30:22: note: Derived function 'GranitoGiant::class_name'
  1668. static std::string class_name() { return "granito_giant"; }
  1669. ^
  1670. src/badguy/granito_giant.hpp:32:22: warning: The class 'GranitoGiant' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1671. static std::string display_name() { return _("Giant Granito"); }
  1672. ^
  1673. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1674. static std::string display_name() { return _("Badguy"); }
  1675. ^
  1676. src/badguy/granito_giant.hpp:32:22: note: Derived function 'GranitoGiant::display_name'
  1677. static std::string display_name() { return _("Giant Granito"); }
  1678. ^
  1679. src/badguy/granito_giant.hpp:30:22: warning: The class 'GranitoGiant' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1680. static std::string class_name() { return "granito_giant"; }
  1681. ^
  1682. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1683. static std::string class_name() { return "moving-sprite"; }
  1684. ^
  1685. src/badguy/granito_giant.hpp:30:22: note: Derived function 'GranitoGiant::class_name'
  1686. static std::string class_name() { return "granito_giant"; }
  1687. ^
  1688. src/badguy/granito_giant.hpp:30:22: warning: The class 'GranitoGiant' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1689. static std::string class_name() { return "granito_giant"; }
  1690. ^
  1691. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1692. static std::string class_name() { return "moving-object"; }
  1693. ^
  1694. src/badguy/granito_giant.hpp:30:22: note: Derived function 'GranitoGiant::class_name'
  1695. static std::string class_name() { return "granito_giant"; }
  1696. ^
  1697. src/badguy/haywire.cpp:109:9: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1698. auto* player = get_nearest_player();
  1699. ^
  1700. src/badguy/jumpy.hpp:38:22: warning: The class 'Jumpy' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1701. static std::string class_name() { return "jumpy"; }
  1702. ^
  1703. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1704. static std::string class_name() { return "badguy"; }
  1705. ^
  1706. src/badguy/jumpy.hpp:38:22: note: Derived function 'Jumpy::class_name'
  1707. static std::string class_name() { return "jumpy"; }
  1708. ^
  1709. src/badguy/jumpy.hpp:40:22: warning: The class 'Jumpy' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1710. static std::string display_name() { return _("Jumpy"); }
  1711. ^
  1712. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1713. static std::string display_name() { return _("Badguy"); }
  1714. ^
  1715. src/badguy/jumpy.hpp:40:22: note: Derived function 'Jumpy::display_name'
  1716. static std::string display_name() { return _("Jumpy"); }
  1717. ^
  1718. src/badguy/jumpy.hpp:38:22: warning: The class 'Jumpy' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1719. static std::string class_name() { return "jumpy"; }
  1720. ^
  1721. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1722. static std::string class_name() { return "moving-sprite"; }
  1723. ^
  1724. src/badguy/jumpy.hpp:38:22: note: Derived function 'Jumpy::class_name'
  1725. static std::string class_name() { return "jumpy"; }
  1726. ^
  1727. src/badguy/jumpy.hpp:38:22: warning: The class 'Jumpy' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1728. static std::string class_name() { return "jumpy"; }
  1729. ^
  1730. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1731. static std::string class_name() { return "moving-object"; }
  1732. ^
  1733. src/badguy/jumpy.hpp:38:22: note: Derived function 'Jumpy::class_name'
  1734. static std::string class_name() { return "jumpy"; }
  1735. ^
  1736. src/badguy/jumpy.hpp:25:3: style: Class 'Jumpy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1737. Jumpy(const ReaderMapping& reader);
  1738. ^
  1739. src/badguy/igel.hpp:36:22: warning: The class 'Igel' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1740. static std::string class_name() { return "igel"; }
  1741. ^
  1742. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1743. static std::string class_name() { return "badguy"; }
  1744. ^
  1745. src/badguy/igel.hpp:36:22: note: Derived function 'Igel::class_name'
  1746. static std::string class_name() { return "igel"; }
  1747. ^
  1748. src/badguy/igel.hpp:38:22: warning: The class 'Igel' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1749. static std::string display_name() { return _("Igel"); }
  1750. ^
  1751. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1752. static std::string display_name() { return _("Badguy"); }
  1753. ^
  1754. src/badguy/igel.hpp:38:22: note: Derived function 'Igel::display_name'
  1755. static std::string display_name() { return _("Igel"); }
  1756. ^
  1757. src/badguy/igel.hpp:36:22: warning: The class 'Igel' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1758. static std::string class_name() { return "igel"; }
  1759. ^
  1760. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1761. static std::string class_name() { return "moving-sprite"; }
  1762. ^
  1763. src/badguy/igel.hpp:36:22: note: Derived function 'Igel::class_name'
  1764. static std::string class_name() { return "igel"; }
  1765. ^
  1766. src/badguy/igel.hpp:36:22: warning: The class 'Igel' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1767. static std::string class_name() { return "igel"; }
  1768. ^
  1769. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1770. static std::string class_name() { return "moving-object"; }
  1771. ^
  1772. src/badguy/igel.hpp:36:22: note: Derived function 'Igel::class_name'
  1773. static std::string class_name() { return "igel"; }
  1774. ^
  1775. src/badguy/igel.hpp:28:3: style: Class 'Igel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1776. Igel(const ReaderMapping& reader);
  1777. ^
  1778. src/badguy/jumpy.cpp:110:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  1779. auto player = get_nearest_player();
  1780. ^
  1781. src/badguy/kamikazesnowball.hpp:32:22: warning: The class 'KamikazeSnowball' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1782. static std::string class_name() { return "kamikazesnowball"; }
  1783. ^
  1784. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1785. static std::string class_name() { return "badguy"; }
  1786. ^
  1787. src/badguy/kamikazesnowball.hpp:32:22: note: Derived function 'KamikazeSnowball::class_name'
  1788. static std::string class_name() { return "kamikazesnowball"; }
  1789. ^
  1790. src/badguy/kamikazesnowball.hpp:34:22: warning: The class 'KamikazeSnowball' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1791. static std::string display_name() { return _("Kamikaze Snowball"); }
  1792. ^
  1793. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1794. static std::string display_name() { return _("Badguy"); }
  1795. ^
  1796. src/badguy/kamikazesnowball.hpp:34:22: note: Derived function 'KamikazeSnowball::display_name'
  1797. static std::string display_name() { return _("Kamikaze Snowball"); }
  1798. ^
  1799. src/badguy/kamikazesnowball.hpp:32:22: warning: The class 'KamikazeSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1800. static std::string class_name() { return "kamikazesnowball"; }
  1801. ^
  1802. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1803. static std::string class_name() { return "moving-sprite"; }
  1804. ^
  1805. src/badguy/kamikazesnowball.hpp:32:22: note: Derived function 'KamikazeSnowball::class_name'
  1806. static std::string class_name() { return "kamikazesnowball"; }
  1807. ^
  1808. src/badguy/kamikazesnowball.hpp:32:22: warning: The class 'KamikazeSnowball' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1809. static std::string class_name() { return "kamikazesnowball"; }
  1810. ^
  1811. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1812. static std::string class_name() { return "moving-object"; }
  1813. ^
  1814. src/badguy/kamikazesnowball.hpp:32:22: note: Derived function 'KamikazeSnowball::class_name'
  1815. static std::string class_name() { return "kamikazesnowball"; }
  1816. ^
  1817. src/badguy/kamikazesnowball.hpp:62:22: warning: The class 'LeafShot' defines member function with name 'class_name' also defined in its parent class 'KamikazeSnowball'. [duplInheritedMember]
  1818. static std::string class_name() { return "leafshot"; }
  1819. ^
  1820. src/badguy/kamikazesnowball.hpp:32:22: note: Parent function 'KamikazeSnowball::class_name'
  1821. static std::string class_name() { return "kamikazesnowball"; }
  1822. ^
  1823. src/badguy/kamikazesnowball.hpp:62:22: note: Derived function 'LeafShot::class_name'
  1824. static std::string class_name() { return "leafshot"; }
  1825. ^
  1826. src/badguy/kamikazesnowball.hpp:64:22: warning: The class 'LeafShot' defines member function with name 'display_name' also defined in its parent class 'KamikazeSnowball'. [duplInheritedMember]
  1827. static std::string display_name() { return _("Leafshot"); }
  1828. ^
  1829. src/badguy/kamikazesnowball.hpp:34:22: note: Parent function 'KamikazeSnowball::display_name'
  1830. static std::string display_name() { return _("Kamikaze Snowball"); }
  1831. ^
  1832. src/badguy/kamikazesnowball.hpp:64:22: note: Derived function 'LeafShot::display_name'
  1833. static std::string display_name() { return _("Leafshot"); }
  1834. ^
  1835. src/badguy/kamikazesnowball.hpp:62:22: warning: The class 'LeafShot' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1836. static std::string class_name() { return "leafshot"; }
  1837. ^
  1838. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1839. static std::string class_name() { return "badguy"; }
  1840. ^
  1841. src/badguy/kamikazesnowball.hpp:62:22: note: Derived function 'LeafShot::class_name'
  1842. static std::string class_name() { return "leafshot"; }
  1843. ^
  1844. src/badguy/kamikazesnowball.hpp:64:22: warning: The class 'LeafShot' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1845. static std::string display_name() { return _("Leafshot"); }
  1846. ^
  1847. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1848. static std::string display_name() { return _("Badguy"); }
  1849. ^
  1850. src/badguy/kamikazesnowball.hpp:64:22: note: Derived function 'LeafShot::display_name'
  1851. static std::string display_name() { return _("Leafshot"); }
  1852. ^
  1853. src/badguy/kamikazesnowball.hpp:62:22: warning: The class 'LeafShot' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1854. static std::string class_name() { return "leafshot"; }
  1855. ^
  1856. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1857. static std::string class_name() { return "moving-sprite"; }
  1858. ^
  1859. src/badguy/kamikazesnowball.hpp:62:22: note: Derived function 'LeafShot::class_name'
  1860. static std::string class_name() { return "leafshot"; }
  1861. ^
  1862. src/badguy/kamikazesnowball.hpp:62:22: warning: The class 'LeafShot' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1863. static std::string class_name() { return "leafshot"; }
  1864. ^
  1865. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1866. static std::string class_name() { return "moving-object"; }
  1867. ^
  1868. src/badguy/kamikazesnowball.hpp:62:22: note: Derived function 'LeafShot::class_name'
  1869. static std::string class_name() { return "leafshot"; }
  1870. ^
  1871. src/badguy/kamikazesnowball.hpp:27:3: style: Class 'KamikazeSnowball' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1872. KamikazeSnowball(const ReaderMapping& reader,
  1873. ^
  1874. src/badguy/kamikazesnowball.hpp:51:3: style: Class 'LeafShot' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1875. LeafShot(const ReaderMapping& reader);
  1876. ^
  1877. src/badguy/kugelblitz.hpp:49:8: style: Unused private function: 'Kugelblitz::try_activate' [unusedPrivateFunction]
  1878. void try_activate();
  1879. ^
  1880. src/badguy/kugelblitz.hpp:38:22: warning: The class 'Kugelblitz' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1881. static std::string class_name() { return "kugelblitz"; }
  1882. ^
  1883. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1884. static std::string class_name() { return "badguy"; }
  1885. ^
  1886. src/badguy/kugelblitz.hpp:38:22: note: Derived function 'Kugelblitz::class_name'
  1887. static std::string class_name() { return "kugelblitz"; }
  1888. ^
  1889. src/badguy/kugelblitz.hpp:40:22: warning: The class 'Kugelblitz' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1890. static std::string display_name() { return _("Kugelblitz"); }
  1891. ^
  1892. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1893. static std::string display_name() { return _("Badguy"); }
  1894. ^
  1895. src/badguy/kugelblitz.hpp:40:22: note: Derived function 'Kugelblitz::display_name'
  1896. static std::string display_name() { return _("Kugelblitz"); }
  1897. ^
  1898. src/badguy/kugelblitz.hpp:38:22: warning: The class 'Kugelblitz' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1899. static std::string class_name() { return "kugelblitz"; }
  1900. ^
  1901. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1902. static std::string class_name() { return "moving-sprite"; }
  1903. ^
  1904. src/badguy/kugelblitz.hpp:38:22: note: Derived function 'Kugelblitz::class_name'
  1905. static std::string class_name() { return "kugelblitz"; }
  1906. ^
  1907. src/badguy/kugelblitz.hpp:38:22: warning: The class 'Kugelblitz' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1908. static std::string class_name() { return "kugelblitz"; }
  1909. ^
  1910. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1911. static std::string class_name() { return "moving-object"; }
  1912. ^
  1913. src/badguy/kugelblitz.hpp:38:22: note: Derived function 'Kugelblitz::class_name'
  1914. static std::string class_name() { return "kugelblitz"; }
  1915. ^
  1916. src/badguy/kugelblitz.hpp:25:3: style: Class 'Kugelblitz' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  1917. Kugelblitz(const ReaderMapping& reader);
  1918. ^
  1919. src/badguy/kugelblitz.cpp:183:8: style: Variable 'player_' can be declared as pointer to const [constVariablePointer]
  1920. auto player_ = get_nearest_player();
  1921. ^
  1922. src/badguy/kugelblitz.cpp:192:17: style: Variable 'player__' can be declared as pointer to const [constVariablePointer]
  1923. Player* player__ = get_nearest_player();
  1924. ^
  1925. src/badguy/livefire.hpp:36:22: warning: The class 'LiveFire' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1926. static std::string class_name() { return "livefire"; }
  1927. ^
  1928. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1929. static std::string class_name() { return "badguy"; }
  1930. ^
  1931. src/badguy/livefire.hpp:36:22: note: Derived function 'LiveFire::class_name'
  1932. static std::string class_name() { return "livefire"; }
  1933. ^
  1934. src/badguy/livefire.hpp:38:22: warning: The class 'LiveFire' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1935. static std::string display_name() { return _("Walking Flame"); }
  1936. ^
  1937. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1938. static std::string display_name() { return _("Badguy"); }
  1939. ^
  1940. src/badguy/livefire.hpp:38:22: note: Derived function 'LiveFire::display_name'
  1941. static std::string display_name() { return _("Walking Flame"); }
  1942. ^
  1943. src/badguy/livefire.hpp:36:22: warning: The class 'LiveFire' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1944. static std::string class_name() { return "livefire"; }
  1945. ^
  1946. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  1947. static std::string class_name() { return "moving-sprite"; }
  1948. ^
  1949. src/badguy/livefire.hpp:36:22: note: Derived function 'LiveFire::class_name'
  1950. static std::string class_name() { return "livefire"; }
  1951. ^
  1952. src/badguy/livefire.hpp:36:22: warning: The class 'LiveFire' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  1953. static std::string class_name() { return "livefire"; }
  1954. ^
  1955. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  1956. static std::string class_name() { return "moving-object"; }
  1957. ^
  1958. src/badguy/livefire.hpp:36:22: note: Derived function 'LiveFire::class_name'
  1959. static std::string class_name() { return "livefire"; }
  1960. ^
  1961. src/badguy/livefire.hpp:69:22: warning: The class 'LiveFireAsleep' defines member function with name 'class_name' also defined in its parent class 'LiveFire'. [duplInheritedMember]
  1962. static std::string class_name() { return "livefire_asleep"; }
  1963. ^
  1964. src/badguy/livefire.hpp:36:22: note: Parent function 'LiveFire::class_name'
  1965. static std::string class_name() { return "livefire"; }
  1966. ^
  1967. src/badguy/livefire.hpp:69:22: note: Derived function 'LiveFireAsleep::class_name'
  1968. static std::string class_name() { return "livefire_asleep"; }
  1969. ^
  1970. src/badguy/livefire.hpp:71:22: warning: The class 'LiveFireAsleep' defines member function with name 'display_name' also defined in its parent class 'LiveFire'. [duplInheritedMember]
  1971. static std::string display_name() { return _("Sleeping Flame"); }
  1972. ^
  1973. src/badguy/livefire.hpp:38:22: note: Parent function 'LiveFire::display_name'
  1974. static std::string display_name() { return _("Walking Flame"); }
  1975. ^
  1976. src/badguy/livefire.hpp:71:22: note: Derived function 'LiveFireAsleep::display_name'
  1977. static std::string display_name() { return _("Sleeping Flame"); }
  1978. ^
  1979. src/badguy/livefire.hpp:69:22: warning: The class 'LiveFireAsleep' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1980. static std::string class_name() { return "livefire_asleep"; }
  1981. ^
  1982. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  1983. static std::string class_name() { return "badguy"; }
  1984. ^
  1985. src/badguy/livefire.hpp:69:22: note: Derived function 'LiveFireAsleep::class_name'
  1986. static std::string class_name() { return "livefire_asleep"; }
  1987. ^
  1988. src/badguy/livefire.hpp:71:22: warning: The class 'LiveFireAsleep' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  1989. static std::string display_name() { return _("Sleeping Flame"); }
  1990. ^
  1991. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  1992. static std::string display_name() { return _("Badguy"); }
  1993. ^
  1994. src/badguy/livefire.hpp:71:22: note: Derived function 'LiveFireAsleep::display_name'
  1995. static std::string display_name() { return _("Sleeping Flame"); }
  1996. ^
  1997. src/badguy/livefire.hpp:69:22: warning: The class 'LiveFireAsleep' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  1998. static std::string class_name() { return "livefire_asleep"; }
  1999. ^
  2000. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2001. static std::string class_name() { return "moving-sprite"; }
  2002. ^
  2003. src/badguy/livefire.hpp:69:22: note: Derived function 'LiveFireAsleep::class_name'
  2004. static std::string class_name() { return "livefire_asleep"; }
  2005. ^
  2006. src/badguy/livefire.hpp:69:22: warning: The class 'LiveFireAsleep' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2007. static std::string class_name() { return "livefire_asleep"; }
  2008. ^
  2009. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2010. static std::string class_name() { return "moving-object"; }
  2011. ^
  2012. src/badguy/livefire.hpp:69:22: note: Derived function 'LiveFireAsleep::class_name'
  2013. static std::string class_name() { return "livefire_asleep"; }
  2014. ^
  2015. src/badguy/livefire.hpp:87:22: warning: The class 'LiveFireDormant' defines member function with name 'class_name' also defined in its parent class 'LiveFire'. [duplInheritedMember]
  2016. static std::string class_name() { return "livefire_dormant"; }
  2017. ^
  2018. src/badguy/livefire.hpp:36:22: note: Parent function 'LiveFire::class_name'
  2019. static std::string class_name() { return "livefire"; }
  2020. ^
  2021. src/badguy/livefire.hpp:87:22: note: Derived function 'LiveFireDormant::class_name'
  2022. static std::string class_name() { return "livefire_dormant"; }
  2023. ^
  2024. src/badguy/livefire.hpp:89:22: warning: The class 'LiveFireDormant' defines member function with name 'display_name' also defined in its parent class 'LiveFire'. [duplInheritedMember]
  2025. static std::string display_name() { return _("Dormant Flame"); }
  2026. ^
  2027. src/badguy/livefire.hpp:38:22: note: Parent function 'LiveFire::display_name'
  2028. static std::string display_name() { return _("Walking Flame"); }
  2029. ^
  2030. src/badguy/livefire.hpp:89:22: note: Derived function 'LiveFireDormant::display_name'
  2031. static std::string display_name() { return _("Dormant Flame"); }
  2032. ^
  2033. src/badguy/livefire.hpp:87:22: warning: The class 'LiveFireDormant' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2034. static std::string class_name() { return "livefire_dormant"; }
  2035. ^
  2036. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2037. static std::string class_name() { return "badguy"; }
  2038. ^
  2039. src/badguy/livefire.hpp:87:22: note: Derived function 'LiveFireDormant::class_name'
  2040. static std::string class_name() { return "livefire_dormant"; }
  2041. ^
  2042. src/badguy/livefire.hpp:89:22: warning: The class 'LiveFireDormant' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2043. static std::string display_name() { return _("Dormant Flame"); }
  2044. ^
  2045. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2046. static std::string display_name() { return _("Badguy"); }
  2047. ^
  2048. src/badguy/livefire.hpp:89:22: note: Derived function 'LiveFireDormant::display_name'
  2049. static std::string display_name() { return _("Dormant Flame"); }
  2050. ^
  2051. src/badguy/livefire.hpp:87:22: warning: The class 'LiveFireDormant' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2052. static std::string class_name() { return "livefire_dormant"; }
  2053. ^
  2054. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2055. static std::string class_name() { return "moving-sprite"; }
  2056. ^
  2057. src/badguy/livefire.hpp:87:22: note: Derived function 'LiveFireDormant::class_name'
  2058. static std::string class_name() { return "livefire_dormant"; }
  2059. ^
  2060. src/badguy/livefire.hpp:87:22: warning: The class 'LiveFireDormant' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2061. static std::string class_name() { return "livefire_dormant"; }
  2062. ^
  2063. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2064. static std::string class_name() { return "moving-object"; }
  2065. ^
  2066. src/badguy/livefire.hpp:87:22: note: Derived function 'LiveFireDormant::class_name'
  2067. static std::string class_name() { return "livefire_dormant"; }
  2068. ^
  2069. src/badguy/livefire.hpp:25:3: style: Class 'LiveFire' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2070. LiveFire(const ReaderMapping& reader);
  2071. ^
  2072. src/badguy/livefire.hpp:64:3: style: Class 'LiveFireAsleep' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2073. LiveFireAsleep(const ReaderMapping& reader);
  2074. ^
  2075. src/badguy/livefire.hpp:82:3: style: Class 'LiveFireDormant' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2076. LiveFireDormant(const ReaderMapping& reader);
  2077. ^
  2078. src/badguy/mole.hpp:36:22: warning: The class 'Mole' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2079. static std::string class_name() { return "mole"; }
  2080. ^
  2081. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2082. static std::string class_name() { return "badguy"; }
  2083. ^
  2084. src/badguy/mole.hpp:36:22: note: Derived function 'Mole::class_name'
  2085. static std::string class_name() { return "mole"; }
  2086. ^
  2087. src/badguy/mole.hpp:38:22: warning: The class 'Mole' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2088. static std::string display_name() { return _("Mole"); }
  2089. ^
  2090. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2091. static std::string display_name() { return _("Badguy"); }
  2092. ^
  2093. src/badguy/mole.hpp:38:22: note: Derived function 'Mole::display_name'
  2094. static std::string display_name() { return _("Mole"); }
  2095. ^
  2096. src/badguy/mole.hpp:36:22: warning: The class 'Mole' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2097. static std::string class_name() { return "mole"; }
  2098. ^
  2099. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2100. static std::string class_name() { return "moving-sprite"; }
  2101. ^
  2102. src/badguy/mole.hpp:36:22: note: Derived function 'Mole::class_name'
  2103. static std::string class_name() { return "mole"; }
  2104. ^
  2105. src/badguy/mole.hpp:36:22: warning: The class 'Mole' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2106. static std::string class_name() { return "mole"; }
  2107. ^
  2108. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2109. static std::string class_name() { return "moving-object"; }
  2110. ^
  2111. src/badguy/mole.hpp:36:22: note: Derived function 'Mole::class_name'
  2112. static std::string class_name() { return "mole"; }
  2113. ^
  2114. src/badguy/mole_rock.hpp:42:22: warning: The class 'MoleRock' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2115. static std::string class_name() { return "mole_rock"; }
  2116. ^
  2117. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2118. static std::string class_name() { return "badguy"; }
  2119. ^
  2120. src/badguy/mole_rock.hpp:42:22: note: Derived function 'MoleRock::class_name'
  2121. static std::string class_name() { return "mole_rock"; }
  2122. ^
  2123. src/badguy/mole_rock.hpp:44:22: warning: The class 'MoleRock' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2124. static std::string display_name() { return _("Mole's rock"); }
  2125. ^
  2126. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2127. static std::string display_name() { return _("Badguy"); }
  2128. ^
  2129. src/badguy/mole_rock.hpp:44:22: note: Derived function 'MoleRock::display_name'
  2130. static std::string display_name() { return _("Mole's rock"); }
  2131. ^
  2132. src/badguy/mole_rock.hpp:42:22: warning: The class 'MoleRock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2133. static std::string class_name() { return "mole_rock"; }
  2134. ^
  2135. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2136. static std::string class_name() { return "moving-sprite"; }
  2137. ^
  2138. src/badguy/mole_rock.hpp:42:22: note: Derived function 'MoleRock::class_name'
  2139. static std::string class_name() { return "mole_rock"; }
  2140. ^
  2141. src/badguy/mole_rock.hpp:42:22: warning: The class 'MoleRock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2142. static std::string class_name() { return "mole_rock"; }
  2143. ^
  2144. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2145. static std::string class_name() { return "moving-object"; }
  2146. ^
  2147. src/badguy/mole_rock.hpp:42:22: note: Derived function 'MoleRock::class_name'
  2148. static std::string class_name() { return "mole_rock"; }
  2149. ^
  2150. src/badguy/mole.hpp:25:3: style: Class 'Mole' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2151. Mole(const ReaderMapping& );
  2152. ^
  2153. src/badguy/mole_rock.hpp:26:3: style: Class 'MoleRock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2154. MoleRock(const ReaderMapping& reader);
  2155. ^
  2156. src/badguy/livefire.cpp:70:10: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2157. auto player = get_nearest_player();
  2158. ^
  2159. src/badguy/mrbomb.hpp:38:22: warning: The class 'MrBomb' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2160. static std::string class_name() { return "mrbomb"; }
  2161. ^
  2162. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2163. static std::string class_name() { return "badguy"; }
  2164. ^
  2165. src/badguy/mrbomb.hpp:38:22: note: Derived function 'MrBomb::class_name'
  2166. static std::string class_name() { return "mrbomb"; }
  2167. ^
  2168. src/badguy/mrbomb.hpp:40:22: warning: The class 'MrBomb' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2169. static std::string display_name() { return _("Mr. Bomb"); }
  2170. ^
  2171. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2172. static std::string display_name() { return _("Badguy"); }
  2173. ^
  2174. src/badguy/mrbomb.hpp:40:22: note: Derived function 'MrBomb::display_name'
  2175. static std::string display_name() { return _("Mr. Bomb"); }
  2176. ^
  2177. src/badguy/mrbomb.hpp:38:22: warning: The class 'MrBomb' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2178. static std::string class_name() { return "mrbomb"; }
  2179. ^
  2180. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2181. static std::string class_name() { return "moving-sprite"; }
  2182. ^
  2183. src/badguy/mrbomb.hpp:38:22: note: Derived function 'MrBomb::class_name'
  2184. static std::string class_name() { return "mrbomb"; }
  2185. ^
  2186. src/badguy/mrbomb.hpp:38:22: warning: The class 'MrBomb' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2187. static std::string class_name() { return "mrbomb"; }
  2188. ^
  2189. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2190. static std::string class_name() { return "moving-object"; }
  2191. ^
  2192. src/badguy/mrbomb.hpp:38:22: note: Derived function 'MrBomb::class_name'
  2193. static std::string class_name() { return "mrbomb"; }
  2194. ^
  2195. src/badguy/mrbomb.hpp:25:3: style: Class 'MrBomb' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2196. MrBomb(const ReaderMapping& reader);
  2197. ^
  2198. src/badguy/mriceblock.hpp:47:22: warning: The class 'MrIceBlock' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2199. static std::string class_name() { return "mriceblock"; }
  2200. ^
  2201. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2202. static std::string class_name() { return "badguy"; }
  2203. ^
  2204. src/badguy/mriceblock.hpp:47:22: note: Derived function 'MrIceBlock::class_name'
  2205. static std::string class_name() { return "mriceblock"; }
  2206. ^
  2207. src/badguy/mriceblock.hpp:49:22: warning: The class 'MrIceBlock' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2208. static std::string display_name() { return _("Mr. Iceblock"); }
  2209. ^
  2210. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2211. static std::string display_name() { return _("Badguy"); }
  2212. ^
  2213. src/badguy/mriceblock.hpp:49:22: note: Derived function 'MrIceBlock::display_name'
  2214. static std::string display_name() { return _("Mr. Iceblock"); }
  2215. ^
  2216. src/badguy/mriceblock.hpp:58:8: warning: The class 'MrIceBlock' defines member function with name 'can_break' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2217. bool can_break();
  2218. ^
  2219. src/badguy/badguy.hpp:87:16: note: Parent function 'BadGuy::can_break'
  2220. virtual bool can_break() const { return false; }
  2221. ^
  2222. src/badguy/mriceblock.hpp:58:8: note: Derived function 'MrIceBlock::can_break'
  2223. bool can_break();
  2224. ^
  2225. src/badguy/mriceblock.hpp:47:22: warning: The class 'MrIceBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2226. static std::string class_name() { return "mriceblock"; }
  2227. ^
  2228. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2229. static std::string class_name() { return "moving-sprite"; }
  2230. ^
  2231. src/badguy/mriceblock.hpp:47:22: note: Derived function 'MrIceBlock::class_name'
  2232. static std::string class_name() { return "mriceblock"; }
  2233. ^
  2234. src/badguy/mriceblock.hpp:47:22: warning: The class 'MrIceBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2235. static std::string class_name() { return "mriceblock"; }
  2236. ^
  2237. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2238. static std::string class_name() { return "moving-object"; }
  2239. ^
  2240. src/badguy/mriceblock.hpp:47:22: note: Derived function 'MrIceBlock::class_name'
  2241. static std::string class_name() { return "mriceblock"; }
  2242. ^
  2243. src/badguy/mriceblock.hpp:26:3: style: Class 'MrIceBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2244. MrIceBlock(const ReaderMapping& reader,
  2245. ^
  2246. src/badguy/mriceblock.cpp:292:10: style: Variable 'movingobject' can be declared as pointer to const [constVariablePointer]
  2247. auto movingobject = dynamic_cast<MovingObject*>(&object);
  2248. ^
  2249. src/badguy/mriceblock.cpp:374:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2250. auto player = dynamic_cast<Player*> (&object);
  2251. ^
  2252. src/badguy/mrtree.hpp:30:22: warning: The class 'MrTree' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2253. static std::string class_name() { return "mrtree"; }
  2254. ^
  2255. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2256. static std::string class_name() { return "badguy"; }
  2257. ^
  2258. src/badguy/mrtree.hpp:30:22: note: Derived function 'MrTree::class_name'
  2259. static std::string class_name() { return "mrtree"; }
  2260. ^
  2261. src/badguy/mrtree.hpp:32:22: warning: The class 'MrTree' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2262. static std::string display_name() { return _("Mr. Tree"); }
  2263. ^
  2264. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2265. static std::string display_name() { return _("Badguy"); }
  2266. ^
  2267. src/badguy/mrtree.hpp:32:22: note: Derived function 'MrTree::display_name'
  2268. static std::string display_name() { return _("Mr. Tree"); }
  2269. ^
  2270. src/badguy/mrtree.hpp:30:22: warning: The class 'MrTree' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2271. static std::string class_name() { return "mrtree"; }
  2272. ^
  2273. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2274. static std::string class_name() { return "moving-sprite"; }
  2275. ^
  2276. src/badguy/mrtree.hpp:30:22: note: Derived function 'MrTree::class_name'
  2277. static std::string class_name() { return "mrtree"; }
  2278. ^
  2279. src/badguy/mrtree.hpp:30:22: warning: The class 'MrTree' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2280. static std::string class_name() { return "mrtree"; }
  2281. ^
  2282. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2283. static std::string class_name() { return "moving-object"; }
  2284. ^
  2285. src/badguy/mrtree.hpp:30:22: note: Derived function 'MrTree::class_name'
  2286. static std::string class_name() { return "mrtree"; }
  2287. ^
  2288. src/badguy/stumpy.hpp:36:22: warning: The class 'Stumpy' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2289. static std::string class_name() { return "stumpy"; }
  2290. ^
  2291. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2292. static std::string class_name() { return "badguy"; }
  2293. ^
  2294. src/badguy/stumpy.hpp:36:22: note: Derived function 'Stumpy::class_name'
  2295. static std::string class_name() { return "stumpy"; }
  2296. ^
  2297. src/badguy/stumpy.hpp:38:22: warning: The class 'Stumpy' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2298. static std::string display_name() { return _("Stumpy"); }
  2299. ^
  2300. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2301. static std::string display_name() { return _("Badguy"); }
  2302. ^
  2303. src/badguy/stumpy.hpp:38:22: note: Derived function 'Stumpy::display_name'
  2304. static std::string display_name() { return _("Stumpy"); }
  2305. ^
  2306. src/badguy/stumpy.hpp:36:22: warning: The class 'Stumpy' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2307. static std::string class_name() { return "stumpy"; }
  2308. ^
  2309. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2310. static std::string class_name() { return "moving-sprite"; }
  2311. ^
  2312. src/badguy/stumpy.hpp:36:22: note: Derived function 'Stumpy::class_name'
  2313. static std::string class_name() { return "stumpy"; }
  2314. ^
  2315. src/badguy/stumpy.hpp:36:22: warning: The class 'Stumpy' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2316. static std::string class_name() { return "stumpy"; }
  2317. ^
  2318. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2319. static std::string class_name() { return "moving-object"; }
  2320. ^
  2321. src/badguy/stumpy.hpp:36:22: note: Derived function 'Stumpy::class_name'
  2322. static std::string class_name() { return "stumpy"; }
  2323. ^
  2324. src/badguy/viciousivy.hpp:31:22: warning: The class 'ViciousIvy' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2325. static std::string class_name() { return "viciousivy"; }
  2326. ^
  2327. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2328. static std::string class_name() { return "badguy"; }
  2329. ^
  2330. src/badguy/viciousivy.hpp:31:22: note: Derived function 'ViciousIvy::class_name'
  2331. static std::string class_name() { return "viciousivy"; }
  2332. ^
  2333. src/badguy/viciousivy.hpp:33:22: warning: The class 'ViciousIvy' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2334. static std::string display_name() { return _("Vicious Ivy"); }
  2335. ^
  2336. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2337. static std::string display_name() { return _("Badguy"); }
  2338. ^
  2339. src/badguy/viciousivy.hpp:33:22: note: Derived function 'ViciousIvy::display_name'
  2340. static std::string display_name() { return _("Vicious Ivy"); }
  2341. ^
  2342. src/badguy/viciousivy.hpp:31:22: warning: The class 'ViciousIvy' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2343. static std::string class_name() { return "viciousivy"; }
  2344. ^
  2345. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2346. static std::string class_name() { return "moving-sprite"; }
  2347. ^
  2348. src/badguy/viciousivy.hpp:31:22: note: Derived function 'ViciousIvy::class_name'
  2349. static std::string class_name() { return "viciousivy"; }
  2350. ^
  2351. src/badguy/viciousivy.hpp:31:22: warning: The class 'ViciousIvy' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2352. static std::string class_name() { return "viciousivy"; }
  2353. ^
  2354. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2355. static std::string class_name() { return "moving-object"; }
  2356. ^
  2357. src/badguy/viciousivy.hpp:31:22: note: Derived function 'ViciousIvy::class_name'
  2358. static std::string class_name() { return "viciousivy"; }
  2359. ^
  2360. src/badguy/mrtree.hpp:25:3: style: Class 'MrTree' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2361. MrTree(const ReaderMapping& reader);
  2362. ^
  2363. src/badguy/stumpy.hpp:25:3: style: Class 'Stumpy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2364. Stumpy(const ReaderMapping& reader);
  2365. ^
  2366. src/badguy/viciousivy.hpp:25:3: style: Class 'ViciousIvy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2367. ViciousIvy(const ReaderMapping& reader);
  2368. ^
  2369. src/badguy/owl.cpp:87:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2370. auto player = Sector::get().get_nearest_player(m_col.m_bbox);
  2371. ^
  2372. src/badguy/owl.cpp:116:12: style: Variable 'obj' can be declared as pointer to const [constVariablePointer]
  2373. auto obj = dynamic_cast<MovingObject*>(carried_object);
  2374. ^
  2375. src/badguy/plant.hpp:32:22: warning: The class 'Plant' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2376. static std::string class_name() { return "plant"; }
  2377. ^
  2378. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2379. static std::string class_name() { return "badguy"; }
  2380. ^
  2381. src/badguy/plant.hpp:32:22: note: Derived function 'Plant::class_name'
  2382. static std::string class_name() { return "plant"; }
  2383. ^
  2384. src/badguy/plant.hpp:34:22: warning: The class 'Plant' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2385. static std::string display_name() { return _("Plant"); }
  2386. ^
  2387. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2388. static std::string display_name() { return _("Badguy"); }
  2389. ^
  2390. src/badguy/plant.hpp:34:22: note: Derived function 'Plant::display_name'
  2391. static std::string display_name() { return _("Plant"); }
  2392. ^
  2393. src/badguy/plant.hpp:32:22: warning: The class 'Plant' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2394. static std::string class_name() { return "plant"; }
  2395. ^
  2396. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2397. static std::string class_name() { return "moving-sprite"; }
  2398. ^
  2399. src/badguy/plant.hpp:32:22: note: Derived function 'Plant::class_name'
  2400. static std::string class_name() { return "plant"; }
  2401. ^
  2402. src/badguy/plant.hpp:32:22: warning: The class 'Plant' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2403. static std::string class_name() { return "plant"; }
  2404. ^
  2405. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2406. static std::string class_name() { return "moving-object"; }
  2407. ^
  2408. src/badguy/plant.hpp:32:22: note: Derived function 'Plant::class_name'
  2409. static std::string class_name() { return "plant"; }
  2410. ^
  2411. src/badguy/plant.hpp:25:3: style: Class 'Plant' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2412. Plant(const ReaderMapping& reader);
  2413. ^
  2414. src/badguy/plant.cpp:75:10: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2415. auto player = get_nearest_player();
  2416. ^
  2417. src/badguy/rcrystallo.cpp:92:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2418. auto player = get_nearest_player();
  2419. ^
  2420. src/badguy/scrystallo.hpp:29:22: warning: The class 'SCrystallo' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2421. static std::string class_name() { return "scrystallo"; }
  2422. ^
  2423. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2424. static std::string class_name() { return "badguy"; }
  2425. ^
  2426. src/badguy/scrystallo.hpp:29:22: note: Derived function 'SCrystallo::class_name'
  2427. static std::string class_name() { return "scrystallo"; }
  2428. ^
  2429. src/badguy/scrystallo.hpp:31:22: warning: The class 'SCrystallo' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2430. static std::string display_name() { return _("Sleeping Crystallo"); }
  2431. ^
  2432. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2433. static std::string display_name() { return _("Badguy"); }
  2434. ^
  2435. src/badguy/scrystallo.hpp:31:22: note: Derived function 'SCrystallo::display_name'
  2436. static std::string display_name() { return _("Sleeping Crystallo"); }
  2437. ^
  2438. src/badguy/scrystallo.hpp:29:22: warning: The class 'SCrystallo' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2439. static std::string class_name() { return "scrystallo"; }
  2440. ^
  2441. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2442. static std::string class_name() { return "moving-sprite"; }
  2443. ^
  2444. src/badguy/scrystallo.hpp:29:22: note: Derived function 'SCrystallo::class_name'
  2445. static std::string class_name() { return "scrystallo"; }
  2446. ^
  2447. src/badguy/scrystallo.hpp:29:22: warning: The class 'SCrystallo' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2448. static std::string class_name() { return "scrystallo"; }
  2449. ^
  2450. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2451. static std::string class_name() { return "moving-object"; }
  2452. ^
  2453. src/badguy/scrystallo.hpp:29:22: note: Derived function 'SCrystallo::class_name'
  2454. static std::string class_name() { return "scrystallo"; }
  2455. ^
  2456. src/badguy/scrystallo.hpp:25:3: style: Class 'SCrystallo' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2457. SCrystallo(const ReaderMapping& reader);
  2458. ^
  2459. src/badguy/scrystallo.cpp:90:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2460. auto player = get_nearest_player();
  2461. ^
  2462. src/badguy/short_fuse.hpp:28:22: warning: The class 'ShortFuse' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2463. static std::string class_name() { return "short_fuse"; }
  2464. ^
  2465. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2466. static std::string class_name() { return "badguy"; }
  2467. ^
  2468. src/badguy/short_fuse.hpp:28:22: note: Derived function 'ShortFuse::class_name'
  2469. static std::string class_name() { return "short_fuse"; }
  2470. ^
  2471. src/badguy/short_fuse.hpp:30:22: warning: The class 'ShortFuse' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2472. static std::string display_name() { return _("Short Fuse"); }
  2473. ^
  2474. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2475. static std::string display_name() { return _("Badguy"); }
  2476. ^
  2477. src/badguy/short_fuse.hpp:30:22: note: Derived function 'ShortFuse::display_name'
  2478. static std::string display_name() { return _("Short Fuse"); }
  2479. ^
  2480. src/badguy/short_fuse.hpp:28:22: warning: The class 'ShortFuse' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2481. static std::string class_name() { return "short_fuse"; }
  2482. ^
  2483. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2484. static std::string class_name() { return "moving-sprite"; }
  2485. ^
  2486. src/badguy/short_fuse.hpp:28:22: note: Derived function 'ShortFuse::class_name'
  2487. static std::string class_name() { return "short_fuse"; }
  2488. ^
  2489. src/badguy/short_fuse.hpp:28:22: warning: The class 'ShortFuse' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2490. static std::string class_name() { return "short_fuse"; }
  2491. ^
  2492. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2493. static std::string class_name() { return "moving-object"; }
  2494. ^
  2495. src/badguy/short_fuse.hpp:28:22: note: Derived function 'ShortFuse::class_name'
  2496. static std::string class_name() { return "short_fuse"; }
  2497. ^
  2498. src/badguy/short_fuse.hpp:26:3: style: Class 'ShortFuse' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2499. ShortFuse(const ReaderMapping& reader);
  2500. ^
  2501. src/badguy/skydive.hpp:41:22: warning: The class 'SkyDive' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2502. static std::string class_name() { return "skydive"; }
  2503. ^
  2504. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2505. static std::string class_name() { return "badguy"; }
  2506. ^
  2507. src/badguy/skydive.hpp:41:22: note: Derived function 'SkyDive::class_name'
  2508. static std::string class_name() { return "skydive"; }
  2509. ^
  2510. src/badguy/skydive.hpp:43:22: warning: The class 'SkyDive' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2511. static std::string display_name() { return _("Skydive"); }
  2512. ^
  2513. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2514. static std::string display_name() { return _("Badguy"); }
  2515. ^
  2516. src/badguy/skydive.hpp:43:22: note: Derived function 'SkyDive::display_name'
  2517. static std::string display_name() { return _("Skydive"); }
  2518. ^
  2519. src/badguy/skydive.hpp:41:22: warning: The class 'SkyDive' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2520. static std::string class_name() { return "skydive"; }
  2521. ^
  2522. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2523. static std::string class_name() { return "moving-sprite"; }
  2524. ^
  2525. src/badguy/skydive.hpp:41:22: note: Derived function 'SkyDive::class_name'
  2526. static std::string class_name() { return "skydive"; }
  2527. ^
  2528. src/badguy/skydive.hpp:41:22: warning: The class 'SkyDive' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2529. static std::string class_name() { return "skydive"; }
  2530. ^
  2531. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2532. static std::string class_name() { return "moving-object"; }
  2533. ^
  2534. src/badguy/skydive.hpp:41:22: note: Derived function 'SkyDive::class_name'
  2535. static std::string class_name() { return "skydive"; }
  2536. ^
  2537. src/badguy/skydive.hpp:25:3: style: Class 'SkyDive' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2538. SkyDive(const ReaderMapping& reader);
  2539. ^
  2540. src/badguy/smartball.hpp:30:22: warning: The class 'SmartBall' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2541. static std::string class_name() { return "smartball"; }
  2542. ^
  2543. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2544. static std::string class_name() { return "badguy"; }
  2545. ^
  2546. src/badguy/smartball.hpp:30:22: note: Derived function 'SmartBall::class_name'
  2547. static std::string class_name() { return "smartball"; }
  2548. ^
  2549. src/badguy/smartball.hpp:32:22: warning: The class 'SmartBall' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2550. static std::string display_name() { return _("Mrs. Snowball"); }
  2551. ^
  2552. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2553. static std::string display_name() { return _("Badguy"); }
  2554. ^
  2555. src/badguy/smartball.hpp:32:22: note: Derived function 'SmartBall::display_name'
  2556. static std::string display_name() { return _("Mrs. Snowball"); }
  2557. ^
  2558. src/badguy/smartball.hpp:30:22: warning: The class 'SmartBall' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2559. static std::string class_name() { return "smartball"; }
  2560. ^
  2561. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2562. static std::string class_name() { return "moving-sprite"; }
  2563. ^
  2564. src/badguy/smartball.hpp:30:22: note: Derived function 'SmartBall::class_name'
  2565. static std::string class_name() { return "smartball"; }
  2566. ^
  2567. src/badguy/smartball.hpp:30:22: warning: The class 'SmartBall' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2568. static std::string class_name() { return "smartball"; }
  2569. ^
  2570. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2571. static std::string class_name() { return "moving-object"; }
  2572. ^
  2573. src/badguy/smartball.hpp:30:22: note: Derived function 'SmartBall::class_name'
  2574. static std::string class_name() { return "smartball"; }
  2575. ^
  2576. src/badguy/smartball.hpp:26:3: style: Class 'SmartBall' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2577. SmartBall(const ReaderMapping& reader);
  2578. ^
  2579. src/badguy/smartblock.hpp:28:22: warning: The class 'SmartBlock' defines member function with name 'class_name' also defined in its parent class 'MrIceBlock'. [duplInheritedMember]
  2580. static std::string class_name() { return "smartblock"; }
  2581. ^
  2582. src/badguy/mriceblock.hpp:47:22: note: Parent function 'MrIceBlock::class_name'
  2583. static std::string class_name() { return "mriceblock"; }
  2584. ^
  2585. src/badguy/smartblock.hpp:28:22: note: Derived function 'SmartBlock::class_name'
  2586. static std::string class_name() { return "smartblock"; }
  2587. ^
  2588. src/badguy/smartblock.hpp:30:22: warning: The class 'SmartBlock' defines member function with name 'display_name' also defined in its parent class 'MrIceBlock'. [duplInheritedMember]
  2589. static std::string display_name() { return _("Mrs. Iceblock"); }
  2590. ^
  2591. src/badguy/mriceblock.hpp:49:22: note: Parent function 'MrIceBlock::display_name'
  2592. static std::string display_name() { return _("Mr. Iceblock"); }
  2593. ^
  2594. src/badguy/smartblock.hpp:30:22: note: Derived function 'SmartBlock::display_name'
  2595. static std::string display_name() { return _("Mrs. Iceblock"); }
  2596. ^
  2597. src/badguy/smartblock.hpp:28:22: warning: The class 'SmartBlock' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2598. static std::string class_name() { return "smartblock"; }
  2599. ^
  2600. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2601. static std::string class_name() { return "badguy"; }
  2602. ^
  2603. src/badguy/smartblock.hpp:28:22: note: Derived function 'SmartBlock::class_name'
  2604. static std::string class_name() { return "smartblock"; }
  2605. ^
  2606. src/badguy/smartblock.hpp:30:22: warning: The class 'SmartBlock' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2607. static std::string display_name() { return _("Mrs. Iceblock"); }
  2608. ^
  2609. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2610. static std::string display_name() { return _("Badguy"); }
  2611. ^
  2612. src/badguy/smartblock.hpp:30:22: note: Derived function 'SmartBlock::display_name'
  2613. static std::string display_name() { return _("Mrs. Iceblock"); }
  2614. ^
  2615. src/badguy/smartblock.hpp:28:22: warning: The class 'SmartBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2616. static std::string class_name() { return "smartblock"; }
  2617. ^
  2618. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2619. static std::string class_name() { return "moving-sprite"; }
  2620. ^
  2621. src/badguy/smartblock.hpp:28:22: note: Derived function 'SmartBlock::class_name'
  2622. static std::string class_name() { return "smartblock"; }
  2623. ^
  2624. src/badguy/smartblock.hpp:28:22: warning: The class 'SmartBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2625. static std::string class_name() { return "smartblock"; }
  2626. ^
  2627. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2628. static std::string class_name() { return "moving-object"; }
  2629. ^
  2630. src/badguy/smartblock.hpp:28:22: note: Derived function 'SmartBlock::class_name'
  2631. static std::string class_name() { return "smartblock"; }
  2632. ^
  2633. src/badguy/smartblock.hpp:25:3: style: Class 'SmartBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2634. SmartBlock(const ReaderMapping& reader);
  2635. ^
  2636. src/badguy/snowball.hpp:28:22: warning: The class 'SnowBall' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2637. static std::string class_name() { return "snowball"; }
  2638. ^
  2639. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2640. static std::string class_name() { return "badguy"; }
  2641. ^
  2642. src/badguy/snowball.hpp:28:22: note: Derived function 'SnowBall::class_name'
  2643. static std::string class_name() { return "snowball"; }
  2644. ^
  2645. src/badguy/snowball.hpp:30:22: warning: The class 'SnowBall' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2646. static std::string display_name() { return _("Mr. Snowball"); }
  2647. ^
  2648. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2649. static std::string display_name() { return _("Badguy"); }
  2650. ^
  2651. src/badguy/snowball.hpp:30:22: note: Derived function 'SnowBall::display_name'
  2652. static std::string display_name() { return _("Mr. Snowball"); }
  2653. ^
  2654. src/badguy/snowball.hpp:28:22: warning: The class 'SnowBall' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2655. static std::string class_name() { return "snowball"; }
  2656. ^
  2657. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2658. static std::string class_name() { return "moving-sprite"; }
  2659. ^
  2660. src/badguy/snowball.hpp:28:22: note: Derived function 'SnowBall::class_name'
  2661. static std::string class_name() { return "snowball"; }
  2662. ^
  2663. src/badguy/snowball.hpp:28:22: warning: The class 'SnowBall' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2664. static std::string class_name() { return "snowball"; }
  2665. ^
  2666. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2667. static std::string class_name() { return "moving-object"; }
  2668. ^
  2669. src/badguy/snowball.hpp:28:22: note: Derived function 'SnowBall::class_name'
  2670. static std::string class_name() { return "snowball"; }
  2671. ^
  2672. src/badguy/snowball.hpp:25:3: style: Class 'SnowBall' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2673. SnowBall(const ReaderMapping& reader);
  2674. ^
  2675. src/badguy/snail.hpp:41:22: warning: The class 'Snail' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2676. static std::string class_name() { return "snail"; }
  2677. ^
  2678. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2679. static std::string class_name() { return "badguy"; }
  2680. ^
  2681. src/badguy/snail.hpp:41:22: note: Derived function 'Snail::class_name'
  2682. static std::string class_name() { return "snail"; }
  2683. ^
  2684. src/badguy/snail.hpp:43:22: warning: The class 'Snail' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2685. static std::string display_name() { return _("Snail"); }
  2686. ^
  2687. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2688. static std::string display_name() { return _("Badguy"); }
  2689. ^
  2690. src/badguy/snail.hpp:43:22: note: Derived function 'Snail::display_name'
  2691. static std::string display_name() { return _("Snail"); }
  2692. ^
  2693. src/badguy/snail.hpp:41:22: warning: The class 'Snail' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2694. static std::string class_name() { return "snail"; }
  2695. ^
  2696. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2697. static std::string class_name() { return "moving-sprite"; }
  2698. ^
  2699. src/badguy/snail.hpp:41:22: note: Derived function 'Snail::class_name'
  2700. static std::string class_name() { return "snail"; }
  2701. ^
  2702. src/badguy/snail.hpp:41:22: warning: The class 'Snail' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2703. static std::string class_name() { return "snail"; }
  2704. ^
  2705. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2706. static std::string class_name() { return "moving-object"; }
  2707. ^
  2708. src/badguy/snail.hpp:41:22: note: Derived function 'Snail::class_name'
  2709. static std::string class_name() { return "snail"; }
  2710. ^
  2711. src/badguy/snail.hpp:28:3: style: Class 'Snail' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2712. Snail(const ReaderMapping& reader);
  2713. ^
  2714. src/badguy/snail.cpp:367:23: style: Variable 'movingobject' can be declared as pointer to const [constVariablePointer]
  2715. MovingObject* movingobject = dynamic_cast<MovingObject*>(&object);
  2716. ^
  2717. src/badguy/snowman.hpp:27:22: warning: The class 'Snowman' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2718. static std::string class_name() { return "snowman"; }
  2719. ^
  2720. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2721. static std::string class_name() { return "badguy"; }
  2722. ^
  2723. src/badguy/snowman.hpp:27:22: note: Derived function 'Snowman::class_name'
  2724. static std::string class_name() { return "snowman"; }
  2725. ^
  2726. src/badguy/snowman.hpp:29:22: warning: The class 'Snowman' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2727. static std::string display_name() { return _("Snowman"); }
  2728. ^
  2729. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2730. static std::string display_name() { return _("Badguy"); }
  2731. ^
  2732. src/badguy/snowman.hpp:29:22: note: Derived function 'Snowman::display_name'
  2733. static std::string display_name() { return _("Snowman"); }
  2734. ^
  2735. src/badguy/snowman.hpp:27:22: warning: The class 'Snowman' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2736. static std::string class_name() { return "snowman"; }
  2737. ^
  2738. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2739. static std::string class_name() { return "moving-sprite"; }
  2740. ^
  2741. src/badguy/snowman.hpp:27:22: note: Derived function 'Snowman::class_name'
  2742. static std::string class_name() { return "snowman"; }
  2743. ^
  2744. src/badguy/snowman.hpp:27:22: warning: The class 'Snowman' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2745. static std::string class_name() { return "snowman"; }
  2746. ^
  2747. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2748. static std::string class_name() { return "moving-object"; }
  2749. ^
  2750. src/badguy/snowman.hpp:27:22: note: Derived function 'Snowman::class_name'
  2751. static std::string class_name() { return "snowman"; }
  2752. ^
  2753. src/badguy/snowman.hpp:25:3: style: Class 'Snowman' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2754. Snowman(const ReaderMapping& reader);
  2755. ^
  2756. src/badguy/spidermite.hpp:36:22: warning: The class 'SpiderMite' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2757. static std::string class_name() { return "spidermite"; }
  2758. ^
  2759. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2760. static std::string class_name() { return "badguy"; }
  2761. ^
  2762. src/badguy/spidermite.hpp:36:22: note: Derived function 'SpiderMite::class_name'
  2763. static std::string class_name() { return "spidermite"; }
  2764. ^
  2765. src/badguy/spidermite.hpp:38:22: warning: The class 'SpiderMite' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2766. static std::string display_name() { return _("Spidermite"); }
  2767. ^
  2768. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2769. static std::string display_name() { return _("Badguy"); }
  2770. ^
  2771. src/badguy/spidermite.hpp:38:22: note: Derived function 'SpiderMite::display_name'
  2772. static std::string display_name() { return _("Spidermite"); }
  2773. ^
  2774. src/badguy/spidermite.hpp:36:22: warning: The class 'SpiderMite' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2775. static std::string class_name() { return "spidermite"; }
  2776. ^
  2777. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2778. static std::string class_name() { return "moving-sprite"; }
  2779. ^
  2780. src/badguy/spidermite.hpp:36:22: note: Derived function 'SpiderMite::class_name'
  2781. static std::string class_name() { return "spidermite"; }
  2782. ^
  2783. src/badguy/spidermite.hpp:36:22: warning: The class 'SpiderMite' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2784. static std::string class_name() { return "spidermite"; }
  2785. ^
  2786. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2787. static std::string class_name() { return "moving-object"; }
  2788. ^
  2789. src/badguy/spidermite.hpp:36:22: note: Derived function 'SpiderMite::class_name'
  2790. static std::string class_name() { return "spidermite"; }
  2791. ^
  2792. src/badguy/spidermite.hpp:25:3: style: Class 'SpiderMite' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2793. SpiderMite(const ReaderMapping& reader);
  2794. ^
  2795. src/badguy/spidermite.cpp:83:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2796. auto player = get_nearest_player();
  2797. ^
  2798. src/badguy/spiky.hpp:29:22: warning: The class 'Spiky' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2799. static std::string class_name() { return "spiky"; }
  2800. ^
  2801. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2802. static std::string class_name() { return "badguy"; }
  2803. ^
  2804. src/badguy/spiky.hpp:29:22: note: Derived function 'Spiky::class_name'
  2805. static std::string class_name() { return "spiky"; }
  2806. ^
  2807. src/badguy/spiky.hpp:31:22: warning: The class 'Spiky' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2808. static std::string display_name() { return _("Spiky"); }
  2809. ^
  2810. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2811. static std::string display_name() { return _("Badguy"); }
  2812. ^
  2813. src/badguy/spiky.hpp:31:22: note: Derived function 'Spiky::display_name'
  2814. static std::string display_name() { return _("Spiky"); }
  2815. ^
  2816. src/badguy/spiky.hpp:29:22: warning: The class 'Spiky' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2817. static std::string class_name() { return "spiky"; }
  2818. ^
  2819. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2820. static std::string class_name() { return "moving-sprite"; }
  2821. ^
  2822. src/badguy/spiky.hpp:29:22: note: Derived function 'Spiky::class_name'
  2823. static std::string class_name() { return "spiky"; }
  2824. ^
  2825. src/badguy/spiky.hpp:29:22: warning: The class 'Spiky' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2826. static std::string class_name() { return "spiky"; }
  2827. ^
  2828. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2829. static std::string class_name() { return "moving-object"; }
  2830. ^
  2831. src/badguy/spiky.hpp:29:22: note: Derived function 'Spiky::class_name'
  2832. static std::string class_name() { return "spiky"; }
  2833. ^
  2834. src/badguy/spiky.hpp:25:3: style: Class 'Spiky' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2835. Spiky(const ReaderMapping& reader);
  2836. ^
  2837. src/badguy/sspiky.hpp:35:22: warning: The class 'SSpiky' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2838. static std::string class_name() { return "sspiky"; }
  2839. ^
  2840. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2841. static std::string class_name() { return "badguy"; }
  2842. ^
  2843. src/badguy/sspiky.hpp:35:22: note: Derived function 'SSpiky::class_name'
  2844. static std::string class_name() { return "sspiky"; }
  2845. ^
  2846. src/badguy/sspiky.hpp:37:22: warning: The class 'SSpiky' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2847. static std::string display_name() { return _("Sleeping Spiky"); }
  2848. ^
  2849. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2850. static std::string display_name() { return _("Badguy"); }
  2851. ^
  2852. src/badguy/sspiky.hpp:37:22: note: Derived function 'SSpiky::display_name'
  2853. static std::string display_name() { return _("Sleeping Spiky"); }
  2854. ^
  2855. src/badguy/sspiky.hpp:35:22: warning: The class 'SSpiky' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2856. static std::string class_name() { return "sspiky"; }
  2857. ^
  2858. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2859. static std::string class_name() { return "moving-sprite"; }
  2860. ^
  2861. src/badguy/sspiky.hpp:35:22: note: Derived function 'SSpiky::class_name'
  2862. static std::string class_name() { return "sspiky"; }
  2863. ^
  2864. src/badguy/sspiky.hpp:35:22: warning: The class 'SSpiky' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2865. static std::string class_name() { return "sspiky"; }
  2866. ^
  2867. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2868. static std::string class_name() { return "moving-object"; }
  2869. ^
  2870. src/badguy/sspiky.hpp:35:22: note: Derived function 'SSpiky::class_name'
  2871. static std::string class_name() { return "sspiky"; }
  2872. ^
  2873. src/badguy/sspiky.hpp:25:3: style: Class 'SSpiky' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2874. SSpiky(const ReaderMapping& reader);
  2875. ^
  2876. src/badguy/sspiky.cpp:66:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2877. Player* player = get_nearest_player();
  2878. ^
  2879. src/badguy/stalactite.hpp:40:22: warning: The class 'Stalactite' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2880. static std::string class_name() { return "stalactite"; }
  2881. ^
  2882. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2883. static std::string class_name() { return "badguy"; }
  2884. ^
  2885. src/badguy/stalactite.hpp:40:22: note: Derived function 'Stalactite::class_name'
  2886. static std::string class_name() { return "stalactite"; }
  2887. ^
  2888. src/badguy/stalactite.hpp:42:22: warning: The class 'Stalactite' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2889. static std::string display_name() { return _("Stalactite"); }
  2890. ^
  2891. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2892. static std::string display_name() { return _("Badguy"); }
  2893. ^
  2894. src/badguy/stalactite.hpp:42:22: note: Derived function 'Stalactite::display_name'
  2895. static std::string display_name() { return _("Stalactite"); }
  2896. ^
  2897. src/badguy/stalactite.hpp:40:22: warning: The class 'Stalactite' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2898. static std::string class_name() { return "stalactite"; }
  2899. ^
  2900. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2901. static std::string class_name() { return "moving-sprite"; }
  2902. ^
  2903. src/badguy/stalactite.hpp:40:22: note: Derived function 'Stalactite::class_name'
  2904. static std::string class_name() { return "stalactite"; }
  2905. ^
  2906. src/badguy/stalactite.hpp:40:22: warning: The class 'Stalactite' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2907. static std::string class_name() { return "stalactite"; }
  2908. ^
  2909. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2910. static std::string class_name() { return "moving-object"; }
  2911. ^
  2912. src/badguy/stalactite.hpp:40:22: note: Derived function 'Stalactite::class_name'
  2913. static std::string class_name() { return "stalactite"; }
  2914. ^
  2915. src/badguy/stalactite.hpp:25:3: style: Class 'Stalactite' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2916. Stalactite(const ReaderMapping& reader);
  2917. ^
  2918. src/badguy/toad.hpp:36:22: warning: The class 'Toad' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2919. static std::string class_name() { return "toad"; }
  2920. ^
  2921. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2922. static std::string class_name() { return "badguy"; }
  2923. ^
  2924. src/badguy/toad.hpp:36:22: note: Derived function 'Toad::class_name'
  2925. static std::string class_name() { return "toad"; }
  2926. ^
  2927. src/badguy/toad.hpp:38:22: warning: The class 'Toad' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2928. static std::string display_name() { return _("Toad"); }
  2929. ^
  2930. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2931. static std::string display_name() { return _("Badguy"); }
  2932. ^
  2933. src/badguy/toad.hpp:38:22: note: Derived function 'Toad::display_name'
  2934. static std::string display_name() { return _("Toad"); }
  2935. ^
  2936. src/badguy/toad.hpp:36:22: warning: The class 'Toad' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2937. static std::string class_name() { return "toad"; }
  2938. ^
  2939. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2940. static std::string class_name() { return "moving-sprite"; }
  2941. ^
  2942. src/badguy/toad.hpp:36:22: note: Derived function 'Toad::class_name'
  2943. static std::string class_name() { return "toad"; }
  2944. ^
  2945. src/badguy/toad.hpp:36:22: warning: The class 'Toad' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2946. static std::string class_name() { return "toad"; }
  2947. ^
  2948. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2949. static std::string class_name() { return "moving-object"; }
  2950. ^
  2951. src/badguy/toad.hpp:36:22: note: Derived function 'Toad::class_name'
  2952. static std::string class_name() { return "toad"; }
  2953. ^
  2954. src/badguy/stalactite.cpp:55:10: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2955. auto player = get_nearest_player();
  2956. ^
  2957. src/badguy/toad.hpp:26:3: style: Class 'Toad' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  2958. Toad(const ReaderMapping& reader);
  2959. ^
  2960. src/badguy/toad.cpp:62:17: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  2961. Player* player = get_nearest_player();
  2962. ^
  2963. src/badguy/totem.hpp:35:22: warning: The class 'Totem' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2964. static std::string class_name() { return "totem"; }
  2965. ^
  2966. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  2967. static std::string class_name() { return "badguy"; }
  2968. ^
  2969. src/badguy/totem.hpp:35:22: note: Derived function 'Totem::class_name'
  2970. static std::string class_name() { return "totem"; }
  2971. ^
  2972. src/badguy/totem.hpp:37:22: warning: The class 'Totem' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  2973. static std::string display_name() { return _("Totem"); }
  2974. ^
  2975. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  2976. static std::string display_name() { return _("Badguy"); }
  2977. ^
  2978. src/badguy/totem.hpp:37:22: note: Derived function 'Totem::display_name'
  2979. static std::string display_name() { return _("Totem"); }
  2980. ^
  2981. src/badguy/totem.hpp:35:22: warning: The class 'Totem' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  2982. static std::string class_name() { return "totem"; }
  2983. ^
  2984. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  2985. static std::string class_name() { return "moving-sprite"; }
  2986. ^
  2987. src/badguy/totem.hpp:35:22: note: Derived function 'Totem::class_name'
  2988. static std::string class_name() { return "totem"; }
  2989. ^
  2990. src/badguy/totem.hpp:35:22: warning: The class 'Totem' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  2991. static std::string class_name() { return "totem"; }
  2992. ^
  2993. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  2994. static std::string class_name() { return "moving-object"; }
  2995. ^
  2996. src/badguy/totem.hpp:35:22: note: Derived function 'Totem::class_name'
  2997. static std::string class_name() { return "totem"; }
  2998. ^
  2999. src/badguy/totem.hpp:26:3: style: Class 'Totem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3000. Totem(const ReaderMapping& reader);
  3001. ^
  3002. src/badguy/treewillowisp.cpp:96:8: style: Variable 'lantern' can be declared as pointer to const [constVariablePointer]
  3003. auto lantern = dynamic_cast<Lantern*>(&other);
  3004. ^
  3005. src/badguy/walking_badguy.hpp:60:16: style: The function 'freeze' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
  3006. virtual void freeze() override;
  3007. ^
  3008. src/badguy/badguy.hpp:109:16: note: Virtual function in base class
  3009. virtual void freeze();
  3010. ^
  3011. src/badguy/walking_badguy.hpp:60:16: note: Function in derived class
  3012. virtual void freeze() override;
  3013. ^
  3014. src/badguy/walking_candle.hpp:39:22: warning: The class 'WalkingCandle' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3015. static std::string class_name() { return "walking_candle"; }
  3016. ^
  3017. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3018. static std::string class_name() { return "badguy"; }
  3019. ^
  3020. src/badguy/walking_candle.hpp:39:22: note: Derived function 'WalkingCandle::class_name'
  3021. static std::string class_name() { return "walking_candle"; }
  3022. ^
  3023. src/badguy/walking_candle.hpp:41:22: warning: The class 'WalkingCandle' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3024. static std::string display_name() { return _("Walking Candle"); }
  3025. ^
  3026. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3027. static std::string display_name() { return _("Badguy"); }
  3028. ^
  3029. src/badguy/walking_candle.hpp:41:22: note: Derived function 'WalkingCandle::display_name'
  3030. static std::string display_name() { return _("Walking Candle"); }
  3031. ^
  3032. src/badguy/walking_candle.hpp:39:22: warning: The class 'WalkingCandle' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3033. static std::string class_name() { return "walking_candle"; }
  3034. ^
  3035. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3036. static std::string class_name() { return "moving-sprite"; }
  3037. ^
  3038. src/badguy/walking_candle.hpp:39:22: note: Derived function 'WalkingCandle::class_name'
  3039. static std::string class_name() { return "walking_candle"; }
  3040. ^
  3041. src/badguy/walking_candle.hpp:39:22: warning: The class 'WalkingCandle' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3042. static std::string class_name() { return "walking_candle"; }
  3043. ^
  3044. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3045. static std::string class_name() { return "moving-object"; }
  3046. ^
  3047. src/badguy/walking_candle.hpp:39:22: note: Derived function 'WalkingCandle::class_name'
  3048. static std::string class_name() { return "walking_candle"; }
  3049. ^
  3050. src/badguy/walking_candle.hpp:25:3: style: Class 'WalkingCandle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3051. WalkingCandle(const ReaderMapping& reader);
  3052. ^
  3053. src/badguy/walkingleaf.hpp:31:22: warning: The class 'WalkingLeaf' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3054. static std::string class_name() { return "walkingleaf"; }
  3055. ^
  3056. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3057. static std::string class_name() { return "badguy"; }
  3058. ^
  3059. src/badguy/walkingleaf.hpp:31:22: note: Derived function 'WalkingLeaf::class_name'
  3060. static std::string class_name() { return "walkingleaf"; }
  3061. ^
  3062. src/badguy/walkingleaf.hpp:33:22: warning: The class 'WalkingLeaf' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3063. static std::string display_name() { return _("Walking Leaf"); }
  3064. ^
  3065. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3066. static std::string display_name() { return _("Badguy"); }
  3067. ^
  3068. src/badguy/walkingleaf.hpp:33:22: note: Derived function 'WalkingLeaf::display_name'
  3069. static std::string display_name() { return _("Walking Leaf"); }
  3070. ^
  3071. src/badguy/walkingleaf.hpp:31:22: warning: The class 'WalkingLeaf' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3072. static std::string class_name() { return "walkingleaf"; }
  3073. ^
  3074. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3075. static std::string class_name() { return "moving-sprite"; }
  3076. ^
  3077. src/badguy/walkingleaf.hpp:31:22: note: Derived function 'WalkingLeaf::class_name'
  3078. static std::string class_name() { return "walkingleaf"; }
  3079. ^
  3080. src/badguy/walkingleaf.hpp:31:22: warning: The class 'WalkingLeaf' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3081. static std::string class_name() { return "walkingleaf"; }
  3082. ^
  3083. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3084. static std::string class_name() { return "moving-object"; }
  3085. ^
  3086. src/badguy/walkingleaf.hpp:31:22: note: Derived function 'WalkingLeaf::class_name'
  3087. static std::string class_name() { return "walkingleaf"; }
  3088. ^
  3089. src/badguy/walkingleaf.hpp:26:3: style: Class 'WalkingLeaf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3090. WalkingLeaf(const ReaderMapping& reader);
  3091. ^
  3092. src/badguy/willowisp.hpp:55:22: warning: The class 'WillOWisp' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3093. static std::string class_name() { return "willowisp"; }
  3094. ^
  3095. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3096. static std::string class_name() { return "badguy"; }
  3097. ^
  3098. src/badguy/willowisp.hpp:55:22: note: Derived function 'WillOWisp::class_name'
  3099. static std::string class_name() { return "willowisp"; }
  3100. ^
  3101. src/badguy/willowisp.hpp:57:22: warning: The class 'WillOWisp' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3102. static std::string display_name() { return _("Will o' Wisp"); }
  3103. ^
  3104. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3105. static std::string display_name() { return _("Badguy"); }
  3106. ^
  3107. src/badguy/willowisp.hpp:57:22: note: Derived function 'WillOWisp::display_name'
  3108. static std::string display_name() { return _("Will o' Wisp"); }
  3109. ^
  3110. src/badguy/willowisp.hpp:55:22: warning: The class 'WillOWisp' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3111. static std::string class_name() { return "willowisp"; }
  3112. ^
  3113. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3114. static std::string class_name() { return "moving-sprite"; }
  3115. ^
  3116. src/badguy/willowisp.hpp:55:22: note: Derived function 'WillOWisp::class_name'
  3117. static std::string class_name() { return "willowisp"; }
  3118. ^
  3119. src/badguy/willowisp.hpp:55:22: warning: The class 'WillOWisp' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3120. static std::string class_name() { return "willowisp"; }
  3121. ^
  3122. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3123. static std::string class_name() { return "moving-object"; }
  3124. ^
  3125. src/badguy/willowisp.hpp:55:22: note: Derived function 'WillOWisp::class_name'
  3126. static std::string class_name() { return "willowisp"; }
  3127. ^
  3128. src/scripting/willowisp.hpp:43:3: style: Class 'WillOWisp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3129. WillOWisp(const ::GameObject& object) :
  3130. ^
  3131. src/badguy/willowisp.hpp:33:3: style: Class 'WillOWisp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3132. WillOWisp(const ReaderMapping& reader);
  3133. ^
  3134. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < WillOWisp , scripting :: WillOWisp >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3135. ExposedObject(S* parent) :
  3136. ^
  3137. src/badguy/willowisp.cpp:119:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  3138. auto player = get_nearest_player();
  3139. ^
  3140. src/badguy/willowisp.cpp:229:8: style: Variable 'lantern' can be declared as pointer to const [constVariablePointer]
  3141. auto lantern = dynamic_cast<Lantern*>(&other);
  3142. ^
  3143. src/badguy/yeti.hpp:36:22: warning: The class 'Yeti' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3144. static std::string class_name() { return "yeti"; }
  3145. ^
  3146. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3147. static std::string class_name() { return "badguy"; }
  3148. ^
  3149. src/badguy/yeti.hpp:36:22: note: Derived function 'Yeti::class_name'
  3150. static std::string class_name() { return "yeti"; }
  3151. ^
  3152. src/badguy/yeti.hpp:38:22: warning: The class 'Yeti' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3153. static std::string display_name() { return _("Yeti"); }
  3154. ^
  3155. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3156. static std::string display_name() { return _("Badguy"); }
  3157. ^
  3158. src/badguy/yeti.hpp:38:22: note: Derived function 'Yeti::display_name'
  3159. static std::string display_name() { return _("Yeti"); }
  3160. ^
  3161. src/badguy/yeti.cpp:243:7: warning: The class 'Yeti' defines member function with name 'kill_squished' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3162. Yeti::kill_squished(GameObject& object)
  3163. ^
  3164. src/badguy/badguy.hpp:193:8: note: Parent function 'BadGuy::kill_squished'
  3165. void kill_squished(GameObject& object);
  3166. ^
  3167. src/badguy/yeti.cpp:243:7: note: Derived function 'Yeti::kill_squished'
  3168. Yeti::kill_squished(GameObject& object)
  3169. ^
  3170. src/badguy/yeti.hpp:36:22: warning: The class 'Yeti' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3171. static std::string class_name() { return "yeti"; }
  3172. ^
  3173. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3174. static std::string class_name() { return "moving-sprite"; }
  3175. ^
  3176. src/badguy/yeti.hpp:36:22: note: Derived function 'Yeti::class_name'
  3177. static std::string class_name() { return "yeti"; }
  3178. ^
  3179. src/badguy/yeti.hpp:36:22: warning: The class 'Yeti' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3180. static std::string class_name() { return "yeti"; }
  3181. ^
  3182. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3183. static std::string class_name() { return "moving-object"; }
  3184. ^
  3185. src/badguy/yeti.hpp:36:22: note: Derived function 'Yeti::class_name'
  3186. static std::string class_name() { return "yeti"; }
  3187. ^
  3188. src/badguy/yeti_stalactite.hpp:32:22: warning: The class 'YetiStalactite' defines member function with name 'class_name' also defined in its parent class 'Stalactite'. [duplInheritedMember]
  3189. static std::string class_name() { return "yeti_stalactite"; }
  3190. ^
  3191. src/badguy/stalactite.hpp:40:22: note: Parent function 'Stalactite::class_name'
  3192. static std::string class_name() { return "stalactite"; }
  3193. ^
  3194. src/badguy/yeti_stalactite.hpp:32:22: note: Derived function 'YetiStalactite::class_name'
  3195. static std::string class_name() { return "yeti_stalactite"; }
  3196. ^
  3197. src/badguy/yeti_stalactite.hpp:34:22: warning: The class 'YetiStalactite' defines member function with name 'display_name' also defined in its parent class 'Stalactite'. [duplInheritedMember]
  3198. static std::string display_name() { return _("Yeti's Stalactite"); }
  3199. ^
  3200. src/badguy/stalactite.hpp:42:22: note: Parent function 'Stalactite::display_name'
  3201. static std::string display_name() { return _("Stalactite"); }
  3202. ^
  3203. src/badguy/yeti_stalactite.hpp:34:22: note: Derived function 'YetiStalactite::display_name'
  3204. static std::string display_name() { return _("Yeti's Stalactite"); }
  3205. ^
  3206. src/badguy/yeti_stalactite.hpp:32:22: warning: The class 'YetiStalactite' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3207. static std::string class_name() { return "yeti_stalactite"; }
  3208. ^
  3209. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3210. static std::string class_name() { return "badguy"; }
  3211. ^
  3212. src/badguy/yeti_stalactite.hpp:32:22: note: Derived function 'YetiStalactite::class_name'
  3213. static std::string class_name() { return "yeti_stalactite"; }
  3214. ^
  3215. src/badguy/yeti_stalactite.hpp:34:22: warning: The class 'YetiStalactite' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3216. static std::string display_name() { return _("Yeti's Stalactite"); }
  3217. ^
  3218. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3219. static std::string display_name() { return _("Badguy"); }
  3220. ^
  3221. src/badguy/yeti_stalactite.hpp:34:22: note: Derived function 'YetiStalactite::display_name'
  3222. static std::string display_name() { return _("Yeti's Stalactite"); }
  3223. ^
  3224. src/badguy/yeti_stalactite.hpp:32:22: warning: The class 'YetiStalactite' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3225. static std::string class_name() { return "yeti_stalactite"; }
  3226. ^
  3227. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3228. static std::string class_name() { return "moving-sprite"; }
  3229. ^
  3230. src/badguy/yeti_stalactite.hpp:32:22: note: Derived function 'YetiStalactite::class_name'
  3231. static std::string class_name() { return "yeti_stalactite"; }
  3232. ^
  3233. src/badguy/yeti_stalactite.hpp:32:22: warning: The class 'YetiStalactite' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3234. static std::string class_name() { return "yeti_stalactite"; }
  3235. ^
  3236. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3237. static std::string class_name() { return "moving-object"; }
  3238. ^
  3239. src/badguy/yeti_stalactite.hpp:32:22: note: Derived function 'YetiStalactite::class_name'
  3240. static std::string class_name() { return "yeti_stalactite"; }
  3241. ^
  3242. src/badguy/yeti.hpp:26:3: style: Class 'Yeti' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3243. Yeti(const ReaderMapping& mapping);
  3244. ^
  3245. src/badguy/yeti_stalactite.hpp:25:3: style: Class 'YetiStalactite' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3246. YetiStalactite(const ReaderMapping& mapping);
  3247. ^
  3248. src/badguy/yeti.cpp:289:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  3249. auto player = get_nearest_player();
  3250. ^
  3251. src/badguy/zeekling.hpp:37:22: warning: The class 'Zeekling' defines member function with name 'class_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3252. static std::string class_name() { return "zeekling"; }
  3253. ^
  3254. src/badguy/badguy.hpp:59:22: note: Parent function 'BadGuy::class_name'
  3255. static std::string class_name() { return "badguy"; }
  3256. ^
  3257. src/badguy/zeekling.hpp:37:22: note: Derived function 'Zeekling::class_name'
  3258. static std::string class_name() { return "zeekling"; }
  3259. ^
  3260. src/badguy/zeekling.hpp:39:22: warning: The class 'Zeekling' defines member function with name 'display_name' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  3261. static std::string display_name() { return _("Zeekling"); }
  3262. ^
  3263. src/badguy/badguy.hpp:61:22: note: Parent function 'BadGuy::display_name'
  3264. static std::string display_name() { return _("Badguy"); }
  3265. ^
  3266. src/badguy/zeekling.hpp:39:22: note: Derived function 'Zeekling::display_name'
  3267. static std::string display_name() { return _("Zeekling"); }
  3268. ^
  3269. src/badguy/zeekling.hpp:37:22: warning: The class 'Zeekling' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3270. static std::string class_name() { return "zeekling"; }
  3271. ^
  3272. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3273. static std::string class_name() { return "moving-sprite"; }
  3274. ^
  3275. src/badguy/zeekling.hpp:37:22: note: Derived function 'Zeekling::class_name'
  3276. static std::string class_name() { return "zeekling"; }
  3277. ^
  3278. src/badguy/zeekling.hpp:37:22: warning: The class 'Zeekling' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3279. static std::string class_name() { return "zeekling"; }
  3280. ^
  3281. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3282. static std::string class_name() { return "moving-object"; }
  3283. ^
  3284. src/badguy/zeekling.hpp:37:22: note: Derived function 'Zeekling::class_name'
  3285. static std::string class_name() { return "zeekling"; }
  3286. ^
  3287. src/badguy/zeekling.hpp:26:3: style: Class 'Zeekling' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3288. Zeekling(const ReaderMapping& reader);
  3289. ^
  3290. src/control/game_controller_manager.hpp:40:3: style: Class 'GameControllerManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3291. GameControllerManager(InputManager* parent);
  3292. ^
  3293. src/supertux/console.hpp:61:3: style: Class 'Console' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3294. Console(ConsoleBuffer& buffer);
  3295. ^
  3296. src/control/mobile_controller.hpp:23:0: information: Include file: "config.h" not found. [missingInclude]
  3297. #include "config.h"
  3298. ^
  3299. src/control/mobile_controller.cpp:22:0: information: Include file: "SDL.h" not found. [missingInclude]
  3300. #include "SDL.h"
  3301. ^
  3302. src/control/mobile_controller.cpp:188:14: style: Variable 'i' can be declared as reference to const [constVariableReference]
  3303. for (auto& i : m_fingers)
  3304. ^
  3305. src/collision/collision_system.cpp:61:14: style: Local variable 'collision_object' shadows outer function [shadowFunction]
  3306. for (auto* collision_object : m_objects) {
  3307. ^
  3308. src/collision/collision_system.hpp:98:8: note: Shadowed declaration
  3309. void collision_object(CollisionObject* object1, CollisionObject* object2) const;
  3310. ^
  3311. src/collision/collision_system.cpp:61:14: note: Shadow variable
  3312. for (auto* collision_object : m_objects) {
  3313. ^
  3314. src/collision/collision_system.cpp:78:14: style: Variable 'object' can be declared as pointer to const [constVariableReference]
  3315. for (auto& object : m_objects) {
  3316. ^
  3317. src/collision/collision_system.cpp:300:14: style: Variable 'solids' can be declared as pointer to const [constVariableReference]
  3318. for (auto& solids: m_sector.get_solid_tilemaps())
  3319. ^
  3320. src/collision/collision_system.cpp:670:20: style: Variable 'solids' can be declared as pointer to const [constVariableReference]
  3321. for (const auto& solids : m_sector.get_solid_tilemaps()) {
  3322. ^
  3323. src/collision/collision_system.cpp:706:20: style: Variable 'object' can be declared as pointer to const [constVariableReference]
  3324. for (const auto& object : m_objects) {
  3325. ^
  3326. src/collision/collision_system.cpp:724:20: style: Variable 'object' can be declared as pointer to const [constVariableReference]
  3327. for (const auto& object : m_objects) {
  3328. ^
  3329. src/collision/collision_system.cpp:742:20: style: Variable 'object' can be declared as pointer to const [constVariableReference]
  3330. for (const auto& object : m_objects) {
  3331. ^
  3332. src/editor/bezier_marker.cpp:64:15: warning: The class 'BezierMarker' defines member function with name 'get_parent' also defined in its parent class 'GameObject'. [duplInheritedMember]
  3333. BezierMarker::get_parent() const
  3334. ^
  3335. src/supertux/game_object.hpp:198:22: note: Parent function 'GameObject::get_parent'
  3336. GameObjectManager* get_parent() const { return m_parent; }
  3337. ^
  3338. src/editor/bezier_marker.cpp:64:15: note: Derived function 'BezierMarker::get_parent'
  3339. BezierMarker::get_parent() const
  3340. ^
  3341. src/editor/button_widget.hpp:39:16: style: The function 'update' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3342. virtual void update(float dt_sec) override;
  3343. ^
  3344. src/editor/widget.hpp:33:16: note: Virtual function in base class
  3345. virtual void update(float dt_sec) {}
  3346. ^
  3347. src/editor/button_widget.hpp:39:16: note: Function in derived class
  3348. virtual void update(float dt_sec) override;
  3349. ^
  3350. src/editor/button_widget.hpp:41:16: style: The function 'setup' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3351. virtual void setup() override;
  3352. ^
  3353. src/editor/widget.hpp:35:16: note: Virtual function in base class
  3354. virtual void setup() {}
  3355. ^
  3356. src/editor/button_widget.hpp:41:16: note: Function in derived class
  3357. virtual void setup() override;
  3358. ^
  3359. src/editor/button_widget.hpp:42:16: style: The function 'resize' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3360. virtual void resize() override;
  3361. ^
  3362. src/editor/widget.hpp:36:16: note: Virtual function in base class
  3363. virtual void resize() {}
  3364. ^
  3365. src/editor/button_widget.hpp:42:16: note: Function in derived class
  3366. virtual void resize() override;
  3367. ^
  3368. src/editor/editor.cpp:31:0: information: Include file: "zip_manager.hpp" not found. [missingInclude]
  3369. #include "zip_manager.hpp"
  3370. ^
  3371. src/gui/mousecursor.hpp:23:0: information: Include file: "config.h" not found. [missingInclude]
  3372. #include "config.h"
  3373. ^
  3374. src/supertux/screen_manager.hpp:24:0: information: Include file: "config.h" not found. [missingInclude]
  3375. #include "config.h"
  3376. ^
  3377. src/editor/object_icon.hpp:32:3: style: Class 'ObjectIcon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3378. ObjectIcon(const ReaderMapping& reader);
  3379. ^
  3380. src/editor/layer_icon.hpp:28:3: style: Class 'LayerIcon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3381. LayerIcon(GameObject* layer);
  3382. ^
  3383. src/object/background.hpp:37:3: style: Class 'Background' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3384. Background(const ReaderMapping& reader);
  3385. ^
  3386. src/object/gradient.hpp:33:3: style: Class 'Gradient' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3387. Gradient(const ReaderMapping& reader);
  3388. ^
  3389. src/object/particlesystem.hpp:50:3: style: Class 'ParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3390. ParticleSystem(const ReaderMapping& reader, float max_particle_size = 60);
  3391. ^
  3392. src/object/particlesystem.hpp:51:3: style: Class 'ParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3393. ParticleSystem(float max_particle_size = 60);
  3394. ^
  3395. src/object/particlesystem_interactive.hpp:43:3: style: Class 'ParticleSystem_Interactive' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3396. ParticleSystem_Interactive(const ReaderMapping& mapping);
  3397. ^
  3398. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Background , scripting :: Background >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3399. ExposedObject(S* parent) :
  3400. ^
  3401. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Gradient , scripting :: Gradient >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3402. ExposedObject(S* parent) :
  3403. ^
  3404. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < ParticleSystem , scripting :: ParticleSystem >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3405. ExposedObject(S* parent) :
  3406. ^
  3407. src/editor/layer_icon.cpp:52:18: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3408. if (TileMap* tilemap = dynamic_cast<TileMap*>(m_layer)) {
  3409. ^
  3410. src/editor/layer_icon.cpp:69:18: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3411. if (TileMap* tilemap = dynamic_cast<TileMap*>(m_layer)) {
  3412. ^
  3413. src/editor/layer_icon.cpp:84:13: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3414. if (auto* tilemap = dynamic_cast<TileMap*>(m_layer)) {
  3415. ^
  3416. src/editor/layer_icon.cpp:86:20: style: Variable 'bkgrd' can be declared as pointer to const [constVariablePointer]
  3417. } else if (auto* bkgrd = dynamic_cast<Background*>(m_layer)) {
  3418. ^
  3419. src/editor/layer_icon.cpp:88:20: style: Variable 'grd' can be declared as pointer to const [constVariablePointer]
  3420. } else if (auto* grd = dynamic_cast<Gradient*>(m_layer)) {
  3421. ^
  3422. src/editor/layer_icon.cpp:90:20: style: Variable 'ps' can be declared as pointer to const [constVariablePointer]
  3423. } else if (auto* ps = dynamic_cast<ParticleSystem*>(m_layer)) {
  3424. ^
  3425. src/editor/layer_icon.cpp:92:20: style: Variable 'psi' can be declared as pointer to const [constVariablePointer]
  3426. } else if (auto* psi = dynamic_cast<ParticleSystem_Interactive*>(m_layer)) {
  3427. ^
  3428. src/object/particle_zone.hpp:39:22: warning: The class 'ParticleZone' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3429. static std::string class_name() { return "particle-zone"; }
  3430. ^
  3431. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3432. static std::string class_name() { return "moving-object"; }
  3433. ^
  3434. src/object/particle_zone.hpp:39:22: note: Derived function 'ParticleZone::class_name'
  3435. static std::string class_name() { return "particle-zone"; }
  3436. ^
  3437. src/object/custom_particle_system.hpp:44:22: warning: The class 'CustomParticleSystem' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  3438. static std::string class_name() { return "particles-custom"; }
  3439. ^
  3440. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  3441. static std::string class_name() { return "particle-system"; }
  3442. ^
  3443. src/object/custom_particle_system.hpp:44:22: note: Derived function 'CustomParticleSystem::class_name'
  3444. static std::string class_name() { return "particles-custom"; }
  3445. ^
  3446. src/object/custom_particle_system.hpp:46:22: warning: The class 'CustomParticleSystem' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  3447. static std::string display_name() { return _("Custom Particles"); }
  3448. ^
  3449. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  3450. static std::string display_name() { return _("Particle system"); }
  3451. ^
  3452. src/object/custom_particle_system.hpp:46:22: note: Derived function 'CustomParticleSystem::display_name'
  3453. static std::string display_name() { return _("Custom Particles"); }
  3454. ^
  3455. src/gui/mousecursor.hpp:46:23: warning: The class 'MouseCursor' defines member function with name 'current' also defined in its parent class 'Currenton < MouseCursor >'. [duplInheritedMember]
  3456. static MouseCursor* current() { return current_; }
  3457. ^
  3458. src/util/currenton.hpp:53:13: note: Parent function 'Currenton < MouseCursor >::current'
  3459. static C* current() { return static_cast<C*>(s_current); }
  3460. ^
  3461. src/gui/mousecursor.hpp:46:23: note: Derived function 'MouseCursor::current'
  3462. static MouseCursor* current() { return current_; }
  3463. ^
  3464. src/object/spawnpoint.hpp:46:22: warning: The class 'SpawnPointMarker' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3465. static std::string class_name() { return "spawnpoint"; }
  3466. ^
  3467. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3468. static std::string class_name() { return "moving-object"; }
  3469. ^
  3470. src/object/spawnpoint.hpp:46:22: note: Derived function 'SpawnPointMarker::class_name'
  3471. static std::string class_name() { return "spawnpoint"; }
  3472. ^
  3473. src/editor/object_group.hpp:31:3: style: Class 'ObjectGroup' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3474. ObjectGroup(const ReaderMapping& reader);
  3475. ^
  3476. src/interface/control_button.hpp:25:3: style: Class 'ControlButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3477. ControlButton(std::string label);
  3478. ^
  3479. src/object/particle_zone.hpp:33:3: style: Class 'ParticleZone' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3480. ParticleZone(const ReaderMapping& reader);
  3481. ^
  3482. src/object/custom_particle_system.hpp:36:3: style: Class 'CustomParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3483. CustomParticleSystem(const ReaderMapping& reader);
  3484. ^
  3485. src/object/custom_particle_system.hpp:147:5: style: Class 'SpriteProperties' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3486. SpriteProperties(const SurfacePtr& surface) :
  3487. ^
  3488. src/editor/tool_icon.hpp:31:3: style: Class 'ToolIcon' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3489. ToolIcon(const std::string& icon);
  3490. ^
  3491. src/gui/mousecursor.hpp:53:3: style: Class 'MouseCursor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3492. MouseCursor(SpritePtr sprite);
  3493. ^
  3494. src/object/spawnpoint.hpp:32:3: style: Class 'SpawnPointMarker' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3495. SpawnPointMarker(const ReaderMapping& mapping);
  3496. ^
  3497. src/physfs/ifile_stream.hpp:29:3: style: Class 'IFileStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3498. IFileStream(const std::string& filename);
  3499. ^
  3500. src/squirrel/squirrel_thread_queue.hpp:31:3: style: Class 'SquirrelThreadQueue' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3501. SquirrelThreadQueue(SquirrelVM& vm);
  3502. ^
  3503. src/supertux/screen_manager.hpp:94:5: style: Struct 'Action' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3504. Action(Type type_,
  3505. ^
  3506. src/video/compositor.hpp:36:3: style: Class 'Compositor' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3507. Compositor(VideoSystem& video_system);
  3508. ^
  3509. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < CustomParticleSystem , scripting :: CustomParticles >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3510. ExposedObject(S* parent) :
  3511. ^
  3512. src/interface/control_enum.hpp:117:7: style: The scope of the variable 'i' can be reduced. [variableScope]
  3513. int i = 0;
  3514. ^
  3515. src/object/particle_zone.hpp:75:39: style: Parameter 'particle_name' can be declared as reference to const [constParameterReference]
  3516. void set_particle_name(std::string& particle_name) {m_particle_name = particle_name;}
  3517. ^
  3518. src/editor/editor.cpp:85:11: style: Variable 'self' can be declared as pointer to const [constVariablePointer]
  3519. auto* self = Editor::current();
  3520. ^
  3521. src/editor/editor.cpp:332:10: style: Variable 'current_world' can be declared as pointer to const [constVariablePointer]
  3522. World* current_world = m_world.get();
  3523. ^
  3524. src/editor/object_menu.hpp:40:3: style: Class 'ObjectMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3525. ObjectMenu(GameObject* go, const std::function<bool (GameObject*)>& remove_function = {});
  3526. ^
  3527. src/editor/layers_widget.hpp:52:16: style: The function 'on_mouse_button_up' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3528. virtual bool on_mouse_button_up(const SDL_MouseButtonEvent& button) override;
  3529. ^
  3530. src/editor/widget.hpp:38:16: note: Virtual function in base class
  3531. virtual bool on_mouse_button_up(const SDL_MouseButtonEvent& button) { return false; }
  3532. ^
  3533. src/editor/layers_widget.hpp:52:16: note: Function in derived class
  3534. virtual bool on_mouse_button_up(const SDL_MouseButtonEvent& button) override;
  3535. ^
  3536. src/editor/layers_widget.cpp:400:39: warning: Access of moved variable 'icon'. [accessMoved]
  3537. m_layer_icons.push_back(std::move(icon));
  3538. ^
  3539. src/editor/layers_widget.cpp:393:31: note: Calling std::move(icon)
  3540. m_layer_icons.insert(i, std::move(icon));
  3541. ^
  3542. src/editor/layers_widget.cpp:400:39: note: Access of moved variable 'icon'.
  3543. m_layer_icons.push_back(std::move(icon));
  3544. ^
  3545. src/editor/bezier_marker.hpp:40:15: warning: The class 'BezierMarker' defines member function with name 'get_parent' also defined in its parent class 'GameObject'. [duplInheritedMember]
  3546. NodeMarker* get_parent() const;
  3547. ^
  3548. src/supertux/game_object.hpp:198:22: note: Parent function 'GameObject::get_parent'
  3549. GameObjectManager* get_parent() const { return m_parent; }
  3550. ^
  3551. src/editor/bezier_marker.hpp:40:15: note: Derived function 'BezierMarker::get_parent'
  3552. NodeMarker* get_parent() const;
  3553. ^
  3554. src/gui/menu_item.hpp:26:3: style: Class 'MenuItem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3555. MenuItem(const std::string& text, int id = -1);
  3556. ^
  3557. src/gui/menu_object_select.hpp:30:3: style: Class 'ObjectSelectMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3558. ObjectSelectMenu(std::vector<std::unique_ptr<GameObject>>& objects, uint8_t get_objects_param = 0,
  3559. ^
  3560. src/gui/item_stringselect.hpp:40:16: style: The function 'changes_width' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3561. virtual bool changes_width() const override {
  3562. ^
  3563. src/gui/menu_item.hpp:76:16: note: Virtual function in base class
  3564. virtual bool changes_width() const {
  3565. ^
  3566. src/gui/item_stringselect.hpp:40:16: note: Function in derived class
  3567. virtual bool changes_width() const override {
  3568. ^
  3569. src/editor/object_option.cpp:306:8: style: Variable 'selected_id' can be declared as pointer to const [constVariablePointer]
  3570. int* selected_id = static_cast<int*>(m_value_pointer);
  3571. ^
  3572. src/editor/object_settings.cpp:257:46: warning: Function 'add_level' argument order different: declaration 'text, value_ptr, basedir, key, flags' definition 'text, value_ptr, key, basedir, flags' [funcArgOrderDifferent]
  3573. ObjectSettings::add_level(const std::string& text, std::string* value_ptr, const std::string& key,
  3574. ^
  3575. src/editor/object_settings.hpp:133:37: note: Function 'add_level' argument order different: declaration 'text, value_ptr, basedir, key, flags' definition 'text, value_ptr, key, basedir, flags'
  3576. void add_level(const std::string& text, std::string* value_ptr, const std::string& basedir,
  3577. ^
  3578. src/editor/object_settings.cpp:257:46: note: Function 'add_level' argument order different: declaration 'text, value_ptr, basedir, key, flags' definition 'text, value_ptr, key, basedir, flags'
  3579. ObjectSettings::add_level(const std::string& text, std::string* value_ptr, const std::string& key,
  3580. ^
  3581. src/worldmap/worldmap_object.hpp:40:22: warning: The class 'WorldMapObject' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3582. static std::string class_name() { return "worldmap-object"; }
  3583. ^
  3584. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3585. static std::string class_name() { return "moving-sprite"; }
  3586. ^
  3587. src/worldmap/worldmap_object.hpp:40:22: note: Derived function 'WorldMapObject::class_name'
  3588. static std::string class_name() { return "worldmap-object"; }
  3589. ^
  3590. src/worldmap/worldmap_object.hpp:40:22: warning: The class 'WorldMapObject' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3591. static std::string class_name() { return "worldmap-object"; }
  3592. ^
  3593. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3594. static std::string class_name() { return "moving-object"; }
  3595. ^
  3596. src/worldmap/worldmap_object.hpp:40:22: note: Derived function 'WorldMapObject::class_name'
  3597. static std::string class_name() { return "worldmap-object"; }
  3598. ^
  3599. src/worldmap/worldmap_object.hpp:37:3: style: Class 'WorldMapObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3600. WorldMapObject(const ReaderMapping& mapping);
  3601. ^
  3602. src/editor/overlay_widget.cpp:1401:7: warning: Identical condition '!m_editor.get_selected_tilemap()', second condition is always false [identicalConditionAfterEarlyExit]
  3603. if (!current_tm) return;
  3604. ^
  3605. src/editor/overlay_widget.cpp:1400:50: note: 'current_tm' is assigned value 'm_editor.get_selected_tilemap()' here.
  3606. auto current_tm = m_editor.get_selected_tilemap();
  3607. ^
  3608. src/editor/overlay_widget.cpp:1398:7: note: If condition '!m_editor.get_selected_tilemap()' is true, the function will return/exit
  3609. if (!m_editor.get_selected_tilemap()) return;
  3610. ^
  3611. src/editor/overlay_widget.cpp:1401:7: note: Testing identical condition '!m_editor.get_selected_tilemap()'
  3612. if (!current_tm) return;
  3613. ^
  3614. src/editor/overlay_widget.cpp:436:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3615. auto tilemap = m_editor.get_selected_tilemap();
  3616. ^
  3617. src/editor/overlay_widget.cpp:672:8: style: Variable 'path_obj' can be declared as pointer to const [constVariablePointer]
  3618. auto path_obj = dynamic_cast<PathObject*>(m_dragged_object.get());
  3619. ^
  3620. src/editor/overlay_widget.cpp:774:12: style: Variable 'pm' can be declared as pointer to const [constVariablePointer]
  3621. auto pm = dynamic_cast<MarkerObject*>(m_dragged_object.get());
  3622. ^
  3623. src/editor/overlay_widget.cpp:1041:8: style: Variable 'tileset' can be declared as pointer to const [constVariablePointer]
  3624. auto tileset = m_editor.get_tileset();
  3625. ^
  3626. src/editor/overlay_widget.cpp:1042:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3627. auto tilemap = m_editor.get_selected_tilemap();
  3628. ^
  3629. src/editor/overlay_widget.cpp:1257:10: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3630. auto tilemap = m_editor.get_selected_tilemap();
  3631. ^
  3632. src/editor/overlay_widget.cpp:1296:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3633. auto tilemap = m_editor.get_selected_tilemap();
  3634. ^
  3635. src/editor/overlay_widget.cpp:1332:8: style: Variable 'current_tm' can be declared as pointer to const [constVariablePointer]
  3636. auto current_tm = m_editor.get_selected_tilemap();
  3637. ^
  3638. src/editor/overlay_widget.cpp:1400:8: style: Variable 'current_tm' can be declared as pointer to const [constVariablePointer]
  3639. auto current_tm = m_editor.get_selected_tilemap();
  3640. ^
  3641. src/editor/overlay_widget.cpp:1423:17: style: Variable 'node1' can be declared as pointer to const [constVariablePointer]
  3642. Path::Node* node1 = &(*i);
  3643. ^
  3644. src/editor/overlay_widget.cpp:1424:17: style: Variable 'node2' can be declared as pointer to const [constVariablePointer]
  3645. Path::Node* node2;
  3646. ^
  3647. src/editor/overlay_widget.cpp:1496:10: style: Variable 'sel_tilemap' can be declared as pointer to const [constVariablePointer]
  3648. auto sel_tilemap = m_editor.get_selected_tilemap();
  3649. ^
  3650. src/editor/overlay_widget.cpp:1583:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3651. auto tilemap = m_editor.get_selected_tilemap();
  3652. ^
  3653. src/editor/overlay_widget.cpp:1593:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3654. auto tilemap = m_editor.get_selected_tilemap();
  3655. ^
  3656. src/editor/overlay_widget.cpp:1610:8: style: Variable 'tilemap' can be declared as pointer to const [constVariablePointer]
  3657. auto tilemap = m_editor.get_selected_tilemap();
  3658. ^
  3659. src/supertux/menu/particle_editor_save_as.hpp:31:3: style: Class 'ParticleEditorSaveAs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3660. ParticleEditorSaveAs(std::function<void(bool)> callback);
  3661. ^
  3662. src/editor/toolbox_widget.cpp:148:14: style: Variable 'tile_ID' can be declared as reference to const [constVariableReference]
  3663. for (auto& tile_ID : m_active_tilegroup->tiles)
  3664. ^
  3665. src/gui/item_action.hpp:25:3: style: Class 'ItemAction' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3666. ItemAction(const std::string& text, int id = -1, std::function<void()> callback = {});
  3667. ^
  3668. src/gui/item_back.hpp:25:3: style: Class 'ItemBack' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3669. ItemBack(const std::string& text, int id = -1);
  3670. ^
  3671. src/gui/menu_color.hpp:25:3: style: Class 'ColorMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3672. ColorMenu(Color* color_);
  3673. ^
  3674. src/util/colorspace_oklab.hpp:28:3: style: Struct 'ColorOKLCh' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3675. ColorOKLCh(Color& c);
  3676. ^
  3677. src/gui/item_colorchannel_oklab.cpp:216:46: style: Parameter 'col_oklch_clipped' can be declared as reference to const [constParameterReference]
  3678. ItemColorChannelOKLab::set_color(ColorOKLCh& col_oklch_clipped,
  3679. ^
  3680. src/gui/item_colorchannel_oklab.cpp:217:15: style: Parameter 'col_oklch_store' can be declared as reference to const [constParameterReference]
  3681. ColorOKLCh& col_oklch_store)
  3682. ^
  3683. src/gui/item_colorchannel_rgba.cpp:99:16: style: Variable 'c' can be declared as reference to const [constVariableReference]
  3684. for (auto& c : txt) {
  3685. ^
  3686. src/gui/item_colordisplay.hpp:27:3: style: Class 'ItemColorDisplay' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3687. ItemColorDisplay(Color* color, int id_ = -1);
  3688. ^
  3689. src/gui/item_floatfield.cpp:125:14: style: Variable 'c' can be declared as reference to const [constVariableReference]
  3690. for (auto& c : text)
  3691. ^
  3692. src/gui/item_floatfield.cpp:85:16: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3693. *input = input->substr(0, input->size() - left_offset_pos) + '.' +
  3694. ^
  3695. src/gui/item_floatfield.cpp:92:14: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3696. *input = input->substr(0, input->size() - left_offset_pos) + c +
  3697. ^
  3698. src/gui/item_images.hpp:26:3: style: Class 'ItemImages' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3699. ItemImages(const std::string& image_path, int max_image_width = 0, int max_image_height = 0, int id = -1);
  3700. ^
  3701. src/gui/item_images.hpp:27:3: style: Class 'ItemImages' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3702. ItemImages(const std::vector<std::string>& image_paths, int max_image_width = 0, int max_image_height = 0, int id = -1);
  3703. ^
  3704. src/gui/item_intfield.cpp:98:14: style: Variable 'c' can be declared as reference to const [constVariableReference]
  3705. for (auto& c : text)
  3706. ^
  3707. src/gui/item_intfield.cpp:68:12: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3708. *input = input->substr(0, input->size() - left_offset_pos) + c +
  3709. ^
  3710. src/gui/item_label.hpp:25:3: style: Class 'ItemLabel' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3711. ItemLabel(const std::string& text_);
  3712. ^
  3713. src/gui/menu_script.hpp:25:3: style: Class 'ScriptMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3714. ScriptMenu(std::string* script_);
  3715. ^
  3716. src/gui/item_script_line.hpp:26:3: style: Class 'ItemScriptLine' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3717. ItemScriptLine(std::string* input_, int id_ = -1);
  3718. ^
  3719. src/gui/menu_string_array.hpp:27:3: style: Class 'StringArrayMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3720. StringArrayMenu(std::vector<std::string>& items);
  3721. ^
  3722. src/gui/item_textfield.cpp:151:12: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3723. *input = input->substr(0, input->size() - left_offset_pos) + text +
  3724. ^
  3725. src/gui/item_textfield.cpp:217:16: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3726. *input = input->substr(0, index) +
  3727. ^
  3728. src/gui/item_textfield.cpp:239:16: performance: Ineffective call of function 'substr' because a prefix of the string is assigned to itself. Use replace() instead. [uselessCallsSubstr]
  3729. *input = input->substr(0, input->size() - m_cursor_left_offset) +
  3730. ^
  3731. src/gui/menu.cpp:500:18: style: Local variable 'm_items' shadows outer variable [shadowVariable]
  3732. menu_action(*m_items[m_active_item]);
  3733. ^
  3734. src/gui/menu.hpp:159:43: note: Shadowed declaration
  3735. std::vector<std::unique_ptr<MenuItem> > m_items;
  3736. ^
  3737. src/gui/menu.cpp:500:18: note: Shadow variable
  3738. menu_action(*m_items[m_active_item]);
  3739. ^
  3740. src/gui/notification.hpp:53:3: style: Class 'Notification' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3741. Notification(std::string id, bool no_auto_hide = false, bool no_auto_disable = false);
  3742. ^
  3743. src/gui/menu_manager.cpp:315:28: error: Dereference of an invalid iterator: m_menu_stack.end() [derefInvalidIterator]
  3744. return m_menu_stack.end()[-2].get();
  3745. ^
  3746. src/gui/menu_object_select.cpp:54:14: style: Variable 'obj' can be declared as reference to const [constVariableReference]
  3747. for (auto& obj : m_objects)
  3748. ^
  3749. src/interface/control_scrollbar.hpp:34:16: style: The function 'update' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  3750. virtual void update(float dt_sec) override;
  3751. ^
  3752. src/editor/widget.hpp:33:16: note: Virtual function in base class
  3753. virtual void update(float dt_sec) {}
  3754. ^
  3755. src/interface/control_scrollbar.hpp:34:16: note: Function in derived class
  3756. virtual void update(float dt_sec) override;
  3757. ^
  3758. src/interface/control_textbox_float.hpp:40:16: style: Virtual function 'revert_value' is called from constructor 'ControlTextboxFloat()' at line 26. Dynamic binding is not used. [virtualCallInConstructor]
  3759. virtual void revert_value() override;
  3760. ^
  3761. src/interface/control_textbox_float.cpp:26:3: note: Calling revert_value
  3762. revert_value();
  3763. ^
  3764. src/interface/control_textbox_float.hpp:40:16: note: revert_value is a virtual function
  3765. virtual void revert_value() override;
  3766. ^
  3767. src/interface/control_textbox_int.hpp:40:16: style: Virtual function 'revert_value' is called from constructor 'ControlTextboxInt()' at line 26. Dynamic binding is not used. [virtualCallInConstructor]
  3768. virtual void revert_value() override;
  3769. ^
  3770. src/interface/control_textbox_int.cpp:26:3: note: Calling revert_value
  3771. revert_value();
  3772. ^
  3773. src/interface/control_textbox_int.hpp:40:16: note: revert_value is a virtual function
  3774. virtual void revert_value() override;
  3775. ^
  3776. src/supertux/profile.hpp:29:3: style: Class 'Profile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3777. Profile(int id);
  3778. ^
  3779. src/video/ttf_surface_manager.hpp:51:5: style: Struct 'CacheEntry' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3780. CacheEntry(const TTFSurfacePtr& s);
  3781. ^
  3782. src/object/ambient_light.hpp:27:3: style: Class 'AmbientLight' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3783. AmbientLight(const Color& color);
  3784. ^
  3785. src/object/ambient_light.hpp:28:3: style: Class 'AmbientLight' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3786. AmbientLight(const ReaderMapping& mapping);
  3787. ^
  3788. src/object/ambient_sound.hpp:41:22: warning: The class 'AmbientSound' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3789. static std::string class_name() { return "ambient-sound"; }
  3790. ^
  3791. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3792. static std::string class_name() { return "moving-object"; }
  3793. ^
  3794. src/object/ambient_sound.hpp:41:22: note: Derived function 'AmbientSound::class_name'
  3795. static std::string class_name() { return "ambient-sound"; }
  3796. ^
  3797. src/object/ambient_sound.hpp:35:3: style: Class 'AmbientSound' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3798. AmbientSound(const ReaderMapping& mapping);
  3799. ^
  3800. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < AmbientSound , scripting :: AmbientSound >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3801. ExposedObject(S* parent) :
  3802. ^
  3803. src/object/bicycle_platform.hpp:58:3: style: Class 'BicyclePlatform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3804. BicyclePlatform(const ReaderMapping& reader);
  3805. ^
  3806. src/object/bicycle_platform.hpp:72:16: style: The function 'after_editor_set' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
  3807. virtual void after_editor_set() override;
  3808. ^
  3809. src/supertux/game_object.hpp:125:16: note: Virtual function in base class
  3810. virtual void after_editor_set();
  3811. ^
  3812. src/object/bicycle_platform.hpp:72:16: note: Function in derived class
  3813. virtual void after_editor_set() override;
  3814. ^
  3815. src/object/bicycle_platform.cpp:62:8: style: Variable 'pl' can be declared as pointer to const [constVariablePointer]
  3816. auto pl = dynamic_cast<Player*>(mo);
  3817. ^
  3818. src/object/growup.hpp:27:3: style: Class 'GrowUp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3819. GrowUp(const Vector& pos, Direction direction = Direction::RIGHT, const std::string& custom_sprite = "");
  3820. ^
  3821. src/object/block.cpp:100:8: style: Variable 'portable' can be declared as pointer to const [constVariablePointer]
  3822. auto portable = dynamic_cast<Portable*> (&other);
  3823. ^
  3824. src/object/block.cpp:101:8: style: Variable 'moving_object' can be declared as pointer to const [constVariablePointer]
  3825. auto moving_object = dynamic_cast<MovingObject*> (&other);
  3826. ^
  3827. src/object/block.cpp:102:8: style: Variable 'bomb' can be declared as pointer to const [constVariablePointer]
  3828. auto bomb = dynamic_cast<Bomb*> (&other);
  3829. ^
  3830. src/object/block.cpp:170:17: style: Variable 'hitter_mo' can be declared as pointer to const [constVariablePointer]
  3831. MovingObject* hitter_mo = dynamic_cast<MovingObject*>(hitter);
  3832. ^
  3833. src/object/bouncy_coin.hpp:28:3: style: Class 'BouncyCoin' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3834. BouncyCoin(const Vector& pos, bool emerge = false,
  3835. ^
  3836. src/object/bonus_block.cpp:162:3: error: Non-local variable 'm_object' will use pointer to local variable 'object'. [danglingLifetime]
  3837. m_object = object.get();
  3838. ^
  3839. src/object/bonus_block.cpp:162:24: note: Raw pointer to smart pointer created here.
  3840. m_object = object.get();
  3841. ^
  3842. src/object/bonus_block.cpp:160:52: note: Variable created here.
  3843. BonusBlock::set_object(std::unique_ptr<GameObject> object)
  3844. ^
  3845. src/object/bonus_block.cpp:162:3: note: Non-local variable 'm_object' will use pointer to local variable 'object'.
  3846. m_object = object.get();
  3847. ^
  3848. src/object/bonus_block.hpp:60:22: warning: The class 'BonusBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3849. static std::string class_name() { return "bonusblock"; }
  3850. ^
  3851. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3852. static std::string class_name() { return "moving-sprite"; }
  3853. ^
  3854. src/object/bonus_block.hpp:60:22: note: Derived function 'BonusBlock::class_name'
  3855. static std::string class_name() { return "bonusblock"; }
  3856. ^
  3857. src/object/bonus_block.hpp:60:22: warning: The class 'BonusBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3858. static std::string class_name() { return "bonusblock"; }
  3859. ^
  3860. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3861. static std::string class_name() { return "moving-object"; }
  3862. ^
  3863. src/object/bonus_block.hpp:60:22: note: Derived function 'BonusBlock::class_name'
  3864. static std::string class_name() { return "bonusblock"; }
  3865. ^
  3866. src/object/powerup.hpp:38:22: warning: The class 'PowerUp' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3867. static std::string class_name() { return "powerup"; }
  3868. ^
  3869. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3870. static std::string class_name() { return "moving-sprite"; }
  3871. ^
  3872. src/object/powerup.hpp:38:22: note: Derived function 'PowerUp::class_name'
  3873. static std::string class_name() { return "powerup"; }
  3874. ^
  3875. src/object/powerup.hpp:38:22: warning: The class 'PowerUp' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3876. static std::string class_name() { return "powerup"; }
  3877. ^
  3878. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3879. static std::string class_name() { return "moving-object"; }
  3880. ^
  3881. src/object/powerup.hpp:38:22: note: Derived function 'PowerUp::class_name'
  3882. static std::string class_name() { return "powerup"; }
  3883. ^
  3884. src/object/trampoline.hpp:35:22: warning: The class 'Trampoline' defines member function with name 'class_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  3885. static std::string class_name() { return "trampoline"; }
  3886. ^
  3887. src/object/rock.hpp:41:22: note: Parent function 'Rock::class_name'
  3888. static std::string class_name() { return "rock"; }
  3889. ^
  3890. src/object/trampoline.hpp:35:22: note: Derived function 'Trampoline::class_name'
  3891. static std::string class_name() { return "trampoline"; }
  3892. ^
  3893. src/object/trampoline.hpp:37:22: warning: The class 'Trampoline' defines member function with name 'display_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  3894. static std::string display_name() { return _("Trampoline"); }
  3895. ^
  3896. src/object/rock.hpp:43:22: note: Parent function 'Rock::display_name'
  3897. static std::string display_name() { return _("Rock"); }
  3898. ^
  3899. src/object/trampoline.hpp:37:22: note: Derived function 'Trampoline::display_name'
  3900. static std::string display_name() { return _("Trampoline"); }
  3901. ^
  3902. src/object/trampoline.hpp:35:22: warning: The class 'Trampoline' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  3903. static std::string class_name() { return "trampoline"; }
  3904. ^
  3905. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  3906. static std::string class_name() { return "moving-sprite"; }
  3907. ^
  3908. src/object/trampoline.hpp:35:22: note: Derived function 'Trampoline::class_name'
  3909. static std::string class_name() { return "trampoline"; }
  3910. ^
  3911. src/object/trampoline.hpp:35:22: warning: The class 'Trampoline' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  3912. static std::string class_name() { return "trampoline"; }
  3913. ^
  3914. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  3915. static std::string class_name() { return "moving-object"; }
  3916. ^
  3917. src/object/trampoline.hpp:35:22: note: Derived function 'Trampoline::class_name'
  3918. static std::string class_name() { return "trampoline"; }
  3919. ^
  3920. src/object/bonus_block.hpp:54:3: style: Class 'BonusBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3921. BonusBlock(const ReaderMapping& mapping);
  3922. ^
  3923. src/object/coin_rain.hpp:28:3: style: Class 'CoinRain' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3924. CoinRain(const Vector& pos, bool emerge=false, bool count_stats = true,
  3925. ^
  3926. src/object/flower.hpp:32:3: style: Class 'Flower' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3927. Flower(BonusType type, const std::string& custom_sprite = "");
  3928. ^
  3929. src/object/oneup.hpp:27:3: style: Class 'OneUp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3930. OneUp(const Vector& pos, Direction direction = Direction::RIGHT);
  3931. ^
  3932. src/object/powerup.hpp:26:3: style: Class 'PowerUp' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3933. PowerUp(const ReaderMapping& mapping);
  3934. ^
  3935. src/object/star.hpp:28:3: style: Class 'Star' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3936. Star(const Vector& pos, Direction direction = Direction::RIGHT, const std::string& custom_sprite = "");
  3937. ^
  3938. src/object/trampoline.hpp:26:3: style: Class 'Trampoline' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  3939. Trampoline(const ReaderMapping& reader);
  3940. ^
  3941. src/object/bonus_block.cpp:304:8: style: Variable 'badguy' can be declared as pointer to const [constVariablePointer]
  3942. auto badguy = dynamic_cast<BadGuy*> (&other);
  3943. ^
  3944. src/object/bonus_block.cpp:314:8: style: Variable 'crusher' can be declared as pointer to const [constVariablePointer]
  3945. auto crusher = dynamic_cast<Crusher*> (&other);
  3946. ^
  3947. src/object/bonus_block.cpp:320:8: style: Variable 'portable' can be declared as pointer to const [constVariablePointer]
  3948. auto portable = dynamic_cast<Portable*> (&other);
  3949. ^
  3950. src/object/bonus_block.cpp:322:10: style: Variable 'moving' can be declared as pointer to const [constVariablePointer]
  3951. auto moving = dynamic_cast<MovingObject*> (&other);
  3952. ^
  3953. src/object/bonus_block.cpp:648:40: style: Parameter 'player' can be declared as pointer to const [constParameterPointer]
  3954. BonusBlock::raise_growup_bonus(Player* player, const BonusType& bonus, const Direction& dir,
  3955. ^
  3956. src/object/bonus_block.cpp:666:39: style: Parameter 'player' can be declared as pointer to const [constParameterPointer]
  3957. BonusBlock::drop_growup_bonus(Player* player, int type, const Direction& dir, bool& countdown,
  3958. ^
  3959. src/object/brick.cpp:135:5: error: Using reference to dangling temporary. [danglingTempReference]
  3960. player_one.get_status().add_coins(1);
  3961. ^
  3962. src/object/brick.cpp:134:24: note: Assigned to reference.
  3963. Player& player_one = *Sector::get().get_players()[0];
  3964. ^
  3965. src/object/brick.cpp:135:5: note: Using reference to dangling temporary.
  3966. player_one.get_status().add_coins(1);
  3967. ^
  3968. src/object/brick.cpp:134:13: style: Variable 'player_one' can be declared as reference to const [constVariableReference]
  3969. Player& player_one = *Sector::get().get_players()[0];
  3970. ^
  3971. src/object/brick.cpp:91:8: style: Variable 'badguy' can be declared as pointer to const [constVariablePointer]
  3972. auto badguy = dynamic_cast<BadGuy*> (&other);
  3973. ^
  3974. src/object/brick.cpp:100:8: style: Variable 'portable' can be declared as pointer to const [constVariablePointer]
  3975. auto portable = dynamic_cast<Portable*> (&other);
  3976. ^
  3977. src/object/brick.cpp:102:10: style: Variable 'moving' can be declared as pointer to const [constVariablePointer]
  3978. auto moving = dynamic_cast<MovingObject*> (&other);
  3979. ^
  3980. src/object/brick.cpp:108:8: style: Variable 'explosion' can be declared as pointer to const [constVariablePointer]
  3981. auto explosion = dynamic_cast<Explosion*> (&other);
  3982. ^
  3983. src/object/brick.cpp:113:8: style: Variable 'crusher' can be declared as pointer to const [constVariablePointer]
  3984. auto crusher = dynamic_cast<Crusher*> (&other);
  3985. ^
  3986. src/object/brick.cpp:183:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  3987. auto player = dynamic_cast<Player*>(&other);
  3988. ^
  3989. src/object/brick.cpp:186:8: style: Variable 'crusher' can be declared as pointer to const [constVariablePointer]
  3990. auto crusher = dynamic_cast<Crusher*> (&other);
  3991. ^
  3992. src/object/brick.cpp:195:8: style: Variable 'badguy' can be declared as pointer to const [constVariablePointer]
  3993. auto badguy = dynamic_cast<BadGuy*> (&other);
  3994. ^
  3995. src/object/brick.cpp:199:8: style: Variable 'portable' can be declared as pointer to const [constVariablePointer]
  3996. auto portable = dynamic_cast<Portable*> (&other);
  3997. ^
  3998. src/object/brick.cpp:202:10: style: Variable 'moving' can be declared as pointer to const [constVariablePointer]
  3999. auto moving = dynamic_cast<MovingObject*> (&other);
  4000. ^
  4001. src/object/bumper.hpp:36:22: warning: The class 'Bumper' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4002. static std::string class_name() { return "bumper"; }
  4003. ^
  4004. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4005. static std::string class_name() { return "moving-sprite"; }
  4006. ^
  4007. src/object/bumper.hpp:36:22: note: Derived function 'Bumper::class_name'
  4008. static std::string class_name() { return "bumper"; }
  4009. ^
  4010. src/object/bumper.hpp:36:22: warning: The class 'Bumper' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4011. static std::string class_name() { return "bumper"; }
  4012. ^
  4013. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4014. static std::string class_name() { return "moving-object"; }
  4015. ^
  4016. src/object/bumper.hpp:36:22: note: Derived function 'Bumper::class_name'
  4017. static std::string class_name() { return "bumper"; }
  4018. ^
  4019. src/object/bumper.hpp:29:3: style: Class 'Bumper' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4020. Bumper(const ReaderMapping& reader);
  4021. ^
  4022. src/object/bumper.cpp:78:8: style: Variable 'bumper' can be declared as pointer to const [constVariablePointer]
  4023. auto bumper = dynamic_cast<Bumper*> (&other);
  4024. ^
  4025. src/object/camera.cpp:483:7: style: The if condition is the same as the previous if condition [duplicateCondition]
  4026. if (!player.is_dying())
  4027. ^
  4028. src/object/camera.cpp:455:7: note: First condition
  4029. if (!player.is_dying())
  4030. ^
  4031. src/object/camera.cpp:483:7: note: Second condition
  4032. if (!player.is_dying())
  4033. ^
  4034. src/object/camera.cpp:433:11: style: Variable 'player' can be declared as reference to const [constVariableReference]
  4035. Player& player = *d_sector->get_players()[0];
  4036. ^
  4037. src/object/candle.hpp:35:22: warning: The class 'Candle' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4038. static std::string class_name() { return "candle"; }
  4039. ^
  4040. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4041. static std::string class_name() { return "moving-sprite"; }
  4042. ^
  4043. src/object/candle.hpp:35:22: note: Derived function 'Candle::class_name'
  4044. static std::string class_name() { return "candle"; }
  4045. ^
  4046. src/object/candle.hpp:35:22: warning: The class 'Candle' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4047. static std::string class_name() { return "candle"; }
  4048. ^
  4049. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4050. static std::string class_name() { return "moving-object"; }
  4051. ^
  4052. src/object/candle.hpp:35:22: note: Derived function 'Candle::class_name'
  4053. static std::string class_name() { return "candle"; }
  4054. ^
  4055. src/object/candle.hpp:31:3: style: Class 'Candle' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4056. Candle(const ReaderMapping& mapping);
  4057. ^
  4058. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Candle , scripting :: Candle >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4059. ExposedObject(S* parent) :
  4060. ^
  4061. src/object/circleplatform.hpp:39:16: style: Virtual function 'initialize' is called from constructor 'CirclePlatform(const ReaderMapping&reader)' at line 42. Dynamic binding is not used. [virtualCallInConstructor]
  4062. virtual void initialize();
  4063. ^
  4064. src/object/circleplatform.cpp:42:5: note: Calling initialize
  4065. initialize();
  4066. ^
  4067. src/object/circleplatform.hpp:39:16: note: initialize is a virtual function
  4068. virtual void initialize();
  4069. ^
  4070. src/object/circleplatform.hpp:33:22: warning: The class 'CirclePlatform' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4071. static std::string class_name() { return "circleplatform"; }
  4072. ^
  4073. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4074. static std::string class_name() { return "moving-sprite"; }
  4075. ^
  4076. src/object/circleplatform.hpp:33:22: note: Derived function 'CirclePlatform::class_name'
  4077. static std::string class_name() { return "circleplatform"; }
  4078. ^
  4079. src/object/circleplatform.hpp:33:22: warning: The class 'CirclePlatform' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4080. static std::string class_name() { return "circleplatform"; }
  4081. ^
  4082. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4083. static std::string class_name() { return "moving-object"; }
  4084. ^
  4085. src/object/circleplatform.hpp:33:22: note: Derived function 'CirclePlatform::class_name'
  4086. static std::string class_name() { return "circleplatform"; }
  4087. ^
  4088. src/object/circleplatform.hpp:25:3: style: Class 'CirclePlatform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4089. CirclePlatform(const ReaderMapping& reader);
  4090. ^
  4091. src/object/cloud_particle_system.hpp:40:22: warning: The class 'CloudParticleSystem' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4092. static std::string class_name() { return "particles-clouds"; }
  4093. ^
  4094. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  4095. static std::string class_name() { return "particle-system"; }
  4096. ^
  4097. src/object/cloud_particle_system.hpp:40:22: note: Derived function 'CloudParticleSystem::class_name'
  4098. static std::string class_name() { return "particles-clouds"; }
  4099. ^
  4100. src/object/cloud_particle_system.hpp:42:22: warning: The class 'CloudParticleSystem' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4101. static std::string display_name() { return _("Cloud Particles"); }
  4102. ^
  4103. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  4104. static std::string display_name() { return _("Particle system"); }
  4105. ^
  4106. src/object/cloud_particle_system.hpp:42:22: note: Derived function 'CloudParticleSystem::display_name'
  4107. static std::string display_name() { return _("Cloud Particles"); }
  4108. ^
  4109. src/object/cloud_particle_system.hpp:32:3: style: Class 'CloudParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4110. CloudParticleSystem(const ReaderMapping& reader);
  4111. ^
  4112. src/video/surface_batch.hpp:31:3: style: Class 'SurfaceBatch' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4113. SurfaceBatch(const SurfacePtr& surface, const Color& color = Color::WHITE);
  4114. ^
  4115. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < CloudParticleSystem , scripting :: Clouds >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4116. ExposedObject(S* parent) :
  4117. ^
  4118. src/object/cloud_particle_system.cpp:142:10: style: Variable 'particle' can be declared as pointer to const [constVariablePointer]
  4119. auto particle = dynamic_cast<CloudParticle*>(particles.at(i).get());
  4120. ^
  4121. src/object/coin.cpp:239:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4122. auto player = dynamic_cast<Player*>(&other);
  4123. ^
  4124. src/object/conveyor_belt.hpp:37:22: warning: The class 'ConveyorBelt' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4125. static std::string class_name() { return "conveyor-belt"; }
  4126. ^
  4127. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4128. static std::string class_name() { return "moving-sprite"; }
  4129. ^
  4130. src/object/conveyor_belt.hpp:37:22: note: Derived function 'ConveyorBelt::class_name'
  4131. static std::string class_name() { return "conveyor-belt"; }
  4132. ^
  4133. src/object/conveyor_belt.hpp:37:22: warning: The class 'ConveyorBelt' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4134. static std::string class_name() { return "conveyor-belt"; }
  4135. ^
  4136. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4137. static std::string class_name() { return "moving-object"; }
  4138. ^
  4139. src/object/conveyor_belt.hpp:37:22: note: Derived function 'ConveyorBelt::class_name'
  4140. static std::string class_name() { return "conveyor-belt"; }
  4141. ^
  4142. src/object/conveyor_belt.hpp:31:3: style: Class 'ConveyorBelt' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4143. ConveyorBelt(const ReaderMapping& reader);
  4144. ^
  4145. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < ConveyorBelt , scripting :: ConveyorBelt >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4146. ExposedObject(S* parent) :
  4147. ^
  4148. src/object/custom_particle_system_file.hpp:38:22: warning: The class 'CustomParticleSystemFile' defines member function with name 'class_name' also defined in its parent class 'CustomParticleSystem'. [duplInheritedMember]
  4149. static std::string class_name() { return "particles-custom-file"; }
  4150. ^
  4151. src/object/custom_particle_system.hpp:44:22: note: Parent function 'CustomParticleSystem::class_name'
  4152. static std::string class_name() { return "particles-custom"; }
  4153. ^
  4154. src/object/custom_particle_system_file.hpp:38:22: note: Derived function 'CustomParticleSystemFile::class_name'
  4155. static std::string class_name() { return "particles-custom-file"; }
  4156. ^
  4157. src/object/custom_particle_system_file.hpp:40:22: warning: The class 'CustomParticleSystemFile' defines member function with name 'display_name' also defined in its parent class 'CustomParticleSystem'. [duplInheritedMember]
  4158. static std::string display_name() { return _("Custom Particles from file"); }
  4159. ^
  4160. src/object/custom_particle_system.hpp:46:22: note: Parent function 'CustomParticleSystem::display_name'
  4161. static std::string display_name() { return _("Custom Particles"); }
  4162. ^
  4163. src/object/custom_particle_system_file.hpp:40:22: note: Derived function 'CustomParticleSystemFile::display_name'
  4164. static std::string display_name() { return _("Custom Particles from file"); }
  4165. ^
  4166. src/object/custom_particle_system_file.hpp:38:22: warning: The class 'CustomParticleSystemFile' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4167. static std::string class_name() { return "particles-custom-file"; }
  4168. ^
  4169. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  4170. static std::string class_name() { return "particle-system"; }
  4171. ^
  4172. src/object/custom_particle_system_file.hpp:38:22: note: Derived function 'CustomParticleSystemFile::class_name'
  4173. static std::string class_name() { return "particles-custom-file"; }
  4174. ^
  4175. src/object/custom_particle_system_file.hpp:40:22: warning: The class 'CustomParticleSystemFile' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4176. static std::string display_name() { return _("Custom Particles from file"); }
  4177. ^
  4178. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  4179. static std::string display_name() { return _("Particle system"); }
  4180. ^
  4181. src/object/custom_particle_system_file.hpp:40:22: note: Derived function 'CustomParticleSystemFile::display_name'
  4182. static std::string display_name() { return _("Custom Particles from file"); }
  4183. ^
  4184. src/object/custom_particle_system_file.hpp:35:3: style: Class 'CustomParticleSystemFile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4185. CustomParticleSystemFile(const ReaderMapping& reader);
  4186. ^
  4187. src/object/custom_particle_system.cpp:816:10: style: Variable 'particle' can be declared as pointer to const [constVariablePointer]
  4188. auto particle = dynamic_cast<CustomParticle*>(custom_particles.at(i).get());
  4189. ^
  4190. src/object/custom_particle_system.cpp:957:20: style: Variable 'solids' can be declared as pointer to const [constVariableReference]
  4191. for (const auto& solids : Sector::get().get_solid_tilemaps()) {
  4192. ^
  4193. src/object/custom_particle_system.cpp:1043:20: style: Variable 'solids' can be declared as pointer to const [constVariableReference]
  4194. for (const auto& solids : Sector::get().get_solid_tilemaps()) {
  4195. ^
  4196. src/object/decal.hpp:39:22: warning: The class 'Decal' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4197. static std::string class_name() { return "decal"; }
  4198. ^
  4199. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4200. static std::string class_name() { return "moving-sprite"; }
  4201. ^
  4202. src/object/decal.hpp:39:22: note: Derived function 'Decal::class_name'
  4203. static std::string class_name() { return "decal"; }
  4204. ^
  4205. src/object/decal.hpp:39:22: warning: The class 'Decal' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4206. static std::string class_name() { return "decal"; }
  4207. ^
  4208. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4209. static std::string class_name() { return "moving-object"; }
  4210. ^
  4211. src/object/decal.hpp:39:22: note: Derived function 'Decal::class_name'
  4212. static std::string class_name() { return "decal"; }
  4213. ^
  4214. src/object/decal.hpp:34:3: style: Class 'Decal' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4215. Decal(const ReaderMapping& reader);
  4216. ^
  4217. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Decal , scripting :: Decal >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4218. ExposedObject(S* parent) :
  4219. ^
  4220. src/object/display_effect.hpp:28:3: style: Class 'DisplayEffect' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4221. DisplayEffect(const std::string& name = "");
  4222. ^
  4223. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < DisplayEffect , scripting :: DisplayEffect >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4224. ExposedObject(S* parent) :
  4225. ^
  4226. src/object/electrifier.cpp:26:14: style: Variable 'tile' can be declared as reference to const [constVariableReference]
  4227. for (auto& tile : change_map) {
  4228. ^
  4229. src/object/electrifier.cpp:36:14: style: Variable 'tile' can be declared as reference to const [constVariableReference]
  4230. for (auto& tile : change_map) {
  4231. ^
  4232. src/object/endsequence_fireworks.hpp:33:16: style: The function 'stopping' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
  4233. virtual void stopping() override; /**< called when EndSequence stops */
  4234. ^
  4235. src/object/endsequence.hpp:50:16: note: Virtual function in base class
  4236. virtual void stopping(); /**< called when EndSequence stops */
  4237. ^
  4238. src/object/endsequence_fireworks.hpp:33:16: note: Function in derived class
  4239. virtual void stopping() override; /**< called when EndSequence stops */
  4240. ^
  4241. src/object/endsequence_fireworks.cpp:52:20: style: Variable 'player' can be declared as pointer to const [constVariableReference]
  4242. for (const auto& player : Sector::get().get_players())
  4243. ^
  4244. src/object/endsequence_walk.hpp:33:16: style: The function 'stopping' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
  4245. virtual void stopping() override; /**< called when EndSequence stops */
  4246. ^
  4247. src/object/endsequence.hpp:50:16: note: Virtual function in base class
  4248. virtual void stopping(); /**< called when EndSequence stops */
  4249. ^
  4250. src/object/endsequence_walk.hpp:33:16: note: Function in derived class
  4251. virtual void stopping() override; /**< called when EndSequence stops */
  4252. ^
  4253. src/object/endsequence_walk.cpp:52:14: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4254. for (auto* player : Sector::get().get_players())
  4255. ^
  4256. src/object/fallblock.hpp:39:22: warning: The class 'FallBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4257. static std::string class_name() { return "fallblock"; }
  4258. ^
  4259. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4260. static std::string class_name() { return "moving-sprite"; }
  4261. ^
  4262. src/object/fallblock.hpp:39:22: note: Derived function 'FallBlock::class_name'
  4263. static std::string class_name() { return "fallblock"; }
  4264. ^
  4265. src/object/fallblock.hpp:39:22: warning: The class 'FallBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4266. static std::string class_name() { return "fallblock"; }
  4267. ^
  4268. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4269. static std::string class_name() { return "moving-object"; }
  4270. ^
  4271. src/object/fallblock.hpp:39:22: note: Derived function 'FallBlock::class_name'
  4272. static std::string class_name() { return "fallblock"; }
  4273. ^
  4274. src/object/fallblock.hpp:30:3: style: Class 'FallBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4275. FallBlock(const ReaderMapping& reader);
  4276. ^
  4277. src/object/fallblock.cpp:99:8: style: Variable 'fallblock' can be declared as pointer to const [constVariablePointer]
  4278. auto fallblock = dynamic_cast<FallBlock*> (&other);
  4279. ^
  4280. src/object/fallblock.cpp:106:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4281. auto player = dynamic_cast<Player*>(&other);
  4282. ^
  4283. src/object/fallblock.cpp:148:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4284. if (auto* player = Sector::get().get_nearest_player(m_col.m_bbox))
  4285. ^
  4286. src/object/weak_block.hpp:34:22: warning: The class 'WeakBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4287. static std::string class_name() { return "weak_block"; }
  4288. ^
  4289. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4290. static std::string class_name() { return "moving-sprite"; }
  4291. ^
  4292. src/object/weak_block.hpp:34:22: note: Derived function 'WeakBlock::class_name'
  4293. static std::string class_name() { return "weak_block"; }
  4294. ^
  4295. src/object/weak_block.hpp:34:22: warning: The class 'WeakBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4296. static std::string class_name() { return "weak_block"; }
  4297. ^
  4298. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4299. static std::string class_name() { return "moving-object"; }
  4300. ^
  4301. src/object/weak_block.hpp:34:22: note: Derived function 'WeakBlock::class_name'
  4302. static std::string class_name() { return "weak_block"; }
  4303. ^
  4304. src/object/weak_block.hpp:29:3: style: Class 'WeakBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4305. WeakBlock(const ReaderMapping& mapping);
  4306. ^
  4307. src/object/firefly.hpp:36:22: warning: The class 'Firefly' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4308. static std::string class_name() { return "firefly"; }
  4309. ^
  4310. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4311. static std::string class_name() { return "moving-sprite"; }
  4312. ^
  4313. src/object/firefly.hpp:36:22: note: Derived function 'Firefly::class_name'
  4314. static std::string class_name() { return "firefly"; }
  4315. ^
  4316. src/object/firefly.hpp:36:22: warning: The class 'Firefly' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4317. static std::string class_name() { return "firefly"; }
  4318. ^
  4319. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4320. static std::string class_name() { return "moving-object"; }
  4321. ^
  4322. src/object/firefly.hpp:36:22: note: Derived function 'Firefly::class_name'
  4323. static std::string class_name() { return "firefly"; }
  4324. ^
  4325. src/object/firefly.hpp:30:3: style: Class 'Firefly' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4326. Firefly(const ReaderMapping& mapping);
  4327. ^
  4328. src/object/firefly.cpp:106:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4329. auto player = dynamic_cast<Player*> (&other);
  4330. ^
  4331. src/object/floating_image.hpp:27:3: style: Class 'FloatingImage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4332. FloatingImage(const std::string& sprite);
  4333. ^
  4334. src/object/ghost_particle_system.hpp:35:22: warning: The class 'GhostParticleSystem' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4335. static std::string class_name() { return "particles-ghosts"; }
  4336. ^
  4337. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  4338. static std::string class_name() { return "particle-system"; }
  4339. ^
  4340. src/object/ghost_particle_system.hpp:35:22: note: Derived function 'GhostParticleSystem::class_name'
  4341. static std::string class_name() { return "particles-ghosts"; }
  4342. ^
  4343. src/object/ghost_particle_system.hpp:37:22: warning: The class 'GhostParticleSystem' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4344. static std::string display_name() { return _("Ghost Particles"); }
  4345. ^
  4346. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  4347. static std::string display_name() { return _("Particle system"); }
  4348. ^
  4349. src/object/ghost_particle_system.hpp:37:22: note: Derived function 'GhostParticleSystem::display_name'
  4350. static std::string display_name() { return _("Ghost Particles"); }
  4351. ^
  4352. src/object/ghost_particle_system.hpp:29:3: style: Class 'GhostParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4353. GhostParticleSystem(const ReaderMapping& reader);
  4354. ^
  4355. src/object/platform.hpp:44:22: warning: The class 'Platform' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4356. static std::string class_name() { return "platform"; }
  4357. ^
  4358. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4359. static std::string class_name() { return "moving-sprite"; }
  4360. ^
  4361. src/object/platform.hpp:44:22: note: Derived function 'Platform::class_name'
  4362. static std::string class_name() { return "platform"; }
  4363. ^
  4364. src/object/platform.hpp:44:22: warning: The class 'Platform' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4365. static std::string class_name() { return "platform"; }
  4366. ^
  4367. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4368. static std::string class_name() { return "moving-object"; }
  4369. ^
  4370. src/object/platform.hpp:44:22: note: Derived function 'Platform::class_name'
  4371. static std::string class_name() { return "platform"; }
  4372. ^
  4373. src/object/hurting_platform.hpp:29:22: warning: The class 'HurtingPlatform' defines member function with name 'class_name' also defined in its parent class 'Platform'. [duplInheritedMember]
  4374. static std::string class_name() { return "hurting_platform"; }
  4375. ^
  4376. src/object/platform.hpp:44:22: note: Parent function 'Platform::class_name'
  4377. static std::string class_name() { return "platform"; }
  4378. ^
  4379. src/object/hurting_platform.hpp:29:22: note: Derived function 'HurtingPlatform::class_name'
  4380. static std::string class_name() { return "hurting_platform"; }
  4381. ^
  4382. src/object/hurting_platform.hpp:31:22: warning: The class 'HurtingPlatform' defines member function with name 'display_name' also defined in its parent class 'Platform'. [duplInheritedMember]
  4383. static std::string display_name() { return _("Hurting Platform"); }
  4384. ^
  4385. src/object/platform.hpp:46:22: note: Parent function 'Platform::display_name'
  4386. static std::string display_name() { return _("Platform"); }
  4387. ^
  4388. src/object/hurting_platform.hpp:31:22: note: Derived function 'HurtingPlatform::display_name'
  4389. static std::string display_name() { return _("Hurting Platform"); }
  4390. ^
  4391. src/object/hurting_platform.hpp:29:22: warning: The class 'HurtingPlatform' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4392. static std::string class_name() { return "hurting_platform"; }
  4393. ^
  4394. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4395. static std::string class_name() { return "moving-sprite"; }
  4396. ^
  4397. src/object/hurting_platform.hpp:29:22: note: Derived function 'HurtingPlatform::class_name'
  4398. static std::string class_name() { return "hurting_platform"; }
  4399. ^
  4400. src/object/hurting_platform.hpp:29:22: warning: The class 'HurtingPlatform' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4401. static std::string class_name() { return "hurting_platform"; }
  4402. ^
  4403. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4404. static std::string class_name() { return "moving-object"; }
  4405. ^
  4406. src/object/hurting_platform.hpp:29:22: note: Derived function 'HurtingPlatform::class_name'
  4407. static std::string class_name() { return "hurting_platform"; }
  4408. ^
  4409. src/object/platform.hpp:32:3: style: Class 'Platform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4410. Platform(const ReaderMapping& reader);
  4411. ^
  4412. src/object/hurting_platform.hpp:26:3: style: Class 'HurtingPlatform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4413. HurtingPlatform(const ReaderMapping& reader);
  4414. ^
  4415. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Platform , scripting :: Platform >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4416. ExposedObject(S* parent) :
  4417. ^
  4418. src/object/infoblock.hpp:35:22: warning: The class 'InfoBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4419. static std::string class_name() { return "infoblock"; }
  4420. ^
  4421. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4422. static std::string class_name() { return "moving-sprite"; }
  4423. ^
  4424. src/object/infoblock.hpp:35:22: note: Derived function 'InfoBlock::class_name'
  4425. static std::string class_name() { return "infoblock"; }
  4426. ^
  4427. src/object/infoblock.hpp:35:22: warning: The class 'InfoBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4428. static std::string class_name() { return "infoblock"; }
  4429. ^
  4430. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4431. static std::string class_name() { return "moving-object"; }
  4432. ^
  4433. src/object/infoblock.hpp:35:22: note: Derived function 'InfoBlock::class_name'
  4434. static std::string class_name() { return "infoblock"; }
  4435. ^
  4436. src/object/infoblock.hpp:29:3: style: Class 'InfoBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4437. InfoBlock(const ReaderMapping& mapping);
  4438. ^
  4439. src/object/infoblock.cpp:112:13: style: Variable 'cam' can be declared as reference to const [constVariableReference]
  4440. Camera& cam = Sector::get().get_singleton_by_type<Camera>();
  4441. ^
  4442. src/object/infoblock.cpp:152:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4443. if (auto* player = get_nearest_player()) {
  4444. ^
  4445. src/object/invisible_block.hpp:28:22: warning: The class 'InvisibleBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4446. static std::string class_name() { return "invisible_block"; }
  4447. ^
  4448. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4449. static std::string class_name() { return "moving-sprite"; }
  4450. ^
  4451. src/object/invisible_block.hpp:28:22: note: Derived function 'InvisibleBlock::class_name'
  4452. static std::string class_name() { return "invisible_block"; }
  4453. ^
  4454. src/object/invisible_block.hpp:28:22: warning: The class 'InvisibleBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4455. static std::string class_name() { return "invisible_block"; }
  4456. ^
  4457. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4458. static std::string class_name() { return "moving-object"; }
  4459. ^
  4460. src/object/invisible_block.hpp:28:22: note: Derived function 'InvisibleBlock::class_name'
  4461. static std::string class_name() { return "invisible_block"; }
  4462. ^
  4463. src/object/invisible_block.hpp:25:3: style: Class 'InvisibleBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4464. InvisibleBlock(const Vector& pos);
  4465. ^
  4466. src/object/invisible_block.hpp:26:3: style: Class 'InvisibleBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4467. InvisibleBlock(const ReaderMapping& mapping);
  4468. ^
  4469. src/object/invisible_block.cpp:68:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4470. auto player = dynamic_cast<Player*> (&other);
  4471. ^
  4472. src/object/invisible_wall.hpp:35:22: warning: The class 'InvisibleWall' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4473. static std::string class_name() { return "invisible_wall"; }
  4474. ^
  4475. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4476. static std::string class_name() { return "moving-object"; }
  4477. ^
  4478. src/object/invisible_wall.hpp:35:22: note: Derived function 'InvisibleWall::class_name'
  4479. static std::string class_name() { return "invisible_wall"; }
  4480. ^
  4481. src/object/invisible_wall.hpp:30:3: style: Class 'InvisibleWall' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4482. InvisibleWall(const ReaderMapping& mapping);
  4483. ^
  4484. src/object/ispy.hpp:33:22: warning: The class 'Ispy' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4485. static std::string class_name() { return "ispy"; }
  4486. ^
  4487. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4488. static std::string class_name() { return "moving-sprite"; }
  4489. ^
  4490. src/object/ispy.hpp:33:22: note: Derived function 'Ispy::class_name'
  4491. static std::string class_name() { return "ispy"; }
  4492. ^
  4493. src/object/ispy.hpp:33:22: warning: The class 'Ispy' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4494. static std::string class_name() { return "ispy"; }
  4495. ^
  4496. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4497. static std::string class_name() { return "moving-object"; }
  4498. ^
  4499. src/object/ispy.hpp:33:22: note: Derived function 'Ispy::class_name'
  4500. static std::string class_name() { return "ispy"; }
  4501. ^
  4502. src/object/ispy.hpp:28:3: style: Class 'Ispy' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4503. Ispy(const ReaderMapping& mapping);
  4504. ^
  4505. src/object/key.hpp:36:22: warning: The class 'Key' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4506. static std::string class_name() { return "key"; }
  4507. ^
  4508. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4509. static std::string class_name() { return "moving-sprite"; }
  4510. ^
  4511. src/object/key.hpp:36:22: note: Derived function 'Key::class_name'
  4512. static std::string class_name() { return "key"; }
  4513. ^
  4514. src/object/key.hpp:36:22: warning: The class 'Key' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4515. static std::string class_name() { return "key"; }
  4516. ^
  4517. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4518. static std::string class_name() { return "moving-object"; }
  4519. ^
  4520. src/object/key.hpp:36:22: note: Derived function 'Key::class_name'
  4521. static std::string class_name() { return "key"; }
  4522. ^
  4523. src/trigger/door.hpp:29:22: warning: The class 'Door' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4524. static std::string class_name() { return "door"; }
  4525. ^
  4526. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4527. static std::string class_name() { return "moving-sprite"; }
  4528. ^
  4529. src/trigger/door.hpp:29:22: note: Derived function 'Door::class_name'
  4530. static std::string class_name() { return "door"; }
  4531. ^
  4532. src/trigger/door.hpp:29:22: warning: The class 'Door' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4533. static std::string class_name() { return "door"; }
  4534. ^
  4535. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4536. static std::string class_name() { return "moving-object"; }
  4537. ^
  4538. src/trigger/door.hpp:29:22: note: Derived function 'Door::class_name'
  4539. static std::string class_name() { return "door"; }
  4540. ^
  4541. src/object/key.hpp:30:3: style: Class 'Key' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4542. Key(const ReaderMapping& reader);
  4543. ^
  4544. src/trigger/trigger_base.hpp:70:3: style: Class 'Trigger' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4545. Trigger(const ReaderMapping& reader);
  4546. ^
  4547. src/trigger/door.hpp:27:3: style: Class 'Door' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4548. Door(const ReaderMapping& reader);
  4549. ^
  4550. src/object/level_time.hpp:33:3: style: Class 'LevelTime' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4551. LevelTime(const ReaderMapping& reader);
  4552. ^
  4553. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < LevelTime , scripting :: LevelTime >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4554. ExposedObject(S* parent) :
  4555. ^
  4556. src/object/light.hpp:28:3: style: Class 'Light' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4557. Light(const Vector& center, const Color& color = Color(1.0, 1.0, 1.0, 1.0));
  4558. ^
  4559. src/object/lit_object.hpp:38:22: warning: The class 'LitObject' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4560. static std::string class_name() { return "lit-object"; }
  4561. ^
  4562. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4563. static std::string class_name() { return "moving-sprite"; }
  4564. ^
  4565. src/object/lit_object.hpp:38:22: note: Derived function 'LitObject::class_name'
  4566. static std::string class_name() { return "lit-object"; }
  4567. ^
  4568. src/object/lit_object.cpp:100:12: warning: The class 'LitObject' defines member function with name 'get_action' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4569. LitObject::get_action() const
  4570. ^
  4571. src/object/moving_sprite.hpp:70:22: note: Parent function 'MovingSprite::get_action'
  4572. const std::string& get_action() const { return m_sprite->get_action(); }
  4573. ^
  4574. src/object/lit_object.cpp:100:12: note: Derived function 'LitObject::get_action'
  4575. LitObject::get_action() const
  4576. ^
  4577. src/object/lit_object.hpp:38:22: warning: The class 'LitObject' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4578. static std::string class_name() { return "lit-object"; }
  4579. ^
  4580. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4581. static std::string class_name() { return "moving-object"; }
  4582. ^
  4583. src/object/lit_object.hpp:38:22: note: Derived function 'LitObject::class_name'
  4584. static std::string class_name() { return "lit-object"; }
  4585. ^
  4586. src/object/lit_object.hpp:31:3: style: Class 'LitObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4587. LitObject(const ReaderMapping& reader);
  4588. ^
  4589. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < LitObject , scripting :: LitObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4590. ExposedObject(S* parent) :
  4591. ^
  4592. src/object/magicblock.hpp:40:22: warning: The class 'MagicBlock' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4593. static std::string class_name() { return "magicblock"; }
  4594. ^
  4595. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4596. static std::string class_name() { return "moving-sprite"; }
  4597. ^
  4598. src/object/magicblock.hpp:40:22: note: Derived function 'MagicBlock::class_name'
  4599. static std::string class_name() { return "magicblock"; }
  4600. ^
  4601. src/object/magicblock.hpp:40:22: warning: The class 'MagicBlock' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4602. static std::string class_name() { return "magicblock"; }
  4603. ^
  4604. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4605. static std::string class_name() { return "moving-object"; }
  4606. ^
  4607. src/object/magicblock.hpp:40:22: note: Derived function 'MagicBlock::class_name'
  4608. static std::string class_name() { return "magicblock"; }
  4609. ^
  4610. src/object/magicblock.hpp:34:3: style: Class 'MagicBlock' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4611. MagicBlock(const ReaderMapping& reader);
  4612. ^
  4613. src/object/music_object.hpp:33:3: style: Class 'MusicObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4614. MusicObject(const ReaderMapping& mapping);
  4615. ^
  4616. src/object/moving_sprite.hpp:103:16: style: Virtual function 'update_hitbox' is called from constructor 'MovingSprite(const glm::vec2&pos,const std::string&sprite_name,int layer=LAYER_OBJECTS,CollisionGroup collision_group=COLGROUP_MOVING)' at line 41. Dynamic binding is not used. [virtualCallInConstructor]
  4617. virtual void update_hitbox();
  4618. ^
  4619. src/object/moving_sprite.cpp:41:3: note: Calling update_hitbox
  4620. update_hitbox();
  4621. ^
  4622. src/object/moving_sprite.hpp:103:16: note: update_hitbox is a virtual function
  4623. virtual void update_hitbox();
  4624. ^
  4625. src/object/moving_sprite.hpp:103:16: style: Virtual function 'update_hitbox' is called from constructor 'MovingSprite(const ReaderMapping&reader,const glm::vec2&pos,int layer=LAYER_OBJECTS,CollisionGroup collision_group=COLGROUP_MOVING)' at line 46. Dynamic binding is not used. [virtualCallInConstructor]
  4626. virtual void update_hitbox();
  4627. ^
  4628. src/object/moving_sprite.cpp:46:3: note: Calling MovingSprite
  4629. MovingSprite(reader, layer_, collision_group)
  4630. ^
  4631. src/object/moving_sprite.cpp:91:3: note: Calling update_hitbox
  4632. update_hitbox();
  4633. ^
  4634. src/object/moving_sprite.hpp:103:16: note: update_hitbox is a virtual function
  4635. virtual void update_hitbox();
  4636. ^
  4637. src/object/moving_sprite.hpp:103:16: style: Virtual function 'update_hitbox' is called from constructor 'MovingSprite(const ReaderMapping&reader,const std::string&sprite_name,int layer=LAYER_OBJECTS,CollisionGroup collision_group=COLGROUP_MOVING)' at line 66. Dynamic binding is not used. [virtualCallInConstructor]
  4638. virtual void update_hitbox();
  4639. ^
  4640. src/object/moving_sprite.cpp:66:33: note: Calling change_sprite
  4641. if (m_sprite_name.empty() || !change_sprite(m_sprite_name))
  4642. ^
  4643. src/object/moving_sprite.cpp:182:3: note: Calling update_hitbox
  4644. update_hitbox();
  4645. ^
  4646. src/object/moving_sprite.hpp:103:16: note: update_hitbox is a virtual function
  4647. virtual void update_hitbox();
  4648. ^
  4649. src/object/moving_sprite.hpp:103:16: style: Virtual function 'update_hitbox' is called from constructor 'MovingSprite(const ReaderMapping&reader,const std::string&sprite_name,int layer=LAYER_OBJECTS,CollisionGroup collision_group=COLGROUP_MOVING)' at line 68. Dynamic binding is not used. [virtualCallInConstructor]
  4650. virtual void update_hitbox();
  4651. ^
  4652. src/object/moving_sprite.cpp:68:5: note: Calling change_sprite
  4653. change_sprite(m_default_sprite_name);
  4654. ^
  4655. src/object/moving_sprite.cpp:182:3: note: Calling update_hitbox
  4656. update_hitbox();
  4657. ^
  4658. src/object/moving_sprite.hpp:103:16: note: update_hitbox is a virtual function
  4659. virtual void update_hitbox();
  4660. ^
  4661. src/object/moving_sprite.hpp:103:16: style: Virtual function 'update_hitbox' is called from constructor 'MovingSprite(const ReaderMapping&reader,int layer=LAYER_OBJECTS,CollisionGroup collision_group=COLGROUP_MOVING)' at line 91. Dynamic binding is not used. [virtualCallInConstructor]
  4662. virtual void update_hitbox();
  4663. ^
  4664. src/object/moving_sprite.cpp:91:3: note: Calling update_hitbox
  4665. update_hitbox();
  4666. ^
  4667. src/object/moving_sprite.hpp:103:16: note: update_hitbox is a virtual function
  4668. virtual void update_hitbox();
  4669. ^
  4670. src/object/oneup.cpp:43:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4671. auto player = dynamic_cast<Player*> (&other);
  4672. ^
  4673. src/object/particles.cpp:108:11: style: Variable 'camera' can be declared as reference to const [constVariableReference]
  4674. Camera& camera = Sector::get().get_camera();
  4675. ^
  4676. src/object/particlesystem_interactive.cpp:126:20: style: Variable 'solids' can be declared as pointer to const [constVariableReference]
  4677. for (const auto& solids : Sector::get().get_solid_tilemaps()) {
  4678. ^
  4679. src/object/path_object.cpp:120:8: style: Variable 'path_gameobject' can be declared as pointer to const [constVariablePointer]
  4680. auto path_gameobject = get_path_gameobject();
  4681. ^
  4682. src/object/path_walker.cpp:96:10: style: Variable 'current_node' can be declared as pointer to const [constVariablePointer]
  4683. auto current_node = & (path->m_nodes[m_current_node_nr]);
  4684. ^
  4685. src/object/path_walker.cpp:151:9: style: Variable 'path' can be declared as pointer to const [constVariablePointer]
  4686. Path* path = get_path();
  4687. ^
  4688. src/object/platform.cpp:111:17: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4689. if (auto* player = Sector::get().get_nearest_player(m_col.m_bbox)) {
  4690. ^
  4691. src/object/pneumatic_platform.hpp:56:3: style: Class 'PneumaticPlatform' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4692. PneumaticPlatform(const ReaderMapping& mapping);
  4693. ^
  4694. src/object/pneumatic_platform.hpp:69:16: style: The function 'after_editor_set' overrides a function in a base class but just delegates back to the base class. [uselessOverride]
  4695. virtual void after_editor_set() override;
  4696. ^
  4697. src/supertux/game_object.hpp:125:16: note: Virtual function in base class
  4698. virtual void after_editor_set();
  4699. ^
  4700. src/object/pneumatic_platform.hpp:69:16: note: Function in derived class
  4701. virtual void after_editor_set() override;
  4702. ^
  4703. src/object/pneumatic_platform.cpp:57:8: style: Variable 'pl' can be declared as pointer to const [constVariablePointer]
  4704. auto pl = dynamic_cast<Player*>(mo);
  4705. ^
  4706. src/object/powerup.cpp:259:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4707. if (auto* player = Sector::get().get_nearest_player(m_col.m_bbox))
  4708. ^
  4709. src/trigger/climbable.hpp:44:22: warning: The class 'Climbable' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4710. static std::string class_name() { return "climbable"; }
  4711. ^
  4712. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4713. static std::string class_name() { return "moving-object"; }
  4714. ^
  4715. src/trigger/climbable.hpp:44:22: note: Derived function 'Climbable::class_name'
  4716. static std::string class_name() { return "climbable"; }
  4717. ^
  4718. src/trigger/climbable.hpp:41:3: style: Class 'Climbable' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4719. Climbable(const ReaderMapping& reader);
  4720. ^
  4721. src/object/player.cpp:1914:9: style: The statement 'if (m_does_buttjump) m_does_buttjump=false' is logically equivalent to 'm_does_buttjump=false'. [duplicateConditionalAssign]
  4722. if (m_does_buttjump) m_does_buttjump = false;
  4723. ^
  4724. src/object/player.cpp:1914:42: note: Assignment 'm_does_buttjump=false'
  4725. if (m_does_buttjump) m_does_buttjump = false;
  4726. ^
  4727. src/object/player.cpp:1914:9: note: Condition 'm_does_buttjump' is redundant
  4728. if (m_does_buttjump) m_does_buttjump = false;
  4729. ^
  4730. src/object/player.cpp:1675:12: style: Condition '!m_sliding' is always true [knownConditionTrueFalse]
  4731. else if (!m_sliding && (m_coyote_timer.started()) && !m_skidding_timer.started() &&
  4732. ^
  4733. src/object/player.cpp:1670:7: note: Assuming that condition 'm_sliding' is not redundant
  4734. if (m_sliding)
  4735. ^
  4736. src/object/player.cpp:1675:12: note: Condition '!m_sliding' is always true
  4737. else if (!m_sliding && (m_coyote_timer.started()) && !m_skidding_timer.started() &&
  4738. ^
  4739. src/object/player.cpp:328:10: style: Variable 'grabbed_game_object' can be declared as pointer to const [constVariablePointer]
  4740. auto grabbed_game_object = dynamic_cast<GameObject*>(m_grabbed_object);
  4741. ^
  4742. src/object/player.cpp:333:13: style: Variable 'key' can be declared as pointer to const [constVariablePointer]
  4743. for (Key* key : m_collected_keys)
  4744. ^
  4745. src/object/player.cpp:2317:8: style: Variable 'bullet' can be declared as pointer to const [constVariablePointer]
  4746. auto bullet = dynamic_cast<Bullet*> (&other);
  4747. ^
  4748. src/object/player.cpp:2322:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4749. auto player = dynamic_cast<Player*> (&other);
  4750. ^
  4751. src/object/player.cpp:2331:8: style: Variable 'moving_object' can be declared as pointer to const [constVariablePointer]
  4752. auto moving_object = static_cast<MovingObject*> (&other);
  4753. ^
  4754. src/object/player.cpp:2342:8: style: Variable 'badguy' can be declared as pointer to const [constVariablePointer]
  4755. auto badguy = dynamic_cast<BadGuy*> (&other);
  4756. ^
  4757. src/object/player.cpp:2414:11: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  4758. auto* session = GameSession::current();
  4759. ^
  4760. src/object/player.cpp:2782:12: style: Variable 'object' can be declared as pointer to const [constVariablePointer]
  4761. if (auto object = dynamic_cast<GameObject*>(m_grabbed_object))
  4762. ^
  4763. src/object/player.cpp:2796:35: style: Parameter 'gameobject' can be declared as pointer to const [constParameterPointer]
  4764. Player::ungrab_object(GameObject* gameobject)
  4765. ^
  4766. src/object/player.cpp:2819:11: style: Variable 'first' can be declared as pointer to const [constVariablePointer]
  4767. Player* first = nullptr;
  4768. ^
  4769. src/object/player.cpp:2860:11: style: Variable 'last' can be declared as pointer to const [constVariablePointer]
  4770. Player* last = nullptr;
  4771. ^
  4772. src/object/pulsing_light.hpp:28:3: style: Class 'PulsingLight' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4773. PulsingLight(const Vector& center, float cycle_len = 5.0, float min_alpha = 0.0, float max_alpha = 1.0, const Color& color = Color(1.0, 1.0, 1.0, 1.0));
  4774. ^
  4775. src/object/pushbutton.hpp:30:22: warning: The class 'PushButton' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4776. static std::string class_name() { return "pushbutton"; }
  4777. ^
  4778. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4779. static std::string class_name() { return "moving-sprite"; }
  4780. ^
  4781. src/object/pushbutton.hpp:30:22: note: Derived function 'PushButton::class_name'
  4782. static std::string class_name() { return "pushbutton"; }
  4783. ^
  4784. src/object/pushbutton.hpp:30:22: warning: The class 'PushButton' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4785. static std::string class_name() { return "pushbutton"; }
  4786. ^
  4787. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4788. static std::string class_name() { return "moving-object"; }
  4789. ^
  4790. src/object/pushbutton.hpp:30:22: note: Derived function 'PushButton::class_name'
  4791. static std::string class_name() { return "pushbutton"; }
  4792. ^
  4793. src/object/pushbutton.hpp:26:3: style: Class 'PushButton' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4794. PushButton(const ReaderMapping& reader);
  4795. ^
  4796. src/object/rain_particle_system.hpp:39:22: warning: The class 'RainParticleSystem' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4797. static std::string class_name() { return "particles-rain"; }
  4798. ^
  4799. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  4800. static std::string class_name() { return "particle-system"; }
  4801. ^
  4802. src/object/rain_particle_system.hpp:39:22: note: Derived function 'RainParticleSystem::class_name'
  4803. static std::string class_name() { return "particles-rain"; }
  4804. ^
  4805. src/object/rain_particle_system.hpp:41:22: warning: The class 'RainParticleSystem' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4806. static std::string display_name() { return _("Rain Particles"); }
  4807. ^
  4808. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  4809. static std::string display_name() { return _("Particle system"); }
  4810. ^
  4811. src/object/rain_particle_system.hpp:41:22: note: Derived function 'RainParticleSystem::display_name'
  4812. static std::string display_name() { return _("Rain Particles"); }
  4813. ^
  4814. src/object/rain_particle_system.hpp:31:3: style: Class 'RainParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4815. RainParticleSystem(const ReaderMapping& reader);
  4816. ^
  4817. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < RainParticleSystem , scripting :: Rain >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4818. ExposedObject(S* parent) :
  4819. ^
  4820. src/object/pushbutton.cpp:85:8: style: Variable 'rock' can be declared as pointer to const [constVariablePointer]
  4821. auto rock = dynamic_cast<Rock*>(&other);
  4822. ^
  4823. src/object/lit_object.hpp:50:22: warning: The class 'LitObject' defines member function with name 'get_action' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4824. const std::string& get_action() const;
  4825. ^
  4826. src/object/moving_sprite.hpp:70:22: note: Parent function 'MovingSprite::get_action'
  4827. const std::string& get_action() const { return m_sprite->get_action(); }
  4828. ^
  4829. src/object/lit_object.hpp:50:22: note: Derived function 'LitObject::get_action'
  4830. const std::string& get_action() const;
  4831. ^
  4832. src/object/rock.cpp:126:8: style: Variable 'heavy_coin' can be declared as pointer to const [constVariablePointer]
  4833. auto heavy_coin = dynamic_cast<HeavyCoin*> (&other);
  4834. ^
  4835. src/object/rock.cpp:131:8: style: Variable 'explosion' can be declared as pointer to const [constVariablePointer]
  4836. auto explosion = dynamic_cast<Explosion*> (&other);
  4837. ^
  4838. src/object/rock.cpp:138:8: style: Variable 'litobject' can be declared as pointer to const [constVariablePointer]
  4839. auto litobject = dynamic_cast<LitObject*> (&other);
  4840. ^
  4841. src/object/rock.cpp:143:8: style: Variable 'pushbutton' can be declared as pointer to const [constVariablePointer]
  4842. auto pushbutton = dynamic_cast<PushButton*> (&other);
  4843. ^
  4844. src/object/rock.cpp:152:8: style: Variable 'crusher' can be declared as pointer to const [constVariablePointer]
  4845. auto crusher = dynamic_cast<Crusher*> (&other);
  4846. ^
  4847. src/object/rock.cpp:163:8: style: Variable 'rock' can be declared as pointer to const [constVariablePointer]
  4848. auto rock = dynamic_cast<Rock*> (&other);
  4849. ^
  4850. src/object/rublight.hpp:32:22: warning: The class 'RubLight' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4851. static std::string class_name() { return "rublight"; }
  4852. ^
  4853. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4854. static std::string class_name() { return "moving-sprite"; }
  4855. ^
  4856. src/object/rublight.hpp:32:22: note: Derived function 'RubLight::class_name'
  4857. static std::string class_name() { return "rublight"; }
  4858. ^
  4859. src/object/rublight.hpp:32:22: warning: The class 'RubLight' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4860. static std::string class_name() { return "rublight"; }
  4861. ^
  4862. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4863. static std::string class_name() { return "moving-object"; }
  4864. ^
  4865. src/object/rublight.hpp:32:22: note: Derived function 'RubLight::class_name'
  4866. static std::string class_name() { return "rublight"; }
  4867. ^
  4868. src/object/rublight.hpp:27:3: style: Class 'RubLight' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4869. RubLight(const ReaderMapping& mapping);
  4870. ^
  4871. src/object/rublight.cpp:68:11: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4872. Player* player = dynamic_cast<Player*>(&other);
  4873. ^
  4874. src/object/rublight.cpp:85:18: style: Variable 'obj' can be declared as pointer to const [constVariablePointer]
  4875. WalkingBadguy* obj = dynamic_cast<WalkingBadguy*>(&other);
  4876. ^
  4877. src/object/rusty_trampoline.hpp:38:22: warning: The class 'RustyTrampoline' defines member function with name 'class_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  4878. static std::string class_name() { return "rustytrampoline"; }
  4879. ^
  4880. src/object/rock.hpp:41:22: note: Parent function 'Rock::class_name'
  4881. static std::string class_name() { return "rock"; }
  4882. ^
  4883. src/object/rusty_trampoline.hpp:38:22: note: Derived function 'RustyTrampoline::class_name'
  4884. static std::string class_name() { return "rustytrampoline"; }
  4885. ^
  4886. src/object/rusty_trampoline.hpp:40:22: warning: The class 'RustyTrampoline' defines member function with name 'display_name' also defined in its parent class 'Rock'. [duplInheritedMember]
  4887. static std::string display_name() { return _("Rusty Trampoline"); }
  4888. ^
  4889. src/object/rock.hpp:43:22: note: Parent function 'Rock::display_name'
  4890. static std::string display_name() { return _("Rock"); }
  4891. ^
  4892. src/object/rusty_trampoline.hpp:40:22: note: Derived function 'RustyTrampoline::display_name'
  4893. static std::string display_name() { return _("Rusty Trampoline"); }
  4894. ^
  4895. src/object/rusty_trampoline.hpp:38:22: warning: The class 'RustyTrampoline' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4896. static std::string class_name() { return "rustytrampoline"; }
  4897. ^
  4898. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4899. static std::string class_name() { return "moving-sprite"; }
  4900. ^
  4901. src/object/rusty_trampoline.hpp:38:22: note: Derived function 'RustyTrampoline::class_name'
  4902. static std::string class_name() { return "rustytrampoline"; }
  4903. ^
  4904. src/object/rusty_trampoline.hpp:38:22: warning: The class 'RustyTrampoline' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4905. static std::string class_name() { return "rustytrampoline"; }
  4906. ^
  4907. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4908. static std::string class_name() { return "moving-object"; }
  4909. ^
  4910. src/object/rusty_trampoline.hpp:38:22: note: Derived function 'RustyTrampoline::class_name'
  4911. static std::string class_name() { return "rustytrampoline"; }
  4912. ^
  4913. src/object/rusty_trampoline.hpp:29:3: style: Class 'RustyTrampoline' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4914. RustyTrampoline(const ReaderMapping& reader);
  4915. ^
  4916. src/object/scripted_object.hpp:38:22: warning: The class 'ScriptedObject' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  4917. static std::string class_name() { return "scriptedobject"; }
  4918. ^
  4919. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  4920. static std::string class_name() { return "moving-sprite"; }
  4921. ^
  4922. src/object/scripted_object.hpp:38:22: note: Derived function 'ScriptedObject::class_name'
  4923. static std::string class_name() { return "scriptedobject"; }
  4924. ^
  4925. src/object/scripted_object.hpp:38:22: warning: The class 'ScriptedObject' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4926. static std::string class_name() { return "scriptedobject"; }
  4927. ^
  4928. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4929. static std::string class_name() { return "moving-object"; }
  4930. ^
  4931. src/object/scripted_object.hpp:38:22: note: Derived function 'ScriptedObject::class_name'
  4932. static std::string class_name() { return "scriptedobject"; }
  4933. ^
  4934. src/object/scripted_object.hpp:30:3: style: Class 'ScriptedObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4935. ScriptedObject(const ReaderMapping& mapping);
  4936. ^
  4937. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < ScriptedObject , scripting :: ScriptedObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4938. ExposedObject(S* parent) :
  4939. ^
  4940. src/object/scripted_object.cpp:201:8: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  4941. auto player = dynamic_cast<Player*> (&other);
  4942. ^
  4943. src/object/smoke_cloud.hpp:28:3: style: Class 'SmokeCloud' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4944. SmokeCloud(const Vector& pos);
  4945. ^
  4946. src/object/shard.cpp:73:8: style: Variable 'shard' can be declared as pointer to const [constVariablePointer]
  4947. auto shard = dynamic_cast<Shard*>(&other);
  4948. ^
  4949. src/object/snow_particle_system.cpp:34:21: warning: Member variable 'SnowParticleSystem::m_wind_speed' is not initialized in the constructor. [uninitMemberVar]
  4950. SnowParticleSystem::SnowParticleSystem() :
  4951. ^
  4952. src/object/snow_particle_system.cpp:34:21: warning: Member variable 'SnowParticleSystem::m_epsilon' is not initialized in the constructor. [uninitMemberVar]
  4953. SnowParticleSystem::SnowParticleSystem() :
  4954. ^
  4955. src/object/snow_particle_system.cpp:34:21: warning: Member variable 'SnowParticleSystem::m_state_length' is not initialized in the constructor. [uninitMemberVar]
  4956. SnowParticleSystem::SnowParticleSystem() :
  4957. ^
  4958. src/object/snow_particle_system.hpp:35:22: warning: The class 'SnowParticleSystem' defines member function with name 'class_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4959. static std::string class_name() { return "particles-snow"; }
  4960. ^
  4961. src/object/particlesystem.hpp:56:22: note: Parent function 'ParticleSystem::class_name'
  4962. static std::string class_name() { return "particle-system"; }
  4963. ^
  4964. src/object/snow_particle_system.hpp:35:22: note: Derived function 'SnowParticleSystem::class_name'
  4965. static std::string class_name() { return "particles-snow"; }
  4966. ^
  4967. src/object/snow_particle_system.hpp:37:22: warning: The class 'SnowParticleSystem' defines member function with name 'display_name' also defined in its parent class 'ParticleSystem'. [duplInheritedMember]
  4968. static std::string display_name() { return _("Snow Particles"); }
  4969. ^
  4970. src/object/particlesystem.hpp:58:22: note: Parent function 'ParticleSystem::display_name'
  4971. static std::string display_name() { return _("Particle system"); }
  4972. ^
  4973. src/object/snow_particle_system.hpp:37:22: note: Derived function 'SnowParticleSystem::display_name'
  4974. static std::string display_name() { return _("Snow Particles"); }
  4975. ^
  4976. src/object/snow_particle_system.hpp:30:3: style: Class 'SnowParticleSystem' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4977. SnowParticleSystem(const ReaderMapping& reader);
  4978. ^
  4979. src/object/sound_object.hpp:33:3: style: Class 'SoundObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4980. SoundObject(const ReaderMapping& mapping);
  4981. ^
  4982. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < SoundObject , scripting :: SoundObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4983. ExposedObject(S* parent) :
  4984. ^
  4985. src/object/spotlight.hpp:50:22: warning: The class 'Spotlight' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  4986. static std::string class_name() { return "spotlight"; }
  4987. ^
  4988. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  4989. static std::string class_name() { return "moving-object"; }
  4990. ^
  4991. src/object/spotlight.hpp:50:22: note: Derived function 'Spotlight::class_name'
  4992. static std::string class_name() { return "spotlight"; }
  4993. ^
  4994. src/object/spotlight.hpp:42:3: style: Class 'Spotlight' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4995. Spotlight(const ReaderMapping& reader);
  4996. ^
  4997. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Spotlight , scripting :: Spotlight >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  4998. ExposedObject(S* parent) :
  4999. ^
  5000. src/object/sprite_particle.cpp:93:11: style: Variable 'camera' can be declared as reference to const [constVariableReference]
  5001. Camera& camera = Sector::get().get_camera();
  5002. ^
  5003. src/object/star.cpp:47:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  5004. if (auto* player = Sector::get().get_nearest_player (m_col.m_bbox)) {
  5005. ^
  5006. src/object/text_object.hpp:39:3: style: Class 'TextObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5007. TextObject(const std::string& name = "");
  5008. ^
  5009. src/object/text_array_object.hpp:37:3: style: Class 'TextArrayObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5010. TextArrayObject(const std::string& name = "");
  5011. ^
  5012. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < TextObject , scripting :: TextObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5013. ExposedObject(S* parent) :
  5014. ^
  5015. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < TextArrayObject , scripting :: TextArrayObject >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5016. ExposedObject(S* parent) :
  5017. ^
  5018. src/object/text_array_object.cpp:227:11: style: Variable 'text' can be declared as pointer to const [constVariablePointer]
  5019. auto* text = get_current_text_item();
  5020. ^
  5021. src/object/textscroller.hpp:37:3: style: Class 'TextScroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5022. TextScroller(const ReaderMapping& mapping);
  5023. ^
  5024. src/object/textscroller.hpp:38:3: style: Class 'TextScroller' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5025. TextScroller(const ReaderObject& root);
  5026. ^
  5027. src/object/thunderstorm.hpp:36:3: style: Class 'Thunderstorm' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5028. Thunderstorm(const ReaderMapping& reader);
  5029. ^
  5030. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Thunderstorm , scripting :: Thunderstorm >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5031. ExposedObject(S* parent) :
  5032. ^
  5033. src/object/torch.hpp:39:22: warning: The class 'Torch' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5034. static std::string class_name() { return "torch"; }
  5035. ^
  5036. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5037. static std::string class_name() { return "moving-sprite"; }
  5038. ^
  5039. src/object/torch.hpp:39:22: note: Derived function 'Torch::class_name'
  5040. static std::string class_name() { return "torch"; }
  5041. ^
  5042. src/object/torch.hpp:39:22: warning: The class 'Torch' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5043. static std::string class_name() { return "torch"; }
  5044. ^
  5045. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5046. static std::string class_name() { return "moving-object"; }
  5047. ^
  5048. src/object/torch.hpp:39:22: note: Derived function 'Torch::class_name'
  5049. static std::string class_name() { return "torch"; }
  5050. ^
  5051. src/object/torch.hpp:32:3: style: Class 'Torch' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5052. Torch(const ReaderMapping& reader);
  5053. ^
  5054. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Torch , scripting :: Torch >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5055. ExposedObject(S* parent) :
  5056. ^
  5057. src/object/tilemap.cpp:737:16: style: Variable 'curr_set' can be declared as pointer to const [constVariablePointer]
  5058. AutotileSet* curr_set;
  5059. ^
  5060. src/object/tilemap.cpp:787:16: style: Variable 'curr_set' can be declared as pointer to const [constVariablePointer]
  5061. AutotileSet* curr_set = m_tileset->get_autotileset_from_tile(tile);
  5062. ^
  5063. src/object/tilemap.cpp:832:9: style: Variable 'ats' can be declared as pointer to const [constVariablePointer]
  5064. auto* ats = m_tileset->get_autotileset_from_tile(tile);
  5065. ^
  5066. src/object/tilemap.cpp:850:16: style: Variable 'curr_set' can be declared as pointer to const [constVariablePointer]
  5067. AutotileSet* curr_set = m_tileset->get_autotileset_from_tile(current_tile);
  5068. ^
  5069. src/object/trampoline.cpp:96:8: style: Variable 'heavy_coin' can be declared as pointer to const [constVariablePointer]
  5070. auto heavy_coin = dynamic_cast<HeavyCoin*> (&other);
  5071. ^
  5072. src/object/unstable_tile.hpp:40:22: warning: The class 'UnstableTile' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5073. static std::string class_name() { return "unstable_tile"; }
  5074. ^
  5075. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5076. static std::string class_name() { return "moving-sprite"; }
  5077. ^
  5078. src/object/unstable_tile.hpp:40:22: note: Derived function 'UnstableTile::class_name'
  5079. static std::string class_name() { return "unstable_tile"; }
  5080. ^
  5081. src/object/unstable_tile.hpp:40:22: warning: The class 'UnstableTile' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5082. static std::string class_name() { return "unstable_tile"; }
  5083. ^
  5084. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5085. static std::string class_name() { return "moving-object"; }
  5086. ^
  5087. src/object/unstable_tile.hpp:40:22: note: Derived function 'UnstableTile::class_name'
  5088. static std::string class_name() { return "unstable_tile"; }
  5089. ^
  5090. src/object/unstable_tile.hpp:33:3: style: Class 'UnstableTile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5091. UnstableTile(const ReaderMapping& mapping, int type = -1);
  5092. ^
  5093. src/object/unstable_tile.cpp:95:13: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  5094. Player* player = dynamic_cast<Player*>(&other);
  5095. ^
  5096. src/object/wind.hpp:41:22: warning: The class 'Wind' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5097. static std::string class_name() { return "wind"; }
  5098. ^
  5099. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5100. static std::string class_name() { return "moving-object"; }
  5101. ^
  5102. src/object/wind.hpp:41:22: note: Derived function 'Wind::class_name'
  5103. static std::string class_name() { return "wind"; }
  5104. ^
  5105. src/object/wind.hpp:34:3: style: Class 'Wind' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5106. Wind(const ReaderMapping& reader);
  5107. ^
  5108. src/squirrel/exposed_object.hpp:58:3: style: Class 'ExposedObject < Wind , scripting :: Wind >' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5109. ExposedObject(S* parent) :
  5110. ^
  5111. src/physfs/ifile_streambuf.hpp:30:3: style: Class 'IFileStreambuf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5112. IFileStreambuf(const std::string& filename);
  5113. ^
  5114. src/physfs/ofile_stream.hpp:29:3: style: Class 'OFileStream' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5115. OFileStream(const std::string& filename);
  5116. ^
  5117. src/physfs/ofile_streambuf.hpp:27:3: style: Class 'OFileStreambuf' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5118. OFileStreambuf(const std::string& filename);
  5119. ^
  5120. src/scripting/custom_particles.cpp:42:3: style: The scope of the variable 'object' can be reduced. [variableScope]
  5121. SCRIPT_GUARD_VOID;
  5122. ^
  5123. src/scripting/floating_image.hpp:43:3: style: Class 'FloatingImage' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5124. FloatingImage(const std::string& spritefile);
  5125. ^
  5126. src/worldmap/tux.hpp:37:3: style: Class 'Tux' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5127. Tux(WorldMap* worldmap);
  5128. ^
  5129. src/worldmap/worldmap_sector.hpp:43:3: style: Class 'WorldMapSector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5130. WorldMapSector(WorldMap& parent);
  5131. ^
  5132. src/scripting/functions.cpp:362:3: error: Using reference to dangling temporary. [danglingTempReference]
  5133. tux.get_physic().set_velocity_x(tux.get_physic().get_velocity_x()*3);
  5134. ^
  5135. src/scripting/functions.cpp:361:17: note: Assigned to reference.
  5136. ::Player& tux = *(::Sector::get().get_players()[0]); // scripting::Player != ::Player
  5137. ^
  5138. src/scripting/functions.cpp:362:3: note: Using reference to dangling temporary.
  5139. tux.get_physic().set_velocity_x(tux.get_physic().get_velocity_x()*3);
  5140. ^
  5141. src/scripting/functions.cpp:370:3: error: Using reference to dangling temporary. [danglingTempReference]
  5142. tux.m_invincible_timer.start(10000);
  5143. ^
  5144. src/scripting/functions.cpp:369:17: note: Assigned to reference.
  5145. ::Player& tux = *(::Sector::get().get_players()[0]);
  5146. ^
  5147. src/scripting/functions.cpp:370:3: note: Using reference to dangling temporary.
  5148. tux.m_invincible_timer.start(10000);
  5149. ^
  5150. src/scripting/functions.cpp:378:3: error: Using reference to dangling temporary. [danglingTempReference]
  5151. tux.set_ghost_mode(true);
  5152. ^
  5153. src/scripting/functions.cpp:377:17: note: Assigned to reference.
  5154. ::Player& tux = *(::Sector::get().get_players()[0]);
  5155. ^
  5156. src/scripting/functions.cpp:378:3: note: Using reference to dangling temporary.
  5157. tux.set_ghost_mode(true);
  5158. ^
  5159. src/scripting/functions.cpp:386:3: error: Using reference to dangling temporary. [danglingTempReference]
  5160. tux.m_invincible_timer.stop();
  5161. ^
  5162. src/scripting/functions.cpp:385:17: note: Assigned to reference.
  5163. ::Player& tux = *(::Sector::get().get_players()[0]);
  5164. ^
  5165. src/scripting/functions.cpp:386:3: note: Using reference to dangling temporary.
  5166. tux.m_invincible_timer.stop();
  5167. ^
  5168. src/scripting/functions.cpp:387:3: error: Using reference to dangling temporary. [danglingTempReference]
  5169. tux.set_ghost_mode(false);
  5170. ^
  5171. src/scripting/functions.cpp:385:17: note: Assigned to reference.
  5172. ::Player& tux = *(::Sector::get().get_players()[0]);
  5173. ^
  5174. src/scripting/functions.cpp:387:3: note: Using reference to dangling temporary.
  5175. tux.set_ghost_mode(false);
  5176. ^
  5177. src/scripting/functions.cpp:406:52: error: Using reference to dangling temporary. [danglingTempReference]
  5178. log_info << "You are at x " << (static_cast<int>(tux.get_pos().x)) << ", y " << (static_cast<int>(tux.get_pos().y)) << std::endl;
  5179. ^
  5180. src/scripting/functions.cpp:405:17: note: Assigned to reference.
  5181. ::Player& tux = *(::Sector::get().get_players()[0]);
  5182. ^
  5183. src/scripting/functions.cpp:406:52: note: Using reference to dangling temporary.
  5184. log_info << "You are at x " << (static_cast<int>(tux.get_pos().x)) << ", y " << (static_cast<int>(tux.get_pos().y)) << std::endl;
  5185. ^
  5186. src/scripting/functions.cpp:414:3: error: Using reference to dangling temporary. [danglingTempReference]
  5187. tux.move(Vector(
  5188. ^
  5189. src/scripting/functions.cpp:413:17: note: Assigned to reference.
  5190. ::Player& tux = *(::Sector::get().get_players()[0]);
  5191. ^
  5192. src/scripting/functions.cpp:414:3: note: Using reference to dangling temporary.
  5193. tux.move(Vector(
  5194. ^
  5195. src/scripting/functions.cpp:417:12: error: Using reference to dangling temporary. [danglingTempReference]
  5196. Vector(tux.get_pos().x, tux.get_pos().y));
  5197. ^
  5198. src/scripting/functions.cpp:413:17: note: Assigned to reference.
  5199. ::Player& tux = *(::Sector::get().get_players()[0]);
  5200. ^
  5201. src/scripting/functions.cpp:417:12: note: Using reference to dangling temporary.
  5202. Vector(tux.get_pos().x, tux.get_pos().y));
  5203. ^
  5204. src/scripting/functions.cpp:425:3: error: Using reference to dangling temporary. [danglingTempReference]
  5205. tux.move(Vector(
  5206. ^
  5207. src/scripting/functions.cpp:424:17: note: Assigned to reference.
  5208. ::Player& tux = *(::Sector::get().get_players()[0]);
  5209. ^
  5210. src/scripting/functions.cpp:425:3: note: Using reference to dangling temporary.
  5211. tux.move(Vector(
  5212. ^
  5213. src/scripting/functions.cpp:426:15: error: Using reference to dangling temporary. [danglingTempReference]
  5214. tux.get_pos().x + (offset_x*32), tux.get_pos().y - (offset_y*32)));
  5215. ^
  5216. src/scripting/functions.cpp:424:17: note: Assigned to reference.
  5217. ::Player& tux = *(::Sector::get().get_players()[0]);
  5218. ^
  5219. src/scripting/functions.cpp:426:15: note: Using reference to dangling temporary.
  5220. tux.get_pos().x + (offset_x*32), tux.get_pos().y - (offset_y*32)));
  5221. ^
  5222. src/scripting/functions.cpp:428:12: error: Using reference to dangling temporary. [danglingTempReference]
  5223. Vector(tux.get_pos().x, tux.get_pos().y));
  5224. ^
  5225. src/scripting/functions.cpp:424:17: note: Assigned to reference.
  5226. ::Player& tux = *(::Sector::get().get_players()[0]);
  5227. ^
  5228. src/scripting/functions.cpp:428:12: note: Using reference to dangling temporary.
  5229. Vector(tux.get_pos().x, tux.get_pos().y));
  5230. ^
  5231. src/supertux/textscroller_screen.hpp:36:3: style: Class 'TextScrollerScreen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5232. TextScrollerScreen(const std::string& file);
  5233. ^
  5234. src/supertux/title_screen.hpp:41:3: style: Class 'TitleScreen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5235. TitleScreen(Savegame& savegame, bool christmas = false);
  5236. ^
  5237. src/scripting/functions.cpp:405:13: style: The scope of the variable 'tux' can be reduced. [variableScope]
  5238. ::Player& tux = *(::Sector::get().get_players()[0]);
  5239. ^
  5240. src/scripting/functions.cpp:405:13: style: Variable 'tux' can be declared as reference to const [constVariableReference]
  5241. ::Player& tux = *(::Sector::get().get_players()[0]);
  5242. ^
  5243. src/scripting/functions.cpp:85:8: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  5244. auto session = GameSession::current();
  5245. ^
  5246. src/scripting/functions.cpp:107:8: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  5247. auto session = GameSession::current();
  5248. ^
  5249. src/scripting/functions.cpp:129:8: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  5250. auto session = GameSession::current();
  5251. ^
  5252. src/scripting/functions.cpp:141:8: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  5253. auto session = GameSession::current();
  5254. ^
  5255. src/scripting/game_object.hpp:91:3: style: Class 'GameObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5256. GameObject(const ::GameObject& object) :
  5257. ^
  5258. src/scripting/game_object_manager.hpp:39:3: style: Class 'GameObjectManager' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5259. GameObjectManager(::GameObjectManager* parent);
  5260. ^
  5261. src/scripting/sector.hpp:40:3: style: Class 'Sector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5262. Sector(::Sector* parent);
  5263. ^
  5264. src/sdk/discord.cpp:17:0: information: Include file: "config.h" not found. [missingInclude]
  5265. #include "config.h"
  5266. ^
  5267. src/sdk/discord.hpp:20:0: information: Include file: "config.h" not found. [missingInclude]
  5268. #include "config.h"
  5269. ^
  5270. src/scripting/worldmap_sector.hpp:50:3: style: Class 'WorldMapSector' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5271. WorldMapSector(::worldmap::WorldMapSector* parent);
  5272. ^
  5273. src/sdk/integration.cpp:17:0: information: Include file: "config.h" not found. [missingInclude]
  5274. #include "config.h"
  5275. ^
  5276. src/squirrel/squirrel_environment.cpp:115:5: performance: Passing the result of c_str() to a function that takes std::string as argument no. 3 is slow and redundant. [stlcstrParam]
  5277. unexpose_object(m_vm.get_vm(), -1, name.c_str());
  5278. ^
  5279. src/scripting/wrapper.cpp:14127:1: information: Limiting ValueFlow analysis in function 'register_supertux_wrapper' since it is too complex. Please specify --check-level=exhaustive to perform full analysis. [checkLevelNormal]
  5280. {
  5281. ^
  5282. src/squirrel/squirrel_virtual_machine.cpp:38:0: information: Include file: "../../external/squirrel/sqdbg/sqrdbg.h" not found. [missingInclude]
  5283. # include "../../external/squirrel/sqdbg/sqrdbg.h"
  5284. ^
  5285. src/supertux/autotile.cpp:50:14: style: Variable 'l_mask' can be declared as reference to const [constVariableReference]
  5286. for (auto& l_mask : m_masks)
  5287. ^
  5288. src/supertux/autotile.cpp:194:14: style: Variable 'autotile' can be declared as pointer to const [constVariablePointer]
  5289. for (auto* autotile : m_autotiles)
  5290. ^
  5291. src/supertux/autotile.cpp:208:14: style: Variable 'tile' can be declared as pointer to const [constVariableReference]
  5292. for (auto& tile : m_autotiles)
  5293. ^
  5294. src/supertux/autotile.cpp:236:14: style: Variable 'tile' can be declared as pointer to const [constVariablePointer]
  5295. for (auto* tile : m_autotiles)
  5296. ^
  5297. src/supertux/autotile.cpp:264:14: style: Variable 'autotile' can be declared as pointer to const [constVariablePointer]
  5298. for (auto* autotile : m_autotiles)
  5299. ^
  5300. src/supertux/autotile.cpp:285:16: style: Variable 'autotile' can be declared as pointer to const [constVariablePointer]
  5301. for (auto* autotile : m_autotiles)
  5302. ^
  5303. src/supertux/command_line_arguments.cpp:27:0: information: Include file: "version.h" not found. [missingInclude]
  5304. #include "version.h"
  5305. ^
  5306. src/trigger/secretarea_trigger.hpp:34:22: warning: The class 'SecretAreaTrigger' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5307. static std::string class_name() { return "secretarea"; }
  5308. ^
  5309. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5310. static std::string class_name() { return "moving-object"; }
  5311. ^
  5312. src/trigger/secretarea_trigger.hpp:34:22: note: Derived function 'SecretAreaTrigger::class_name'
  5313. static std::string class_name() { return "secretarea"; }
  5314. ^
  5315. src/supertux/player_status_hud.hpp:36:3: style: Class 'PlayerStatusHUD' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5316. PlayerStatusHUD(PlayerStatus& player_status);
  5317. ^
  5318. src/trigger/secretarea_trigger.hpp:32:3: style: Class 'SecretAreaTrigger' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5319. SecretAreaTrigger(const ReaderMapping& reader);
  5320. ^
  5321. src/scripting/wrapper.cpp:70:28: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5322. scripting::AmbientSound* _this = reinterpret_cast<scripting::AmbientSound*> (data);
  5323. ^
  5324. src/scripting/wrapper.cpp:96:28: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5325. scripting::AmbientSound* _this = reinterpret_cast<scripting::AmbientSound*> (data);
  5326. ^
  5327. src/scripting/wrapper.cpp:1185:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5328. scripting::Candle* _this = reinterpret_cast<scripting::Candle*> (data);
  5329. ^
  5330. src/scripting/wrapper.cpp:1278:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5331. scripting::Clouds* _this = reinterpret_cast<scripting::Clouds*> (data);
  5332. ^
  5333. src/scripting/wrapper.cpp:1588:31: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5334. scripting::CustomParticles* _this = reinterpret_cast<scripting::CustomParticles*> (data);
  5335. ^
  5336. src/scripting/wrapper.cpp:5269:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5337. scripting::DisplayEffect* _this = reinterpret_cast<scripting::DisplayEffect*> (data);
  5338. ^
  5339. src/scripting/wrapper.cpp:5420:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5340. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5341. ^
  5342. src/scripting/wrapper.cpp:5481:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5343. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5344. ^
  5345. src/scripting/wrapper.cpp:5507:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5346. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5347. ^
  5348. src/scripting/wrapper.cpp:5563:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5349. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5350. ^
  5351. src/scripting/wrapper.cpp:5619:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5352. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5353. ^
  5354. src/scripting/wrapper.cpp:5675:29: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5355. scripting::FloatingImage* _this = reinterpret_cast<scripting::FloatingImage*> (data);
  5356. ^
  5357. src/scripting/wrapper.cpp:5854:33: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5358. scripting::GameObjectManager* _this = reinterpret_cast<scripting::GameObjectManager*> (data);
  5359. ^
  5360. src/scripting/wrapper.cpp:5880:33: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5361. scripting::GameObjectManager* _this = reinterpret_cast<scripting::GameObjectManager*> (data);
  5362. ^
  5363. src/scripting/wrapper.cpp:5906:33: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5364. scripting::GameObjectManager* _this = reinterpret_cast<scripting::GameObjectManager*> (data);
  5365. ^
  5366. src/scripting/wrapper.cpp:6054:24: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5367. scripting::Gradient* _this = reinterpret_cast<scripting::Gradient*> (data);
  5368. ^
  5369. src/scripting/wrapper.cpp:6448:25: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5370. scripting::LevelTime* _this = reinterpret_cast<scripting::LevelTime*> (data);
  5371. ^
  5372. src/scripting/wrapper.cpp:6511:25: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5373. scripting::LitObject* _this = reinterpret_cast<scripting::LitObject*> (data);
  5374. ^
  5375. src/scripting/wrapper.cpp:6568:25: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5376. scripting::LitObject* _this = reinterpret_cast<scripting::LitObject*> (data);
  5377. ^
  5378. src/scripting/wrapper.cpp:6662:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5379. scripting::ParticleSystem* _this = reinterpret_cast<scripting::ParticleSystem*> (data);
  5380. ^
  5381. src/scripting/wrapper.cpp:6805:24: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5382. scripting::Platform* _this = reinterpret_cast<scripting::Platform*> (data);
  5383. ^
  5384. src/scripting/wrapper.cpp:6936:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5385. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5386. ^
  5387. src/scripting/wrapper.cpp:6993:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5388. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5389. ^
  5390. src/scripting/wrapper.cpp:7184:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5391. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5392. ^
  5393. src/scripting/wrapper.cpp:7270:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5394. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5395. ^
  5396. src/scripting/wrapper.cpp:7546:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5397. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5398. ^
  5399. src/scripting/wrapper.cpp:7577:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5400. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5401. ^
  5402. src/scripting/wrapper.cpp:7603:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5403. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5404. ^
  5405. src/scripting/wrapper.cpp:7664:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5406. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5407. ^
  5408. src/scripting/wrapper.cpp:7690:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5409. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5410. ^
  5411. src/scripting/wrapper.cpp:7751:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5412. scripting::Player* _this = reinterpret_cast<scripting::Player*> (data);
  5413. ^
  5414. src/scripting/wrapper.cpp:7908:20: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5415. scripting::Rain* _this = reinterpret_cast<scripting::Rain*> (data);
  5416. ^
  5417. src/scripting/wrapper.cpp:8088:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5418. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5419. ^
  5420. src/scripting/wrapper.cpp:8115:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5421. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5422. ^
  5423. src/scripting/wrapper.cpp:8212:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5424. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5425. ^
  5426. src/scripting/wrapper.cpp:8238:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5427. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5428. ^
  5429. src/scripting/wrapper.cpp:8299:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5430. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5431. ^
  5432. src/scripting/wrapper.cpp:8325:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5433. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5434. ^
  5435. src/scripting/wrapper.cpp:8381:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5436. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5437. ^
  5438. src/scripting/wrapper.cpp:8437:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5439. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5440. ^
  5441. src/scripting/wrapper.cpp:8493:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5442. scripting::ScriptedObject* _this = reinterpret_cast<scripting::ScriptedObject*> (data);
  5443. ^
  5444. src/scripting/wrapper.cpp:8556:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5445. scripting::Sector* _this = reinterpret_cast<scripting::Sector*> (data);
  5446. ^
  5447. src/scripting/wrapper.cpp:8607:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5448. scripting::Sector* _this = reinterpret_cast<scripting::Sector*> (data);
  5449. ^
  5450. src/scripting/wrapper.cpp:8658:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5451. scripting::Sector* _this = reinterpret_cast<scripting::Sector*> (data);
  5452. ^
  5453. src/scripting/wrapper.cpp:8704:22: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5454. scripting::Sector* _this = reinterpret_cast<scripting::Sector*> (data);
  5455. ^
  5456. src/scripting/wrapper.cpp:8837:27: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5457. scripting::SoundObject* _this = reinterpret_cast<scripting::SoundObject*> (data);
  5458. ^
  5459. src/scripting/wrapper.cpp:9621:26: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5460. scripting::TextObject* _this = reinterpret_cast<scripting::TextObject*> (data);
  5461. ^
  5462. src/scripting/wrapper.cpp:9647:26: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5463. scripting::TextObject* _this = reinterpret_cast<scripting::TextObject*> (data);
  5464. ^
  5465. src/scripting/wrapper.cpp:9703:26: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5466. scripting::TextObject* _this = reinterpret_cast<scripting::TextObject*> (data);
  5467. ^
  5468. src/scripting/wrapper.cpp:9764:26: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5469. scripting::TextObject* _this = reinterpret_cast<scripting::TextObject*> (data);
  5470. ^
  5471. src/scripting/wrapper.cpp:10610:31: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5472. scripting::TextArrayObject* _this = reinterpret_cast<scripting::TextArrayObject*> (data);
  5473. ^
  5474. src/scripting/wrapper.cpp:10636:31: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5475. scripting::TextArrayObject* _this = reinterpret_cast<scripting::TextArrayObject*> (data);
  5476. ^
  5477. src/scripting/wrapper.cpp:10692:31: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5478. scripting::TextArrayObject* _this = reinterpret_cast<scripting::TextArrayObject*> (data);
  5479. ^
  5480. src/scripting/wrapper.cpp:10753:31: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5481. scripting::TextArrayObject* _this = reinterpret_cast<scripting::TextArrayObject*> (data);
  5482. ^
  5483. src/scripting/wrapper.cpp:11248:23: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5484. scripting::TileMap* _this = reinterpret_cast<scripting::TileMap*> (data);
  5485. ^
  5486. src/scripting/wrapper.cpp:11284:23: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5487. scripting::TileMap* _this = reinterpret_cast<scripting::TileMap*> (data);
  5488. ^
  5489. src/scripting/wrapper.cpp:11515:23: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5490. scripting::TileMap* _this = reinterpret_cast<scripting::TileMap*> (data);
  5491. ^
  5492. src/scripting/wrapper.cpp:11578:21: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5493. scripting::Torch* _this = reinterpret_cast<scripting::Torch*> (data);
  5494. ^
  5495. src/scripting/wrapper.cpp:11815:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5496. scripting::WorldMapSector* _this = reinterpret_cast<scripting::WorldMapSector*> (data);
  5497. ^
  5498. src/scripting/wrapper.cpp:11841:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5499. scripting::WorldMapSector* _this = reinterpret_cast<scripting::WorldMapSector*> (data);
  5500. ^
  5501. src/scripting/wrapper.cpp:11962:30: style: Variable '_this' can be declared as pointer to const [constVariablePointer]
  5502. scripting::WorldMapSector* _this = reinterpret_cast<scripting::WorldMapSector*> (data);
  5503. ^
  5504. src/supertux/console.cpp:89:43: style: Parameter 'buffer' can be declared as reference to const [constParameterReference]
  5505. ConsoleBuffer::flush(ConsoleStreamBuffer& buffer)
  5506. ^
  5507. src/worldmap/worldmap_screen.hpp:34:3: style: Class 'WorldMapScreen' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5508. WorldMapScreen(std::unique_ptr<WorldMap> worldmap);
  5509. ^
  5510. src/supertux/game_object_manager.cpp:155:10: error: Reference to local variable returned. [returnReference]
  5511. return tmp;
  5512. ^
  5513. src/supertux/game_object_manager.cpp:153:19: note: Assigned to reference.
  5514. GameObject& tmp = *object;
  5515. ^
  5516. src/supertux/game_object_manager.cpp:155:10: note: Reference to local variable returned.
  5517. return tmp;
  5518. ^
  5519. src/supertux/game_object_manager.cpp:435:51: style: Parameter 'object' can be declared as reference to const [constParameterReference]
  5520. GameObjectManager::save_object_change(GameObject& object, const std::string& data)
  5521. ^
  5522. src/supertux/game_object_manager.cpp:74:17: style: Variable 'object' can be declared as pointer to const [constVariablePointer]
  5523. GameObject* object = get_object_by_name<GameObject>(request.name);
  5524. ^
  5525. src/supertux/game_object_manager.cpp:100:11: style: Variable 'object' can be declared as pointer to const [constVariablePointer]
  5526. auto* object = get_object_by_name<GameObject>(request.name);
  5527. ^
  5528. src/supertux/game_object_manager.cpp:217:12: style: Variable 'tm' can be declared as pointer to const [constVariablePointer]
  5529. auto tm = dynamic_cast<TileMap*>(object.get());
  5530. ^
  5531. src/supertux/game_object_manager.cpp:508:14: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5532. for (auto& tilemap : get_solid_tilemaps())
  5533. ^
  5534. src/supertux/game_object_manager.cpp:518:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5535. for (const auto& tilemap : get_solid_tilemaps())
  5536. ^
  5537. src/supertux/game_object_manager.cpp:528:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5538. for (const auto& tilemap : get_all_tilemaps()) // Determine from all tilemaps
  5539. ^
  5540. src/supertux/game_object_manager.cpp:538:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5541. for (const auto& tilemap : get_all_tilemaps()) // Determine from all tilemaps
  5542. ^
  5543. src/supertux/game_object_manager.cpp:548:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5544. for (const auto& tilemap : get_solid_tilemaps())
  5545. ^
  5546. src/supertux/game_object_manager.cpp:560:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5547. for (const auto& tilemap : get_solid_tilemaps())
  5548. ^
  5549. src/badguy/yeti.hpp:43:8: warning: The class 'Yeti' defines member function with name 'kill_squished' also defined in its parent class 'BadGuy'. [duplInheritedMember]
  5550. void kill_squished(GameObject& object);
  5551. ^
  5552. src/badguy/badguy.hpp:193:8: note: Parent function 'BadGuy::kill_squished'
  5553. void kill_squished(GameObject& object);
  5554. ^
  5555. src/badguy/yeti.hpp:43:8: note: Derived function 'Yeti::kill_squished'
  5556. void kill_squished(GameObject& object);
  5557. ^
  5558. src/trigger/scripttrigger.hpp:27:22: warning: The class 'ScriptTrigger' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5559. static std::string class_name() { return "scripttrigger"; }
  5560. ^
  5561. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5562. static std::string class_name() { return "moving-object"; }
  5563. ^
  5564. src/trigger/scripttrigger.hpp:27:22: note: Derived function 'ScriptTrigger::class_name'
  5565. static std::string class_name() { return "scripttrigger"; }
  5566. ^
  5567. src/trigger/sequence_trigger.hpp:29:22: warning: The class 'SequenceTrigger' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5568. static std::string class_name() { return "sequencetrigger"; }
  5569. ^
  5570. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5571. static std::string class_name() { return "moving-object"; }
  5572. ^
  5573. src/trigger/sequence_trigger.hpp:29:22: note: Derived function 'SequenceTrigger::class_name'
  5574. static std::string class_name() { return "sequencetrigger"; }
  5575. ^
  5576. src/trigger/switch.hpp:28:22: warning: The class 'Switch' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5577. static std::string class_name() { return "switch"; }
  5578. ^
  5579. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5580. static std::string class_name() { return "moving-sprite"; }
  5581. ^
  5582. src/trigger/switch.hpp:28:22: note: Derived function 'Switch::class_name'
  5583. static std::string class_name() { return "switch"; }
  5584. ^
  5585. src/trigger/switch.hpp:28:22: warning: The class 'Switch' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5586. static std::string class_name() { return "switch"; }
  5587. ^
  5588. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5589. static std::string class_name() { return "moving-object"; }
  5590. ^
  5591. src/trigger/switch.hpp:28:22: note: Derived function 'Switch::class_name'
  5592. static std::string class_name() { return "switch"; }
  5593. ^
  5594. src/trigger/text_area.hpp:45:22: warning: The class 'TextArea' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5595. static std::string class_name() { return "text-area"; }
  5596. ^
  5597. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5598. static std::string class_name() { return "moving-object"; }
  5599. ^
  5600. src/trigger/text_area.hpp:45:22: note: Derived function 'TextArea::class_name'
  5601. static std::string class_name() { return "text-area"; }
  5602. ^
  5603. src/worldmap/level_tile.hpp:34:22: warning: The class 'LevelTile' defines member function with name 'class_name' also defined in its parent class 'WorldMapObject'. [duplInheritedMember]
  5604. static std::string class_name() { return "level"; }
  5605. ^
  5606. src/worldmap/worldmap_object.hpp:40:22: note: Parent function 'WorldMapObject::class_name'
  5607. static std::string class_name() { return "worldmap-object"; }
  5608. ^
  5609. src/worldmap/level_tile.hpp:34:22: note: Derived function 'LevelTile::class_name'
  5610. static std::string class_name() { return "level"; }
  5611. ^
  5612. src/worldmap/level_tile.hpp:34:22: warning: The class 'LevelTile' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5613. static std::string class_name() { return "level"; }
  5614. ^
  5615. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5616. static std::string class_name() { return "moving-sprite"; }
  5617. ^
  5618. src/worldmap/level_tile.hpp:34:22: note: Derived function 'LevelTile::class_name'
  5619. static std::string class_name() { return "level"; }
  5620. ^
  5621. src/worldmap/level_tile.hpp:34:22: warning: The class 'LevelTile' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5622. static std::string class_name() { return "level"; }
  5623. ^
  5624. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5625. static std::string class_name() { return "moving-object"; }
  5626. ^
  5627. src/worldmap/level_tile.hpp:34:22: note: Derived function 'LevelTile::class_name'
  5628. static std::string class_name() { return "level"; }
  5629. ^
  5630. src/worldmap/spawn_point.hpp:56:22: warning: The class 'SpawnPointObject' defines member function with name 'class_name' also defined in its parent class 'WorldMapObject'. [duplInheritedMember]
  5631. static std::string class_name() { return "worldmap-spawnpoint"; }
  5632. ^
  5633. src/worldmap/worldmap_object.hpp:40:22: note: Parent function 'WorldMapObject::class_name'
  5634. static std::string class_name() { return "worldmap-object"; }
  5635. ^
  5636. src/worldmap/spawn_point.hpp:56:22: note: Derived function 'SpawnPointObject::class_name'
  5637. static std::string class_name() { return "worldmap-spawnpoint"; }
  5638. ^
  5639. src/worldmap/spawn_point.hpp:56:22: warning: The class 'SpawnPointObject' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5640. static std::string class_name() { return "worldmap-spawnpoint"; }
  5641. ^
  5642. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5643. static std::string class_name() { return "moving-sprite"; }
  5644. ^
  5645. src/worldmap/spawn_point.hpp:56:22: note: Derived function 'SpawnPointObject::class_name'
  5646. static std::string class_name() { return "worldmap-spawnpoint"; }
  5647. ^
  5648. src/worldmap/spawn_point.hpp:56:22: warning: The class 'SpawnPointObject' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5649. static std::string class_name() { return "worldmap-spawnpoint"; }
  5650. ^
  5651. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5652. static std::string class_name() { return "moving-object"; }
  5653. ^
  5654. src/worldmap/spawn_point.hpp:56:22: note: Derived function 'SpawnPointObject::class_name'
  5655. static std::string class_name() { return "worldmap-spawnpoint"; }
  5656. ^
  5657. src/worldmap/special_tile.hpp:34:22: warning: The class 'SpecialTile' defines member function with name 'class_name' also defined in its parent class 'WorldMapObject'. [duplInheritedMember]
  5658. static std::string class_name() { return "special-tile"; }
  5659. ^
  5660. src/worldmap/worldmap_object.hpp:40:22: note: Parent function 'WorldMapObject::class_name'
  5661. static std::string class_name() { return "worldmap-object"; }
  5662. ^
  5663. src/worldmap/special_tile.hpp:34:22: note: Derived function 'SpecialTile::class_name'
  5664. static std::string class_name() { return "special-tile"; }
  5665. ^
  5666. src/worldmap/special_tile.hpp:34:22: warning: The class 'SpecialTile' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5667. static std::string class_name() { return "special-tile"; }
  5668. ^
  5669. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5670. static std::string class_name() { return "moving-sprite"; }
  5671. ^
  5672. src/worldmap/special_tile.hpp:34:22: note: Derived function 'SpecialTile::class_name'
  5673. static std::string class_name() { return "special-tile"; }
  5674. ^
  5675. src/worldmap/special_tile.hpp:34:22: warning: The class 'SpecialTile' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5676. static std::string class_name() { return "special-tile"; }
  5677. ^
  5678. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5679. static std::string class_name() { return "moving-object"; }
  5680. ^
  5681. src/worldmap/special_tile.hpp:34:22: note: Derived function 'SpecialTile::class_name'
  5682. static std::string class_name() { return "special-tile"; }
  5683. ^
  5684. src/worldmap/sprite_change.hpp:33:22: warning: The class 'SpriteChange' defines member function with name 'class_name' also defined in its parent class 'WorldMapObject'. [duplInheritedMember]
  5685. static std::string class_name() { return "sprite-change"; }
  5686. ^
  5687. src/worldmap/worldmap_object.hpp:40:22: note: Parent function 'WorldMapObject::class_name'
  5688. static std::string class_name() { return "worldmap-object"; }
  5689. ^
  5690. src/worldmap/sprite_change.hpp:33:22: note: Derived function 'SpriteChange::class_name'
  5691. static std::string class_name() { return "sprite-change"; }
  5692. ^
  5693. src/worldmap/sprite_change.hpp:33:22: warning: The class 'SpriteChange' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5694. static std::string class_name() { return "sprite-change"; }
  5695. ^
  5696. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5697. static std::string class_name() { return "moving-sprite"; }
  5698. ^
  5699. src/worldmap/sprite_change.hpp:33:22: note: Derived function 'SpriteChange::class_name'
  5700. static std::string class_name() { return "sprite-change"; }
  5701. ^
  5702. src/worldmap/sprite_change.hpp:33:22: warning: The class 'SpriteChange' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5703. static std::string class_name() { return "sprite-change"; }
  5704. ^
  5705. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5706. static std::string class_name() { return "moving-object"; }
  5707. ^
  5708. src/worldmap/sprite_change.hpp:33:22: note: Derived function 'SpriteChange::class_name'
  5709. static std::string class_name() { return "sprite-change"; }
  5710. ^
  5711. src/worldmap/teleporter.hpp:32:22: warning: The class 'Teleporter' defines member function with name 'class_name' also defined in its parent class 'WorldMapObject'. [duplInheritedMember]
  5712. static std::string class_name() { return "teleporter"; }
  5713. ^
  5714. src/worldmap/worldmap_object.hpp:40:22: note: Parent function 'WorldMapObject::class_name'
  5715. static std::string class_name() { return "worldmap-object"; }
  5716. ^
  5717. src/worldmap/teleporter.hpp:32:22: note: Derived function 'Teleporter::class_name'
  5718. static std::string class_name() { return "teleporter"; }
  5719. ^
  5720. src/worldmap/teleporter.hpp:32:22: warning: The class 'Teleporter' defines member function with name 'class_name' also defined in its parent class 'MovingSprite'. [duplInheritedMember]
  5721. static std::string class_name() { return "teleporter"; }
  5722. ^
  5723. src/object/moving_sprite.hpp:51:22: note: Parent function 'MovingSprite::class_name'
  5724. static std::string class_name() { return "moving-sprite"; }
  5725. ^
  5726. src/worldmap/teleporter.hpp:32:22: note: Derived function 'Teleporter::class_name'
  5727. static std::string class_name() { return "teleporter"; }
  5728. ^
  5729. src/worldmap/teleporter.hpp:32:22: warning: The class 'Teleporter' defines member function with name 'class_name' also defined in its parent class 'MovingObject'. [duplInheritedMember]
  5730. static std::string class_name() { return "teleporter"; }
  5731. ^
  5732. src/supertux/moving_object.hpp:100:22: note: Parent function 'MovingObject::class_name'
  5733. static std::string class_name() { return "moving-object"; }
  5734. ^
  5735. src/worldmap/teleporter.hpp:32:22: note: Derived function 'Teleporter::class_name'
  5736. static std::string class_name() { return "teleporter"; }
  5737. ^
  5738. src/trigger/scripttrigger.hpp:25:3: style: Class 'ScriptTrigger' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5739. ScriptTrigger(const ReaderMapping& reader);
  5740. ^
  5741. src/trigger/sequence_trigger.hpp:27:3: style: Class 'SequenceTrigger' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5742. SequenceTrigger(const ReaderMapping& reader);
  5743. ^
  5744. src/trigger/switch.hpp:25:3: style: Class 'Switch' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5745. Switch(const ReaderMapping& reader);
  5746. ^
  5747. src/trigger/text_area.hpp:38:3: style: Class 'TextArea' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5748. TextArea(const ReaderMapping& mapping);
  5749. ^
  5750. src/worldmap/level_tile.hpp:31:3: style: Class 'LevelTile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5751. LevelTile(const ReaderMapping& mapping);
  5752. ^
  5753. src/worldmap/spawn_point.hpp:33:3: style: Class 'SpawnPoint' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5754. SpawnPoint(const ReaderMapping& mapping);
  5755. ^
  5756. src/worldmap/spawn_point.hpp:53:3: style: Class 'SpawnPointObject' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5757. SpawnPointObject(const ReaderMapping& mapping);
  5758. ^
  5759. src/worldmap/special_tile.hpp:31:3: style: Class 'SpecialTile' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5760. SpecialTile(const ReaderMapping& mapping);
  5761. ^
  5762. src/worldmap/sprite_change.hpp:30:3: style: Class 'SpriteChange' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5763. SpriteChange(const ReaderMapping& mapping);
  5764. ^
  5765. src/worldmap/teleporter.hpp:30:3: style: Class 'Teleporter' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5766. Teleporter(const ReaderMapping& mapping);
  5767. ^
  5768. src/supertux/game_object_factory.cpp:237:20: style: Variable 'm_adding_badguys' is reassigned a value before the old one has been used. [redundantAssignment]
  5769. m_adding_badguys = false;
  5770. ^
  5771. src/supertux/game_object_factory.cpp:167:20: note: m_adding_badguys is assigned
  5772. m_adding_badguys = true;
  5773. ^
  5774. src/supertux/game_object_factory.cpp:237:20: note: m_adding_badguys is overwritten
  5775. m_adding_badguys = false;
  5776. ^
  5777. src/supertux/game_session.cpp:410:7: style: The statement 'if (!m_active) m_active=true' is logically equivalent to 'm_active=true'. [duplicateConditionalAssign]
  5778. if (!m_active)
  5779. ^
  5780. src/supertux/game_session.cpp:412:14: note: Assignment 'm_active=true'
  5781. m_active = true;
  5782. ^
  5783. src/supertux/game_session.cpp:410:7: note: Condition '!m_active' is redundant
  5784. if (!m_active)
  5785. ^
  5786. src/supertux/game_session.cpp:496:24: style: Variable 'player' can be declared as pointer to const [constVariableReference]
  5787. for (const auto& player : m_currentsector->get_players())
  5788. ^
  5789. src/supertux/info_box.hpp:34:3: style: Class 'InfoBox' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5790. InfoBox(const std::string& text);
  5791. ^
  5792. src/supertux/level.cpp:213:11: style: Variable 'test' can be declared as pointer to const [constVariablePointer]
  5793. Sector* test = get_sector(sector->get_name());
  5794. ^
  5795. src/supertux/level.cpp:250:12: style: Variable 'coin' can be declared as pointer to const [constVariablePointer]
  5796. auto coin = dynamic_cast<Coin*>(o.get());
  5797. ^
  5798. src/supertux/level.cpp:256:12: style: Variable 'block' can be declared as pointer to const [constVariablePointer]
  5799. auto block = dynamic_cast<BonusBlock*>(o.get());
  5800. ^
  5801. src/supertux/level.cpp:270:12: style: Variable 'goldbomb' can be declared as pointer to const [constVariablePointer]
  5802. auto goldbomb = dynamic_cast<GoldBomb*>(o.get());
  5803. ^
  5804. src/supertux/levelintro.hpp:44:16: style: The function 'setup' overrides a function in a base class but is identical to the overridden function [uselessOverride]
  5805. virtual void setup() override;
  5806. ^
  5807. src/supertux/screen.hpp:41:16: note: Virtual function in base class
  5808. virtual void setup()
  5809. ^
  5810. src/supertux/levelintro.hpp:44:16: note: Function in derived class
  5811. virtual void setup() override;
  5812. ^
  5813. src/supertux/levelset.hpp:30:3: style: Class 'Levelset' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5814. Levelset(const std::string& basedir, bool recursively = false);
  5815. ^
  5816. src/supertux/main.cpp:0:0: information: Too many #ifdef configurations - cppcheck only checks 12 of 15 configurations. Use --force to check all configurations. [toomanyconfigs]
  5817.  
  5818. ^
  5819. src/supertux/menu/addon_preview_menu.hpp:51:3: style: Class 'AddonPreviewMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5820. AddonPreviewMenu(const Addon& addon, bool auto_install = false, bool update = false);
  5821. ^
  5822. src/supertux/menu/download_dialog.hpp:37:3: style: Class 'DownloadDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5823. DownloadDialog(TransferStatusPtr status, bool auto_close = false,
  5824. ^
  5825. src/supertux/menu/download_dialog.hpp:39:3: style: Class 'DownloadDialog' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5826. DownloadDialog(TransferStatusListPtr statuses, bool auto_close = false,
  5827. ^
  5828. src/supertux/menu/addon_browse_menu.cpp:82:14: style: Variable 'installed_addon' can be declared as reference to const [constVariableReference]
  5829. Addon& installed_addon = m_addon_manager.get_installed_addon(addon_id);
  5830. ^
  5831. src/supertux/menu/addon_file_install_menu.hpp:27:3: style: Class 'AddonFileInstallMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5832. AddonFileInstallMenu(AddonMenu* addon_menu);
  5833. ^
  5834. src/supertux/menu/addon_preview_menu.cpp:153:11: style: Condition 'm_auto_install' is always false [knownConditionTrueFalse]
  5835. if (m_auto_install)
  5836. ^
  5837. src/supertux/menu/addon_preview_menu.cpp:136:32: note: Assuming that condition '!m_auto_install' is not redundant
  5838. if (screenshots_available && !m_auto_install)
  5839. ^
  5840. src/supertux/menu/addon_preview_menu.cpp:153:11: note: Condition 'm_auto_install' is always false
  5841. if (m_auto_install)
  5842. ^
  5843. src/supertux/menu/cheat_apply_menu.hpp:27:3: style: Class 'CheatApplyMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5844. CheatApplyMenu(std::function<void(Player&)> callback);
  5845. ^
  5846. src/supertux/menu/cheat_apply_menu.hpp:29:3: style: Class 'CheatApplyMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5847. CheatApplyMenu(std::function<void(Player&, int)> callback);
  5848. ^
  5849. src/supertux/menu/contrib_levelset_menu.hpp:32:3: style: Class 'ContribLevelsetMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5850. ContribLevelsetMenu(std::unique_ptr<World> current_world);
  5851. ^
  5852. src/supertux/menu/custom_menu_menu.cpp:19:0: information: Include file: "config.h" not found. [missingInclude]
  5853. #include "config.h"
  5854. ^
  5855. src/supertux/menu/editor_level_select_menu.hpp:30:3: style: Class 'EditorLevelSelectMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5856. EditorLevelSelectMenu(std::unique_ptr<World> world, EditorLevelsetSelectMenu* levelset_select_menu = nullptr);
  5857. ^
  5858. src/supertux/menu/editor_delete_levelset_menu.hpp:28:3: style: Class 'EditorDeleteLevelsetMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5859. EditorDeleteLevelsetMenu(EditorLevelsetSelectMenu* editor_levelset_select_menu);
  5860. ^
  5861. src/supertux/menu/editor_delete_levelset_menu.cpp:46:20: style: Variable 'level_world' can be declared as reference to const [constVariableReference]
  5862. for(std::string& level_world : contrib_worlds)
  5863. ^
  5864. src/supertux/menu/editor_levelset_menu.hpp:27:3: style: Class 'EditorLevelsetMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5865. EditorLevelsetMenu(World* world_);
  5866. ^
  5867. src/supertux/menu/editor_level_select_menu.cpp:62:10: style: Variable 'world' can be declared as pointer to const [constVariablePointer]
  5868. World* world = get_world();
  5869. ^
  5870. src/supertux/menu/editor_level_select_menu.cpp:131:10: style: Variable 'world' can be declared as pointer to const [constVariablePointer]
  5871. World* world = get_world();
  5872. ^
  5873. src/supertux/menu/editor_level_select_menu.cpp:171:8: style: Variable 'editor' can be declared as pointer to const [constVariablePointer]
  5874. auto editor = Editor::current();
  5875. ^
  5876. src/supertux/menu/editor_save_as.hpp:31:3: style: Class 'EditorSaveAs' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5877. EditorSaveAs(bool do_switch_file);
  5878. ^
  5879. src/supertux/menu/editor_objectgroup_menu.cpp:34:14: style: Variable 'og' can be declared as reference to const [constVariableReference]
  5880. for (auto& og : Editor::current()->get_objectgroups()) {
  5881. ^
  5882. src/supertux/menu/editor_sector_menu.cpp:51:8: style: Variable 'editor' can be declared as pointer to const [constVariablePointer]
  5883. auto editor = Editor::current();
  5884. ^
  5885. src/supertux/menu/editor_sector_menu.cpp:56:8: style: Variable 'level' can be declared as pointer to const [constVariablePointer]
  5886. auto level = editor->get_level();
  5887. ^
  5888. src/supertux/menu/editor_sectors_menu.cpp:87:10: style: Variable 'level' can be declared as pointer to const [constVariablePointer]
  5889. Level* level = Editor::current()->get_level();
  5890. ^
  5891. src/supertux/menu/editor_sectors_menu.cpp:113:12: style: Variable 'level' can be declared as pointer to const [constVariablePointer]
  5892. Level* level = Editor::current()->get_level();
  5893. ^
  5894. src/supertux/menu/editor_sectors_menu.cpp:114:13: style: Variable 'sector' can be declared as pointer to const [constVariablePointer]
  5895. Sector* sector = level->get_sector(item.get_id());
  5896. ^
  5897. src/supertux/menu/editor_tilegroup_menu.cpp:30:14: style: Variable 'tg' can be declared as reference to const [constVariableReference]
  5898. for (auto& tg : Editor::current()->get_tilegroups()) {
  5899. ^
  5900. src/supertux/menu/game_menu.cpp:47:10: style: Variable 'level' can be declared as reference to const [constVariableReference]
  5901. Level& level = GameSession::current()->get_current_level();
  5902. ^
  5903. src/supertux/menu/integrations_menu.cpp:21:0: information: Include file: "config.h" not found. [missingInclude]
  5904. #include "config.h"
  5905. ^
  5906. src/supertux/menu/joystick_menu.hpp:27:3: style: Class 'JoystickMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5907. JoystickMenu(InputManager& input_manager);
  5908. ^
  5909. src/supertux/menu/keyboard_menu.hpp:29:3: style: Class 'KeyboardMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5910. KeyboardMenu(InputManager& input_manager, int player_id = 0);
  5911. ^
  5912. src/supertux/menu/keyboard_menu.cpp:155:19: style: Variable 'kbd_cfg' can be declared as reference to const [constVariableReference]
  5913. KeyboardConfig& kbd_cfg = g_config->keyboard_config;
  5914. ^
  5915. src/supertux/menu/options_select_menu.hpp:28:3: style: Class 'OptionsSelectMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5916. OptionsSelectMenu(bool complete = true);
  5917. ^
  5918. src/supertux/menu/multiplayer_player_menu.hpp:25:3: style: Class 'MultiplayerPlayerMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5919. MultiplayerPlayerMenu(int player_id);
  5920. ^
  5921. src/supertux/menu/options_menu.hpp:56:8: style: Unused private function: 'OptionsMenu::add_mobile_control_scales' [unusedPrivateFunction]
  5922. void add_mobile_control_scales();
  5923. ^
  5924. src/supertux/menu/options_menu.hpp:50:8: style: Unused private function: 'OptionsMenu::add_aspect_ratio' [unusedPrivateFunction]
  5925. void add_aspect_ratio();
  5926. ^
  5927. src/supertux/menu/options_menu.hpp:51:8: style: Unused private function: 'OptionsMenu::add_window_resolutions' [unusedPrivateFunction]
  5928. void add_window_resolutions();
  5929. ^
  5930. src/supertux/menu/options_menu.hpp:52:8: style: Unused private function: 'OptionsMenu::add_resolutions' [unusedPrivateFunction]
  5931. void add_resolutions();
  5932. ^
  5933. src/supertux/menu/profile_name_menu.hpp:27:3: style: Class 'ProfileNameMenu' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  5934. ProfileNameMenu(Profile* profile = nullptr);
  5935. ^
  5936. src/supertux/menu/profile_menu.cpp:159:18: style: Variable 'profile' can be declared as pointer to const [constVariablePointer]
  5937. for (auto* profile : m_profiles)
  5938. ^
  5939. src/supertux/menu/profile_menu.cpp:180:18: style: Variable 'profile' can be declared as pointer to const [constVariablePointer]
  5940. for (auto* profile : m_profiles)
  5941. ^
  5942. src/supertux/menu/sorted_contrib_menu.cpp:29:75: style: Parameter 'worlds' can be declared as reference to const [constParameterReference]
  5943. SortedContribMenu::SortedContribMenu(std::vector<std::unique_ptr<World>>& worlds, const std::string& contrib_type, const std::string& title, const std::string& empty_message) :
  5944. ^
  5945. src/supertux/menu/web_asset_menu.cpp:31:0: information: Include file: "physfs.h" not found. [missingInclude]
  5946. #include "physfs.h"
  5947. ^
  5948. src/supertux/savegame.cpp:426:17: style: Variable 'state' is assigned a value that is never used. [unreadVariable]
  5949. LevelsetState state = get_levelset_state(basedir);
  5950. ^
  5951. src/supertux/sector.cpp:248:5: error: Using reference to dangling temporary. [danglingTempReference]
  5952. player.move(player.get_pos()+Vector(-32, 0));
  5953. ^
  5954. src/supertux/sector.cpp:246:20: note: Assigned to reference.
  5955. Player& player = *(get_players()[0]);
  5956. ^
  5957. src/supertux/sector.cpp:248:5: note: Using reference to dangling temporary.
  5958. player.move(player.get_pos()+Vector(-32, 0));
  5959. ^
  5960. src/supertux/sector.cpp:249:18: error: Using reference to dangling temporary. [danglingTempReference]
  5961. camera.reset(player.get_pos());
  5962. ^
  5963. src/supertux/sector.cpp:246:20: note: Assigned to reference.
  5964. Player& player = *(get_players()[0]);
  5965. ^
  5966. src/supertux/sector.cpp:249:18: note: Using reference to dangling temporary.
  5967. camera.reset(player.get_pos());
  5968. ^
  5969. src/supertux/sector.cpp:251:5: error: Using reference to dangling temporary. [danglingTempReference]
  5970. player.move(player.get_pos()+(Vector(32, 0)));
  5971. ^
  5972. src/supertux/sector.cpp:246:20: note: Assigned to reference.
  5973. Player& player = *(get_players()[0]);
  5974. ^
  5975. src/supertux/sector.cpp:251:5: note: Using reference to dangling temporary.
  5976. player.move(player.get_pos()+(Vector(32, 0)));
  5977. ^
  5978. src/supertux/sector.cpp:297:11: style: Variable 'camera' can be declared as reference to const [constVariableReference]
  5979. Camera& camera = get_camera();
  5980. ^
  5981. src/supertux/sector.cpp:473:11: style: Variable 'camera' can be declared as reference to const [constVariableReference]
  5982. Camera& camera = get_camera();
  5983. ^
  5984. src/supertux/sector.cpp:544:13: style: Variable 'player' can be declared as reference to const [constVariableReference]
  5985. Player& player = *static_cast<Player*>(player_ptr);
  5986. ^
  5987. src/supertux/sector.cpp:174:21: style: Variable 'sp' can be declared as pointer to const [constVariablePointer]
  5988. SpawnPointMarker* sp = nullptr;
  5989. ^
  5990. src/supertux/sector.cpp:558:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5991. for (const auto& tilemap : get_all_tilemaps()) {
  5992. ^
  5993. src/supertux/sector.cpp:577:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  5994. for (const auto& tilemap : get_all_tilemaps()) {
  5995. ^
  5996. src/supertux/sector.cpp:725:58: style: Parameter 'rhs' can be declared as pointer to const [constParameterPointer]
  5997. [](const GameObject* lhs, GameObject* rhs) {
  5998. ^
  5999. src/supertux/screen_manager.cpp:218:61: style: Parameter 'fps_statistics' can be declared as reference to const [constParameterReference]
  6000. ScreenManager::draw_fps(DrawingContext& context, FPS_Stats& fps_statistics)
  6001. ^
  6002. src/supertux/screen_manager.cpp:252:13: style: Variable 'sector' can be declared as reference to const [constVariableReference]
  6003. Sector& sector = session->get_current_sector();
  6004. ^
  6005. src/supertux/screen_manager.cpp:250:12: style: Variable 'session' can be declared as pointer to const [constVariablePointer]
  6006. if (auto session = GameSession::current())
  6007. ^
  6008. src/supertux/screen_manager.cpp:553:50: warning: Either the condition 'm_screen_stack.empty()' is redundant or expression 'm_screen_stack.back()' cause access out of bounds. [containerOutOfBounds]
  6009. if (current_screen != m_screen_stack.back().get())
  6010. ^
  6011. src/supertux/screen_manager.cpp:562:36: note: Assuming that condition 'm_screen_stack.empty()' is not redundant
  6012. if (!m_screen_stack.empty())
  6013. ^
  6014. src/supertux/screen_manager.cpp:553:50: note: Access out of bounds
  6015. if (current_screen != m_screen_stack.back().get())
  6016. ^
  6017. src/supertux/tile_set.cpp:134:11: style: Variable 'tile_object' can be declared as pointer to const [constVariablePointer]
  6018. Tile* tile_object = m_tiles[tile].get();
  6019. ^
  6020. src/supertux/world.hpp:34:3: style: Class 'World' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6021. World(const std::string& directory);
  6022. ^
  6023. src/trigger/door.cpp:190:15: style: Variable 'player' can be declared as pointer to const [constVariablePointer]
  6024. Player* player = dynamic_cast<Player*> (&other);
  6025. ^
  6026. src/util/colorspace_oklab.cpp:311:31: style: Parameter 'c' can be declared as reference to const [constParameterReference]
  6027. ColorOKLCh::ColorOKLCh(Color& c) :
  6028. ^
  6029. src/util/line_iterator.hpp:39:3: style: Class 'LineIterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6030. LineIterator(const std::string& str);
  6031. ^
  6032. src/util/utf8_iterator.hpp:31:3: style: Class 'UTF8Iterator' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6033. UTF8Iterator(const std::string& text_);
  6034. ^
  6035. src/video/drawing_request.hpp:62:3: style: Struct 'TextureRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6036. TextureRequest(const DrawingTransform& transform) :
  6037. ^
  6038. src/video/drawing_request.hpp:88:3: style: Struct 'GradientRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6039. GradientRequest(const DrawingTransform& transform) :
  6040. ^
  6041. src/video/drawing_request.hpp:110:3: style: Struct 'FillRectRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6042. FillRectRequest(const DrawingTransform& transform) :
  6043. ^
  6044. src/video/drawing_request.hpp:126:3: style: Struct 'InverseEllipseRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6045. InverseEllipseRequest(const DrawingTransform& transform) :
  6046. ^
  6047. src/video/drawing_request.hpp:142:3: style: Struct 'LineRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6048. LineRequest(const DrawingTransform& transform) :
  6049. ^
  6050. src/video/drawing_request.hpp:158:3: style: Struct 'TriangleRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6051. TriangleRequest(const DrawingTransform& transform) :
  6052. ^
  6053. src/video/drawing_request.hpp:174:3: style: Struct 'GetPixelRequest' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6054. GetPixelRequest(const DrawingTransform& transform) :
  6055. ^
  6056. src/video/bitmap_font.cpp:369:13: warning: Either the condition 'i==text.size()' is redundant or 'i' can have the value text.size(). Expression 'text[i]' cause access out of bounds. [containerOutOfBounds]
  6057. if (text[i] == '\n' || i == text.size())
  6058. ^
  6059. src/video/bitmap_font.cpp:369:30: note: Assuming that condition 'i==text.size()' is not redundant
  6060. if (text[i] == '\n' || i == text.size())
  6061. ^
  6062. src/video/bitmap_font.cpp:369:13: note: Access out of bounds
  6063. if (text[i] == '\n' || i == text.size())
  6064. ^
  6065. src/video/compositor.cpp:56:71: style: Parameter 'ctx' can be declared as reference to const [constParameterReference]
  6066. [](std::unique_ptr<DrawingContext>& ctx){
  6067. ^
  6068. src/video/gl/gl_framebuffer.hpp:31:3: style: Class 'GLFramebuffer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6069. GLFramebuffer(/*GLVideoSystem& video_system,*/ GLTexture& texture);
  6070. ^
  6071. src/video/gl/gl_framebuffer.cpp:22:74: style: Parameter 'texture' can be declared as reference to const [constParameterReference]
  6072. GLFramebuffer::GLFramebuffer(/*GLVideoSystem& video_system,*/ GLTexture& texture) :
  6073. ^
  6074. src/video/gl/gl33core_context.hpp:32:3: style: Class 'GL33CoreContext' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6075. GL33CoreContext(GLVideoSystem& video_system);
  6076. ^
  6077. src/video/gl/gl_shader.hpp:33:3: style: Class 'GLShader' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6078. GLShader(GLenum type);
  6079. ^
  6080. src/video/gl/gl_vertex_arrays.hpp:30:3: style: Class 'GLVertexArrays' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6081. GLVertexArrays(GL33CoreContext& context);
  6082. ^
  6083. src/video/gl/gl33core_context.cpp:65:22: style: Variable 'back_renderer' can be declared as pointer to const [constVariablePointer]
  6084. GLTextureRenderer* back_renderer = static_cast<GLTextureRenderer*>(m_video_system.get_back_renderer());
  6085. ^
  6086. src/video/gl/gl33core_context.cpp:67:14: style: Variable 'texture' can be declared as pointer to const [constVariablePointer]
  6087. GLTexture* texture;
  6088. ^
  6089. src/video/gl/gl33core_context.cpp:182:22: style: Variable 'back_renderer' can be declared as pointer to const [constVariablePointer]
  6090. GLTextureRenderer* back_renderer = static_cast<GLTextureRenderer*>(m_video_system.get_back_renderer());
  6091. ^
  6092. src/video/gl/gl_screen_renderer.cpp:0:0: information: Too many #ifdef configurations - cppcheck only checks 12 of 14 configurations. Use --force to check all configurations. [toomanyconfigs]
  6093.  
  6094. ^
  6095. src/video/gl/gl_screen_renderer.hpp:32:3: style: Class 'GLScreenRenderer' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6096. GLScreenRenderer(GLVideoSystem& video_system);
  6097. ^
  6098. src/video/gl/gl_texture.cpp:0:0: information: Too many #ifdef configurations - cppcheck only checks 12 of 14 configurations. Use --force to check all configurations. [toomanyconfigs]
  6099.  
  6100. ^
  6101. src/video/gl/gl_video_system.cpp:0:0: information: Too many #ifdef configurations - cppcheck only checks 12 of 17 configurations. Use --force to check all configurations. [toomanyconfigs]
  6102.  
  6103. ^
  6104. src/video/gl/gl_video_system.cpp:365:11: style: Variable 'src' can be declared as pointer to const [constVariablePointer]
  6105. char* src = &pixels[3 * viewport_width * (viewport_height - i - 1)];
  6106. ^
  6107. src/video/null/null_texture.hpp:27:3: style: Class 'NullTexture' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6108. NullTexture(const Size& size);
  6109. ^
  6110. src/video/sdlbase_video_system.cpp:134:15: style: Condition 'g_config->fit_window' is always true [knownConditionTrueFalse]
  6111. if (g_config->fit_window)
  6112. ^
  6113. src/video/sdlbase_video_system.cpp:132:26: note: Assignment 'g_config->fit_window=true', assigned value is 1
  6114. g_config->fit_window = true;
  6115. ^
  6116. src/video/sdlbase_video_system.cpp:134:15: note: Condition 'g_config->fit_window' is always true
  6117. if (g_config->fit_window)
  6118. ^
  6119. src/video/viewport.cpp:21:0: information: Include file: "config.h" not found. [missingInclude]
  6120. #include "config.h"
  6121. ^
  6122. src/worldmap/camera.cpp:97:9: style: Variable 'worldmap_sector' can be declared as reference to const [constVariableReference]
  6123. auto& worldmap_sector = *WorldMapSector::current();
  6124. ^
  6125. src/worldmap/tux.cpp:385:40: style: Parameter 'special_tile' can be declared as pointer to const [constParameterPointer]
  6126. Tux::process_special_tile(SpecialTile* special_tile)
  6127. ^
  6128. src/worldmap/world_select.hpp:49:3: style: Class 'WorldSelect' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6129. WorldSelect(const std::string& current_world_filename);
  6130. ^
  6131. src/worldmap/worldmap_state.hpp:38:3: style: Class 'WorldMapState' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6132. WorldMapState(WorldMap& worldmap);
  6133. ^
  6134. src/worldmap/worldmap.cpp:211:14: style: Variable 'sector' can be declared as reference to const [constVariableReference]
  6135. for (auto& sector : m_sectors)
  6136. ^
  6137. src/worldmap/worldmap.cpp:222:14: style: Variable 'sector' can be declared as reference to const [constVariableReference]
  6138. for (auto& sector : m_sectors)
  6139. ^
  6140. src/worldmap/worldmap_sector.cpp:240:18: style: Variable 'special_tile' can be declared as pointer to const [constVariablePointer]
  6141. SpecialTile* special_tile = at_object<SpecialTile>();
  6142. ^
  6143. src/worldmap/worldmap_sector.cpp:252:17: style: Variable 'teleporter' can be declared as pointer to const [constVariablePointer]
  6144. Teleporter* teleporter = at_object<Teleporter>();
  6145. ^
  6146. src/worldmap/worldmap_sector.cpp:284:12: style: Variable 'teleporter' can be declared as pointer to const [constVariablePointer]
  6147. auto teleporter = at_object<Teleporter>();
  6148. ^
  6149. src/worldmap/worldmap_sector.cpp:422:20: style: Variable 'tilemap' can be declared as pointer to const [constVariableReference]
  6150. for (const auto& tilemap : get_solid_tilemaps()) {
  6151. ^
  6152. src/worldmap/worldmap_sector.cpp:453:39: style: Parameter 'gamelevel' can be declared as pointer to const [constParameterPointer]
  6153. WorldMapSector::finished_level(Level* gamelevel)
  6154. ^
  6155. src/worldmap/worldmap_sector.cpp:567:8: style: Variable 'sp' can be declared as pointer to const [constVariablePointer]
  6156. auto sp = get_spawnpoint_by_name(spawnpoint);
  6157. ^
  6158. src/worldmap/worldmap_sector_parser.hpp:33:3: style: Class 'WorldMapSectorParser' has a constructor with 1 argument that is not explicit. [noExplicitConstructor]
  6159. WorldMapSectorParser(WorldMapSector& sector);
  6160. ^
  6161. nofile:0:0: information: Active checkers: 157/592 (use --checkers-report=<filename> to see details) [checkersReport]
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement
Public Pastes
Advertisement
We use cookies for various purposes including analytics. By continuing to use Pastebin, you agree to our use of cookies as described in the Cookies Policy.  OK, I Understand
Not a member of Pastebin yet?
Sign Up, it unlocks many cool features!