fixes_gw.kz

DB/Creature: Supremus (BT) trash mobs, waypoints & spawns
Creature/script: Add area restriction for Freed Proto Drake
DB/Creature: Root for 7th Legion Chain Gun
Core/Unit: add impurity attack power bonus to healing too (for Death Coil for example)
Core/Player: fix regression with EquippedItemClass requiring spells
Revert "Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts"
Core/Spell: add EquipedItemClass/EquippedItemSubClass check to passive spell casts
Core/Auras: Rewritten conditionally applying SPELL_AURA_MOD_WEAPON_CRIT_PERCENT, SPELL_AURA_MOD_DAMAGE_DONE and SPELL_AURA_MOD_DAMAGE_PERCENT_DONE auras
Core/Spells: Updated spell required items check, EquippedItemInventoryTypeMask should only be used for enchantments
Core/Guild: avoid data integrity problems wrapping delete+insert statements in a transaction
Core/Guild: fix indentation and codestyle
Core/Unit: do not allow judgement spells to bypass damage immunity
Core/Scripts: fixed Imp. Leader of the Pack
Core/Player: recheck shapeshift bonus auras when switching spec.
Core/Scripts: Seal of Corruption/Vengeance shouldn't reset periodic timer on reapply
Core/Entities: fix interaction of traps with ffa pvp and sanctuary flags
DB/Spell: Vampiric Embrace proc
DB/Spell: fix Art of War procs
Core/Entities: better support of absorb, resist and block procs
Core/Spell: restore old proc system behaviour on auras self proc.
Core/Spell: register items received through SPELL_EFFECT_SUMMON_CHANGE_ITEM for quest credit
Core/Spell: Fixed Drain Soul incorrectly downscaling ranks when targetting lower level enemies
Core/Spell: Added the possibility to explicitly disable auraEffect procs using attributes
Core/Spell: spells with ignore hit result should pierce damage immunities
Core/Gameobject: fixed sometimes not found linked trap
Core/Spell: Fixed irregular handling of SPELLMOD_DOT
Core/Unit: fix some SPELL_AURA_MOD_DAMAGE_PERCENT_DONE effects being applied more than once
Core/Unit: fix build
Core/Unit: damage immune improvements (9f5df023b746d324588f175e264c62205b69e165 follow up)
DB/GameObjects: Cursed Egg
Core/Spell: fix a potential null dereference crash
DB/Spell: Vampiric Embrace proc
Core/Unit: don't use damage immunity to calculate hit result for the whole spell. Should be used only for damage
Core/Spell: perform charmer check against player controlling unit. Fixes spellcasts while charmed
DB/Creature: correct 2 npc walk/run speed
Core/Unit: improved handling of some spell attributes
Core/GameObject: use a friendly trigger for positive spells.
Core/Scripts: add checks to Master's Call script
Core/Spell: do not fail triggered Charge effects in case a root is present.
Core/Spell: Fix warrior Enrage stacking with Wrecking Crew and Imp. Defensive Stance
Core/Globals: Load spellspecific and aurastate after loading spell ranks
Core/Spell: use SpellEntry to select implicit targets in case RadiusEntry wasn't set for the current effect.
Core/Spell: Fixed immunities for some spells (they were broken before rewrite too)
Core/Unit: consider creatures with same faction to be on the same party/raid for the purposes of spell/aura targets
Core/SpellScript: allow optional parameters to be passed to FinishCast
Core/ScriptMgr: use vector instead of list to contain Spell and Aura scripts and hooks
Core/Misc: codestyle fixes in GridNotifiers.h
DB/Misc: Dark portal Event
Core/Scripts: Cleanup in instance_black_temple and added missing datas (#18246)
Core/Auras: Fixed removing auras triggered by aurastates
DB/Spell: require spellmod consumption for Clearcasting
Core/Unit: misc codestyle
Core/Spell: fix warning
Core/Spell: revamp of immunities system
Core/Spell: move attribute helpers to spellInfo
DB/gameobject: set positive spawntimesecs for 2 quest objects
Core/Auth: Resolved authentication bypass
Core/Scripts: Fixed a typo and removed randtime of Shade of Akama events (#18231)
DB/Spell: add attribute for Stoneclaw Totem Effect, should not brask stealth
DB/Spell: Mage armor procs
DB/Spell: change phaseMask to finish for Deathchill and Killing Machine
DB/Spell: kill some startup errors
Core/SpellMgr: overwrite dbc range for Unleashed Souls
Core/Spell: reimplemented TRIGGERED_DISALLOW_PROC_EVENTS trigger flag
DB/Spell: Aspect of the Pack and Aspect of the Cheetah, proc on damage only
Rename 2016_11_07_01_world_335.sql to 2016_11_08_00_world_335.sql
Core/Entities: add yet another utility overload to CastSpell, fixes AppVeyor build
Core/Spell: fix interaction of on taken damage procs with triggered casts
DB/Spell: disable LoS checks for Death and Decay damage spell
Core/Spell: make a distinction between triggered flags with debugging purposes, and don't use them when casting triggered spells
Core/Gameobject: remove immune flags from trigger used to cast GO spells
Core/SpellMgr: add some trap effect range overrides
Core/Spells: do not add PROC_HIT_NORMAL/PROC_HIT_CRITICAL flags if damage is fully nullified
DB/SAI: Misc Summon spells
Core/Spell: apply SPELLFAMILY_GENERIC mods to all spells by default
DB/Creature: Citadel Watcher
[3.3.5] Core/Loot: Fix conditional Master Loot (#17943)
Core/Player: fix static analysis issue
DB/Spell: Recklessness & Sweeping Strikes procs
Core/SpellMgr: static analysis checks
DB/Misc: Fix a lot of server side summon spells
Core/Creature: Correctly reset pathfinding capability on respawn. Prevents evade chains on some bosses. Closes #18188.
DB/Spell: Maelstrom Weapon charge drop on cast
Core/Globals: normalize DBC data for Maelstrom Weapon ranks
Core/Scripts: Archmage Arugal event script (#17922)
DB/Spell: Savage Combat proc
DB/Spell: Earthgrab Totem
DB/Gameobject: Add two missing game object
DB/Creature: Earthgrab Totem and Tainted Earthgrab Totem
DB/SAI: Bloodscalp Beastmaster, Skullsplinter Beastmaster and Skullsplitter Hunter
DB/Event: Fix Day of the Dead spawns
Core/GameObject: spawn linked traps at gameobject creation instead of using DB spawns. (#18172)
Remove reference to eastern plaguelands script
Remove obsolete file
DB/Creature: Augustus the Untouched
DB/CreatureText: revert 06d658f.
DB/Quest: Defenders of Darrowshire
DB/CreatureText: swap wrong faction texts for Commoners during Hallow's End.
Shared/Metric: Initial support for tag value escaping
Core/Auras: fix elixir aura saving
DB/SAI: remove SAI from gameobject Felhound Poo.
DB/GameObject: add another missed trap from 7.x.
DB/GameObject: add missing traps taken from 7.x.
DB/Object: Fix an Apple Bob position in Lakeshire
DB/Creature: Goramosh add aggro text
DB/SAI: Karen "I Don't Caribou" the Culler
Core/Transports: Fixed crash added in b88cecb656c62cd3bcc3ae2a171b173eb64a28c9
Update characters_database.sql
Core/Transports: Added extra transport position update just when it stops moving
Core/Quest: Only delete all quest bound items from inventory on turn in if the quest is not repeatable
Update characters_database.sql
Core/Auras: don't save auras casted by items
Core/GameObjects: Handle despawning and respawning of nearby linked traps on gameobject despawn and respawn
Core/GameObjects: Fixed Frozen Trap target selection
DB/Spell: Implemented Master Poisoner (proper) Closes #12221 (also proper)
Core/Spell: fix range for Ancestral Healing (shaman) and Grace (priest)
Core/Spells: workaround stealth interaction with Death and Decay and GameObject casts
Core/SpellMgr: fix Abolish Disease/Poison targets
DB/Gossip: remove wrong gossip text from Hemet Nesingwary (Nagrand).
Core/Script: set original caster for Paladin judgement triggered effects.
Core/Unit: send original caster in heal packet log
Core/SAI: reset event phase when calling SMART_ACTION_CALL_SCRIPT_RESET.
Script/Quest: improvements for Shizz Work:
DB/Creature: restore ScriptName for Sentinel Sweetspring.
DB/Event: forgot that Hallow's End is still running.
DB/Event: fix start date for Winter Veil.
DB/Gossip: Grinkle and Barrus.
Codestyle.
DB/Creature: Remove wrong creature text from Horde Scout
DB/SAI: Add some SAI scripts
DB/Events: update event start dates and fix some wrong event durations.
Core/Auras: only apply shapeshift aura passives when changing forms
Core/Unit: consistency fix
Core/Player: cleanup single target auras on spec switch
Core/Auras: fix removal of Master of Subtlety/Overkill auras
DB/Spell: proc fixes
Core/Spells: require phaseMask set for trap activation procs
Rename 2016_10_28_01_world_335.sql to 2016_10_28_02_world_335.sql
Core/Scripts: fix Cobra Strikes
Core/Unit: allow pets and totems to drop mod charges in owner auras.
Core/Scripts: fix Glyph of Mend pet
Core/Script: Messenger Torvus.
Core/Unit: fix error introduced in 8a82a3ba81a187b5c76f4065697925a1da15aa13.
DB/SAI: Borus Ironbender.
Core/Unit: fix warning reported by VS2015
Core/Conditions: merge CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK with CONDITION_SOURCE_TYPE_QUEST_ACCEPT. (#18151)
DB/SAI: Zebu'tan and Alys Vol'tyr's conversations.
Core/Unit: fix logic error in DamageInfo::ModifyDamage.
Forgot a wild comment, sorry.
DB/SAI: Sentinel Sweetspring.
DB/SAI: Otonambusi.
DB/Spell: fix Inferno Flame aura stack drop
Core/SpellMgr: overwrite DBC RangeEntry for Safeguard
DB/Spell: Proc fixes
Core/Auras: allow damage from periodics to trigger auras if they're not fully resisted/absorbed
DB/Conditions: add missing data for CONDITION_SOURCE_TYPE_QUEST_ACCEPT and CONDITION_SOURCE_TYPE_QUEST_SHOW_MARK.
Core/SAI: remove wrong DB errors.
DB/SAI: fix Plague Walker's Aura of Lost Hope usage (Ahn'Kahet: The Old Kingdom).
DB/Quest: event for quests Hallow's End Treats for Spoops/Jesper.
Core/Unit: CalculateMeleeDamage should use unmodified damage to compute HitInfo
Core/Spells: use DamageInfo struct to calc spell absorbs and resists, and use calculated proc hitMask on aura ticks
DB/Creature: fix Prince Valanar (ICC) respawn health
Core/Globals: abort server startup if there are wrong factions in DB
Core/Unit: fix chain cc's not being diminished properly
Core/Spells: moved handling of SPELL_ATTR0_CU_DONT_BREAK_STEALTH inside proc system.
DB/Quest: remove wrong repeatable flag from some quests.
DB/Event: Add new event Darkmoon Faire Building (Mulgore)
Tools/VMAPs: Fix extractor crash when some .mpq files does not exist (#18130)
Scripts/Trial of the Crusader: Fixed crash in Snobold Vassal script (#18124)
DB/GameObject: Containment Coffer TRAP
Core/Chat: coding standards
Core/Unit: prematurely abort GetFactionTemplateEntry instead of returning a null pointer
Fix non-PCH build.
DB/SAI: Duggan Wildhammer
Add forgotten override.
Script/Spell: remove cosmetic effect for Water Bucket item at login if it expired after the player logged out.
DB/Spell: fix cosmetic effect triggered when a Water Barrel is used.
Core/Arena: Fix lag caused by arena distribution (#17989)
DB/GameObject: Change position of the Candy Bucket in Bor'gorok Outpost
Update revision_data.h.in.cmake
Core/GameObject Also spawn trap for GAMEOBJECT_TYPE_BUTTON (#18083)
DB/Quest: Stinking Up Southshore should not be repeatable.
DB/Spell: Fix Grace proc with Penance
DB/Spell: Fix Shadow Trance aura drop
Core/Spell: do positivity spell checks only against actually hitted effects instead of the whole spell
DB: Add some Npcs/Gobs related to Hallow's End
DB/Creature: Fix height of Rachelle Gothena
DB/Creature: Move Rachelle out of the Mailbox in Orgrimmar
DB/Creature: Set correct Position Z height of Orc Commoner in Orgrimmar
DB/Quest: Hallow's End Treats for Spoops! should not be repeatable.
DB/GameObjects: Remove Apple Bob duplicate spawns
DB/Creature: assign core script to creature Magister Aledis.
DB/Creature: Set correct Position Z height of all Orgrimmar NPCs
DB/Creature: Remove [UNUSED] Henria Derth <Wolf Trainer>
DB/Event: Brewfest Soon
Core/Unit: Change aura proc pair container to vector
Core/Spell: clear auras of channeled spells if channeling is cancelled due to invalid targets (dead or w/e)
Core/Spells: mark Arcane Missiles aura as negative. Was downranking the spell when targetting low level mobs due to effect 1 flagged as possitive.
Core/Script: Fix improved drain soul mana return.
DB/Spell: some proc fixes
Core/SpellMgr: some changes in default proc generation. Fix an issue of stealth breaking with positive and/or healing spells
Core/Globals: compute aura diminishing return info at startup and cache it
Core/AuctionHouseBot: ahbot characters subsystem shake-up
Core/Scripts: fix static analysis issues
DB/Creature: remove wrong text from NPC Argos Nightwhisper.
Core/Spell: allow SPELL_EFFECT_QUEST_COMPLETE to set a quest to rewarded only if that quest is used as internal flag by the server (has flag 1024 - QUEST_FLAGS_TRACKING).
Core/Quest: show DIALOG_STATUS_AVAILABLE instead of DIALOG_STATUS_REWARD for non-repeatable autocomplete quests.
Core/Quest: send correct packet when a quest cannot be rewarded for item-related errors.
DB/SAI: improve timers and remove wrong text from Viera Sunwhisper.
TDB 335.62 - 2016/10/17
Entities/Creature: Fix an edge case issue where creatures would re-acquire target after respawn if they despawned while spell focusing.
Core/Text: allow GENDER_NONE to use FemaleText in broadcast_text if not empty.
DB/Gossip: add gossip texts for the following creatures in Stranglethorn Vale:
DB/Gossip: Wizlo Bearingshiner.
DB/Conditions: show correct gossip for Baron Revilgaz if event Pirates' Day is not running.
DB/Misc: fix gossip text for Noth the Plaguebringer and remove wrong quest turn-in from the same npc.
Fix warning.
Script/Quest: Arelion's Mistress.
DB/Object: Fix objects phaseMask on TOC
Core/Quest: do not set a quest to failed if it's rewarded or has no status at all (not taken).
Scripts/AzjolNerub: Make pulling Anub'arak a bit cleaner.
DB/Quest: fix race availability for four quests (that should be Human only).
Fix _DespawnAtEvade for other creatures to actually respawn said other creatures.
DB/SAI: prevent Dawnblade Hawkrider's SAI from targeting players.
DB/Misc: add conditions for spell Arrow Assault and remove wrong texts for two Death Knight starting zone creatures.
Core/Creature: Fix respawn logic to call reset react state BEFORE calling Reset(). Fixes Krik'thir behavior after a wipe (and maybe some others).
Fix for a typo in variable name. (#18086)
DB/Quest: Volatility (daily version) requires completion of Volatility (non-daily version).
DB/Gossip: add gossip for creature Deino that is shown after completing the quest A Letter for Home.
[3.3.5] Core/Scripts: move npc_braug_dimspirit to SAI (#17853)
Rename 2016_10_32_17813_world.sql to 2016_10_15_01_world.sql
Core/Scripts: move npc_saat to DB (#17813)
Rename 2016_09_09_20_world.sql to 2016_10_15_00_world.sql
[WIP] Core/Scripts: Gnomish Mind Control Cap and Gnomish Universal Remote (#17374)
Remove deprecated procEx usage.
Core/AI: initial support for monster sparring (#17673)
Creature/AI: prevent Kologarn's arms from attacking.
Core/Scripts: Implemented right Snobold Vassal behavior on Gormok fight. (#17934)
[3.3.5] AHBot Characters (#17885)
Core/Unit: Remove incorrect check that dont allow units attack your vehicle/passenger (#17932)
Core/SAI: always use DespawnOrUnsummon() for SMART_ACTION_FORCE_DESPAWN.
Rename 2016_99_99_99_world.sql to 2016_10_14_05_world.sql
Core/Scripts Boss Lady DeathWhisper improvements (#17389)
DB/Quest: add mail reward for the following quests:
DB/Quest: fix mail reward for True Believers and Still Believing.
Core/Event: Change Midsummer Music container to vector
Core/Event: Change Midsummer Music to search grid only
Script/Creature: Scarshield Infiltrator/Vaelan.
DB/Spell: fix second effect of Infusion of Light (3cbd4bc22f013e8a4ab593c6f0afd2654fed6a66 partial revert)
Core/SmartScripts: fixup SMART_EVENT_FLAG_WHILE_CHARMED behaviour to only mean charmed creatures (#17738 follow-up)
Core/Unit: disallow parry for totems
Core/AI: added container independent wrappers for WorldObject::GetxxxInGrid
Core/Entities: fix dynamic linking
Revert "Core/DBC: fix wrong field type for ItemLimitCategory.dbc."
Core/Item: fix wrong error message triggered when trying to equip two items with the same ItemLimitCategory.
Core/DBC: fix wrong field type for ItemLimitCategory.dbc.
Core/Spell: overwrite DBC RangeEntry values for spells Concussive Barrage, Desecration and Polymorph.
Core/Entities: extend available containers for WorldObject::GetxxxInGrid
Core/Spells: Make slice and dice positive. Was breaking stealth.
Core/Scripts: Fix runtime error
DB/Spell: Fix Glyph of Healing Wave
Forgot to change guid.
Script/Quest: Stop the Ascension!
Core/Spell: do not automatically set proc Family Name if no Family Flags present
DB/Creature: add additional text for Chief Plaguebringer Harris.
DB/Spell: Fix a few nonworking procs:
Core/Spells: fix auto repeat spells triggering auras
Core/Auras: don't ignore SPELL_ATTR3_ONLY_TARGET_PLAYERS in area auras.
DB/Spell: Fix Infusion of Light proc
Core/Items: Defined all item flags
Core/Loot: revert unique item check introduced in ea69115.
Core/Loot: limit unique items check introduced in ea69115 to affect only items that start a quest.
Core/Scripts: Implemented Blessing of the Eternals Earthliving proc chance increase
DB/Creature: cosmetic lightning effect for quest The Staff of Storm's Fury's location.
DB/Creature: Abdul the Insane.
DB/Loot: item Abandoned Adventurer's Satchel should always drop from Northrend rares.
DB/Quest: add vendor conditions for quest items related to A Carver and a Croaker and Parts for the Job.
Script/Quest: Apply Heat and Stir.
DB/Gossip: fix gossip for creature Jack Adams.
DB/Conditions: spells Plagued Blood Explosion and Arcane Charges can only hit certain mobs.
Core/Creature: Call SetSpawnHealth after JustReachedHome in HomeMovementGenerator
Core/SmartAI: There's a function for that
Core/Scripts: don't check ghoul each update. Send proper text packet, so client replaces %s with DK name
Core/Spells: fix runtime error
Core/Scripts: fix warning reported by MSVC
DB/Gameobject: Fix respawn time  for some objects
Dep/G3D: Backport warning fix from G3D10
DB/Misc:
DB/Quest: ... Or Maybe We Don't
Rename 2016_10_09_01_world.sql to 2016_10_09_01_world_335.sql
DB/SAI: fix quest Gambling Debt (Part 1).
Core/SAI: don't reset event phase when npc evades/resets.
Core/Spell: Fix 2 more off by one probability calc and duplicated logic in spell hit roll
Core/Spells: Effect leap back fix (#18057)
DB/Loot: Dustbringer.
DB/Loot: Blacktip Shark.
Core/Unit: enabled parry for all creatures, not only humanoids
Core/Auras: moved check for CC auras out of proc handler, and fixed its logic
DB/Spells: revised SpellTypeMask for Procs that needed it.
Core/Scripts: added missing null checks for DamageInfo struct
Core/Wintergrasp: fix ownership of workshops at the beginning of a new battle.
Core/Scripts: fix some copy paste and indentation mistake in Chimera Shot script
Core/Scripts: updated Lock and Load script with new hooks, DamageInfo might be null, so check for that too
Core/Wintergrasp: cleanup and codestyle.
DB/Wintergrasp: availability of different No Mercy for the Merciless and Slay Them All! depends on who is currently holding the keep.
Scripts/Azjol-Nerub: fix static analysis issues
Core/Scripts: Initialize rnd and remove where it was not needed
DB/Wintergrasp: four more Horde guards in Wintergrasp Keep that should only appear when it is held by Horde.
Core/Event: Pirate Day Music during the event
Core/Event: Add Darkmoon Fair Music during the event
Core/Event: Add Midsummer Music during the event
Remove unused variable.
Battlefield/Wintergrasp: improvements:
Core/Wintergrasp: fix Defend the Siege quests.
DB/Quest: improvements for quests related to NPC Denalan:
Core/Auras: prevent stack overflow while processing SPELL_EFFECT_ADD_EXTRA_ATTACKS
Revert "Core/Unit: prevent m_extraAttacks underflow. Fixes a freeze with SPELL_EFFECT_ADD_EXTRA_ATTACKS"
Core/Channels: remove unneeded default constructor
DB/Gameobject: remove wrong "Greetings, $n" gossip from 256 questgiver gameobjects.
Core/Channel: revamp channel system (#17980)
Core/Globals: cache SpellSpecific and AuraState information instead of computing them each time they're needed
Core/Auras: stop some compilers from complaining
Core/Scripts: Fix some runtime errors
Core/Misc: fix interaction of spells like Shadowmeld with Threat reducing effects
DB/SAI: Update event flag for war-golem used on ... Or Maybe We Don't
Core/Grids: Allow arbitrary containers in grid searchers that support push_back * Makes it possible to use vector and dequeue with grid searchers.
DB/Creature: Update equip for Brewfest Reveler
Core/Event: Fix Brewfest Music
DB/Quest: Covert Ops - Alpha and Covert Ops - Beta require completion of both Ineptitude + Chemicals = Fun and Special Delivery for Gaxim.
Revert "Core/Creature: don't give kill and achievement credit if a creature kills itself."
Core/Creature: don't give kill and achievement credit if a creature kills itself.
DB/Quest: the two versions of Jonespyre's Request require Morrowgrain Research rewarded.
DB/Creature: fix faction for Githyiss the Vile.
Core/Unit: implemented crit suppression
Core/Scripts: De-hack glyph of Barkskin with proper spell
Core/Unit: prevent m_extraAttacks underflow. Fixes a freeze with SPELL_EFFECT_ADD_EXTRA_ATTACKS
DB/Quest: fix quest "Gerenzo's Orders" (Part 1).
Fix non PCH build.
DB/Misc:
DB/SAI: better handling for Ward of Laze aura.
Update 2016_10_05_11_world_335.sql
DB/Quest: fix quest "One Shot. One Kill."
Core/Event: Add Brewfest Music during the event
DB/Creature: fix gossip for some creatures.
Core/Unit: fix weapon skill up.
DB/Spell: fix a few procs that should only proc from damaging spells
DB/Quest: improve Escape Through Force and fix Escape Through Stealth.
DB/Quest: fix event for quest A Lost Master (Part 2).
DB/Quest: Hot and Cold
Both updates are only for 3.3.5 branch.
DB/Quest: improve end event for Escape Through Stealth/Force.
DB/Quest: end event for How Big a Threat? (Part 2).
Core/Auras: reset periodic aura timers by default. Except when aura comes from triggered spell
Core/Scripts: add a workaround for Will of the Forsaken shared cooldown
DB/Spell: correct proc phase for Elemental Shaman 2P Bonus
Core/Spells: add Target Processing (SMSG_SPELLLOGEXECUTE) to LAUNCH_TARGET phase.
Core/Scripts: fix 2 runtime error logs
Core/Spells: add proc cooldown on item equip.
DB/Spell: Fix Sudden Death charge drop
Core/Scripts: add even more headers
Core/Scripts: add more headers required for NoPCH
Core/Scripts: add headers required for NoPCH build
Rename 2016_xx_xx_xx_world.sql to 2016_10_04_06_world.sql
Core/Scripts: Convert spells to new proc system
Core/Spells: Implementation of QAston proc system
Core/Spells: Calculate hitMask and store it in DamageInfo/HealInfo structures
Ofcourse 335 only
DB/Event: Add missing Lunar Festival Objects in Stormwind
Scripts/Wintergrasp: Fix vehicle teleporter (#17550)
Core/Units: Clear UNIT_NPC_EMOTESTATE on death (blizzlike)
Core/Wintergrasp: fix leaving Wintergrasp via the minimap button.
Core/Wintergrasp: properly set and remove GO_FLAG_NOT_SELECTABLE from the Wintergrasp Relic, allowing the attacking faction to capture it.
Update 2016_10_04_03_world.sql
DB/Creature: Ward of Laze: root and spellcast.
Core/Conditions: partially revert 723c253, replacing CONDITION_WINTERGRASP_HORDE with a ConditionScript.
Core/Wintergrasp: give quest credit for southern towers destroyed.
DB/Conditions: quests Southern Sabotage and Toppling the Towers are only available if the respective faction is defending Wintergrasp.
Core/Scripts: kill whitespace
Core/Unit: fix a copy/paste mistake
Various: Fix coverity reported issues.
Core/Wintergrasp: fix victory quests.
DB/Pool: add pools for Wintergrasp item-gathering weekly quests.
Make travis happy and fix codestyle for previous commit.
Core/Conditions: implement CONDITION_WINTERGRASP_HORDE to check if Wintergrasp is held by Horde.
Core/Unit: rewrite of the attack table system
Core/Unit: don't reset offhand timer for players when starting attack.
Rename two SQL files.
Script/Quest: A Cry For Help: (#18026)
Core/Loot: limit unique items check in LootItem::AllowedForPlayer() to bind-when-picked-up items only.
Core/Loot: do not show unique items if player already has the maximum allowed quantity.
Core/Quest: send INVALIDREASON_QUEST_ALREADY_DONE if player tries to accept a quest that is already rewarded.
DB/PageText: add newlines to some item texts.
DB/Quest: end event for Harlan Needs a Resupply.
Build: Added 1.62 Boost version to FindBoost
DB/SAI: fix db error introduced in 2a8669d.
DB/Creature: remove loot and experience for Webbed Creature.
Core/Quest: Gordunni Cobalt:
Rename 2016_10_00_00_world.sql to 2016_10_01_00_world.sql
Core/Spells: Flag of Ownership shouldn't target creatures
Core/Player: correct logic for IsUsingTwoHandedWeaponInOneHand
Core/Spells: fixed SPELL_ATTR5_USABLE_WHILE_STUNNED
Core/Spell: Add Dual Wield skill dependency to Dual Wield effect, should remove the skill properly when unlearning spell.
DB/Loot: remove some wrong items from gameobject and creature loot.
DB/Quest: Supplies to Auberdine:
DB/SAI: Twilight Disciple and Twilight Thug.
DB/SAI: use spell instead of direct add item SAI for previous commit's script.
DB/Creature: Raene Wolfrunner:
Core/Player: unconditionally remove Titan's grip penalty aura on Spell removal
Core/Spells: SPELL_AURA_SCHOOL_IMMUNITY auras shouldn't remove passive auras (even if negative)
Core/Player: Implemented Titan's Grip damage reduction
Core/Spells: Implemented SPELL_ATTR6_NOT_RESET_SWING_IF_INSTANT.
DB/SAI: fix two events that would never execute because of wrong event_phase_mask set.
DB/Quest: fix offer reward text for Redemption (Part 2, Draenei).
DB/Quest: A Lost Master requires How Big a Threat? (Part 2) rewarded.
DB/SAI: fix db errors introduced in 9c6e12b.
Core/Spells: use spellinfo helper methods
Core/Player: fixed math error
Script/Quest: fix text for creature Gelkak involved in quest Gyromast's Revenge.
DB/Loot: fix loot for item Message in a Bottle and gameobject Half-Buried Bottle.
DB/Item: fix loot for Dented Crate.
DB/Quest: Matis the Cruel:
DB/Object: Fix some gob respawn time
DB/Quest: Fresh Remounts
Core/Script: make creature Webbed Creature spawn creature Expedition Researcher when appropriate.
DB/Quest: Saving Princess Stillpine:
DB/Quest: further improvements to some Azuremyst Isle quests.
DB/Quest: improvements to some Azuremyst Isle quests.
Misc/Config: fix an oversight.
Misc/Config: enable ChatFakeMessagePreventing by default, since it's a blizzlike feature.
Core/Config: allow to specify daily quest reset hour in config.
DB/Misc: charmed flag for Converted Sentry.
DB/Quest: script, spawns and conditions for Intercept the Reinforcements.
DB/Misc: Charmed flags
Core/Spell: set quest to rewarded instead of complete when targeted by SPELL_EFFECT_QUEST_COMPLETE. (#18021)
Core/World: properly re-initialize daily quest reset time when resetting daily quests. (#17986)
DB/Loot: add Phantom Ghostfish to Nettlefish School loot.
Core/Log: move an error to DEBUG level.
DB/Conditions: fix gossip text for creature Technician Zhanaa.
DB/SAI: fix wrong faction in script introduced in 927d002.
DB/Creature: Botanist Taerix:
Update 2016_09_28_02_world.sql
DB/Creature: follow up to b153d783b
DB/Creature: Typo fix on previous commit
DB/Creature: Utgarde Catacombs cleanup
DB/Misc: Fix Skadi the Ruthless
Core/Scripts: Fixed Gunship Mage cast interrupt Closes: #14912
and you get a header, and everyone gets a header...
.....hail PCH
...for real this time (seriously - what happened to test builds before merging, Aok?)
Fix nonPCH.
I think I got all of them this time
Update boss_hadronox.cpp
Update boss_hadronox.cpp
DB/SAI: Several improvements to escape from Silverbrook script
[3.3.5] Azjol-Nerub rewrite
DB/Misc: Updates
Rename 2016_09_26_00_worl to 2016_09_26_00_world.sql
DB/SAI: add yell for NPC Sergeant Lorric.
Core/Scripts: Fix build
DB/SAI: fix db errors introduced in 31e495f.
Rename 9999_99_99_99_world.sql to 2016_09_25_03_world.sql
Script/Quest: Trail of Fire (#17939)
DB/Creature: fix creature_text for Gordok Brew Barker.
Core/Auth: removed unneeded sub query
DB/SAI: close gossip when selecting a gossip option from NPC Wing Commander Brack.
DB/Conditions: limit targets for spell Dropping Heavy Bomb.
Core/Auth: fixed logic in FailedLogins check
Core/Scripts: move #define to enum/boss emote to DB (#17967)
Scripts/ICC: Fix chest loot exploit
Rename 9999_99_99_99_world.sql to 2016_09_24_07_world.sql
Core/Gossip: improve gossips related to Dual Talent Specialization: (#17921)
Rename 9999_99_99_99_world.sql to 2016_09_24_06_world.sql
Script/Quest: improvements for Let Them Eat Crow. (#17948)
Core/Creature: update health/mana/damage/armor when changing a creature's entry while keeping the original level.
DB/Quest: fix creature text for Force Commander Danath Trollbane when quest The Fall of Magtheridon is turned in.
DB/Quest: Weaken the Ramparts, The Longbeards and Unyielding Souls require completion of Expedition Point.
DB/Quest: The Legion Reborn and Know your Enemy require completion of Force Commander Danath.
DB/Quest: The Exorcism of Colonel Jules:
Core/Scripts: move npc_lunaclaw_spirit to SAI
Script/Quest: The Exorcism of Colonel Jules:
Scripts/IcecrownCitadel: Fix an issue where Deathbringer Saurfang's exit door could get stuck in a closed state. Fixes and closes #15018.
Update 2016_09_21_03_world.sql
Core/Scripts: XT002 improvements in Hard Mode. Closes #17141. (PR #17900)
Movement/SplineChain: Fix a potential critical bug where resume info returned during an edge case could fail an assertion when used.
DB/Quest: Steamtank Suprise
Remove space
DB/Quest: Bury Those Cockroaches
d3214a0 follow-up for code style.
Movement/SplineChain: Streamline the script workflow for resume info a bit, provide static method that does all the ugly pointer casts for you. Also prevent a nullptr dereference crash if scripts mishandle motionmaster, and canonize Chain == nullptr to signify "no resume info".
Map/InstanceMap: Ease up on a somewhat overzealous error message regarding instance saves.
DB/Quest: The Sum is Greater than the Parts
DB/Quest: Escape from Silverbrook
DB/SAI: Krolmir, Hammer of storms
Core/Movement: Fix a DB spline chain overload I missed in 2170541
DB/SAI: More event flags
DB/Creature: Re-sniffed Blighted Elk and Rabid Grizzly spawns. Closes #17958. (Thanks, Malcrom!)
Code style follow-up, I blame Notepad++.
Core/Unit: Standardize SetFacingTo and SetFacingToObject behavior while moving. Both now fail while moving unless arg2 bool is true.
5952752 follow-up: Member declaration now matches order of usage.
Instance/Naxxramas: Loatheb no longer instantly murders you. Five spam casts of Doom tend to do that to raids.
DB/SAI: A Rough Ride
PCH build fix. Again.
Core/Movement: Add a convenience default ctor to SplineChainResumeInfo, and fix PCH build in some configurations (zzz why do we even keep Appveyor and Travis around).
Merge remote-tracking branch 'Treeston/3.3.5-splinechains' into 3.3.5 (PR #17946)
Core/Movement: Add new SplineChainMovementGenerator that allows accurate replication of sniffed waypoints in static sequences, along with DB facilities that allow loading of waypoints from DB.
DB/Loot: Burning Legion Missive (Alliance version) should always drop.
DB/Loot: item Bog Lord Tendril is not a quest item.
DB/Quest: Arzeth's Demise:
DB/Creature: Fix unit flag for Tatjana (Unconscious)
DB/Reputation: fix reputation gains for Kurenai.
DB/Quest: Anatoly will talk
DB/Misc: Misc Fixes
DB/SmartAI: Fix charm SAI for Quest 12308 "Escape from Silverbrook"
DB/Spell: remove SP scaling for Shaman T9 Elemental 4p bonus
DB/Spell: remove SP scaling for Shaman T8 Elemental 4p bonus
Rename 2016_09_17_08_world.sql to 2016_09_17_02_world.sql
DB/Spell: remove SP scaling for Spirit Hunt
This sql is only for 335
DB/Object: Update location of Tua'kea's Fishing Hook
DB/Creature: Add missing IMMUNE_TO_NPC to Dahlia Suntouch.
Core/Scripts: simplified npc_pet_trainer gossip script
DB/Quest: fix prevquests required for Gretta the Arbiter's daily quests.
DB/Quest: Dragonblight/Borean Tundra:
DB/Quest: Dragonblight part 2:
DB/Quest: Dragonblight:
DB/Conditions: allow item Goramosh's Strange Device to also drop if the quest Prevent the Accord is rewarded.
DB/Quest: fix previous quests required before being able to accept The Kor'kron Vanguard!
DB/Quest: add missing prevquests for Hellfire Fortifications (for both Alliance and Horde).
DB/Quest: fix chaining for quests Spawn of the Twisted Glade and Seeds of the Blacksouled Keepers.
DB/Quest: improvements to Report to Anselm:
Map/Instances: Greatly simplify PermBindAllPlayers logic. (#17940)
DB/Loot: fix drop chance for three quest items.
DB/SAI: add script for creature Megalith.
DB/SAI: fix event for quest Street "Cred".
Core/Scripts: Fix a crash when swapping creatures with pending vehicle join events. * Closes #17833
Core/Scripts: Fix a crash when adding/removing objects from the map while swapping * Ref #17833
DB/Quest: fix faction availability for Past Endeavors.
DB/Loot: fix drop chance for two quest items.
DB/Quest: remove wrong spell cast for quest The Dead Rise!
Fix wrong copy-paste from last commit.
Core/Achievement: do not consider overkill damage for ACHIEVEMENT_CRITERIA_TYPE_DAMAGE_DONE.
DB/Spell: remove SP scaling for Swift Hand of Justice heal
DB/Spell: remove SP scaling for Glyph of Holy Light
DB/Quest: fix quest credit target type for Krolmir, Hammer of Storms
Core/Creature: enable pet bar for TempSummons with category SUMMON_CATEGORY_PET.
Rename  	2016_09_14_03_world.sql to 2016_09_14_03_world.sql
DB/SAI: Teron Gorefiend I am ....
Core/SmartAI: do not target player's group for SMART_ACTION_CALL_AREAEXPLOREDOREVENTHAPPENS.
DB/Quest: improve end event for A Daughter's Love.
DB/Quest: end event for For Love Eternal.
DB/Spell: remove SP scaling for Sheath of Light HoT
Maps/Boundary: Some code style clean-up in AreaBoundary code, as well as adding an additional utility overload to IsWithinBoundary (Position const&).
Common/Utilities: More std::chrono overloads for EventMap. Specifying 2 std::chrono types now gives you a random (to milliseconds) time in that interval (inclusive) for (Re)ScheduleEvent.
DB/SmartScripts: Fix Jewelcrafting stone statues.
DB/Spell: remove SP Scaling for Druid T10 4p bonus (Balance)
DB/conditions: add condition Pet Type to Pet Trainers gossip
DB/Spell: Glyph of Rejuvenation shouldn't scale with SP
Follow-up to  6f1e823.
Core/Fishing: implement retail-like fishing skill-up functionality (#17528)
DB/Spell: remove SP scaling for Imp. Leader of the Pack
Rename 2016_09_12_03_world.sql to 2016_09_13_01_world.sql
DB/Quest: improvements for Test at Sea:
DB/Quest: Let's Go Surfing Now
Core/Spell: Updated SpellInfo::GetMaxTicks with all effects capable of periodics
Core/Fishing: ignore required skill when fishing in pools.
Core/Spell: do not cast interrupt effect if the spell did not hit
Instance/UtgardePinnacle: Fix Svala Sorrowgrave timings (from sniff).
DB/Spell: Add some attributes to Horsemen Credit
DB/Spell: Priest T10 2p bonus shouldn't scale with SP either
Rename 2016_09_11_02_world.sql to 2016_09_12_00_world.sql
DB/Spell: Fix some set bonus scaling with spell power
Update DBUpdater.cpp
Update DBUpdater.cpp
Core/Updater: Clarify more 2 errors
Update FindOpenSSL.cmake
Cmake: Clarify OpenSSL version required
Cmake: Added OpenSSL version required
DB/SAI: fix wrong caster for a spell involved in quest "Towers of Certain Doom"
Core/Movement: Fix an edge case crash in HomeMovementGenerator.
Core/SpellMgr: removed some wrong spells from LoadSpellInfoCorrections:
DB/Misc: replace wrong spell used in spell_area for Scalawag Point.
DB/Quest: fix reputation gains for two Storm Peaks' quests
DB/Quest: small fixes for The Frost Wyrm and its Master.
DB/Script: implement event for quest 9542 (Totem of Vark)
DB/Creature: remove wrong spell from NPC "Venture Co. Saboteur" and add correct one.
Woops. Thanks, clang.
Entities/Object: Add some Position const& overloads to distance/angle methods for usability.
DB/Quest: add completion text for "Learning the Language".
DB/Gossip: fix gossip text for creature "Admiral Odesyus"
DB/Spell: prevent serverside auras for Paladin talent Pursuit of Justice from vanishing after death.
Script/Quest: fix and use proper serverside summon spell for quest "Red Snapper - Very Tasty!".
Script/Quest: replace wrong test spell used for quest "Red Snapper - Very Tasty!" with actual summoning.
Core/Scripts: Enhance quest status hook by making it catch more status changes (#17865)
Fine, this time I actually built it. Promise.
Build fix.
Game/Scripting: Follow-up to b3d44d6. Fix script selection for creatures on difficulty > 0.
Core/Maps: Add override to allow InstanceMap const* -> InstanceScript const*.
Core/Conditions: New CONDITION_QUESTSTATE (47). It's the existing quest conditions collapsed into a bitmask value2 because I'm a lazy person that doesn't like having long SQL queries.
Creature/Scripting: Move CreatureAI::CanRespawn to CreatureScript::CanSpawn. Now also applies to initial spawn. Dynamic spawning prep.
Derp. Build fix.
AI/SmartAI: Fix an issue where SmartAI creatures would not properly follow their owner on evade. Also fix a bug where creatures with INHABIT_ROOT would get stuck in evade under certain conditions.
DB/Quest: Fix vehicle SAI for quests 12910 and 12855 (Sniffing out the Perpetrator H/A). Tagging issue #17914.
Core/Entities: moved duplicated triggered cast proc check to Unit::ProcDamageAndSpellFor, it was preventing some always triggered auras from proccing.
Core/AI: updated SpellTargetSelector::operator() (#17824 follow-up)