PVS-StudioWarnings

PVS-Studio warning V526 for PostgreSQL

Nov 18th, 2014
160
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.59 KB | None | 0 0
  1. Datum
  2. pg_stat_get_activity(PG_FUNCTION_ARGS)
  3. {
  4.   ....
  5.   if (memcmp(&(beentry->st_clientaddr), &zero_clientaddr,
  6.              sizeof(zero_clientaddr) == 0))
  7.   ....
  8. }
  9.  
  10. This suspicious code was found in PostgreSQL project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V526 The 'memcmp' function returns 0 if corresponding buffers are equal. Consider examining the condition for mistakes. postgres pgstatfuncs.c 712
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment