PVS-StudioWarnings

PVS-Studio warning V501 for TPP

Nov 11th, 2014
149
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.74 KB | None | 0 0
  1. void DIGEST_PROTEIN(char *szSeq,
  2.        int iLenSeq)
  3. {
  4.   ...
  5.   if (pOptions.bMarkNXST
  6.       && szPeptide[i] == 'N'
  7.       && szPeptide[i + 1] != 'P'
  8.       && (szPeptide[i + 2] == 'S' ||
  9.           szPeptide[i + 2] == 'T')
  10.       && szPeptide[i + 1] != 'P')
  11.   ...
  12. }
  13.  
  14. The index in the last line should be this: [i + 3].
  15.  
  16. This suspicious code was found in TPP project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V501 There are identical sub-expressions 'szPeptide[i + 1] != 'P'' to the left and to the right of the '&&' operator. Comet_fastadb comet-fastadb1.cxx 1906
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment