PVS-StudioWarnings

PVS-Studio warning V512 for ReactOS

Nov 19th, 2014
164
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.69 KB | None | 0 0
  1. VOID
  2. UnloadAppInitDlls()
  3. {
  4.   ...
  5.   WCHAR buffer[KEY_LENGTH];
  6.   ...
  7.   RtlCopyMemory(buffer, szAppInit, KEY_LENGTH);
  8.   ...
  9. }
  10.  
  11. Multiplication by sizeof(WCHAR) is missing, which causes copying only half of the data. This is what the code should look like: RtlCopyMemory(buffer, szAppInit, KEY_LENGTH * sizeof(WCHAR)).
  12.  
  13. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V512 A call of the 'memcpy' function will lead to underflow of the buffer 'buffer'. user32 dllmain.c 162
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment