PVS-StudioWarnings

PVS-Studio warning V519 for ReactOS

Nov 11th, 2014
143
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.81 KB | None | 0 0
  1. static HRESULT WINAPI BmpFrameEncode_Commit(....)
  2. {
  3.   ...
  4.   bih.bV5RedMask = This->format->redmask;
  5.   bih.bV5GreenMask = This->format->greenmask;
  6.   bih.bV5BlueMask = This->format->bluemask;
  7.   bih.bV5AlphaMask = This->format->alphamask;  <<<---
  8.   bih.bV5AlphaMask = LCS_DEVICE_RGB;           <<<---
  9.   ...
  10. }
  11.  
  12. Most likely this is what should be written here: bih.bV5CSType = LCS_DEVICE_RGB;
  13.  
  14. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V519 The 'bih.bV5AlphaMask' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 357, 358. windowscodecs bmpencode.c 358
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment