Advertisement
PVS-StudioWarnings

PVS-Studio warning V594 for ReactOS

Nov 27th, 2014
191
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.69 KB | None | 0 0
  1. FF_T_WCHAR FileName[FF_MAX_FILENAME];
  2.  
  3. FF_T_UINT32 FF_FindEntryInDir(....) {
  4.   ....
  5.   FF_T_WCHAR *lastPtr = pDirent->FileName +
  6.                         sizeof(pDirent->FileName);
  7.   ....
  8.   lastPtr[-1] = '\0';
  9.   ....
  10. }
  11.  
  12. This is what should have been written here: FF_T_WCHAR *lastPtr = pDirent->FileName + sizeof(pDirent->FileName) / sizeof(pDirent->FileName[0]);
  13.  
  14. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V594 The pointer steps out of array's bounds. ff_dir.c 260
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement