Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- 22:16 - Noob: looks like this http://i.imgur.com/RYZQgbv.jpg
- 22:16 - IzNoGoD #noticket: u didnt center the route name?
- 22:16 - IzNoGoD #noticket: wot
- 22:16 - Noob: I didn't make it
- 22:16 - IzNoGoD #noticket: prev/next have different fontscale compared to names/times
- 22:17 - Noob: yeah, they should be smaller
- 22:17 - Noob: If you see any poptential bugs, I would aprreciate if you told me xd
- 22:18 - IzNoGoD #noticket: oh im seeing so much shitty code lol
- 22:18 - IzNoGoD #noticket: 9999999 as a number
- 22:18 - IzNoGoD #noticket: and as a string
- 22:18 - Noob: xd
- 22:18 - IzNoGoD #noticket: *shivers
- 22:18 - Noob: lol
- 22:18 - IzNoGoD #noticket: ugh not using undefined for anything
- 22:18 - Noob: this is the guy
- 22:18 - Noob: https://www.youtube.com/user/paap15/videos
- 22:18 - IzNoGoD #noticket: its there for a reason
- 22:18 - Noob: I didn't write it
- 22:19 - Noob: I am just happy it works
- 22:21 - IzNoGoD #noticket: wtf is this
- 22:21 - IzNoGoD #noticket: he's using 999999 where he should be using undefined
- 22:21 - IzNoGoD #noticket: using undefined where he should be using false
- 22:21 - Noob: All I know is it works
- 22:21 - IzNoGoD #noticket: istouching() isntead of waittill on triggers
- 22:21 - Noob: Not saying it's perfect
- 22:21 - Noob: but works
- 22:22 - Noob: Is any of it exploitable? Or crash-causing?
- 22:22 - IzNoGoD #noticket: crash causing ye
- 22:22 - Noob: Which
- 22:23 - IzNoGoD #noticket: oh god
- 22:23 - IzNoGoD #noticket: race condition
- 22:23 - IzNoGoD #noticket: ugh
- 22:23 - Noob: ?
- 22:23 - IzNoGoD #noticket: line 906 for excample
- 22:23 - IzNoGoD #noticket: theres a notify easy_stop
- 22:23 - IzNoGoD #noticket: and on 907 theres checkpointreset
- 22:23 - IzNoGoD #noticket: checkpointreset also fires a easy_stop
- 22:23 - IzNoGoD #noticket: thats no biggy though
- 22:24 - Noob: Is any of it actually crash-causing?
- 22:24 - IzNoGoD #noticket: ye
- 22:24 - IzNoGoD #noticket: if i connect a few times to it and disconnect
- 22:24 - IzNoGoD #noticket: then theres too many variables in use
- 22:24 - IzNoGoD #noticket: cause nothing ends on disconnect
- 22:24 - Noob: That will actually crash?
- 22:24 - IzNoGoD #noticket: dunno how many connects itll take
- 22:24 - IzNoGoD #noticket: but eventually itll crash
- 22:25 - Noob: Shit
- 22:25 - IzNoGoD #noticket: and
- 22:25 - IzNoGoD #noticket: for example
- 22:25 - IzNoGoD #noticket: look at line 1014
- 22:25 - IzNoGoD #noticket: thread checkpointreset()
- 22:25 - IzNoGoD #noticket: followed on 1017 by interpluschk
- 22:25 - IzNoGoD #noticket: ()
- 22:25 - IzNoGoD #noticket: checkpointreset fires a notify interplus_stop
- 22:25 - IzNoGoD #noticket: which interpluschk ends on
- 22:26 - IzNoGoD #noticket: race condition
- 22:26 - IzNoGoD #noticket: cant tell which one will execute first
- 22:26 - IzNoGoD #noticket: if it reads the endon first, interpluschk will not actually run
- 22:26 - IzNoGoD #noticket: same for all other routes
- 22:27 - IzNoGoD #noticket: and
- 22:27 - IzNoGoD #noticket: if you get all records filled
- 22:27 - IzNoGoD #noticket: with players of the max name length
- 22:27 - IzNoGoD #noticket: which is 32 iirc
- 22:27 - IzNoGoD #noticket: maybe its 16 though
- 22:27 - IzNoGoD #noticket: not entirely sure
- 22:27 - Noob: think 16
- 22:27 - Noob: 3xP'FirsbeeSky is limit so
- 22:27 - IzNoGoD #noticket: ah
- 22:28 - Noob: it won't go too far
- 22:28 - IzNoGoD #noticket: anyway you're way too close to the 1024 char limit in your scores_mapname dvar
- 22:28 - IzNoGoD #noticket: 16 chars per name
- 22:28 - IzNoGoD #noticket: +1 char for the ,
- 22:28 - IzNoGoD #noticket: +8 for guid
- 22:28 - IzNoGoD #noticket: + 1 for ,
- 22:28 - IzNoGoD #noticket: +idk for time, lets say 6 chars
- 22:28 - IzNoGoD #noticket: + the ;
- 22:28 - IzNoGoD #noticket: times 5 routes times 6 records
- 22:29 - IzNoGoD #noticket: thats 30*33 chars
- 22:29 - IzNoGoD #noticket: 990
- 22:29 - IzNoGoD #noticket: too close to 1024 for comfort.
- 22:29 - IzNoGoD #noticket: lets say everyone takes forever to finish
- 22:29 - IzNoGoD #noticket: so youll have 8 chars in your time part
- 22:30 - Noob: Ok well thanks for the input
- 22:30 - IzNoGoD #noticket: and wtf is this shit
- 22:30 - IzNoGoD #noticket: lol
- 22:30 - Noob: Any suggestions on fix?
- 22:30 - IzNoGoD #noticket: its not bugging but
- 22:30 - IzNoGoD #noticket: first he resets scores_mapname dvar
- 22:30 - IzNoGoD #noticket: then he uses addtodvar(scores_mapname, something)
- 22:30 - IzNoGoD #noticket: addtodvar reads the current value of scores_mapname (which is an empty string) and adds the something to it
- 22:30 - IzNoGoD #noticket: why not use setdvar instead
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement