Advertisement
PVS-StudioWarnings

PVS-Studio warning V562 for spvolren

Nov 21st, 2014
155
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.58 KB | None | 0 0
  1. void ppmWrite(char *filename, PPMFile *ppmFile)
  2. {
  3.   ...
  4.   FILE *fp;
  5.   if (! (fp = fopen(filename, "wb")) == -1) {
  6.     perror("opening image file failed");
  7.     exit(1);
  8.   }
  9.   ...
  10. }
  11.  
  12. This suspicious code was found in spvolren project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V562 It's odd to compare a bool type value with a value of -1: !(fp = fopen (filename, "wb")) == - 1. spvolren ppm.c 118
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement