Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- diff --git a/Common/Categories/UIViewController+Errors.m b/Common/Categories/UIViewController+Errors.m
- index af06fb6..08a34ef 100644
- --- a/Common/Categories/UIViewController+Errors.m
- +++ b/Common/Categories/UIViewController+Errors.m
- @@ -80,7 +80,7 @@ static NSString * const kETsyUIViewControllerErrorDismissBlockKey = @"kETsyUIVie
- if (self.analyticsName) {
- NSDictionary * attributes = @{@"error_message": message ?: @""};
- - [EtsyAnalytics trackEvent:@"displayed_error_banner" inView:self.analyticsName attributes:attributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"displayed_error_banner" properties:attributes];
- }
- }
- @@ -109,7 +109,8 @@ static NSString * const kETsyUIViewControllerErrorDismissBlockKey = @"kETsyUIVie
- if (self.analyticsName) {
- NSDictionary * attributes = @{@"success_message": message ?: @""};
- - [EtsyAnalytics trackEvent:@"displayed_success_banner" inView:self.analyticsName attributes:attributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"displayed_success_banner" properties:attributes];
- +
- }
- }
- diff --git a/Common/Categories/UIViewController+Referrals.m b/Common/Categories/UIViewController+Referrals.m
- index 0478d6e..9ab7140 100644
- --- a/Common/Categories/UIViewController+Referrals.m
- +++ b/Common/Categories/UIViewController+Referrals.m
- @@ -141,8 +141,7 @@
- navController.toolbarHidden = NO;
- aboutController.dismissModalBarButtonItemStyle = EtsyDismissModalBarButtonItemStyleX;
- - [EtsyAnalytics trackEvent:context action:@"invites_view_learn_more"
- - attributes:[referrals defaultEventProperties]];
- + [self.analyticsContext logAnalyticsEventNamed:@"invites_view_learn_more" properties:[referrals defaultEventProperties]];
- [referrals logMetric:@"invites_view_learn_more"
- withProperties:NSDictionaryOfVariableBindings(context)];
- @@ -287,9 +286,7 @@
- [referrals logMetric:@"invites_share_module" withProperties:eventAttributes];
- - [EtsyAnalytics trackEvent:event
- - action:eventAction
- - attributes:eventAttributes];
- + [self.analyticsContext logAnalyticsEventNamed:eventAction properties:eventAttributes];
- //
- // Event logging parity with web
- @@ -310,7 +307,7 @@
- if (secondaryLogEvent) {
- eventAttributes[@"share_action"] = action;
- [eventAttributes setObjectOrNil:context forKeyOrNil:@"share_context"];
- - [EtsyAnalytics trackPageview:secondaryLogEvent attributes:eventAttributes];
- + [self.analyticsContext logAnalyticsEventNamed:secondaryLogEvent properties:eventAttributes];
- }
- }
- diff --git a/Common/Helpers/EtsyImageScrollViewVideoUtility.m b/Common/Helpers/EtsyImageScrollViewVideoUtility.m
- index 1a302ac..8f10c08 100644
- --- a/Common/Helpers/EtsyImageScrollViewVideoUtility.m
- +++ b/Common/Helpers/EtsyImageScrollViewVideoUtility.m
- @@ -23,6 +23,7 @@
- @property (nonatomic, assign) BOOL trackedPlay;
- @property (nonatomic, strong) id<EtsyObjectID> shopID;
- @property (nonatomic, strong) EtsyShopAboutVideo *aboutVideo;
- +@property (readonly, weak) EtsyAnalyticsContext *analyticsContext;
- @end
- @implementation EtsyImageScrollViewVideoUtility
- @@ -37,7 +38,7 @@
- NSDictionary *atrs = [self attributesForVideoPlayback];
- - [EtsyAnalytics trackEvent:@"shop_about_video_tapped" inView:analyticsName attributes:atrs];
- + [self.analyticsContext logAnalyticsEventNamed:@"shop_about_video_tapped" properties:atrs];
- if(video) {
- if([EtsyEnvironmentInfo isIOS8OrHigher]) {
- AVPlayerViewController *playerVC = [[AVPlayerViewController alloc] init];
- @@ -48,10 +49,10 @@
- EK_STRONGIFY(playerVC);
- [playerVC.player play];
- if(playerVC.player.error) {
- - [EtsyAnalytics trackEvent:@"shop_about_video_playback_error" inView:analyticsName attributes:atrs];
- + [self.analyticsContext logAnalyticsEventNamed:@"shop_about_video_playback_error" properties:atrs];
- [[EtsyGraphite metricWithName:@"shop.about.video.playback_error"] increment];
- } else {
- - [EtsyAnalytics trackEvent:@"shop_about_video_played" inView:analyticsName attributes:atrs];
- + [self.analyticsContext logAnalyticsEventNamed:@"shop_about_video_played" properties:atrs];
- }
- }];
- } else {
- @@ -77,17 +78,13 @@
- if(state == MPMoviePlaybackStatePlaying && !self.trackedPlay) {
- self.trackedPlay = YES;
- - [EtsyAnalytics trackEvent:@"shop_about_video_played"
- - inView:self.analyticsName
- - attributes:[self attributesForVideoPlayback]];
- + [self.analyticsContext logAnalyticsEventNamed:@"shop_about_video_played" properties:[self attributesForVideoPlayback]];
- }
- }
- - (void)videoViewController:(UIViewController *)videoViewController didReceivePlaybackFinishedNotificationWithReason:(MPMovieFinishReason)reason error:(NSError *)error {
- if(error) {
- - [EtsyAnalytics trackEvent:@"shop_about_video_playback_error"
- - inView:self.analyticsName
- - attributes:[self attributesForVideoPlayback]];
- + [self.analyticsContext logAnalyticsEventNamed:@"shop_about_video_playback_error" properties:[self attributesForVideoPlayback]];
- [[EtsyGraphite metricWithName:@"shop.about.video.playback_error"] increment];
- }
- }
- diff --git a/Common/Sharing/Social Invites/EtsySocialInvitesToastView.m b/Common/Sharing/Social Invites/EtsySocialInvitesToastView.m
- index 355bb20..bdaf9db 100644
- --- a/Common/Sharing/Social Invites/EtsySocialInvitesToastView.m
- +++ b/Common/Sharing/Social Invites/EtsySocialInvitesToastView.m
- @@ -104,13 +104,13 @@ static const CGFloat kToastFontSize = 14;
- if(show) {
- self.canHide = NO;
- - [EtsyAnalytics trackEvent:@"toast_shown" inView:@"social_invites" attributes:[self logAttributes]];
- + [self.analyticsContext logAnalyticsEventNamed:@"toast_shown" properties:[self logAttributes]];
- [[EtsyGraphite metricWithName:S(@"appgrowth.socialInvites.toast.show.%@", self.trigger) prefix:@"performance.native.ios"] increment];
- dispatch_after(dispatch_time(DISPATCH_TIME_NOW, (int64_t)(kEtsySocialInvitesToastMinimumDuration * NSEC_PER_SEC)), dispatch_get_main_queue(), ^{
- self.canHide = YES;
- });
- } else {
- - [EtsyAnalytics trackEvent:@"toast_ignored" inView:@"social_invites" attributes:[self logAttributes]];
- + [self.analyticsContext logAnalyticsEventNamed:@"toast_ignored" properties:[self logAttributes]];
- [[EtsyGraphite metricWithName:S(@"appgrowth.socialInvites.toast.ignored.%@", self.trigger) prefix:@"performance.native.ios"] increment];
- }
- @@ -154,7 +154,7 @@ static const CGFloat kToastFontSize = 14;
- }
- - (void)didTap {
- - [EtsyAnalytics trackEvent:@"toast_tapped" inView:@"social_invites" attributes:[self logAttributes]];
- + [self.analyticsContext logAnalyticsEventNamed:@"toast_tapped" properties:[self logAttributes]];
- [[EtsyGraphite metricWithName:S(@"appgrowth.socialInvites.toast.tapped.%@", self.trigger) prefix:@"performance.native.ios"] increment];
- if(self.tapped) {
- self.tapped(self);
- diff --git a/Libraries/facebook-ios-sdk b/Libraries/facebook-ios-sdk
- --- a/Libraries/facebook-ios-sdk
- +++ b/Libraries/facebook-ios-sdk
- @@ -1 +1 @@
- -Subproject commit a0e29cd3183079475c9484909f34e2d3739752f4
- +Subproject commit a0e29cd3183079475c9484909f34e2d3739752f4-dirty
- diff --git a/buyonetsy/Code/ActivityFeed/BOENewActivityFeedViewController.m b/buyonetsy/Code/ActivityFeed/BOENewActivityFeedViewController.m
- index 72acacf..514bbfd 100644
- --- a/buyonetsy/Code/ActivityFeed/BOENewActivityFeedViewController.m
- +++ b/buyonetsy/Code/ActivityFeed/BOENewActivityFeedViewController.m
- @@ -337,7 +337,7 @@ static const UIEdgeInsets kEtsyActivityFeedEdgeInsets = {kEtsyActivityFeedIPhone
- NSDictionary *attributes = [EtsyAnalytics attributesForActivityFeedResponse:result pageNumber:resource.pageNumber];
- - [EtsyAnalytics trackEvent:self.analyticsName action:@"activity_feed" attributes:attributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"activity_feed" properties:attributes];
- [self.view setNeedsLayout];
- }
- diff --git a/buyonetsy/Code/Cart+Checkout/BOECartCheckoutButtonView.m b/buyonetsy/Code/Cart+Checkout/BOECartCheckoutButtonView.m
- index 01d1b44..521be81 100644
- --- a/buyonetsy/Code/Cart+Checkout/BOECartCheckoutButtonView.m
- +++ b/buyonetsy/Code/Cart+Checkout/BOECartCheckoutButtonView.m
- @@ -169,7 +169,7 @@ static const CGFloat EtsyCartCellCheckoutButtonHeight = 50;
- #pragma MARK UITextViewDelegate
- - (BOOL)textView:(UITextView *)textView shouldInteractWithURL:(NSURL *)url inRange:(NSRange)characterRange {
- - [EtsyAnalytics trackEvent:@"applepay_house_rules_link_clicked" inView:nil attributes:@{ @"URL": url.absoluteString }];
- + [self.analyticsContext logAnalyticsEventNamed:@"applepay_house_rules_link_clicked" properties:@{ @"URL": url.absoluteString }];
- return YES;
- }
- diff --git a/buyonetsy/Code/FriendFinder/EtsyFriendFinderResultsController.m b/buyonetsy/Code/FriendFinder/EtsyFriendFinderResultsController.m
- index 6b97a7a..611b19b 100644
- --- a/buyonetsy/Code/FriendFinder/EtsyFriendFinderResultsController.m
- +++ b/buyonetsy/Code/FriendFinder/EtsyFriendFinderResultsController.m
- @@ -464,7 +464,7 @@ NSString *EtsyFindFriendsResultsReuseIdentifier = @"EtsyFindFriendsResultsReuseI
- LOG(@"Friend finder", @"Error following user: %@", error);
- }] load];
- - [EtsyAnalytics trackEvent:@"friend_finder" action:@"friend_finder_follow_all_button_tapped" label:@"Follow"];
- + [self.analyticsContext logAnalyticsEventNamed:@"friend_finder_follow_all_button_tapped" properties:nil];
- } authReason:EtsyAuthReasonFollowAllFriends];
- }
- diff --git a/buyonetsy/Code/FundOnEtsy/Onboarding/Controllers/BOEFundOnEtsyOnboardingViewController.m b/buyonetsy/Code/FundOnEtsy/Onboarding/Controllers/BOEFundOnEtsyOnboardingViewController.m
- index 983f208..a3564aa 100644
- --- a/buyonetsy/Code/FundOnEtsy/Onboarding/Controllers/BOEFundOnEtsyOnboardingViewController.m
- +++ b/buyonetsy/Code/FundOnEtsy/Onboarding/Controllers/BOEFundOnEtsyOnboardingViewController.m
- @@ -96,13 +96,13 @@ static CGFloat const kPageControlHeight = 35.f;
- [me orientationUpdated];
- } name:UIDeviceOrientationDidChangeNotification object:nil];
- - [EtsyAnalytics trackPageview:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:self.analyticsName properties:nil];
- }
- - (void)viewDidAppear:(BOOL)animated {
- [super viewDidAppear:animated];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_onboarding_show" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_onboarding_show" properties:nil];
- }
- - (void)orientationUpdated {
- @@ -185,12 +185,12 @@ static CGFloat const kPageControlHeight = 35.f;
- #pragma mark - FundOnEtsySlideshowCardViewDelegate
- - (void)fundOnEtsySlideshowCardViewDidTapGotIt:(BOEFundOnEtsySlideshowCardView *)fundOnEtsySlideshowCardView {
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_onboarding_got_it" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_onboarding_got_it" properties:nil];
- [self dismissViewControllerAnimated:YES completion:nil];
- }
- - (void)fundOnEtsySlideshowCardViewDidTapClose:(BOEFundOnEtsySlideshowCardView *)fundOnEtsySlideshowCardView {
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_onboarding_dismiss" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_onboarding_dismiss" properties:nil];
- [self dismissViewControllerAnimated:YES completion:nil];
- }
- diff --git a/buyonetsy/Code/GiftCards/EtsyBuyGiftCardController.m b/buyonetsy/Code/GiftCards/EtsyBuyGiftCardController.m
- index 3c4f985..a88af06 100644
- --- a/buyonetsy/Code/GiftCards/EtsyBuyGiftCardController.m
- +++ b/buyonetsy/Code/GiftCards/EtsyBuyGiftCardController.m
- @@ -237,7 +237,7 @@ typedef enum {
- [self relayout];
- - [EtsyAnalytics trackPageview:@"buy_gift_card_view" attributes:@{@"is_updating_gift_card" : (_giftCardListing ? @1 : @0)}];
- + [self.analyticsContext logAnalyticsEventNamed:@"buy_gift_card_view" properties:@{@"is_updating_gift_card" : (_giftCardListing ? @1 : @0)}];
- }
- - (void)layoutCarouselAndTextFieldsWithListing:(EtsyCartListing *)listing
- @@ -488,14 +488,14 @@ typedef enum {
- if ([_delegate respondsToSelector:@selector(didUpdateGiftCard:)])
- [_delegate didUpdateGiftCard:cart];
- - [EtsyAnalytics trackEvent:@"buy_gift_card_view" action:@"updated_gift_card" label:nil value:0 attributes:trackingAttributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"updated_gift_card" properties:trackingAttributes];
- }
- else
- {
- if ([_delegate respondsToSelector:@selector(didBuyGiftCard)])
- [_delegate didBuyGiftCard];
- - [EtsyAnalytics trackEvent:@"buy_gift_card_view" action:@"added_gift_card_to_cart" label:nil value:0 attributes:trackingAttributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"added_gift_card_to_cart" properties:trackingAttributes];
- }
- [self dismiss];
- diff --git a/buyonetsy/Code/Home/BOEListingCollectionEditableViewController.m b/buyonetsy/Code/Home/BOEListingCollectionEditableViewController.m
- index d41058a..525030e 100644
- --- a/buyonetsy/Code/Home/BOEListingCollectionEditableViewController.m
- +++ b/buyonetsy/Code/Home/BOEListingCollectionEditableViewController.m
- @@ -69,7 +69,7 @@ static CGFloat const kListingDeletedHUDMaxWidth = 414.0f;
- - (void)deleteButtonPressedCell:(EtsyListingCollectionCell *)cell listingId:(id<EtsyObjectID>)listingId {
- NSDictionary * attributes = listingId ? @{@"listing_id": listingId} : nil;
- - [EtsyAnalytics trackEvent:@"homescreen_editable_collection_listing_deleted" inView:self.analyticsName attributes:attributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"homescreen_editable_collection_listing_deleted" properties:attributes];
- [self.editableViewDelegate listingDeleted:listingId];
- if ([self.editableViewDelegate numberOfListingsRemaining] == 0) {
- [self.navigationController popViewControllerAnimated:YES];
- @@ -94,7 +94,7 @@ static CGFloat const kListingDeletedHUDMaxWidth = 414.0f;
- [self.collectionView reloadItemsAtIndexPaths:[self.collectionView indexPathsForVisibleItems]];
- - [EtsyAnalytics trackEvent:@"homescreen_editable_collection_entered_edit_mode" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"homescreen_editable_collection_entered_edit_mode" properties:nil];
- }
- - (UIBarButtonItem*)makeDoneButtonItem {
- diff --git a/buyonetsy/Code/Listing/EtsyListingAddToCartButtonsView.m b/buyonetsy/Code/Listing/EtsyListingAddToCartButtonsView.m
- index a8e1638..d4d65bd 100644
- --- a/buyonetsy/Code/Listing/EtsyListingAddToCartButtonsView.m
- +++ b/buyonetsy/Code/Listing/EtsyListingAddToCartButtonsView.m
- @@ -669,7 +669,7 @@ typedef NS_ENUM(NSInteger, BOEListingOptionsCompletionIntention) {
- NSDictionary *analyticsDict = @{@"listing_id": self.listing.listing_id};
- if (self.inCart) {
- - [EtsyAnalytics trackEvent:@"view_listing" action:@"in_cart_tapped" label:nil value:0 attributes:analyticsDict];
- + [self.analyticsContext logAnalyticsEventNamed:@"in_cart_tapped" properties:analyticsDict];
- [[NSNotificationCenter defaultCenter] postNotificationName:kEtsyNotificationShowListingInCart object:nil
- userInfo:@{@"listing_id": self.listing.listing_id, @"listing": self.listing}];
- diff --git a/buyonetsy/Code/Listing/EtsyListingFundingButtonsView.m b/buyonetsy/Code/Listing/EtsyListingFundingButtonsView.m
- index d200e7a..a889c15 100644
- --- a/buyonetsy/Code/Listing/EtsyListingFundingButtonsView.m
- +++ b/buyonetsy/Code/Listing/EtsyListingFundingButtonsView.m
- @@ -441,7 +441,7 @@ static CGFloat const kEtsyListingPageFundButtonHeight = 51.f;
- if (!self.hasSeenPrimaryOptions && self.listing.FundingOptions.count > 1) {
- [self showPrimaryOptionsDropDownForButton:self.primaryOptionsBtn options:self.listing.FundingOptions intentToAddToCart:YES];
- self.hasSeenPrimaryOptions = YES;
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_fund_campaign_options_not_selected" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_fund_campaign_options_not_selected" properties:nil];
- return;
- }
- // Ensure all sub-options are selected
- @@ -450,7 +450,7 @@ static CGFloat const kEtsyListingPageFundButtonHeight = 51.f;
- if (!obj.selectedOption) {
- EtsyLabeledButton *button = self.buttons[idx-1];
- [self showSubOptionsDropDownForButton:button options:obj.options intentToAddToCart:YES];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_fund_campaign_options_not_selected" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_fund_campaign_options_not_selected" properties:nil];
- *stop = YES;
- }
- }];
- diff --git a/buyonetsy/Code/Listing/EtsyListingTitleView.m b/buyonetsy/Code/Listing/EtsyListingTitleView.m
- index 2c68f24..c9e154c 100644
- --- a/buyonetsy/Code/Listing/EtsyListingTitleView.m
- +++ b/buyonetsy/Code/Listing/EtsyListingTitleView.m
- @@ -43,7 +43,7 @@
- [UIView animateWithDuration:0.2 animations:^{
- [self.label sizeToFit];
- }];
- - [EtsyAnalytics trackEvent:@"view_listing" action:@"title_expanded" label:nil value:(int)self.label.attributedText.length attributes:@{}];
- + [self.analyticsContext logAnalyticsEventNamed:@"title_expanded" properties:@{}];
- }
- -(void)layoutSubviews
- diff --git a/buyonetsy/Code/Listing/EtsyListingViewController+FavoritesOnboarding.m b/buyonetsy/Code/Listing/EtsyListingViewController+FavoritesOnboarding.m
- index 977f89e..e6c2d29 100644
- --- a/buyonetsy/Code/Listing/EtsyListingViewController+FavoritesOnboarding.m
- +++ b/buyonetsy/Code/Listing/EtsyListingViewController+FavoritesOnboarding.m
- @@ -165,7 +165,8 @@ const CGFloat kEtsyOverlayTooltipFadeInDelay = 0.15; // delay before fade-down a
- [self.onboardingOverlay startAnimations];
- }];
- - [EtsyAnalytics trackEvent:@"onboarding_listing_favorite" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"onboarding_listing_favorite" properties:nil];
- +
- [[EtsyGraphite metricWithName:@"onboarding.listing.favorites.show"] increment];
- SERVER_LOG_INFO(@"BUYER_ONBOARDING", @"showing listing favorite onboarding:etsy_user_id=\"%@\"",
- [[EtsySession localUser].user_id description] ?: @0);
- @@ -186,13 +187,13 @@ const CGFloat kEtsyOverlayTooltipFadeInDelay = 0.15; // delay before fade-down a
- [self.onboardingOverlay removeFromSuperview];
- self.onboardingOverlay = nil;
- - [EtsyAnalytics trackEvent:@"onboarding_listing_favorite_dismiss" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"onboarding_listing_favorite_dismiss" properties:nil];
- [[EtsyGraphite metricWithName:@"onboarding.listing.favorites.dismiss"] increment];
- }
- - (void)onboardingViewDidTapButton:(TransparentCutoutView *)cutoutView {
- [cutoutView dismissWithCompletion:^{
- - [EtsyAnalytics trackEvent:@"onboarding_listing_favorite_tap" inView:self.analyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"onboarding_listing_favorite_tap" properties:nil];
- [[EtsyGraphite metricWithName:@"onboarding.listing.favorites.tap_heart"] increment];
- [[self toggleManager] toggle:self eventAttributes:@{@"via_favorites_onboarding": @1}];
- diff --git a/buyonetsy/Code/Listing/EtsyListingViewController.m b/buyonetsy/Code/Listing/EtsyListingViewController.m
- index 9294a79..56f6868 100644
- --- a/buyonetsy/Code/Listing/EtsyListingViewController.m
- +++ b/buyonetsy/Code/Listing/EtsyListingViewController.m
- @@ -625,7 +625,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- [listing.fundOnEtsyCampaign unionObjectData:campaign.objectData];
- }
- [resource.owner displayListing:listing];
- - [EtsyAnalytics trackPageview:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:self.fundingCampaignAnalyticsName properties:nil];
- } failure:^(EtsyResource *resource, NSError *error) {
- // Go ahead and display the listing without this info
- [resource.owner displayListing:listing];
- @@ -748,16 +748,16 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- [photoVC setSafeTransitioningDelegate:self];
- [self.screenController presentViewController:photoVC animated:YES completion:nil];
- - [EtsyAnalytics trackEvent:@"view_listing" action:@"photo_tapped" label:nil value:(int)index attributes:[self createAnalyticsAttributes:nil]];
- - [EtsyAnalytics trackPageview:@"listing_image_zoom" attributes:[self createAnalyticsAttributes:nil]];
- + [self.analyticsContext logAnalyticsEventNamed:@"photo_tapped" properties:[self createAnalyticsAttributes:nil]];
- + [self.analyticsContext logAnalyticsEventNamed:@"listing_image_zoom" properties:[self createAnalyticsAttributes:nil]];
- }
- - (void)etsyListingImages:(EtsyListingImagesView *)listingImagesView didScrollToProductImage:(NSUInteger)index
- {
- - [EtsyAnalytics trackEvent:@"view_listing" action:@"listing_image_swipe" label:nil value:0
- - attributes:[self createAnalyticsAttributes:@{ @"active_index" : @(index), @"num_images": @(self.numberOfPhotos) }]];
- + [self.analyticsContext logAnalyticsEventNamed:@"listing_image_swipe" properties:[self createAnalyticsAttributes:@{ @"active_index" : @(index), @"num_images": @(self.numberOfPhotos) }]];
- +
- }
- - (void)etsyListingImagesDidSelectVideo:(id)listingImagesView {
- @@ -858,7 +858,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- - (void)similarListingsView:(BOEListingSimilarListingsView *)view tappedListingCard:(EtsyPublicListingCard *)listingCard
- {
- - [EtsyAnalytics trackEvent:@"similar_listing_selected" inView:self.defaultAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"similar_listing_selected" properties:nil];
- EtsyListingViewController *listingVC = [[EtsyListingViewController alloc] initWithListingID:listingCard.listing_id];
- [self.screenController pushViewController:listingVC];
- }
- @@ -884,7 +884,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- {
- if (self.similarListingsScrolled == NO) {
- self.similarListingsScrolled = YES;
- - [EtsyAnalytics trackEvent:@"similar_listings_scrolled" inView:self.defaultAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"similar_listings_scrolled" properties:nil];
- }
- }
- @@ -892,7 +892,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- {
- if (self.similarListingsScrolledToEnd == NO) {
- self.similarListingsScrolledToEnd = YES;
- - [EtsyAnalytics trackEvent:@"similar_listings_scrolled_to_end" inView:self.defaultAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"similar_listings_scrolled_to_end" properties:nil];
- }
- }
- @@ -920,7 +920,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- // Display share dialog if already funding
- if (isFunding) {
- [self didTapShareButton:bannerButton];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_banner_share" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_banner_share" properties:nil];
- }
- // Otherwise redirect to web landing page
- else {
- @@ -929,7 +929,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- webView.title = @"Fund on Etsy";
- webView.shouldDisableInAppURLRedirection = YES;
- [self.screenController pushViewController:webView];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_banner_learn_more" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_banner_learn_more" properties:nil];
- }
- }
- @@ -1046,13 +1046,13 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- - (void)shopInfoFollowCampaignView:(EtsyListingFundingShopInfoFollowCampaignView *)view didTapShopView:(EtsyShop *)shop
- {
- [self displayShopView:shop];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_view_shop_from_listing" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_view_shop_from_listing" properties:nil];
- }
- - (void)shopInfoFollowCampaignView:(EtsyListingFundingShopInfoFollowCampaignView *)view didTapShopAvatar:(EtsyShop *)shop
- {
- [self displayShopView:shop];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_view_shop_from_listing" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_view_shop_from_listing" properties:nil];
- }
- #pragma mark EtsyListingPageLatestUpdateViewDelegate
- @@ -1068,7 +1068,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- {
- BOEListingUpdatesViewController *controller = [[BOEListingUpdatesViewController alloc] initWithListingId:self.listing.listing_id];
- [self.screenController pushViewController:controller];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_load_more_updates" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_load_more_updates" properties:nil];
- }
- #pragma mark UIViewControllerTransitioningDelegate
- @@ -1199,7 +1199,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- case MPMoviePlaybackStatePlaying:
- if (!self.hasVideoStartedPlaying) {
- self.hasVideoStartedPlaying = YES;
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_video_play" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_video_play" properties:nil];
- }
- break;
- default:
- @@ -1211,11 +1211,11 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- NSString *errorMsg;
- switch (reason) {
- case MPMovieFinishReasonPlaybackEnded:
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_video_completed" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_video_completed" properties:nil];
- break;
- case MPMovieFinishReasonPlaybackError:
- errorMsg = error ? [error localizedDescription] : MSG(@"Video playback failed", @"Generic video playback error message", @"");
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_video_playback_failure" error:errorMsg];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_video_playback_failure" properties:nil];
- break;
- default:
- break;
- @@ -1263,7 +1263,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- storyWebView.title = @"Story";
- storyWebView.shouldDisableInAppURLRedirection = YES;
- [self.screenController pushViewController:storyWebView];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_read_story" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_read_story" properties:nil];
- }
- - (void)fundingButtonsView:(EtsyListingFundingButtonsView *)view needsOptionsControllerPresented:(EtsyListOptionsViewController *)optionController fromView:(UIView *)sourceView {
- @@ -1337,7 +1337,7 @@ typedef NS_ENUM(NSInteger, EtsyListingViewControllerToolbarStyle) {
- completion();
- }
- }];
- - [EtsyAnalytics trackEvent:@"fund_on_etsy_fund_campaign" inView:self.fundingCampaignAnalyticsName];
- + [self.analyticsContext logAnalyticsEventNamed:@"fund_on_etsy_fund_campaign" properties:nil];
- }
- - (void)runAnalyticsNullTests {
- diff --git a/buyonetsy/Code/Local/EtsyLocalBrowseViewController.m b/buyonetsy/Code/Local/EtsyLocalBrowseViewController.m
- index b711e35..7f33eb1 100644
- --- a/buyonetsy/Code/Local/EtsyLocalBrowseViewController.m
- +++ b/buyonetsy/Code/Local/EtsyLocalBrowseViewController.m
- @@ -102,7 +102,7 @@ static NSString * const EtsyLocalBrowseAboutLocalModule = @"EtsyLocalBrowseAbout
- NSMutableDictionary *attributes = [NSMutableDictionary dictionary];
- attributes[@"lat"] = @(location.coordinate.latitude);
- attributes[@"lon"] = @(location.coordinate.longitude);
- - [EtsyAnalytics trackEvent:@"location_obtained" inView:self.container.analyticsName attributes:attributes];
- + [self.analyticsContext logAnalyticsEventNamed:@"location_obtained" properties:attributes];
- [self updateResource];
- self.shouldReloadResource = NO;
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement