Advertisement
PVS-StudioWarnings

PVS-Studio warning V636 for CxImage

Nov 26th, 2014
171
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.70 KB | None | 0 0
  1. psd_argb_color psd_alab_to_color(....)
  2. {
  3.   psd_double var_z;
  4.   ....
  5.   var_z = ( var_z - 16 / 116 ) / 7.787;
  6. }
  7.  
  8. According to the rules of integer division, 16 / 116 == 0. That's why the result will be incorrect.
  9.  
  10. This suspicious code was found in CxImage project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V636 The '16 / 116' expression was implicitly casted from 'int' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;. color.c 125
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement