Advertisement
PVS-StudioWarnings

PVS-Studio warning V668 for Chromium

Nov 10th, 2014
153
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.85 KB | None | 0 0
  1. static base::DictionaryValue* GetDictValueStats(
  2.     const webrtc::StatsReport& report)
  3. {
  4.   ....
  5.   DictionaryValue* dict = new base::DictionaryValue();
  6.   if (!dict)
  7.     return NULL;
  8.  
  9.   dict->SetDouble("timestamp", report.timestamp);
  10.  
  11.   base::ListValue* values = new base::ListValue();
  12.   if (!values) {
  13.     delete dict;
  14.     return NULL;
  15.   }
  16.   ....
  17. }
  18.  
  19. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  20. Warning message is:
  21. V668 There is no sense in testing the 'dict' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. peer_connection_tracker.cc 164
  22.  
  23. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement