Advertisement
PVS-StudioWarnings

PVS-Studio warning V528 for TortoiseGIT

Nov 27th, 2014
169
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. static const char *
  2. fuzzy_escape(const char *src, apr_size_t len, apr_pool_t *pool)
  3. {
  4.   const char *src_orig = src;
  5.   ....
  6.   while (src_orig < src_end)
  7.   {
  8.     if (! svn_ctype_isascii(*src_orig) || src_orig == '\0')
  9.   ....
  10. }
  11.  
  12. Most likely this is what should be written here: if (! svn_ctype_isascii(*src_orig) || *src_orig == '\0').
  13.  
  14. This suspicious code was found in TortoiseGIT project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V528 It is odd that pointer to 'char' type is compared with the '\0' value. Probably meant: *src_orig == '\0'. utf.c 501
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement