OpenEMR 4.1.2 (7) mysqli update/fixes

Please use caution when making ANY of the following changes. Some are required changes, and they will mention the mysqli_* function replacement, but will be missing the semi-colon. This means that the function needs to be replaced but not the entire line, where as a line fix that does include a semi-colon will be the entire line.

/setup.php

  line 14 - Notice: Undefined index: state in setup.php
if (isset($_POST["state"]))
  $state = $_POST['state'] ?: NULL;

  line 179 - Notice: Undefined index: inst in setup.php
if (isset($_POST["inst"]))
  $inst = $_POST['inst'] ?: NULL;


/library/globals.inc.php

  line 58 - date_default_timezone_set('America/...'); //Required default timezone set PHP5


/library/classes/Installer.class.php

  line 8 - (Optional) - Suggested so these are the global object variables  which aren't being set properally
  public $iuser = NULL;
  public $iuserpass = NULL;
  public $iuname = NULL;
  public $iufname = NULL;
  public $igroup = NULL;
  public $server = NULL;
  public $loginhost = NULL;
  public $port = NULL;
  public $root = NULL;
  public $rootpass = NULL;
  public $pass = NULL;
  public $dbname = NULL;
  public $collate = NULL;
  public $site = NULL;
  public $source_site_id = NULL;
  public $clone_database = NULL;
  public $no_root_db_access = NULL;
  public $development_translations = NULL;
  public $ippf_specific = NULL;
  public $conffile = NULL;

  line 31 - Notice: Undefined index: "$key" in setup.php
    foreach ($cgi_variables as $key => $var) {
      if (array_key_exists($key, $_REQUEST))
	    $this->$key           = $var;
    }

  line 122 - mysqli_select_db( $this->dbh, $this->dbname)

  line 149 - mysqli_close()

  line 209 - mysqli_error( $this->dbh) mysqli_errno( $this->dbh)
  line 217 - mysqli_error( $this->dbh) mysqli_errno( $this->dbh)
  line 225 - mysqli_error( $this->dbh) mysqli_errno( $this->dbh)
  line 233 - mysqli_error( $this->dbh) mysqli_errno( $this->dbh)

  line 286 - (Optional) - Suggested so that errors are printed and timezone is set
ini_set("display_errors", 1);
error_reporting(E_ALL);

date_default_timezone_set("America/Vancouver");

  line 325 - mysqli_fetch_array($res, MYSQLI_ASSOC)

  line 445 - mysqli_query( $this->dbh, $sql)
  line 449 - mysqli_error($this->dbh)

  line 457 - mysqli_connect()
  line 459 - mysqli_connect()


/library/classes/Controller.class.php

  line 79 - public static function act($qarray) {


/library/classes/Tree.class.php

  line 54 - if ($this->_root_type == ROOT_TYPE_NAME) {
  line 329 - $arrays = func_get_args();


/controllers/C_Document.class.php

  line 1049 - if (@is_array($categories[$id])) {


/library/sql.inc

  line 25 -
    //require_once(dirname(__FILE__) . "/adodb/drivers/adodb-mysql.inc.php");
    require_once(dirname(__FILE__) . "/adodb/drivers/adodb-mysqli.inc.php");

  line 34 - class ADODB_mysqli_log extends ADODB_mysqli
  line 126 - mysqli_insert_id($this->_connectionID)
  line 136 - NewADOConnection("mysqli_log")
  line 202 - mysqli_query($GLOBALS['dbh'], $statement)
  line 244 - mysqli_query($GLOBALS['dbh'], $statement)
  line 284 -
function sqlFetchArray($r)
{
  if (is_object($r) && get_class($r) == 'mysqli_result') {
    //ensure it's an object (ie. is set)
      return mysqli_fetch_array($r, MYSQLI_ASSOC);
  }
  elseif(is_string($r))
    return mysqli_fetch_array(sqlStatement($r), MYSQLI_ASSOC);
  else { //$r != FALSE
    //treat as an adodb recordset
    if (is_a($r->connection->_connectionID, 'mysqli')) {
      if ($r === FALSE)
        return false;
      if (!is_object($r))
        return false;
      if ($r->EOF)
        return false;
      return $r->FetchRow();

    }
  }
}

  line 497 - mysqli_error($GLOBALS['dbh'])
  line 510 - mysqli_real_escape_string($GLOBALS['dbh'], $table)
  line 513 - mysqli_fetch_array($resource, MYSQLI_ASSOC)
  line 532 -
function sqlNumRows($r)
{
  if (is_object($r) && get_class($r) == 'mysqli_result') {
    //treat as a mysql_query resource
    return mysqli_num_rows($r);
  }
  else {
    //treat as an adodb recordset
    return $r->RecordCount();
  }
}
  line 597 - mysqli_query($GLOBALS['dbh'], $statement)


/gacl/gacl.class.php

  line 39 - (Optional) To use the most recent and single adodb from /library/adodb
define('ADODB_DIR', realpath(dirname(__FILE__) . '/../library/adodb'));

  line 74 - var $_db_type = 'mysqli';


/gacl/gacl.ini.php

  line 5 - (Optional/Reconmended)
_db_type = "mysqli"
_db_host = "localhost"
_db_user = "openemr"
_db_password = "password"
_db_name = "openemr"


/gacl/gacl_api.class.php

  line 1089 - Strict Standards: Only variables should be assigned by reference
$object_id = $this->get_object_id($section_value, $value, $map);
  line 1122 - Strict Standards: Only variables should be assigned by reference
$group_data = $this->get_group_data($group_id, $map);


/gacl/setup.php

  line 38 -
/*
 * Test database connection
 */
echo 'Testing database connection...<br/>'."\n";

if (!mysqli_real_connect($db->_connectionID, $gacl->_db_host, $gacl->_db_user, $gacl->_db_password, $gacl->_db_name)) {
	echo_failed('<b>ERROR</b> connecting to database,<br/>
			are you sure you specified the proper host, user name, password, and database in <b>admin/gacl_admin.inc.php</b>?<br/>
			Did you create the database, and give read/write permissions to &quot;<b>'.$db_user.'</b>&quot; already?');
	exit;
} else {
	echo_success('Connected to &quot;<b>'.$db_type.'</b>&quot; database on &quot;<b>'.$db_host.'</b>&quot;.');
}


/library/formdata.inc.php

  line 32 - mysqli_real_escape_string($GLOBALS['dbh'], $s)


/library/log.inc

  line 6 - function newEvent($event, $user, $groupname, $success, $comments="", $patient_id=null) {
  line 17 - if(($patient_id=="NULL") || ($patient_id==null))$patient_id=0;
  line 126 - mysqli_insert_id($GLOBALS['dbh']);


/library/onotes.inc

  line 50 - $all = array();


/interface/globals.php

  line 3 - date_default_timezone_set('America/...'); //Required default timezone set PHP5


/interface/main/calendar/config.php

  line 29 - $pnconfig['dbtype'] = 'mysqli';


/interface/main/onotes/office_comments_full.php

  line 111 - $result_count = 0;
  line 112 - $notes_count = 0;


/interface/usergroup/usergroup_admin.php

  line 43 - mysqli_fetch_array(sqlStatement("select * from users where id={$_POST["id"]}"))
  line 183 - mysqli_fetch_array(sqlStatement("select username from users where id={$_POST["id"]}"))
  line 205 - mysqli_fetch_array($res)


/interface/usergroup/addrbook_list.php

  line 37 -
$form_fname = @trim($_POST['form_fname']) ?: NULL;
$form_lname = @trim($_POST['form_lname']) ?: NULL;
$form_specialty = @trim($_POST['form_specialty']) ?: NULL;
$form_organization = @trim($_POST['form_organization']) ?: NULL;
$form_abook_type = @trim($_REQUEST['form_abook_type']) ?: NULL;
$form_external = @$_POST['form_external'] ? 1 : 0;

 line 102 - attr($form_organization)
 line 105 - attr($form_fname)
 line 108 - attr($form_lname)
 line 111 - attr($form_specialty)
 line 117 - generate_select_list("form_abook_type", "abook_type", $form_abook_type, '', 'All')


/library/patient.inc

  line 266 - mysqli_real_escape_string($GLOBALS['dbh'], $providerID)
  line 297 - mysql1_real_escape_string($providerID)
  line 782 - mysql1_insert_id($GLOBALS['dbh'])


/library/calendar.inc

  line 45 - mysqli_real_escape_string($GLOBALS['dbh'], $name)


/library/classes/Provider.class.php

  line 44 - mysqli_real_escape_string($GLOBALS['dbh'], $this->id)


/library/classes/InsuranceNumbers.class.php

  line 55 - mysqli_fetch_array($results, MYSQLI_ASSOC)


/library/classes/Prescription.class.php

  line 528 - mysqli_real_escape_string($GLOBALS['dbh'], $this->provider->id)
  line 571 - mysqli_real_escape_string($GLOBALS['dbh'], $this->provider->id)
  line 625 - mysqli_real_escape_string($GLOBALS['dbh'], $patient_id)
  line 626 - mysqli_real_escape_string($GLOBALS['dbh'], $order_by)
  line 628 - mysqli_fetch_array($results, MYSQLI_ASSOC)


/library/classes/Tree.class.php

  line 41 - mysqli_real_escape_string($GLOBALS['dbh'], $root)
  line 42 - mysqli_real_escape_string($root_type)


/library/acl.inc

  line 387 - mysqli_fetch_array(sqlStatement("select * from users where username='" .
    $username . "'"))
  line 417 - mysqli_fetch_array(sqlStatement("select * from users where username='" .
    $username . "'"))


/library/report.inc

  line 258 - mysqli_real_escape_string($GLOBALS['dbh'], $pid)
  line 259 - mysqli_real_escape_string($GLOBALS['dbh'], $encounter)


/library/transactions.inc

  line 22 - mysqli_real_escape_string($GLOBALS['dbh'], $body);


/library/registry.inc

  line 20 - mysqli_real_escape_string($GLOBALS['dbh'], $directory)