Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for QT

Nov 24th, 2014
180
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.76 KB | None | 0 0
  1. static ShiftResult shift(....)
  2. {
  3.   ...
  4.   qreal l = (orig->x1 - orig->x2)*(orig->x1 - orig->x2) +
  5.             (orig->y1 - orig->y2)*(orig->y1 - orig->y1) *
  6.             (orig->x3 - orig->x4)*(orig->x3 - orig->x4) +
  7.             (orig->y3 - orig->y4)*(orig->y3 - orig->y4);
  8.   ...
  9. }
  10.  
  11. Seems like it should be "orig->y1 - orig->y2" instead of "orig->y1 - orig->y1".
  12.  
  13. This suspicious code was found in QT project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V501 There are identical sub-expressions to the left and to the right of the '-' operator: orig->y1 - orig->y1 QtGui qbezier.cpp 329
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement