Advertisement
PVS-StudioWarnings

PVS-Studio warning V579 for Firefox

Nov 26th, 2014
155
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.80 KB | None | 0 0
  1. int  AffixMgr::parse_convtable(..., const char * keyword)
  2. {
  3.   ...
  4.   if (strncmp(piece, keyword, sizeof(keyword)) != 0) {
  5.       HUNSPELL_WARNING(stderr,
  6.         "error: line %d: table is corrupt\n", af->getlinenum());
  7.       delete *rl;
  8.       *rl = NULL;
  9.       return 1;
  10.   }
  11.   ...
  12. }
  13.  
  14. Most likely this is what should be written here: if (strncmp(piece, keyword, strlen(keyword)) != 0) {
  15.  
  16. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V579 The strncmp function receives the pointer and its size as arguments. It is possibly a mistake. Inspect the third argument. affixmgr.cpp 3708
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement