Advertisement
PVS-StudioWarnings

PVS-Studio warning V547 for WebRTC

Nov 10th, 2014
157
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.75 KB | None | 0 0
  1. typedef UINT_PTR SOCKET;
  2. typedef SOCKET cpr_socket_t;
  3.  
  4. cpr_socket_t
  5. sip_tcp_create_connection (sipSPIMessage_t *spi_msg)
  6. {
  7.   cpr_socket_t new_fd;
  8.   ....
  9.   new_fd = cprSocket(af_listen, SOCK_STREAM, 0);
  10.   if (new_fd < 0) {
  11.     CCSIP_DEBUG_ERROR(SIP_F_PREFIX"Socket creation failed %d.",
  12.                       fname, cpr_errno);
  13.     return INVALID_SOCKET;
  14.   }
  15.   ....
  16. }
  17.  
  18. This suspicious code was found in WebRTC project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V547 Expression 'new_fd < 0' is always false. Unsigned type value is never < 0. ccsip_platform_tcp.c 438
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement