Advertisement
PVS-StudioWarnings

PVS-Studio warning V517 for saga

Nov 25th, 2014
171
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.83 KB | None | 0 0
  1. CSG_String CWatersheds_ext::GraveliusType(....) {
  2.   ...
  3.   if (fGraveliusIndex > 1.75) {
  4.     sType = "Rectangular";
  5.   }
  6.   else if (fGraveliusIndex > 1.5) {             <<<---
  7.     sType = "Ovalooblonga-rectangularoblonga";
  8.   }
  9.   else if (fGraveliusIndex > 1.5) {             <<<---
  10.     sType = "Ovaloredonda-ovalooblonga";
  11.   }
  12.   else {
  13.     sType = "Redonda-ovaloredonda";
  14.   }
  15.   ...
  16. }
  17.  
  18. This suspicious code was found in saga project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 697, 700. ta_channels watersheds_ext.cpp 697
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement