Advertisement
PVS-StudioWarnings

PVS-Studio warning V519 for wxWidgets

Nov 26th, 2014
177
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 1.06 KB | None | 0 0
  1. WCHAR szEntryName[ RAS_MaxEntryName + 1 ];
  2. WCHAR szPhoneNumber[ RAS_MaxPhoneNumber + 1 ];
  3. WCHAR szCallbackNumber[ RAS_MaxCallbackNumber + 1 ];
  4.  
  5. bool wxDialUpManagerMSW::Dial(const wxString& nameOfISP,
  6.                               const wxString& username,
  7.                               const wxString& password,
  8.                               bool async)
  9. {
  10.   ...
  11.   // default values for other fields
  12.   rasDialParams.szPhoneNumber[0] = '\0';
  13.   rasDialParams.szCallbackNumber[0] = '\0';
  14.   rasDialParams.szCallbackNumber[0] = '\0';
  15.   ...
  16. }
  17.  
  18. Most likely this is what should be written here: rasDialParams.szEntryName[0] = '\0';
  19.  
  20. This suspicious code was found in wxWidgets project by PVS-Studio static code analyzer.
  21. Warning message is:
  22. V519 The 'rasDialParams.szCallbackNumber[0]' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 832, 833. core dialup.cpp 833
  23.  
  24. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement