Issue #899 review

ISSUE #899 notes:

1. (1:14) Orgnil, for me atleast, does exclamate following the completion of quest 823 (Report to Orgnil). I don't think he is meant to do it in response to starting the follow up quest. Joana does it in quick succesion which might create that illusion. It's happening along with the script text for that quest completion which can be found in the 'db_script_string' table at entry '2000005778'

As for the bowing, the value of 'OfferRewardEmote1' for entry 823 in the quest_template table should simply be 2 for bowing.

2. (22:51) A quest's gossip order is seemingly determined by what row order each quest is defined as in the creature_questrelation table. My guess is the table is created with such logic that it is inserting quests in increasing order to the relating creature. (same goes for how vendor items are distributed). To be frank, it's not very gamebreaking and probably alot of drudge work to fix for every questgiver that might have this issue. And i dont have the experience with the core or the smarts to find an elegant solution. Pass on this one.

For salute emote for 'Vanquish the Betrayers' change value of 'OfferRewardEmote1' to 66 for entry '784' in the table 'quest_template' (it has an additional step when completing this quest for me.)

For eliminating the talk emote whenever initiating gossip with him, zero out the emote fields for entry 16535 in the 'npc_text' table. (had to clear out WDB folder in wow dir for this to work fyi) (Also, it looks like the inital gossip text is entirely different in the video).

'From the Wreckage....' bug: change value of IncompleteEmote to 1 for entry 825 in the table 'quest_template'

'The Admiral's Orders' bug: change value of CompleteEmote to 6 and change value of OfferRewardEmote1 to 1 for entry 830 in the table 'quest_template'

3. (23:46) 'Carry Your Weight' bug: change value of OfferRewardEmote1 to 4 for entry 791 in the table 'quest_template'

4. (24:15) NOTE: "What can I Do at an inn?" is only displayed you have gm mode enabled. Change the 'condition_id' value to 0 for every row that has "What can I do at an inn?" option text.

5. (27:00) NOTE: there was one Clacker nearby when i checked. Got nothing else on this one.

6. (29:36) The crawlers should swim to their targets once in combat. Maybe some ACID implementation where the crawlers extraflags are by default 0x00008000 but when aggroed set to zero. and back again when resetting. Or better handling for CREATURE_EXTRA_FLAG_WALK_IN_WATER.

7. (47:56) The scout in question is indeed bugging out of place frequently. This is seemingly caused by being close enough distance-wise to pick a waypoint ontop of the thorns.

8. (53:03) When saving your HS in an inn the only thing that is saved is the position of exactly where you were when clicking accept. The orientation you have when arriving will globally speaking be the same as the orientation you have when you finish casting.

9. (54:25) Looks like its only when the actual quest gossip option is selected that the sheathe occurs, I can't find a suitable emote that takes care of sheathing. I think emotes such as talk or any non-combat emote should sheath the weapon and make it persist. Is this unique for this guy? For talking emote at reward page, change value of OfferRewardEmote1 to 1. He also salutes on completion.

10. (1:02:35) Change value of OfferRewardEmote1 to 2 for bow.

11. (1:02:49) Again, vendor items are seemingly distributed in ascending order of their item ID due to how they are laid out in the npc_vendor table. Some new ideas are here needed... for what should be done about it.

12. (1:05:05) It works for me, and not sure about the charge. I remember it being pretty scary if a mob charge attacked you.

13. (1:19:00 ish) Change heal for voodoo shamans and zalazane to rank 1 from rank 2 (332 to 331). Item is in Zalazane's loottable, but only obtainable if you have the quest, which is how it's supposed to work i assume.

14. (1:19:12) Added egg gameobject in rougly same location. Not sure if there are any way of finding the exact location.
x(-1254.91)	y(-5582.25)	z(7.67776)	o(4.68486)
r2(0.716773)	r3(-0.697306)

15. (1:24:55) Loot table seems to be in order for me. Again furs only drop if you have the quest.

16. (1:29:10) Added egg gameobject in rougly same location as video.
x(-1520.69)	y(-5293.85)	z(7.05261)	o(2.21025)
r2(0.89352)	r3(0.449022)

17. (1:30:59) Dunno where graveyard data is stored

18. (1:31:21) change value of CompleteEmote to 0 for entry 808 in quest_template. The spirit is summoned and bows for me.

19. (1:31:36) Change value of OfferRewardEmote1 to 1 for talk. (entry 817)

20. (1:32:00) Might be patrol waypoint of 6380 guid but missing delay. (extra guard seemingly not present at 23:00) seemingly point 1, but unknown waittime.

21. (1:35:45) No issue for me, further testing.

22. (1:39:58) For some reason, the DetailsEmote1 is not triggering. Infact no emote is triggering when clicking on her. Pass on this one.

23. (1:42:30) Black feathers seem an awful lot like a shader bug or something. double pass alpha cutoff is hard yo. Joana in need of driver updates?

24. (1:43:10) Yup.

25. (1:44:23) Evidently. I'm not sure how severe faulty placement is for the blizzlike experience when there are compensating sacks in the near vicinity. If there should be made an effort in fixing this let me know.

26. (1:44:57) ^

27. (1:46:50) Further discussion needed. Would propose concrete extra spawn points, but focusing on fixing what is straightforward first.

28. (1:51:10) Dont see 'Quest Complete' message anywhere.
Not sure if the rep is announced when discovered. That would explain why all faction become neutral since all the streamwheedle cartel factions seem to reward each other.. According to comments in https://web.archive.org/web/20060325022652/http://wow.allakhazam.com/db/quest.html?wquest=834 rep should only be for DS trolls and ratchet and be 100 for each, atm it has 250 for DS, Org and ratchet.
Change reward factions and amount for entry 834.

29. (1:52:58) This could probably be fixed with tweaked spawnpoints and extra waypoints with some wait time at the water thingy. There are also some points in their path to Valley of Trials where they have small glitches (suddenly spiking up in to the air, and down on the ground again). I assume these are also just caused from faulty waypoints.

Both raiders are supposed to be fairly naked.

About the gossip, breaking the walk cycle. This seems to be recurring. Same thing happens when talking to Moon Priestess Amara (guid: 46394) although her companions appear to actually follow the priestess. Same thing happens with Myra Tyrngaarde (guid: 122) and Ironforge Guards (only tested guid: 1748). They start walking again eventually tho. Maybe waypoints advance but movement logic is halted untill a full walkcycle has occured? Probably core issue.

I honestly think the pull range is fitting. However they should follow the same aggro list (linked creature?). I'm assuming aggrorange is dynamically determined by what level difference there is, and 35 is a fair difference to the mobs on the path. Might be wrong here tho, and have no idea how to tweak core anyway so just gonna let this one sit.

NOTE: Seems like both raiders have weird NPCflags. They should only have OUTDOORPVP and Jhash should also have gossip.

30. (1:53:10) I believe some questgivers have this functionality, but that might be because they only have that potential option. Dunno how to core handles gossip.

31. (1:53:17) For talent gossip change value1 to 15 in conditions for condition_entry 107 (I suspect this might actually have to do with a lack of money to do the change, which there is no condition for i believe).

For emote change DetailsEmote1 to 1 for entry 6062 in quest_template.

32. (1:55:00) Change DetailsEmote1 to 1 for entry 6083 in quest_template.

33. (1:59:50) Change CompleteEmote to 0 and OfferRewardEmote1 to 273 for entry 6083. Change DetailsEmote1 to 1 for entry 6082.

34. (2:01:34) Same as above. for quest 6082 and talk for followup

35. (2:04:54) Discuss how many and where? Only see the one attacking.

36. (2:07:40) Discuss how many and where?

37. (2:07:55) Change DetailsEmote1 to 1 for entry 812 in quest_template.

38. (2:11:10) I actually think this one is good on the DB side. Dunno where to set correct sheath, which should be ranged. issue somewhat related to issue 9. to get rid of axe, Change equipentry1 to 0 for entry 3352 in creature_equip_template

39. (2:13:30) Nazgrel is on the left hand side of the throneroom, standing by another table.
new pos: x:1906.680054 y:-4133.569824 z:40.9175599 o:5.291980
and remove the quest from voljin and add it to Nazgrel. and change quest text to say Nazgrel. Request reward emote should be ! emote. Change OfferRewardEmote1 to 5 for entry 831

NOTE: all of thralls npc text is missing. should have text_id 4477

Thrall emote: Change DetailsEmote1 to 1 for entry 5726 in quest_template. Doesnt work, but it should lol.

40. (2:14:50) change npcflag of Kor'Ghan to 2 (id: 3189) questformat is wrong anyway tho?

change DetailsEmote1 to 1 for entry 813 for /talk emote.

changed specialflags to 0 this corrects format.

41. (2:16:52) Dunno how core handles order but it should be available spells listing down in ascending order of pet level. Then already learnt spells listing down in same order.

42. (2:31:25) Same as the tigers. Available for me. With trashloot.

43. (2:33:14) Can drop, atleast for me. Took along time tho. It might share chance with every other item, which it shouldn't i think. https://web.archive.org/web/20060325022652/http://wow.allakhazam.com/db/quest.html?wquest=834

Change loot groupid to 1 in creature_loot_table for item 4891 at entry. This should give the quest item a unique roll chance each loot instance.

this loot table also have 3 unknown items. maybe delete?

44. (2:36:20) I have no idea how to make this bitch emote. fuck.

45. (2:42:37) the claw drops for me. Create waypoints for him.

46. (2:49:02) Change CompleteEmote to 0 and OfferRewardEmote1 to 4.

47. (2:51:50) Change OfferRewardEmote1 to 2 for quest 828. Changing DetailsEmote1 to 1 for talk for 827 (Skull Rock) should work but doesnt. Doing it anyway incase of a fix for this bug.

48. (2:53:30) Collars drop for me.

49. (2:58:38) He is facing the wall in the video. He's missing a voidwalker tho (ACID i guess). He drops the Eye for me. Im pretty sure he's supposed to only spawn one place and that being on the cliff, not facing a wall.

Changed his position.

50. (3:22:24) Dropped for me.

51. (3:24:38) Changed CompleteEmote to 0 in quest 827 (skull rock)

for the quest end casting its prolly ACID/dbscripting again. Not comfortable enough with that to deal with this one.

52. (3:29:15) Changed Thralls position.
Fixed in earlier point.
Changed OfferRewardEmote1 to 15 for 5726 (Hidden Enemies 1) for /roar emote.
NOTE he also does /question when selecting the q (before continue)
This quest also Changes the gossip text of Thrall. More DBscripting.
And it's apparently not a followup quest. This might actually matter for the odd lore player, who might miss the new text because of auto accepting the next quest

Changed CompleteEmote to 6 for 5726 for /question emote.
Changed NextQuestInChain to 0 for 5726.
Changed PrevQuestId to 0 for 5727.
Changed DetailsEmote1 to 1 for 5727 (Hidden Enemies 2) for /talk emote
(ofc DetailsEmote1 is broken or something so this isnt working)

53. (3:30:21) Fixed that in a previous point. Same with blue question mark (repeatable quest). The quest doesnt appear because the quest is the same and when completed the quest should reset the character_queststatus fields of the quest which it doesnt right now. It could essentially delete the row where the quest is. I think this is quite a rare case of such a quest. Current functionality works for the actual game, where you will never need more than 1 antidote.

54. (3:30:37) Change em0_3 to 0 in npc_text for ID 4513.
Change CompleteEmote to 0 for quest 829.
Follow up quest 809 (Ak'Zeloth) has some event on start it seems yes. Again im not quite comfortable with dbscripting yet.
Burning Shadows seem to have no emote on complete and talk on reward.
Change CompleteEmote to 0 and OfferRewardEmote1 = 1 for quest 832
For repeat of gossip change value2 to 0 in conditions for condition_entry 56.

55. (3:31:50) The NPC exists and is at the correct poisition BUT is not visible? (same with Rexxar fyi, noticed in previous tests). try '.go creature 6519' and test for yourself.

56. (3:32:15) Changed OfferRewardEmote1 to 4 for quest 5727.

Dunno how to skip the completion gossip screen (continue thing) I do think it should have a question emote tho.

57. (3:35:09) Changed OfferRewardEmote1 to 2 for quest 5727.
and Changed OfferRewardEmote2 to 1 and changed OfferRewardEmoteDelay2 to 2000 for delayed talk emote thing. Might be workaround if this gamebreaking bug :S

58. (3:39:07) Judging by the chatlog he is just pointing.
However its DB scripting since it happens after clicking accept, so its a start script.. Will attempt at a later point =).