Advertisement
PVS-StudioWarnings

PVS-Studio warning V528 for Firefox

Nov 24th, 2014
175
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.67 KB | None | 0 0
  1. nsresult
  2. SVGNumberList::SetValueFromString(const nsAString& aValue)
  3. {
  4.   ...
  5.   const char *token = str.get();
  6.   if (token == '\0') {
  7.     return NS_ERROR_DOM_SYNTAX_ERR; // nothing between commas
  8.   }
  9.   ...
  10. }
  11.  
  12. Most likely this is what should be written here: (*token == '\0')
  13.  
  14. This suspicious code was found in Firefox project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V528 It is odd that pointer to 'char' type is compared with the '\0' value. Probably meant: *token == '\0'. svgnumberlist.cpp 96
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement