Advertisement
Guest User

Untitled

a guest
Sep 29th, 2016
42
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 2.33 KB | None | 0 0
  1. [17:05:04] Han: the event loop in
  2. [17:05:11] Han: ConPlayBark.GetBarkSpeech()
  3. [17:05:31] Han: would need to handle
  4. [17:05:42] Han: case ET_SetFlag:
  5. case ET_CheckFlag:
  6. [17:06:10] Hawkbird: Can that be copied from ConPlay?
  7. [17:06:12] Han: maybe others like checkpersona, addnote, addgoal, addtrigger to
  8. [17:06:43] Han: probably
  9. [17:06:48] Han: maybe the issue is more like
  10. [17:07:02] Han: maybe there is no valid event to return based on flags
  11. [17:07:56] Han: so that case would need to be handled properly inside BarkManager.conPlayBark()
  12. [17:08:00] Han: which might be a bit of a hastle
  13. [17:09:02] Han: but checking if GetBarkSpeech() returns none
  14. [17:09:04] Han: AND
  15. [17:09:06] Han: in this case
  16. [17:09:17] Han: make sure that the cleanup code after the bark was played is properly ran
  17. [17:09:33] Han: which is probably in some other place inside the gamecode
  18. [17:09:40] Han: otherwise it might screw things up
  19. [17:09:53] Han: but basically you should try it that way
  20. [17:17:34] Han: ah
  21. [17:17:46] Han: mission2.con the ParkBum*
  22. [17:17:58] Han: they have check flag up front for ambrosia
  23. [17:18:11] Han: so yeah great, i was afraid that there might be multiple barks or sth
  24. [17:18:29] Han: so it's jsut one con with the barks apparently, which is nice
  25. [17:19:50] Han: do the flag making for the convo on PimpOverheader_Player, etc. work for Pimp.PimpBark ?
  26. [17:19:53] Han: *masking
  27. [17:20:12] Han: otherwise that would be another bug there
  28. [17:20:21] Han: but sort of unrelated to the above
  29. [17:21:03] Han: yeah
  30. [17:21:08] Han: StartBark just calls FindConversationByName
  31. [17:21:14] Han: and just use it based on name
  32. [17:21:33] Han: so it looks like there is actually no check happening whether the bark has flags
  33. [17:21:39] Han: or that might just happen outside
  34. [17:21:41] Han: dunno
  35. [17:22:14] Han: nope doesnt look like there is any outside check
  36. [17:26:19] Han: sort of looks like a bit there is some
  37. [17:26:30] Han: sort of bAbortConversation = !CheckFlagRefs(con.flagRefList);
  38. [17:26:37] Han: missing
  39. [17:27:10] Han: which afaik checks the green and red flags below a conversation in the tree view
  40. [17:27:18] Han: so that needs to be added there too
  41. [17:27:58] Han: probably best right before
  42. [17:28:01] Han: if (con != None)
  43. {
  44. [17:28:13] Han: in StartBark
  45. [17:28:14] Han: or well
  46. [17:28:19] Han: inside the first thing
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement