Fix for "Cannot create type" for og_content_type_admin

// THIS is the ORIGINAL og_content_type_admin_menu_access function in og_content_type_admin.module:
/** The necessary changes to fix the problem are lines 80-93 of this paste to replace lines 801 - 809 of the original file. There are instructions and an explanation further down
*//

/**
 * mnode/add access callback override. If gid is present check og_content_type access rights. Otherwise pass processing to original function
 */
function og_content_type_admin_menu_access() {
  $args = func_get_args();
  $type = array_shift($args);
  $type = isset($type) ? str_replace('-', '_', $type) : NULL;
  $original_callback = array_shift($args);
  // First: Allow access to add a particlar type of group content
  if (is_array($_GET['gids'])) {
    $gid = $_GET['gids'][0];
    dsm_once("get[gids]", $_GET['gids'][0]);
    $group = node_load($gid);
    $sql = "SELECT octa.types_active, octa.types_allowed FROM {og_content_type_admin} octa WHERE octa.gid = %d";
    //if we're keeping track of this group, get it's active types, otherwise, get the defaults
    $types = db_fetch_object(db_query($sql, $gid));
    if (!$types) {
      $types = db_fetch_object(db_query($sql, 0));
    }
    if (_og_content_type_admin_is_admin($group)) {
      $active_types = unserialize($types->types_allowed);
    } else {
      $active_types = unserialize($types->types_active);
    }
    if ($active_types[$type]) {
      return TRUE;
    }
  }
  else { // do normal processing plus 'allowed' check
    $sql = "SELECT octa.types_allowed FROM {og_content_type_admin} octa WHERE octa.gid = -1";
    $types = db_fetch_object(db_query($sql));
    $allowed_types = unserialize($types->types_allowed);
    if ($allowed_types[$type] && call_user_func_array($original_callback, $args)) {
      return TRUE;
    }
  }
  return FALSE;
}



/** ************************  INSTRUCTIONS  *************************/
/**We need to replace the last "else" block (lines 33-40)with something that does not check the og_content_type_admin table (sql statement 34). This is ok because og content type admin is not supposed to, and has no mechanism for, enforcing restrictions on ALLOWED SITEWIDE. If you check the admin page for og cta, you will see that the list of types for "ALLOWED SITEWIDE" is checkboxes which are all set to true and have all been disabled. (In fact og CTA rather unnecessarily builds a list of allowed sitewide types on installation, which breaks as soon as new types are created). Line 37 (above) contains an if statement which checks the octa database for "allowed" state and also calls "call_user_func_array($original_callback, $args)", which octa has replaced the original drupal menu access functionatlity, but kept a reference to the old funcion ($original_callback). All that is really necessary is to call this $original_callback function and return the results. Post waffle, the new og_content_type_admin_menu_access() method should be:

(If you just paste this method over the top of the old one, it will work :) ChristopherReay http://drupal.org/node/876162 )
*/

/**
 * mnode/add access callback override. If gid is present check og_content_type access rights. Otherwise pass processing to original function
 */
function og_content_type_admin_menu_access() {
  $args = func_get_args();
  $type = array_shift($args);
  $type = isset($type) ? str_replace('-', '_', $type) : NULL;
  $original_callback = array_shift($args);
  // First: Allow access to add a particlar type of group content
  if (is_array($_GET['gids'])) {
    $gid = $_GET['gids'][0];
    dsm_once("get[gids]", $_GET['gids'][0]);
    $group = node_load($gid);
    $sql = "SELECT octa.types_active, octa.types_allowed FROM {og_content_type_admin} octa WHERE octa.gid = %d";
    //if we're keeping track of this group, get it's active types, otherwise, get the defaults
    $types = db_fetch_object(db_query($sql, $gid));
    if (!$types) {
      $types = db_fetch_object(db_query($sql, 0));
    }
    if (_og_content_type_admin_is_admin($group)) {
      $active_types = unserialize($types->types_allowed);
    } else {
      $active_types = unserialize($types->types_active);
    }
    if ($active_types[$type]) {
      return TRUE;
    }
  }
  else { // do normal processing plus 'allowed' check
    // here '+' denotes lines added by ChristopherReay and '-' suggested removeals
    //+ CR: here "normal processing" means the standard Drupal stuff before the octa
    //+ CR:  module was installed.
    //+ CR:  Actually, octa doesnt enforce any limits on "ALLOWED"
    //+ CR:  types for "octa.gid = -1", which is the GroupID for "sitewide" (check sql in next line)
    // - $sql = "SELECT octa.types_allowed FROM {og_content_type_admin} octa WHERE octa.gid = -1";
    // - $types = db_fetch_object(db_query($sql));
    // - $allowed_types = unserialize($types->types_allowed);
    // - if ($allowed_types[$type] && call_user_func_array($original_callback, $args)) {
    // - return TRUE;
    // - }
    return call_user_func_array($original_callback, $args);
  }
  return FALSE;
}