stronk7@~/git_moodle/integration ((v3.1.1) %)$ git bisect start
stronk7@~/git_moodle/integration ((v3.1.1) %|BISECTING)$ git bisect bad
stronk7@~/git_moodle/integration ((v3.1.1) %|BISECTING)$ git bisect good v3.1.0
Bisecting: 162 revisions left to test after this (roughly 7 steps)
[afee01ac2f59049add17bdfb3270b9eeae16f0da] Merge branch 'MDL-54920-m31' of https://github.com/sammarshallou/moodle into MOODLE_31_STABLE
stronk7@~/git_moodle/integration ((afee01a...) %|BISECTING)$ vi oo.php
stronk7@~/git_moodle/integration ((afee01a...) %|BISECTING)$ git bisect good
Bisecting: 81 revisions left to test after this (roughly 6 steps)
[c944c35cff4f4ce7cbecd142f3b888a655fecc1e] Merge branch 'MDL-54610_31' of https://github.com/snake/moodle into MOODLE_31_STABLE
stronk7@~/git_moodle/integration ((c944c35...) %|BISECTING)$ git bisect bad
Bisecting: 40 revisions left to test after this (roughly 5 steps)
[ac081697dadc6bd60c11c7ab38fb711021e8e8c9] Merge branch 'MDL-52887-31' of git://github.com/marinaglancy/moodle into MOODLE_31_STABLE
stronk7@~/git_moodle/integration ((ac08169...) %|BISECTING)$ git bisect bad
Bisecting: 20 revisions left to test after this (roughly 4 steps)
[e9019af21dc97f7f0e89515e87a54eedfa9eafcc] Merge branch 'MDL-54948-31-fix2' of https://github.com/lameze/moodle into MOODLE_31_STABLE
stronk7@~/git_moodle/integration ((e9019af...) %|BISECTING)$ git bisect bad
Bisecting: 11 revisions left to test after this (roughly 3 steps)
[50804bc956f0fbb511c2c279608d8f6008d207d5] MDL-54778 form: Make it all js style (eslint) compliant
stronk7@~/git_moodle/integration ((50804bc...) %|BISECTING)$ git bisect bad
Bisecting: 3 revisions left to test after this (roughly 2 steps)
[e2dee6f3cdd461e7123859b3f614c9d743b2e9fa] Merge branch 'MDL-54948-31' of git://github.com/lameze/moodle into MOODLE_31_STABLE
stronk7@~/git_moodle/integration ((e2dee6f...) %|BISECTING)$ git bisect good
Bisecting: 2 revisions left to test after this (roughly 1 step)
[56fb03794cbc646676a2f61e11acb8b867ad9e51] MDL-54778 form: Fix lots of issues with form dependencies
stronk7@~/git_moodle/integration ((56fb037...) %|BISECTING)$ git bisect bad
56fb03794cbc646676a2f61e11acb8b867ad9e51 is the first bad commit
commit 56fb03794cbc646676a2f61e11acb8b867ad9e51
Author: Andrew Nicols <[email protected]>
Date:   Tue Jun 7 13:26:42 2016 +0800

    MDL-54778 form: Fix lots of issues with form dependencies

    The original issue here was that each loop of the named values did not
    check for prototypal properties. As a result, if there were input fields
    with names such as 'sort', 'valueOf', 'constructor', etc. these would
    return their prototypal functions instead of a falsy value, and be treated
    as though they are array - hence the 'Cannot push to Function' type error.

    Following on from this I discovered that the data stores were being created
    as arrays, but used as objects. This can also cause issues with some form
    input names -- e.g. if they are numeric.

    These two issues were resolved together by correctly storing them in
    objects, and checking that those objects had real properties
    (hasOwnProperty). This itself has to use the prototypal function to cater
    for the potential of a field name called 'hasOwnProperty'.

    I also found that the instance value stores were being initialised in the
    prototype (and therefore shared), which meant that there were numerous
    issues if two forms were present on the same page, or one form replaced an
    existing one (e.g. forms initialised in JS).

    In addition, it also became apparant that several values were being used
    outside of scope, or in the wrong scope. This caused further issues when
    creating multiple forms on a page.

:040000 040000 8927f77ee3d720c59e3599d2f532b119d887bf44 3339f2804bde9cbf15196d5e5e81dc577db5eabe M	lib