Advertisement
PVS-StudioWarnings

PVS-Studio warning V567 for Doom3

Nov 25th, 2014
178
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.63 KB | None | 0 0
  1. int idFileSystemLocal::ListOSFiles(....)
  2. {
  3.   ...
  4.   dir_cache_index = (++dir_cache_index) % MAX_CACHED_DIRS;
  5.   ...
  6. }
  7.  
  8. This is what should have been written here: dir_cache_index = (dir_cache_index + 1) % MAX_CACHED_DIRS;
  9.  
  10. This suspicious code was found in Doom3 project by PVS-Studio static code analyzer.
  11. Warning message is:
  12. V567 Undefined behavior. The 'dir_cache_index' variable is modified while being used twice between sequence points. TypeInfo filesystem.cpp 1877
  13.  
  14. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement