Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for Chromium

Nov 21st, 2014
144
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.80 KB | None | 0 0
  1. void JingleInfoRequest::OnResponse(....) {
  2.   ...
  3.   std::string host = server->Attr(buzz::QN_JINGLE_INFO_HOST);
  4.   std::string port_str = server->Attr(buzz::QN_JINGLE_INFO_UDP);
  5.   if (host != buzz::STR_EMPTY && host != buzz::STR_EMPTY) {
  6.   ...
  7. }
  8.  
  9. Most likely this is what should be written here: (host != buzz::STR_EMPTY && port_str != buzz::STR_EMPTY).
  10.  
  11. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V501 There are identical sub-expressions 'host != buzz::XmlConstants::str_empty ()' to the left and to the right of the '&&' operator.  chromoting_jingle_glue  iq_request.cc  248
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement