Advertisement
PVS-StudioWarnings

PVS-Studio warning V668 for MTASA

Nov 27th, 2014
170
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.75 KB | None | 0 0
  1. const char* TiXmlElement::Parse(....)
  2. {
  3.   ....
  4.   TiXmlAttribute* attrib = new TiXmlAttribute();
  5.   if ( !attrib )
  6.   {
  7.     if ( document )
  8.       document->SetError( TIXML_ERROR_OUT_OF_MEMORY, pErr,
  9.                           data, encoding );
  10.     return 0;
  11.   }
  12.   ....
  13. }
  14.  
  15. This suspicious code was found in MTASA project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V668 There is no sense in testing the 'attrib' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. tinyxmlparser.cpp 1093
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement