Advertisement
Guest User

Untitled

a guest
Oct 7th, 2011
576
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 1.23 KB | None | 0 0
  1. Date Thu, 6 Oct 2011 15:05:27 -0400
  2. From Dave Jones <>
  3. Subject RFC: virtualbox tainting.
  4. The number of bug reports we get from people with virtualbox loaded are
  5. truly astonishing. It's GPL, but sadly that doesn't mean it's good.
  6. Nearly all of these bugs look like random corruption. (corrupt linked lists,
  7. corrupt page tables, and just plain 'weird' crashes).
  8.  
  9. This diff adds tainting to the module loader to treat it as we do with stuff
  10. from staging/ (crap). With this tainting in place, automatic bug filing tools
  11. can opt out of automatically filing kernel bugs, and inform the user to file
  12. bugs somewhere more appropriate.
  13.  
  14. Signed-off-by: Dave Jones <[email protected]>
  15.  
  16. diff --git a/kernel/module.c b/kernel/module.c
  17. index 04379f92..d26c9a3 100644
  18. --- a/kernel/module.c
  19. +++ b/kernel/module.c
  20. @@ -2653,6 +2653,10 @@ static int check_module_license_and_versions(struct module *mod)
  21. if (strcmp(mod->name, "ndiswrapper") == 0)
  22. add_taint(TAINT_PROPRIETARY_MODULE);
  23.  
  24. + /* vbox is garbage. */
  25. + if (strcmp(mod->name, "vboxdrv") == 0)
  26. + add_taint(TAINT_CRAP);
  27. +
  28. /* driverloader was caught wrongly pretending to be under GPL */
  29. if (strcmp(mod->name, "driverloader") == 0)
  30. add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
  31.  
  32.  
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement