How not to create arrays! - as seen by mullanaphy.

<?php

    /* ... */

    function edit($tpl = null)
    {
        //echo "Edit";
        $model = &$this->getModel();
        //Create discount Amount....
        $amounts = array();
        $amount99=array('id'=>'$99.99','name'=>'$99.99');
        array_unshift($amounts,$amount99);
        $amount99=array('id'=>'$99','name'=>'$99');
        array_unshift($amounts,$amount99);
        $amount89=array('id'=>'$89.99','name'=>'$89.99');
        array_unshift($amounts,$amount89);
        $amount79=array('id'=>'$79.99','name'=>'$79.99');
        array_unshift($amounts,$amount79);
        $amount69=array('id'=>'$69.99','name'=>'$69.99');
        array_unshift($amounts,$amount69);
        $amount59=array('id'=>'$59.99','name'=>'$59.99');
        array_unshift($amounts,$amount59);
        $amount49=array('id'=>'$49.99','name'=>'$49.99');
        array_unshift($amounts,$amount49);
        $amount39=array('id'=>'$39.99','name'=>'$39.99');
        array_unshift($amounts,$amount39);
        $amount29=array('id'=>'$29.99','name'=>'$29.99');
        array_unshift($amounts,$amount29);
        $amount19=array('id'=>'$19.99','name'=>'$19.99');
        array_unshift($amounts,$amount19);
        $amount12=array('id'=>'$12','name'=>'$12');
        array_unshift($amounts,$amount12);
        $amount10=array('id'=>'$10','name'=>'$10');
        array_unshift($amounts,$amount10);
        $amount9=array('id'=>'$9','name'=>'$9');
        array_unshift($amounts,$amount9);
        $amount8=array('id'=>'$8','name'=>'$8');
        array_unshift($amounts,$amount8);
        $amount7=array('id'=>'$7','name'=>'$7');
        array_unshift($amounts,$amount7);
        $amount6=array('id'=>'$6','name'=>'$6');
        array_unshift($amounts,$amount6);
        $amount5=array('id'=>'$5','name'=>'$5');
        array_unshift($amounts,$amount5);
        $amount4=array('id'=>'$4','name'=>'$4');
        array_unshift($amounts,$amount4);
        $amount3=array('id'=>'$3','name'=>'$3');
        array_unshift($amounts,$amount3);
        $amount2=array('id'=>'$2','name'=>'$2');
        array_unshift($amounts,$amount2);
        $amount1=array('id'=>'$1','name'=>'$1');
        array_unshift($amounts,$amount1);
        $amount95=array('id'=>'95%','name'=>'95%');
        array_unshift($amounts,$amount95);
        $amount90=array('id'=>'90%','name'=>'90%');
        array_unshift($amounts,$amount90);
        $amount85=array('id'=>'85%','name'=>'85%');
        array_unshift($amounts,$amount85);
        $amount80=array('id'=>'80%','name'=>'80%');
        array_unshift($amounts,$amount80);
        $amount75=array('id'=>'75%','name'=>'75%');
        array_unshift($amounts,$amount75);
        $amount70=array('id'=>'70%','name'=>'70%');
        array_unshift($amounts,$amount70);
        $amount65=array('id'=>'65%','name'=>'65%');
        array_unshift($amounts,$amount65);
        $amount60=array('id'=>'60%','name'=>'60%');
        array_unshift($amounts,$amount60);
        $amount55=array('id'=>'55%','name'=>'55%');
        array_unshift($amounts,$amount55);
        $amount50=array('id'=>'50%','name'=>'50%');
        array_unshift($amounts,$amount50);
        $amount45=array('id'=>'45%','name'=>'45%');
        array_unshift($amounts,$amount45);
        $amount40=array('id'=>'40%','name'=>'40%');
        array_unshift($amounts,$amount40);
        $amount35=array('id'=>'35%','name'=>'35%');
        array_unshift($amounts,$amount35);
        $amount30=array('id'=>'30%','name'=>'30%');
        array_unshift($amounts,$amount30);
        $amount25=array('id'=>'25%','name'=>'25%');
        array_unshift($amounts,$amount25);
        $amount20=array('id'=>'20%','name'=>'20%');
        array_unshift($amounts,$amount20);
        $amount15=array('id'=>'15%','name'=>'15%');
        array_unshift($amounts,$amount15);
        $amount10=array('id'=>'10%','name'=>'10%');
        array_unshift($amounts,$amount10);
        $amount0=array('id'=>'0%','name'=>'0%');
        array_unshift($amounts,$amount0);
        $blank = array('id' => '', 'name' => '--Select Amount--');
        array_unshift($amounts, $blank);
        $this->assignRef('amounts', $amounts);

        //discount type array start
        $discount_types = array();
        $type1= array( 'id'=>'Special','name'=>'Special');
        array_unshift($discount_types, $type1);
        $type2= array( 'id'=>'Savings','name'=>'Savings');
        array_unshift($discount_types, $type2);
        $type3= array( 'id'=>'Off-Selected','name'=>'Off-Selected');
        array_unshift($discount_types, $type3);
        $type4= array( 'id'=>'Off-All','name'=>'Off-All');
        array_unshift($discount_types, $type4);
        $type5= array( 'id'=>'Off-Any','name'=>'Off-Any');
        array_unshift($discount_types, $type5);
        $type6= array( 'id'=>'Off','name'=>'Off');
        array_unshift($discount_types, $type6);
        $type7= array( 'id'=>'Discount','name'=>'Discount');
        array_unshift($discount_types, $type7);
        $type8= array( 'id'=>'Any','name'=>'Any');
        array_unshift($discount_types, $type8);
        $blank = array('id' => '', 'name' => '--Select Discount Type--');
        array_unshift($discount_types, $blank);
        $this->assignRef('discount_types', $discount_types);
        //discount type array end
        //get image list
        $imageList=array();
        $imageList=$model->getImageList();
        $blankImage = array('id' => '', 'name' => '--Select Image--');
        array_unshift($imageList, $blankImage);
        $this->assignRef('imageList', $imageList);
        //end of image list
        //pull edit data
        $row =& JTable::getInstance('Coupon', 'Table');
        $cid    = JRequest::getVar('cid', array(0), 'method', 'array');
        $cid    = array((int) $cid[0]);
        $row->load($cid[0]);
        $this->assignRef('row', $row);
        parent::display($tpl);
    }

    /* ... */
?>