Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for Apache

Nov 27th, 2014
206
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.69 KB | None | 0 0
  1. static int magic_rsl_to_request(request_rec *r)
  2. {
  3.   ...
  4.   if (state == rsl_subtype || state == rsl_encoding ||
  5.       state == rsl_encoding) {
  6.   ...
  7. }
  8.  
  9. This is what should have been written here: (state == rsl_subtype || state == rsl_separator || state == rsl_encoding).
  10.  
  11. This suspicious code was found in Apache project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V501 There are identical sub-expressions 'state == rsl_encoding' to the left and to the right of the '||' operator. mod_mime_magic mod_mime_magic.c 787
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement