Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- <?xml version="1.0" encoding="UTF-8"?>
- <!-- Save this and import into MyWords, see also http://groups.drupal.org/node/184389 -->
- <mywords>
- <word>
- <label><![CDATA[PAReview: README.txt]]></label>
- <text><![CDATA[<dl>
- <dt>README.txt</dt>
- <dd>Please take a moment to make your README.txt follow the <a href="http://drupal.org/node/447604">guidelines for in-project documentation</a>.</dd>
- </dl>]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: project page]]></label>
- <text><![CDATA[<dl>
- <dt>project page</dt>
- <dd>Please take a moment to make your project page follow <a href="http://drupal.org/node/997024">tips for a great project page</a>.</dd>
- </dl>
- ]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: Master Branch]]></label>
- <text><![CDATA[<dl>
- <dt>Master Branch</dt>
- <dd>It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is <a href="http://drupal.org/node/1127732">Moving from a master branch to a version branch.</a> For additional resources please see the documentation about <a href="http://drupal.org/node/1015226">release naming conventions</a> and <a href="http://drupal.org/node/1066342">creating a branch in git</a>.</dd>
- </dl>
- ]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: Coder on minor]]></label>
- <text><![CDATA[<dl>
- <dt>coder on minor</dt>
- <dd>I noticed some very small code style issues. Please run the <a href="http://drupal.org/project/coder">Coder module</a> on "minor" setting to help catch these. The <a href="http://drupal.org/coding-standards">coding standards</a> have even more information in this area. I noticed things like ...
- Please note: The Coder module currently has an <a href="http://drupal.org/node/1284150">unresolved flaw</a> which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do <strong>not</strong> contain classes or interfaces.</dd>
- </dl>
- ]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: License]]></label>
- <text><![CDATA[<dl>
- <dt>License</dt>
- <dd>Please remove the LICENSE.txt file. Drupal will add the appropriate version automatically during packaging so your repository should not include it.</dd>
- </dl>]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: Access administration vs. administer site configuration]]></label>
- <text><![CDATA[<dl>
- <dt>access administration vs. administer site configuration</dt>
- <dd>The administration menu callback should probably use "administer site configuration" - which implies the user can change something - rather than "access administration pages" which is about viewing but not changing configurations.</dd>
- </dl>]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: files[] without classes or interfaces]]></label>
- <text><![CDATA[<dl>
- <dt>files[] without classes or interfaces</dt>
- <dd>*start by copying the files that do not contain classes*
- Those lines should be removed. It's only necessary to <a href="http://drupal.org/node/542202#files">declare files[] if they declare a class or interface</a>.
- Please note: The Coder module currently has an <a href="http://drupal.org/node/1284150">unresolved flaw</a> which will prompt you to add file declarations to your .info file even when it's not necessary to do so. Please do not try to make this warning go away by declaring files which do <strong>not</strong> contain classes or interfaces.</dd>
- </dl>
- ]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: Licensing issues]]></label>
- <text><![CDATA[<dl>
- <dt>Licensing issues</dt>
- <dd>*name of code* appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the <a href="http://drupal.org/node/422996">getting involved handbook</a>. It also appears in the <a href="http://drupal.org/node/1001544">terms and conditions</a> you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms.
- The <a href="http://drupal.org/project/libraries">Libraries API module</a> is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.</dd>
- </dl>
- ]]></text>
- </word>
- <word>
- <label><![CDATA[PAReview: Promoting someone]]></label>
- <text><![CDATA[As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.
- Thanks for your contribution, PERSONSNAME! Welcome to the community of project contributors on drupal.org.
- I've granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.
- Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are <a href="http://drupal.org/project/issues/projectapplications?status=8">pending review</a>. I encourage you to learn more about that process and join the <a href="http://groups.drupal.org/code-review">group of reviewers</a>.
- As you continue to work on your module, keep in mind: <a href="/node/52287">Commit messages - providing history and credit</a> and <a href="/node/1015226">Release naming conventions</a>.]]></text>
- </word>
- </mywords>
Advertisement
Add Comment
Please, Sign In to add comment