Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- class Wheel : public CStateDeviceBase<Wheel>
- {
- ....
- unsigned wheelNumber_;
- ....
- };
- int Wheel::SetWheelPosition(int position)
- {
- unsigned char cmd[4];
- cmd[0] = moduleId_; cmd[2] = 0; cmd[3] = 58;
- if (wheelNumber_ == 1) {
- switch (position) {
- case 0: cmd[1] = 49; break;
- case 1: cmd[1] = 50; break;
- case 2: cmd[1] = 51; break;
- case 3: cmd[1] = 52; break;
- case 4: cmd[1] = 53; break;
- case 5: cmd[1] = 54; break;
- }
- } else if (wheelNumber_ == 1) {
- switch (position) {
- case 0: cmd[1] = 33; break;
- case 1: cmd[1] = 64; break;
- case 2: cmd[1] = 35; break;
- case 3: cmd[1] = 36; break;
- case 4: cmd[1] = 37; break;
- case 5: cmd[1] = 94; break;
- }
- ....
- }
- This suspicious code was found in Micro-Manager project by PVS-Studio static code analyzer.
- Warning message is:
- V517 The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence. Check lines: 645, 654. Ludl.cpp 645
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement