Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- STDMETHODIMP CShellExt::Initialize(....)
- {
- ...
- ignoredprops.empty();
- for (int p=0; p<props.GetCount(); ++p)
- {
- if (props.GetItemName(p).
- compare(SVN_PROP_IGNORE)==0)
- {
- std::string st = props.GetItemValue(p);
- ignoredprops = UTF8ToWide(st.c_str());
- // remove all escape chars ('\\')
- std::remove(ignoredprops.begin(),
- ignoredprops.end(), '\\');
- break;
- }
- }
- ...
- }
- The std::remove function does not remove elements from the container. It only shifts the elements and brings the iterator back to the beginning of the trash. Suppose we have the vector<int> container that contains elements 1,2,3,1,2,3,1,2,3. If we execute the code "remove( v.begin(), v.end(), 2 )", the container will contain elements 1,3,1,3,?,?,?, where ? is some trash. The function will bring the iterator back to the first senseless element, so if we want to remove these trash elements, we must write the code this way: "v.erase(remove(v.begin(), v.end(), 2), v.end())".
- This suspicious code was found in TortoiseSVN project by PVS-Studio static code analyzer.
- Warning message is:
- V530 The return value of function 'empty' is required to be utilized. contextmenu.cpp 434
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement