Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for WebKit

Nov 27th, 2014
162
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. bool SVGRadialGradientElement::selfHasRelativeLengths() const
  2. {
  3.   return cy().isRelative()
  4.       || cy().isRelative()
  5.       || r().isRelative()
  6.       || fx().isRelative()
  7.       || fy().isRelative();
  8. }
  9.  
  10. This is what should have been written here: return cx().isRelative() || cy().isRelative() || .....
  11.  
  12. This suspicious code was found in WebKit project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V501 There are identical sub-expressions 'cy().isRelative()' to the left and to the right of the '||' operator. webcore_svg svgradialgradientelement.cpp 253
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement