Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for TortoiseGIT

Nov 24th, 2014
184
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.66 KB | None | 0 0
  1. class CGitStatusListCtrl :
  2.       public CListCtrl
  3. {
  4.   ....
  5.   CString m_Rev1;
  6.   CString m_Rev2;
  7.   ....
  8. };
  9.  
  10. void CGitStatusListCtrl::OnContextMenuList(....)
  11. {
  12.   ....
  13.   if( (!this->m_Rev1.IsEmpty()) || (!this->m_Rev1.IsEmpty()) )
  14.   ....
  15. }
  16.  
  17. This suspicious code was found in TortoiseGIT project by PVS-Studio static code analyzer.
  18. Warning message is:
  19. V501 There are identical sub-expressions '(!this->m_Rev1.IsEmpty())' to the left and to the right of the '||' operator. gitstatuslistctrl.cpp 1560
  20.  
  21. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement