Advertisement
PVS-StudioWarnings

PVS-Studio warning V501 for Skia

Nov 27th, 2014
160
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.82 KB | None | 0 0
  1. bool isDisabled() const {
  2.   return kKeep_StencilOp == fFrontPassOp   &&
  3.          kKeep_StencilOp == fBackPassOp    &&
  4.          kKeep_StencilOp == fFrontFailOp   &&
  5.          kKeep_StencilOp == fFrontFailOp   &&
  6.          kAlways_StencilFunc == fFrontFunc &&
  7.          kAlways_StencilFunc == fBackFunc;
  8. }
  9.  
  10. Here we seem to have several errors at once. Besides the repeating condition, && and || may be mixed up.
  11.  
  12. This suspicious code was found in Skia project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V501 There are identical sub-expressions 'kKeep_StencilOp == fFrontFailOp' to the left and to the right of the '&&' operator. skia grstencil.h 159
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement