Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- 20:59 < MagicalTux> gah
- 20:59 < Herodes> imperi: make sure not to leave the house. U never know what might happen. :o
- 20:59 < Herodes> \o/
- 20:59 < MagicalTux> some people have bogus balances
- 21:00 < Herodes> what do you mean by bogus balances?
- 21:00 < MagicalTux> some of the really old accounts have a corrupted history, causing the balance to be wrong
- 21:00 < Vandroiy> o_O
- 21:00 < MagicalTux> usually negative by a lot
- 21:00 < Herodes> :o
- 21:00 < MagicalTux> I'll make a script that checks for differences~
- 21:00 -!- JakeMates [[email protected]] has quit [Quit: JakeMates]
- 21:00 < go1dfish> MagicalTux: are you sure that isn't due to SQLis?
- 21:00 < go1dfish> do you store a record of the balance at each transaction, or only keep a running total at the end
- 21:01 < eleorea> MagicalTux: as far as account balances go, i had an open order that probably executated at some point during the crash, but the balance i gave was prior to that. do you guys compare to the pre or post balance or both?
- 21:01 < go1dfish> one of the big worries I had was that SQLis could artificially inflate the balances tracked in the Mt. Gox system
- 21:01 < go1dfish> leading to an effective fractional reserve (with no wrongoing on the part of mtgox beyond security negligence)
- 21:02 < MagicalTux> go1dfish: for the balances on the new system I just reloaded the whole history and re-executed it line per line
- 21:02 < go1dfish> is the db structured to prevent/detect such an occurence?
- 21:02 < MagicalTux> I fixed the trade entries so now when you buy 1 BTC it shows you bought 1 BTC
- 21:02 < go1dfish> MagicalTux: if you stored a running balance separately...
- 21:02 < go1dfish> and that was used to determine if someone had enough to make a trade...
- 21:02 < x6763> MagicalTux: nice, i like that!
- 21:02 < go1dfish> and someone inflated their balance...
- 21:02 -!- Vandroiy is now known as VandroiyOtherPC
- 21:03 < go1dfish> rerunning the transaction log and getting negative balances is exactly what would happen I think
- 21:03 < MagicalTux> go1dfish: some of those accounts are really old, so I wonder
- 21:03 < MagicalTux> I'll be comparing old & new balances~
- 21:03 < eleorea> a couple days prior to the crash i noticed my BTC balance kept fluctuation up and down .01 of a bitcoin..anyone else notice similar
- 21:03 < MagicalTux> eleorea: rounding bug
- 21:03 < go1dfish> eleorea: some had mentioned that Mt Gox used floating point internally for some calculations
- 21:03 < go1dfish> is that true? and has that been fixed?
- 21:03 -!- Abolfazl [[email protected]] has joined #mtgox
- 21:03 < eleorea> ahh thx
- 21:04 -!- john1400 [[email protected]] has quit [Quit: Ex-Chat]
- 21:04 < MagicalTux> go1dfish: the new system use 100% integers
- 21:04 < go1dfish> MagicalTux: you don't keep a running balance with each transaction?
- 21:05 < go1dfish> if so it seems like it would be pretty simple to see when the total balance diverged with the tracked running balances per transaction
- 21:06 < MagicalTux> go1dfish: we do
- 21:06 < MagicalTux> except for those really old accounts it's missing on most of the really old transactions
- 21:06 -!- Vandroiy [[email protected]] has joined #mtgox
- 21:06 < Abolfazl> I transferred ~1BTC to my account right before the site went down. What will happen to this transaction?
- 21:06 < go1dfish> MagicalTux: I hope you also have a full SQL query log in case it turns out there was injection issues
- 21:07 < MagicalTux> Abolfazl: it was completed
- 21:07 < MagicalTux> go1dfish: we have a binary log with all modifying queries
- 21:07 < go1dfish> MagicalTux: could the differences between old balances and new balances be due to the (now fixed) floating point issues?
- 21:08 < MagicalTux> go1dfish: not for that large differences
Advertisement
Add Comment
Please, Sign In to add comment