Advertisement
Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- bool EdgeBuilder::containsLocation(
- const PathDiagnosticLocation &Container,
- const PathDiagnosticLocation &Containee)
- {
- ...
- return (ContainerBegLine <= ContaineeBegLine &&
- ContainerEndLine >= ContaineeEndLine &&
- (ContainerBegLine != ContaineeBegLine ||
- SM.getExpansionColumnNumber(ContainerRBeg) <=
- SM.getExpansionColumnNumber(ContaineeRBeg)) &&
- (ContainerEndLine != ContaineeEndLine ||
- SM.getExpansionColumnNumber(ContainerREnd) >=
- SM.getExpansionColumnNumber(ContainerREnd)));
- }
- The ContaineeREnd variable should have been used in the last line instead of ContainerREnd. You don't see the difference? Spell the words.
- This suspicious code was found in Clang project by PVS-Studio static code analyzer.
- Warning message is:
- V501 There are identical sub-expressions 'SM.getExpansionColumnNumber(ContainerREnd)' to the left and to the right of the '>=' operator. clangStaticAnalyzerCore bugreporter.cpp 925
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement