Advertisement
PVS-StudioWarnings

PVS-Studio warning V618 for WinSCP

Nov 26th, 2014
173
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.69 KB | None | 0 0
  1. bool CAsyncSslSocketLayer::CreateSslCertificate(....)
  2. {
  3.   ....
  4.   char buffer[1001];
  5.   int len;
  6.   while ((len = pBIO_read(bio, buffer, 1000)) > 0)
  7.   {
  8.     buffer[len] = 0;
  9.     fprintf(file, buffer);
  10.   }
  11.   ....
  12. }
  13.  
  14. This suspicious code was found in WinSCP project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V618 It's dangerous to call the 'fprintf' function in such a manner, as the line being passed could contain format specification. The example of the safe code: printf("%s", str); asyncsslsocketlayer.cpp 2247
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement