drs9999 wrote:



Rseding91 wrote:
Removed the per-tree-type tree growing table and replaced it with 4 different tables of trees that are each called once per tick per 15 ticks - this spaces the tree growth out over one seconds worth of ticks instead of all at once at the end of each second

Why do you think that all trees are checked once each second?
Imo it works (or least it should work) like the following:
I have x tables for growing entities, where x is the number of different tree-types ( x = 1 in the "vanilla" mod-version). Each table is sorted depending on the next update. So each tick I only check the first element of the each table. There is no need to run through all entities. That should be much more performant than checking all entities once in a second as you assumed and more performant than your attempt with 4 tables. Btw the same apllies to the update-cycles of the farms.

That makes sense but the performance overhead of keeping that table sorted in LUA far outweights the savings of only having to check one tree (the first in the table). Every time a tree is planted or advances one stage the table is shifted to move the next-to-be-ticked tree to the top and put the new random growth time tree somewhere near the end but most likely not at the end.




drs9999 wrote:



Rseding91 wrote:
Reworked the tree growth mechanic so when a given table of trees is checked it simply loops through all the trees in that table checking if tick > updateTime where tick is an exact copy of game.tick

See post above

This method is actually where most of the performance gain came from. LUA is horrible at re-sorting arrays as well as the memory overhead of removing and re-adding elements from anywhere but the end of the table.




drs9999 wrote:



Rseding91 wrote:
Reworked trees so on full growth they check all existing farms to see if they're within range of the farm and the farm's active/valid and either mark them self for deconstruction or harvest into the MK1 farm.

That sounds good, it might be even better when the tree is assigned to a farm directly after planting, so there is no need to check all exisiting farms.[*]

I was thinking of doing that but the number of tree farms is going to be small (< 20 normally) and storing the entity of a farm in a tree seemed like extra space that didn't need to get saved every time auto-save is triggered.


Have you tested out the modified version? If you watch the "Script Update" time on the debug screen (F4, enable update times then hit F5) you can see the marked performance improvement the changes made.

On my game with 6 MK2 tree farms running it went from 0.62~ MS/tick update time to 0.055~ MS/tick update time - a 1000%~ improvement. I've since planted 7 more MK2 farms for a new total of 13 MK2 farms and the update time hasn't gone above 0.075~ MS/tick.